)]}'
{
  "commit": "4cf8e17e92500cf52723edc82c20ff3be609081f",
  "tree": "fe9511d1f5ede28c86b643cb1f4a36b0fc878338",
  "parents": [
    "3fb94a488c7ad1cd42be3072584a676784dde662"
  ],
  "author": {
    "name": "Guido Urdaneta",
    "email": "guidou@webrtc.org",
    "time": "Fri Oct 09 09:02:53 2020"
  },
  "committer": {
    "name": "Commit Bot",
    "email": "commit-bot@chromium.org",
    "time": "Fri Oct 09 11:49:11 2020"
  },
  "message": "Revert \"Improve screen sharing with PipeWire on Wayland\"\n\nThis reverts commit 9b87037073f1811bcdae30967167f30b364e6879.\n\nReason for revert: Causing compile failures that prevent rolling into chrome.\nSee https://ci.chromium.org/p/chromium/builders/try/cast_shell_linux/726007\nhttps://chromium-review.googlesource.com/c/chromium/src/+/2461647\n\nOriginal change\u0027s description:\n\u003e Improve screen sharing with PipeWire on Wayland\n\u003e\n\u003e Currently, sharing a screen or a window on Wayland opens unnecessary\n\u003e preview dialog on Chromium side, which is then followed by a similar\n\u003e dialog on xdg-desktop-portal side. The Chromium dialog is useless on\n\u003e Wayland, as it doesn\u0027t show anything. This is because Chromium doesn\u0027t\n\u003e have access to screen content as in case of X11 session. To fix this, we\n\u003e want to avoid showing the preview dialog in case we find that we run on\n\u003e Wayland and only pick a screen or a window from the dialog that comes\n\u003e from xdg-desktop-portal.\n\u003e\n\u003e This patch splits BaseCapturerPipeWire class, moving portal related code\n\u003e into XdgPortalBase, which does all the DBus communication and which is\n\u003e supposed to be reused by BaseCapturerPipeWire when the user confirms\n\u003e the dialog from xdg-desktop-portal. The XdgPortalBase is extended to\n\u003e support multiple calls at once, where each call is identified by Id.\n\u003e\n\u003e Relevant change on Chromium side will be in a different review.\n\u003e\n\u003e Bug: chromium:682122\n\u003e Change-Id: If8afd36da66231eb154cdc00114908ac897ee4cf\n\u003e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/160649\n\u003e Commit-Queue: Tommi \u003ctommi@webrtc.org\u003e\n\u003e Reviewed-by: Tommi \u003ctommi@webrtc.org\u003e\n\u003e Reviewed-by: Erik Språng \u003csprang@webrtc.org\u003e\n\u003e Cr-Commit-Position: refs/heads/master@{#32342}\n\nTBR\u003dmbonadei@webrtc.org,jamiewalch@chromium.org,tommi@webrtc.org,sprang@webrtc.org,tomas.popela@gmail.com,grulja@gmail.com\n\n# Not skipping CQ checks because original CL landed \u003e 1 day ago.\n\nBug: chromium:682122\nChange-Id: I41518f795e34b84374bc8208b711cfeb0a070578\nNo-Try: True\nReviewed-on: https://webrtc-review.googlesource.com/c/src/+/187352\nCommit-Queue: Guido Urdaneta \u003cguidou@webrtc.org\u003e\nReviewed-by: Guido Urdaneta \u003cguidou@webrtc.org\u003e\nCr-Commit-Position: refs/heads/master@{#32365}\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "9bb9f622808c4de5991f1ced70efca39f4091c94",
      "old_mode": 33188,
      "old_path": "modules/desktop_capture/BUILD.gn",
      "new_id": "2cb6891c9e2359790591a831db1047ec8634b7d9",
      "new_mode": 33188,
      "new_path": "modules/desktop_capture/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "5c17dfbbe7bd9971c91484f825259d2c84c0f32d",
      "old_mode": 33188,
      "old_path": "modules/desktop_capture/desktop_capture_options.cc",
      "new_id": "c89896d5fd05c99f8917bf985f627d4242879bcb",
      "new_mode": 33188,
      "new_path": "modules/desktop_capture/desktop_capture_options.cc"
    },
    {
      "type": "modify",
      "old_id": "5323841a9706484270b8d06e93e870d7319b7e85",
      "old_mode": 33188,
      "old_path": "modules/desktop_capture/desktop_capture_options.h",
      "new_id": "521c80b5c5922e2d6b8af9e007ce5d427a386ac6",
      "new_mode": 33188,
      "new_path": "modules/desktop_capture/desktop_capture_options.h"
    },
    {
      "type": "modify",
      "old_id": "f9323f1848211fc9d70ba1d0f84b634c63641f5b",
      "old_mode": 33188,
      "old_path": "modules/desktop_capture/linux/base_capturer_pipewire.cc",
      "new_id": "2640e93aa98b09f7e54743f61423bcc02587da9f",
      "new_mode": 33188,
      "new_path": "modules/desktop_capture/linux/base_capturer_pipewire.cc"
    },
    {
      "type": "modify",
      "old_id": "849b283d247914a5109abe092079b77d65bb99de",
      "old_mode": 33188,
      "old_path": "modules/desktop_capture/linux/base_capturer_pipewire.h",
      "new_id": "f28d7a558bc60224e7960874b588b7ad5115346b",
      "new_mode": 33188,
      "new_path": "modules/desktop_capture/linux/base_capturer_pipewire.h"
    },
    {
      "type": "modify",
      "old_id": "e915bc9f17d2424a1862f677478afc10d0cf142c",
      "old_mode": 33188,
      "old_path": "modules/desktop_capture/linux/pipewire.sigs",
      "new_id": "3e21e9dc07cfab489b8df473d429e3da494b5677",
      "new_mode": 33188,
      "new_path": "modules/desktop_capture/linux/pipewire.sigs"
    },
    {
      "type": "delete",
      "old_id": "6b789eaaf009dc14cdc3d7ddc5464c581b54a568",
      "old_mode": 33188,
      "old_path": "modules/desktop_capture/linux/pipewire_base.cc",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "delete",
      "old_id": "5900b58bca3d7491a7a503ad1a3e5e078550559e",
      "old_mode": 33188,
      "old_path": "modules/desktop_capture/linux/pipewire_base.h",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "fe672140cca41db152038ef893045a5c2c6e0236",
      "new_mode": 33188,
      "new_path": "modules/desktop_capture/linux/screen_capturer_pipewire.cc"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "66dcd680e06a320fa37acfbf0bafb72b5670eefa",
      "new_mode": 33188,
      "new_path": "modules/desktop_capture/linux/screen_capturer_pipewire.h"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "b4559156dce2457db2f87189fa20016579a379b4",
      "new_mode": 33188,
      "new_path": "modules/desktop_capture/linux/window_capturer_pipewire.cc"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "7f184ef29992dfcb7884cefe32eba591d716f455",
      "new_mode": 33188,
      "new_path": "modules/desktop_capture/linux/window_capturer_pipewire.h"
    },
    {
      "type": "delete",
      "old_id": "0c7e693056f6b2142cd40e966e7afafeeb43b79e",
      "old_mode": 33188,
      "old_path": "modules/desktop_capture/linux/xdg_desktop_portal_base.cc",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "delete",
      "old_id": "829cbf9464345b3afe9c91cae84d2ea5ad18f262",
      "old_mode": 33188,
      "old_path": "modules/desktop_capture/linux/xdg_desktop_portal_base.h",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "modify",
      "old_id": "71a81b936351bc2c5515c5c707a50db48db05622",
      "old_mode": 33188,
      "old_path": "modules/desktop_capture/screen_capturer_linux.cc",
      "new_id": "82dbae48137e6c927a34c3c6ef7c41694440578c",
      "new_mode": 33188,
      "new_path": "modules/desktop_capture/screen_capturer_linux.cc"
    },
    {
      "type": "modify",
      "old_id": "c0b6154621701d03e6e3e1317bc6147c891a5f4d",
      "old_mode": 33188,
      "old_path": "modules/desktop_capture/window_capturer_linux.cc",
      "new_id": "41dbf836b036f1cef1576afad3927635d6b50b51",
      "new_mode": 33188,
      "new_path": "modules/desktop_capture/window_capturer_linux.cc"
    }
  ]
}