commit 4e86f142098643f497389d906bbdfcd521440eb4
author Florent Castelli <orphis@webrtc.org> Fri May 24 09:31:04 2024
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri May 24 10:01:59 2024
tree 6c15faa01a8565213d7c74dba3a2ec61ff168ff9
parent 99c519b3fdac0cbedaecead04a841e89a5f0f69b

Fix GN template webrtc_fuzzer_test to work with Abseil targets in deps

Bug: webrtc:341803749
Change-Id: I450a19f87fa08c811579a75b20ac177a481b8162
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/351640
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Auto-Submit: Florent Castelli <orphis@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42373}

test/fuzzers/BUILD.gn

diff --git a/test/fuzzers/BUILD.gn b/test/fuzzers/BUILD.gn
index d932d86..5dd25b4 100644
--- a/test/fuzzers/BUILD.gn
+++ b/test/fuzzers/BUILD.gn
@@ -44,7 +44,6 @@
 
 set_defaults("webrtc_fuzzer_test") {
   configs = rtc_add_configs
-  absl_deps = []
 }
 
 template("webrtc_fuzzer_test") {
@@ -56,17 +55,17 @@
     ]
     additional_configs = configs
 
-    # If absl_deps is [], no action is needed. If not [], then it needs to be
-    # converted to //third_party/abseil-cpp:absl when build_with_chromium=true
-    # otherwise it just needs to be added to deps.
-    if (absl_deps != []) {
-      if (!defined(deps)) {
+    # Convert Abseil dependencies to //third_party/abseil-cpp:absl when
+    # build_with_chromium is true
+    if (build_with_chromium) {
+      absl_dependencies =
+          filter_labels_include(deps, [ "//third_party/abseil-cpp/*" ])
+      if (absl_dependencies != []) {
+        filtered_deps =
+            filter_labels_exclude(deps, [ "//third_party/abseil-cpp/*" ])
         deps = []
-      }
-      if (build_with_chromium) {
+        deps = filtered_deps
         deps += [ "//third_party/abseil-cpp:absl" ]
-      } else {
-        deps += absl_deps
       }
     }