tree 6cf439d0c8beed59aa39d511856f01e6b13456df
parent c6d7d58c13e88f40002afc2f8161269325a2ae6b
author Michael Olbrich <m.olbrich@pengutronix.de> 1566385518 +0200
committer Commit Bot <commit-bot@chromium.org> 1569524336 +0000

pipewire: handle deleting the capturer while a D-Bus call is in progress

If a D-Bus call is in progress when a BaseCapturerPipeWire is deleted, then
the user_data is invalid when the callback function is called. This results
in memory corruption.

To fix this, use a GCancellable. If it is canceled, the callback will be
called with a corresponding error. Detect this error and abort before
accessing the user_data.

Note: The first argument is the 'source_object'. For g_dbus_proxy_call()
this is the proxy object not the connection. This was not a problem before,
because it was not used.

Bug: None
Change-Id: I8d5e3fb5c49fcc9afd61cdb8e8249f78b9434faf
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/149817
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#29326}