)]}' { "commit": "646fda0212b17f55b73e0f52f455fc48a019558a", "tree": "40df88f08d1c29831b14757ecc090fa6023a7b7a", "parents": [ "58c71db1b344295a059ae72d9fe247b7c1cd1047" ], "author": { "name": "Henrik Boström", "email": "hbos@webrtc.org", "time": "Wed May 22 13:49:42 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed May 22 16:03:41 2019" }, "message": "Implement RTCMediaSourceStats and friends in standard getStats().\n\nThis implements RTCAudioSourceStats and RTCVideoSourceStats, both\ninheriting from abstract dictionary RTCMediaSourceStats:\nhttps://w3c.github.io/webrtc-stats/#dom-rtcmediasourcestats\n\nAll members are implemented except for the total \"frames\" counter:\n- trackIdentifier\n- kind\n- width\n- height\n- framesPerSecond\n\nThis means to make googFrameWidthInput, googFrameHeightInput and\ngoogFrameRateInput obsolete.\n\nImplemented using the same code path as the goog stats, there are\nsome minor bugs that should be fixed in the future, but not this CL:\n1. We create media-source objects on a per-track attachment basis.\n If the same track is attached multiple times this results in\n multiple media-source objects, but the spec says it should be on a\n per-source basis.\n2. framesPerSecond is only calculated after connecting (when we have a\n sender with SSRC), but if collected on a per-source basis the source\n should be able to tell us the FPS whether or not we are sending it.\n\nBug: webrtc:10453\nChange-Id: I23705a79f15075dca2536275934af1904a7f0d39\nReviewed-on: https://webrtc-review.googlesource.com/c/src/+/137804\nCommit-Queue: Henrik Boström \u003chbos@webrtc.org\u003e\nReviewed-by: Harald Alvestrand \u003chta@webrtc.org\u003e\nCr-Commit-Position: refs/heads/master@{#28028}\n", "tree_diff": [ { "type": "modify", "old_id": "bb23490ce43f354513d30cdf67a66273433ba69f", "old_mode": 33188, "old_path": "api/stats/rtc_stats.h", "new_id": "4361163576bddf96048205453e13af7191d98059", "new_mode": 33188, "new_path": "api/stats/rtc_stats.h" }, { "type": "modify", "old_id": "2e6cd3b9bb3d0970f097d0b40a9b1ff12327968f", "old_mode": 33188, "old_path": "api/stats/rtcstats_objects.h", "new_id": "cbcc8fa37dfe93972f87d7b14d6b9b7ce34c2c81", "new_mode": 33188, "new_path": "api/stats/rtcstats_objects.h" }, { "type": "modify", "old_id": "3e11a920611b2d5638d9c75e888ba1494b056870", "old_mode": 33188, "old_path": "pc/rtc_stats_collector.cc", "new_id": "9f82abe663dd64b61845eba9b2d1ed0f56bf1094", "new_mode": 33188, "new_path": "pc/rtc_stats_collector.cc" }, { "type": "modify", "old_id": "4837fc0abef4837378555f91072341e97c68cc52", "old_mode": 33188, "old_path": "pc/rtc_stats_collector.h", "new_id": "82501db038ab6515e683ce397a14e29c3c631f61", "new_mode": 33188, "new_path": "pc/rtc_stats_collector.h" }, { "type": "modify", "old_id": "78530dfd63ddba75acfc785386bff44735075961", "old_mode": 33188, "old_path": "pc/rtc_stats_collector_unittest.cc", "new_id": "6cd63196a7fdb4873687604f0d4cb5f1b82b85f0", "new_mode": 33188, "new_path": "pc/rtc_stats_collector_unittest.cc" }, { "type": "modify", "old_id": "438b47b1601b9afbf0ce41ee1fc882f8509453cb", "old_mode": 33188, "old_path": "pc/rtc_stats_integrationtest.cc", "new_id": "10b17e59864fde79dacbeb55dead961af3fd1f0b", "new_mode": 33188, "new_path": "pc/rtc_stats_integrationtest.cc" }, { "type": "modify", "old_id": "e7af0e10e9ea2ab09166a5314ee0bbc8036859d6", "old_mode": 33188, "old_path": "pc/rtc_stats_traversal.cc", "new_id": "16a6c9d668ecd82601ee7329bebc718ae807d617", "new_mode": 33188, "new_path": "pc/rtc_stats_traversal.cc" }, { "type": "modify", "old_id": "e6c96e009273bd7f23dff3e1b52071ff4d36e572", "old_mode": 33188, "old_path": "stats/rtcstats_objects.cc", "new_id": "f97e23fb04c66838b35a5d16262cf8001b3c920b", "new_mode": 33188, "new_path": "stats/rtcstats_objects.cc" } ] }