Add a generic QP parser.
Bug: webrtc:358039777
Change-Id: I13faa8f9d83c237caa208e2a1e03dfd9782cba2e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/415000
Commit-Queue: Emil Vardar (xWF) <vardar@google.com>
Reviewed-by: Fanny Linderborg <linderborg@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#45880}
diff --git a/video/corruption_detection/evaluation/BUILD.gn b/video/corruption_detection/evaluation/BUILD.gn
index 6138b37..87076f4 100644
--- a/video/corruption_detection/evaluation/BUILD.gn
+++ b/video/corruption_detection/evaluation/BUILD.gn
@@ -100,6 +100,22 @@
]
}
+rtc_library("qp_parser") {
+ testonly = true
+ sources = [
+ "qp_parser.cc",
+ "qp_parser.h",
+ ]
+ deps = [
+ ":av1_qp_parser",
+ "../../../api:array_view",
+ "../../../api/video:video_frame",
+ "../../../modules/video_coding:video_coding_utility",
+ "../../../rtc_base:checks",
+ ]
+ public_configs = [ "//third_party/libgav1:libgav1_public_config" ]
+}
+
rtc_library("test_clip") {
testonly = true
sources = [
@@ -178,6 +194,16 @@
]
}
+ rtc_library("qp_parser_unittest") {
+ testonly = true
+ sources = [ "qp_parser_unittest.cc" ]
+ deps = [
+ ":qp_parser",
+ "../../../api/video:video_frame",
+ "../../../test:test_support",
+ ]
+ }
+
rtc_library("test_clip_unittest") {
testonly = true
sources = [ "test_clip_unittest.cc" ]
@@ -249,6 +275,7 @@
sources = []
deps = [
":av1_qp_parser_unittest",
+ ":qp_parser_unittest",
":test_clip_unittest",
":utils_unittest",
":webrtc_picture_pair_provider_unittest",
diff --git a/video/corruption_detection/evaluation/qp_parser.cc b/video/corruption_detection/evaluation/qp_parser.cc
new file mode 100644
index 0000000..b504344
--- /dev/null
+++ b/video/corruption_detection/evaluation/qp_parser.cc
@@ -0,0 +1,37 @@
+/*
+ * Copyright 2025 The WebRTC project authors. All rights reserved.
+ *
+ * Use of this source code is governed by a BSD-style license
+ * that can be found in the LICENSE file in the root of the source
+ * tree. An additional intellectual property rights grant can be found
+ * in the file PATENTS. All contributing project authors may
+ * be found in the AUTHORS file in the root of the source tree.
+ */
+
+#include "video/corruption_detection/evaluation/qp_parser.h"
+
+#include <cstddef>
+#include <cstdint>
+#include <optional>
+
+#include "api/array_view.h"
+#include "api/video/video_codec_type.h"
+#include "rtc_base/checks.h"
+
+namespace webrtc {
+
+std::optional<uint32_t> GenericQpParser::Parse(
+ VideoCodecType codec_type,
+ size_t spatial_idx,
+ ArrayView<const uint8_t> frame_data,
+ int operating_point) {
+ if (codec_type != kVideoCodecAV1) {
+ return non_av1_parsers_.Parse(codec_type, spatial_idx, frame_data.data(),
+ frame_data.size());
+ }
+
+ RTC_DCHECK_EQ(codec_type, kVideoCodecAV1);
+ return av1_parser_.Parse(frame_data, operating_point);
+}
+
+} // namespace webrtc
diff --git a/video/corruption_detection/evaluation/qp_parser.h b/video/corruption_detection/evaluation/qp_parser.h
new file mode 100644
index 0000000..cf7d6eb
--- /dev/null
+++ b/video/corruption_detection/evaluation/qp_parser.h
@@ -0,0 +1,42 @@
+/*
+ * Copyright 2025 The WebRTC project authors. All rights reserved.
+ *
+ * Use of this source code is governed by a BSD-style license
+ * that can be found in the LICENSE file in the root of the source
+ * tree. An additional intellectual property rights grant can be found
+ * in the file PATENTS. All contributing project authors may
+ * be found in the AUTHORS file in the root of the source tree.
+ */
+
+#ifndef VIDEO_CORRUPTION_DETECTION_EVALUATION_QP_PARSER_H_
+#define VIDEO_CORRUPTION_DETECTION_EVALUATION_QP_PARSER_H_
+
+#include <cstddef>
+#include <cstdint>
+#include <optional>
+
+#include "api/array_view.h"
+#include "api/video/video_codec_type.h"
+#include "modules/video_coding/utility/qp_parser.h"
+#include "video/corruption_detection/evaluation/av1_qp_parser.h"
+
+namespace webrtc {
+
+// This class is a wrapper around `Av1QpParser` and `QpParser`. It is used to
+// parse the QP value for any of the following codecs: AV1, VP8, VP9, H264 and
+// H265.
+class GenericQpParser {
+ public:
+ std::optional<uint32_t> Parse(VideoCodecType codec_type,
+ size_t spatial_idx,
+ ArrayView<const uint8_t> frame_data,
+ int operating_point = 0);
+
+ private:
+ Av1QpParser av1_parser_;
+ QpParser non_av1_parsers_;
+};
+
+} // namespace webrtc
+
+#endif // VIDEO_CORRUPTION_DETECTION_EVALUATION_QP_PARSER_H_
diff --git a/video/corruption_detection/evaluation/qp_parser_unittest.cc b/video/corruption_detection/evaluation/qp_parser_unittest.cc
new file mode 100644
index 0000000..9131d8c
--- /dev/null
+++ b/video/corruption_detection/evaluation/qp_parser_unittest.cc
@@ -0,0 +1,205 @@
+/*
+ * Copyright 2025 The WebRTC project authors. All rights reserved.
+ *
+ * Use of this source code is governed by a BSD-style license
+ * that can be found in the LICENSE file in the root of the source
+ * tree. An additional intellectual property rights grant can be found
+ * in the file PATENTS. All contributing project authors may
+ * be found in the AUTHORS file in the root of the source tree.
+ */
+
+#include "video/corruption_detection/evaluation/qp_parser.h"
+
+#include <cstdint>
+#include <optional>
+
+#include "api/video/video_codec_type.h"
+#include "test/gmock.h"
+#include "test/gtest.h"
+
+namespace webrtc {
+namespace {
+
+const uint8_t kWronglyCodedFrame[] = {0x10};
+
+// ffmpeg -s 16x16 -f rawvideo -pix_fmt rgb24 -r 30 -i /dev/zero -c:v libvpx
+// -qmin 20 -qmax 20 -crf 20 -frames:v 1 -y out.ivf
+const uint8_t kCodedFrameVp8Qp25[] = {
+ 0x10, 0x02, 0x00, 0x9d, 0x01, 0x2a, 0x10, 0x00, 0x10, 0x00,
+ 0x02, 0x47, 0x08, 0x85, 0x85, 0x88, 0x85, 0x84, 0x88, 0x0c,
+ 0x82, 0x00, 0x0c, 0x0d, 0x60, 0x00, 0xfe, 0xfc, 0x5c, 0xd0};
+
+// ffmpeg -s 16x16 -f rawvideo -pix_fmt rgb24 -r 30 -i /dev/zero -c:v libvpx-vp9
+// -qmin 24 -qmax 24 -crf 24 -frames:v 1 -y out.ivf
+const uint8_t kCodedFrameVp9Qp96[] = {
+ 0xa2, 0x49, 0x83, 0x42, 0xe0, 0x00, 0xf0, 0x00, 0xf6, 0x00,
+ 0x38, 0x24, 0x1c, 0x18, 0xc0, 0x00, 0x00, 0x30, 0x70, 0x00,
+ 0x00, 0x4a, 0xa7, 0xff, 0xfc, 0xb9, 0x01, 0xbf, 0xff, 0xff,
+ 0x97, 0x20, 0xdb, 0xff, 0xff, 0xcb, 0x90, 0x5d, 0x40};
+
+// ffmpeg -s 16x16 -f rawvideo -pix_fmt yuv420p -r 30 -i /dev/zero -c:v libx264
+// -qmin 38 -qmax 38 -crf 38 -profile:v baseline -frames:v 2 -y out.264
+const uint8_t kCodedFrameH264SpsPpsIdrQp38[] = {
+ 0x00, 0x00, 0x00, 0x01, 0x67, 0x42, 0xc0, 0x0a, 0xd9, 0x1e, 0x84,
+ 0x00, 0x00, 0x03, 0x00, 0x04, 0x00, 0x00, 0x03, 0x00, 0xf0, 0x3c,
+ 0x48, 0x99, 0x20, 0x00, 0x00, 0x00, 0x01, 0x68, 0xcb, 0x80, 0xc4,
+ 0xb2, 0x00, 0x00, 0x01, 0x65, 0x88, 0x84, 0xf1, 0x18, 0xa0, 0x00,
+ 0x20, 0x5b, 0x1c, 0x00, 0x04, 0x07, 0xe3, 0x80, 0x00, 0x80, 0xfe};
+
+const uint8_t kCodedFrameH264SpsPpsIdrQp49[] = {
+ 0x00, 0x00, 0x00, 0x01, 0x67, 0x42, 0xc0, 0x0a, 0xd9, 0x1e, 0x84,
+ 0x00, 0x00, 0x03, 0x00, 0x04, 0x00, 0x00, 0x03, 0x00, 0xf0, 0x3c,
+ 0x48, 0x99, 0x20, 0x00, 0x00, 0x00, 0x01, 0x68, 0xcb, 0x80, 0x5d,
+ 0x2c, 0x80, 0x00, 0x00, 0x01, 0x65, 0x88, 0x84, 0xf1, 0x18, 0xa0,
+ 0x00, 0x5e, 0x38, 0x00, 0x08, 0x03, 0xc7, 0x00, 0x01, 0x00, 0x7c};
+
+#define OBU_TEMPORAL_DELIMITER 0x12, 0x0
+#define OBU_SEQUENCE_HEADER \
+ 0xa, 0xa, 0x0, 0x0, 0x0, 0x2, 0x27, 0xfe, 0xff, 0xfc, 0xc0, 0x20
+#define OBU_FRAME_1 \
+ 0x32, 0x93, 0x2, 0x10, 0x0, 0xa8, 0x80, 0x0, 0x3, 0x0, 0x10, 0x10, 0x30, \
+ 0x0, 0xd3, 0xc6, 0xc6, 0x82, 0xaa, 0x5e, 0xbf, 0x82, 0xf2, 0xa4, 0xa4, \
+ 0x29, 0xab, 0xda, 0xd7, 0x1, 0x5, 0x0, 0xb3, 0xde, 0xa8, 0x6f, 0x8d, \
+ 0xbf, 0x1b, 0xa8, 0x25, 0xc3, 0x84, 0x7c, 0x1a, 0x2b, 0x8b, 0x0, 0xff, \
+ 0x19, 0x1f, 0x45, 0x7e, 0xe0, 0xbe, 0xe1, 0x3a, 0x63, 0xc2, 0xc6, 0x6e, \
+ 0xf4, 0xc8, 0xce, 0x11, 0xe1, 0x9f, 0x48, 0x64, 0x72, 0xeb, 0xbb, 0x4f, \
+ 0xf3, 0x94, 0xb4, 0xb6, 0x9d, 0x4f, 0x4, 0x18, 0x5e, 0x5e, 0x1b, 0x65, \
+ 0x49, 0x74, 0x90, 0x13, 0x50, 0xef, 0x8c, 0xb8, 0xe8, 0xd9, 0x8e, 0x9c, \
+ 0xc9, 0x4d, 0xda, 0x60, 0x6a, 0xa, 0xf9, 0x75, 0xd0, 0x62, 0x69, 0xd, \
+ 0xf5, 0xdc, 0xa9, 0xb9, 0x4c, 0x8, 0x9e, 0x33, 0x15, 0xa3, 0xe1, 0x42, \
+ 0x0, 0xe2, 0xb0, 0x46, 0xd0, 0xf7, 0xad, 0x55, 0xbc, 0x75, 0xe9, 0xe3, \
+ 0x1f, 0xa3, 0x41, 0x11, 0xba, 0xaa, 0x81, 0xf3, 0xcb, 0x82, 0x87, 0x71, \
+ 0x0, 0xe6, 0xb9, 0x8c, 0xe1, 0xe9, 0xd3, 0x21, 0xcc, 0xcd, 0xe7, 0x12, \
+ 0xb9, 0xe, 0x43, 0x6a, 0xa3, 0x76, 0x5c, 0x35, 0x90, 0x45, 0x36, 0x52, \
+ 0xb4, 0x2d, 0xa3, 0x55, 0xde, 0x20, 0xf8, 0x80, 0xe1, 0x26, 0x46, 0x1b, \
+ 0x3f, 0x59, 0xc7, 0x2e, 0x5b, 0x4a, 0x73, 0xf8, 0xb3, 0xf4, 0x62, 0xf4, \
+ 0xf5, 0xa4, 0xc2, 0xae, 0x9e, 0xa6, 0x9c, 0x10, 0xbb, 0xe1, 0xd6, 0x88, \
+ 0x75, 0xb9, 0x85, 0x48, 0xe5, 0x7, 0x12, 0xf3, 0x11, 0x85, 0x8e, 0xa2, \
+ 0x95, 0x9d, 0xed, 0x50, 0xfb, 0x6, 0x5a, 0x1, 0x37, 0xc4, 0x8e, 0x9e, \
+ 0x73, 0x9b, 0x96, 0x64, 0xbd, 0x42, 0xb, 0x80, 0xde, 0x57, 0x86, 0xcb, \
+ 0x7d, 0xab, 0x12, 0xb2, 0xcc, 0xe6, 0xea, 0xb5, 0x89, 0xeb, 0x91, 0xb3, \
+ 0x93, 0xb2, 0x4f, 0x2f, 0x5b, 0xf3, 0x72, 0x12, 0x51, 0x56, 0x75, 0xb3, \
+ 0xdd, 0x49, 0xb6, 0x5b, 0x77, 0xbe, 0xc5, 0xd7, 0xd4, 0xaf, 0xd6, 0x6b, \
+ 0x38
+#define OBU_FRAME_2 \
+ 0x32, 0x33, 0x30, 0x3, 0xc3, 0x0, 0xa7, 0x2e, 0x46, 0xa8, 0x80, 0x0, 0x3, \
+ 0x0, 0x10, 0x1, 0x0, 0xa0, 0x0, 0xed, 0xb1, 0x51, 0x15, 0x58, 0xc7, \
+ 0x69, 0x3, 0x26, 0x35, 0xeb, 0x5a, 0x2d, 0x7a, 0x53, 0x24, 0x26, 0x20, \
+ 0xa6, 0x11, 0x7, 0x49, 0x76, 0xa3, 0xc7, 0x62, 0xf8, 0x3, 0x32, 0xb0, \
+ 0x98, 0x17, 0x3d, 0x80
+
+constexpr uint8_t kCodedFrameAv1Frame1Qp81[] = {
+ OBU_TEMPORAL_DELIMITER, OBU_SEQUENCE_HEADER, OBU_FRAME_1};
+constexpr uint8_t kCodedFrameAv1Frame2Qp81[] = {OBU_TEMPORAL_DELIMITER,
+ OBU_FRAME_2};
+
+#define OBU_SEQUENCE_HEADER_SVC_L3T1 \
+ 0x0a, 0x0d, 0x00, 0x27, 0x01, 0x01, 0x80, 0x80, 0x40, 0x40, 0x89, 0xff, \
+ 0x80, 0x34, 0x01
+#define OBU_FRAME1_SPATIAL_LAYER1 \
+ 0x32, 0x31, 0x12, 0x73, 0xc0, 0x07, 0xc0, 0x07, 0xd2, 0x80, 0x02, 0x08, \
+ 0x20, 0x84, 0x00, 0x09, 0x00, 0x05, 0x6b, 0x68, 0x4c, 0xef, 0x9e, 0xe5, \
+ 0x27, 0xff, 0x0d, 0xb1, 0x41, 0xde, 0xc9, 0xdd, 0x3c, 0x52, 0xea, 0xbf, \
+ 0xaa, 0xf5, 0x8f, 0x57, 0xaa, 0xdd, 0xe5, 0xf1, 0x19, 0x22, 0x3d, 0x5e, \
+ 0x5a, 0x16, 0x2d
+#define OBU_FRAME1_SPATIAL_LAYER2 \
+ 0x36, 0x08, 0x17, 0x31, 0xe0, 0x40, 0x02, 0x00, 0x00, 0xf7, 0xc0, 0x07, \
+ 0xc0, 0x07, 0xc0, 0xf8, 0x81, 0xff, 0xff, 0xfe, 0x2c, 0x54, 0xd8, 0x00, \
+ 0x76, 0x90
+#define OBU_FRAME1_SPATIAL_LAYER3 \
+ 0x36, 0x10, 0x11, 0x30, 0xe0, 0x84, 0x04, 0x00, 0x01, 0xf1, 0x03, 0xff, \
+ 0xff, 0xfc, 0x58, 0xa9, 0xb0, 0x00, 0x8c, 0x70
+
+constexpr uint8_t kL3T1Av1TemporaUnit[] = {
+ OBU_TEMPORAL_DELIMITER, OBU_SEQUENCE_HEADER_SVC_L3T1,
+ OBU_FRAME1_SPATIAL_LAYER1, OBU_FRAME1_SPATIAL_LAYER2,
+ OBU_FRAME1_SPATIAL_LAYER3};
+constexpr uint8_t kQpSpatialLayer1 = 40u;
+constexpr uint8_t kQpSpatialLayer2 = 241u;
+constexpr uint8_t kQpSpatialLayer3 = 241u;
+
+TEST(QpParserTest, ParseQpVp8Error) {
+ GenericQpParser parser;
+ std::optional<uint32_t> qp =
+ parser.Parse(kVideoCodecVP8, 0, kWronglyCodedFrame);
+ EXPECT_EQ(qp, std::nullopt);
+}
+
+TEST(QpParserTest, ParseQpVp8ThroughTemporalUnits) {
+ GenericQpParser parser;
+ std::optional<uint32_t> qp =
+ parser.Parse(kVideoCodecVP8, 0, kCodedFrameVp8Qp25);
+ EXPECT_THAT(qp, 25u);
+}
+
+TEST(QpParserTest, ParseQpVp9ThroughTemporalUnits) {
+ GenericQpParser parser;
+ std::optional<uint32_t> qp =
+ parser.Parse(kVideoCodecVP9, 0, kCodedFrameVp9Qp96);
+ EXPECT_THAT(qp, 96u);
+}
+
+TEST(QpParserTest, ParseQpH264ThroughTemporalUnits) {
+ GenericQpParser parser;
+ std::optional<uint32_t> qp = parser.Parse(VideoCodecType::kVideoCodecH264, 0,
+ kCodedFrameH264SpsPpsIdrQp38);
+ EXPECT_THAT(qp, 38u);
+
+ qp = parser.Parse(kVideoCodecH264, 1, kCodedFrameH264SpsPpsIdrQp49);
+ EXPECT_THAT(qp, 49u);
+}
+
+TEST(QpParserTest, ParseQpAv1KeyFrame) {
+ GenericQpParser parser;
+ std::optional<uint32_t> qp =
+ parser.Parse(kVideoCodecAV1, 0, kCodedFrameAv1Frame1Qp81);
+ EXPECT_THAT(qp, 81u);
+}
+
+TEST(QpParserTest, ParseQpAv1DeltaFrameError) {
+ GenericQpParser parser_error;
+ // When the first frame is skipped the `sequence_header` is not set, hence QP
+ // must be unattainable.
+ std::optional<uint32_t> qp =
+ parser_error.Parse(kVideoCodecAV1, 0, kCodedFrameAv1Frame2Qp81);
+ EXPECT_FALSE(qp.has_value());
+}
+
+TEST(QpParserTest, ParseQpAv1DeltaFrameProper) {
+ GenericQpParser parser;
+ ASSERT_TRUE(
+ parser.Parse(kVideoCodecAV1, 0, kCodedFrameAv1Frame1Qp81).has_value());
+ std::optional<uint32_t> qp =
+ parser.Parse(kVideoCodecAV1, 0, kCodedFrameAv1Frame2Qp81);
+ EXPECT_THAT(qp, 81u);
+}
+
+TEST(QpParserTest, ParseQpAv1SvcL3T1SpatialLayer1) {
+ GenericQpParser parser;
+ // `operating_point` = 2 would get the QP for the lowest resolution.
+ std::optional<uint32_t> qp =
+ parser.Parse(kVideoCodecAV1, 0, kL3T1Av1TemporaUnit,
+ /*operating_point=*/2);
+ EXPECT_THAT(qp, kQpSpatialLayer1);
+}
+
+TEST(QpParserTest, ParseQpAv1SvcL3T1SpatialLayer2) {
+ GenericQpParser parser;
+ // `operating_point` = 1 would get the QP for mid resolution.
+ std::optional<uint32_t> qp =
+ parser.Parse(kVideoCodecAV1, 0, kL3T1Av1TemporaUnit,
+ /*operating_point=*/1);
+ EXPECT_THAT(qp, kQpSpatialLayer2);
+}
+
+TEST(QpParserTest, ParseQpAv1SvcL3T1SpatialLayer3) {
+ GenericQpParser parser;
+ // `operating_point` = 0 would get the QP for the highest resolution.
+ std::optional<uint32_t> qp =
+ parser.Parse(kVideoCodecAV1, 0, kL3T1Av1TemporaUnit,
+ /*operating_point=*/0);
+ EXPECT_THAT(qp, kQpSpatialLayer3);
+}
+
+} // namespace
+} // namespace webrtc
