)]}' { "commit": "8c185fcabeb74b454eddc16fc90fa413bffcd70e", "tree": "a70729e220594bbca52902497385354e5b050e45", "parents": [ "145f289552e1d08b1a597af0c228758a5ce2ed77" ], "author": { "name": "Mirko Bonadei", "email": "mbonadei@webrtc.org", "time": "Wed Jul 21 11:12:38 2021" }, "committer": { "name": "WebRTC LUCI CQ", "email": "webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Jul 21 13:26:14 2021" }, "message": "Reland \"Add WebRTC specific dcheck_always_on.\"\n\nThis is a reland of 9f2a20f4342a3e86e1f9fdfe6f3d76fb539d41c2\n\nSee https://webrtc-review.googlesource.com/c/src/+/226563/1..2\nfor the fix. RTC_DCHECK_ALWAYS_ON needs to be in public_configs\nin order to be propagated together with header #includes and\navoid ODR violations.\n\nOriginal change\u0027s description:\n\u003e Add WebRTC specific dcheck_always_on.\n\u003e\n\u003e Inspired by V8 CL: crrev.com/c/3038528.\n\u003e\n\u003e This makes the WebRTC\u0027s dcheck control independent of Chromium\u0027s and\n\u003e prepares switching Chromium\u0027s default behavior without affecting\n\u003e WebRTC developers or builders.\n\u003e\n\u003e Preparation for: https://crrev.com/c/2893204\n\u003e\n\u003e Bug: chromium:1225701, webrtc:12988\n\u003e Change-Id: Ia0d21f9fb8e9d7704fd1beca16504c301a263b3b\n\u003e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226465\n\u003e Commit-Queue: Mirko Bonadei \u003cmbonadei@webrtc.org\u003e\n\u003e Reviewed-by: Markus Handell \u003chandellm@webrtc.org\u003e\n\u003e Reviewed-by: Dirk Pranke \u003cdpranke@google.com\u003e\n\u003e Cr-Commit-Position: refs/heads/master@{#34512}\n\nBug: chromium:1225701, webrtc:12988\nChange-Id: I1f78587487ee7b1a4a07b8c91b737a9e797b2323\nReviewed-on: https://webrtc-review.googlesource.com/c/src/+/226563\nReviewed-by: Florent Castelli \u003corphis@webrtc.org\u003e\nReviewed-by: Markus Handell \u003chandellm@webrtc.org\u003e\nCommit-Queue: Mirko Bonadei \u003cmbonadei@webrtc.org\u003e\nCr-Commit-Position: refs/heads/master@{#34519}\n", "tree_diff": [ { "type": "modify", "old_id": "bc51df7c07b8034557a34e7dffe5e8fa379e71a4", "old_mode": 33188, "old_path": "BUILD.gn", "new_id": "f2713f62d22ec23dd4d33f1bd8dd7c0c1bff8b12", "new_mode": 33188, "new_path": "BUILD.gn" }, { "type": "modify", "old_id": "21fca7e40f83d0e7d861f43e2a450dde932cbbbe", "old_mode": 33188, "old_path": "rtc_base/checks.h", "new_id": "e7584fb11ccfe9889a638dc379ece21383380269", "new_mode": 33188, "new_path": "rtc_base/checks.h" }, { "type": "modify", "old_id": "8ca9ce76a89cde412d9a6514827a1d7c73a3d3d6", "old_mode": 33188, "old_path": "rtc_base/thread.cc", "new_id": "b54cdedf50228d1aa78c9e8c536c021cafb067b0", "new_mode": 33188, "new_path": "rtc_base/thread.cc" }, { "type": "modify", "old_id": "6e68f1a679dffec1f82b45d80ce386eef702bb4a", "old_mode": 33188, "old_path": "rtc_base/thread.h", "new_id": "cb5a0e9cd0290034b2788e288eab4bd72b26ea0d", "new_mode": 33188, "new_path": "rtc_base/thread.h" }, { "type": "modify", "old_id": "789bdd943e1dba1ca52c12f25737201221c72d60", "old_mode": 33188, "old_path": "rtc_base/thread_unittest.cc", "new_id": "e603930564c6a3fbf42c48cc6c4997e4ee12628e", "new_mode": 33188, "new_path": "rtc_base/thread_unittest.cc" }, { "type": "modify", "old_id": "e01a75c049e0e9c1941d8c06eb5cfed7a07ff127", "old_mode": 33188, "old_path": "tools_webrtc/coverage/generate_ios_coverage_command.py", "new_id": "ff17c58863ce5a9913d1d5dc64dc1b1254866c0e", "new_mode": 33188, "new_path": "tools_webrtc/coverage/generate_ios_coverage_command.py" }, { "type": "modify", "old_id": "8c66cd328c728050279d455b2fd7ef4b0b8835ec", "old_mode": 33188, "old_path": "tools_webrtc/mb/docs/user_guide.md", "new_id": "a8857d2087535d831f29d228f5cd8186724b4893", "new_mode": 33188, "new_path": "tools_webrtc/mb/docs/user_guide.md" }, { "type": "modify", "old_id": "253a57acc501491ea6a089d854544ffc2cf40c1c", "old_mode": 33188, "old_path": "tools_webrtc/mb/mb_config.pyl", "new_id": "74678f875e6a485cd5095fba3b19de2cdb2867c6", "new_mode": 33188, "new_path": "tools_webrtc/mb/mb_config.pyl" }, { "type": "modify", "old_id": "a338d723ed35525c3fe40d325db1f3abc5cc58e5", "old_mode": 33188, "old_path": "webrtc.gni", "new_id": "99d4488e3cc1f1079d1f846e0b0d8b593b70f264", "new_mode": 33188, "new_path": "webrtc.gni" } ] }