)]}' { "commit": "8de900cdcb7ded8f52d6d35b5040b6880d3dda35", "tree": "d4ee5d560f80a4444da611a7d528957722034878", "parents": [ "3fa23eec4bf93280f6d64a63169685df6cfc861a" ], "author": { "name": "Marina Ciocea", "email": "marinaciocea@webrtc.org", "time": "Mon May 18 14:04:42 2020" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon May 18 17:53:38 2020" }, "message": "Reland \"Make TransformableVideoFrameInterface::GetMetadata pure virtual.\"\n\nThis reverts commit 3e9068a6b488c63d98e5dd8a21caf7b83eb3744f.\n\nReason for revert: Fixed Chrome compile in https://crrev.com/c/2207191.\n\nOriginal change\u0027s description:\n\u003e Revert \"Make TransformableVideoFrameInterface::GetMetadata pure virtual.\"\n\u003e \n\u003e This reverts commit 576ad5d510894040d7bbc041d5c86745c67f30f8.\n\u003e \n\u003e Reason for revert: Causes compile error in Chrome.\n\u003e \n\u003e Original change\u0027s description:\n\u003e \u003e Make TransformableVideoFrameInterface::GetMetadata pure virtual.\n\u003e \u003e \n\u003e \u003e GetMetadata() has been implemented downstream and can be made pure\n\u003e \u003e virtual.\n\u003e \u003e \n\u003e \u003e Bug: chromium:1069295\n\u003e \u003e Change-Id: I62a3be6106552d2d82d8c413c6f523d31626b0d8\n\u003e \u003e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175001\n\u003e \u003e Commit-Queue: Marina Ciocea \u003cmarinaciocea@webrtc.org\u003e\n\u003e \u003e Reviewed-by: Harald Alvestrand \u003chta@webrtc.org\u003e\n\u003e \u003e Cr-Commit-Position: refs/heads/master@{#31281}\n\u003e \n\u003e TBR\u003dhta@webrtc.org,marinaciocea@webrtc.org\n\u003e \n\u003e # Not skipping CQ checks because original CL landed \u003e 1 day ago.\n\u003e \n\u003e Bug: chromium:1069295\n\u003e Change-Id: I5915270d5b8dab9fc30a07f22fddedb29beca01a\n\u003e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/175620\n\u003e Reviewed-by: Guido Urdaneta \u003cguidou@webrtc.org\u003e\n\u003e Commit-Queue: Guido Urdaneta \u003cguidou@webrtc.org\u003e\n\u003e Cr-Commit-Position: refs/heads/master@{#31304}\n\nTBR\u003dhta@webrtc.org,guidou@webrtc.org,marinaciocea@webrtc.org\n\n# Not skipping CQ checks because this is a reland.\n\nBug: chromium:1069295\nChange-Id: Icc192a38f2c17898d3547e0eb38aa399befe6250\nReviewed-on: https://webrtc-review.googlesource.com/c/src/+/175624\nReviewed-by: Marina Ciocea \u003cmarinaciocea@webrtc.org\u003e\nCommit-Queue: Marina Ciocea \u003cmarinaciocea@webrtc.org\u003e\nCr-Commit-Position: refs/heads/master@{#31312}\n", "tree_diff": [ { "type": "modify", "old_id": "753c7f4bb95355fabb83b751361465f693939698", "old_mode": 33188, "old_path": "api/frame_transformer_interface.h", "new_id": "2cfe6edb884b53b0b3fa87afad264aa411d112bd", "new_mode": 33188, "new_path": "api/frame_transformer_interface.h" }, { "type": "modify", "old_id": "ce9b2a13182f88f011f0ee30048d84b313a6889c", "old_mode": 33188, "old_path": "api/video/video_frame_metadata.h", "new_id": "2e9309841b0033b393376b4f26364541451e85f8", "new_mode": 33188, "new_path": "api/video/video_frame_metadata.h" } ] }