)]}'
{
  "commit": "9703f8474f156e08e4a96dc36253f1cdccd549e1",
  "tree": "f42452c53c215cc58027bd32ab8420a07078e66c",
  "parents": [
    "518de1673ed411ba84b417377751ca7603a89bc1"
  ],
  "author": {
    "name": "Jan Grulich",
    "email": "grulja@gmail.com",
    "time": "Mon Sep 23 11:27:26 2024"
  },
  "committer": {
    "name": "WebRTC LUCI CQ",
    "email": "webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Mon Sep 23 12:20:30 2024"
  },
  "message": "PipeWire camera: use exact stream parameters specified by capability\n\nWe currently specify stream parameters to be a range for both framerate\nand resolution, where preferred value is specified. The preferred value\ndoesn\u0027t seem to be taken into account and we end up accepting resolution\nfrom 1x1 to MAX_INTxMAX_INT. In case the other side tries to first match\nwith lower resolution than requested, we will happily match it and start\nstreaming low quality video. We should instead request the exact stream\nparameters as specified by requested capability. This capability always\ncome from what has been originally reported as supported so it shouldn\u0027t\nhappen we don\u0027t find a matching stream. This also applies to requested\nvideo format. We previously requested mjpg for streams with resolution\nhigher than 640x480, but it doesn\u0027t necessarily mean the camera supports\nmjpg for the requested resolution. Again, refer to requested capability\nin this case as it should indicate what is supported and we know we can\nrequest exactly the same video format. It can happen that framerate is\nset to 0 as unspecified. In that case keep using a range as before, but\nwith more sane values.\n\nBug: webrtc:42225999\nChange-Id: I46d8e83c636e25e12c45a462596fee1d5e59888e\nReviewed-on: https://webrtc-review.googlesource.com/c/src/+/362820\nReviewed-by: Ilya Nikolaevskiy \u003cilnik@webrtc.org\u003e\nCommit-Queue: Jan Grulich \u003cgrulja@gmail.com\u003e\nReviewed-by: Andreas Pehrson \u003capehrson@mozilla.com\u003e\nCr-Commit-Position: refs/heads/main@{#43067}\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "b21b55fd7d8f4fe10f6b21588cf53392092a7872",
      "old_mode": 33188,
      "old_path": "modules/video_capture/linux/video_capture_pipewire.cc",
      "new_id": "e9d99133f5234a129cc7fbbb8a43432543617af8",
      "new_mode": 33188,
      "new_path": "modules/video_capture/linux/video_capture_pipewire.cc"
    },
    {
      "type": "modify",
      "old_id": "eeb3b9497c73427bb5d15c1de33137bb5a0b5cc7",
      "old_mode": 33188,
      "old_path": "modules/video_capture/linux/video_capture_pipewire.h",
      "new_id": "789f2034d3027bacc22a30366bea0ae33a53435a",
      "new_mode": 33188,
      "new_path": "modules/video_capture/linux/video_capture_pipewire.h"
    }
  ]
}