)]}' { "commit": "998524a08e085f3180740642946a489a74b520e9", "tree": "827bbeec7e85c459a6c7e507e8803d18a2b6e339", "parents": [ "743b9b258c4eda14ce0e13ee80873fcd3ca2aafb" ], "author": { "name": "Erik Språng", "email": "sprang@webrtc.org", "time": "Fri May 29 14:13:32 2020" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Fri May 29 16:27:34 2020" }, "message": "Fixes issue with excessive stats updating in TaskQueuePacedSender.\n\nTaskQueuePacedSender::MaybeUpdateStats() is intended to be called when\npackets are sent or by a sequence of \"scheduled\" calls. There should\nonly be one scheduled call in flight at a time - and that one\nreschedules itself if needed when it runs.\n\nA bug however caused the \"schedules task in flight\" flag to\nincorrectly be set to false, leading to more and more schedules tasks\nbeing alive - eating CPU cycles.\n\nThis CL fixes that and also makes sure the queue time properly goes\ndown to zero before the next idle interval check, even if there are no\nmore packets to send.\n\nBug: webrtc:10809\nChange-Id: I4e13fcf95619a43dcaf0ed38bce9684a5b0d8d5e\nReviewed-on: https://webrtc-review.googlesource.com/c/src/+/176330\nReviewed-by: Ilya Nikolaevskiy \u003cilnik@webrtc.org\u003e\nCommit-Queue: Erik Språng \u003csprang@webrtc.org\u003e\nCr-Commit-Position: refs/heads/master@{#31390}\n", "tree_diff": [ { "type": "modify", "old_id": "77f21bedbe8c4f9af1574c64a4baa989456cf345", "old_mode": 33188, "old_path": "modules/pacing/pacing_controller.cc", "new_id": "07e265b0da6e4b9f54d8c233a4d2feb6e0426dcc", "new_mode": 33188, "new_path": "modules/pacing/pacing_controller.cc" }, { "type": "modify", "old_id": "d058e0371dfe11dcffa3c8de16c21587eafbc562", "old_mode": 33188, "old_path": "modules/pacing/task_queue_paced_sender.cc", "new_id": "e817f1b70887a67ce568dbe3939d4282cce756b4", "new_mode": 33188, "new_path": "modules/pacing/task_queue_paced_sender.cc" }, { "type": "modify", "old_id": "5e6a1770c2450cdf1fbf714ce20ad199885d14a3", "old_mode": 33188, "old_path": "modules/pacing/task_queue_paced_sender.h", "new_id": "c4ee5466e79e26032915c92159655281dbdf0a1b", "new_mode": 33188, "new_path": "modules/pacing/task_queue_paced_sender.h" }, { "type": "modify", "old_id": "50fceea99a8538545f998a52dae1a07bc3995278", "old_mode": 33188, "old_path": "modules/pacing/task_queue_paced_sender_unittest.cc", "new_id": "876cd96cfd581de673e2117e1067824acf461027", "new_mode": 33188, "new_path": "modules/pacing/task_queue_paced_sender_unittest.cc" } ] }