)]}' { "commit": "a743303211b89bbcf4cea438ee797bbbc7b59e80", "tree": "09ac2dce4b3532cf7a3e3a41a018c6298b5cbe74", "parents": [ "84ba1643c28341bc6282bd853b9e8cb6c7fe3091" ], "author": { "name": "Lennart Grahl", "email": "lennart.grahl@gmail.com", "time": "Fri Apr 09 20:05:06 2021" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed Apr 14 08:53:45 2021" }, "message": "Fix RTP header extension encryption\n\nPreviously, RTP header extensions with encryption had been filtered\nif the encryption had been activated (not the other way around) which\nwas likely an unintended logic inversion.\n\nIn addition, it ensures that encrypted RTP header extensions are only\nnegotiated if RTP header extension encryption is turned on. Formerly,\nwhich extensions had been negotiated depended on the order in which\nthey were inserted, regardless of whether or not header encryption was\nactually enabled, leading to no extensions being sent on the wire.\n\nFurther changes:\n\n- If RTP header encryption enabled, prefer encrypted extensions over\n non-encrypted extensions\n- Add most extensions to list of extensions supported for encryption\n- Discard encrypted extensions in a session description in case encryption\n is not supported for that extension\n\nNote that this depends on https://github.com/cisco/libsrtp/pull/491 to get\ninto libwebrtc (cherry-pick or bump libsrtp version). Otherwise, two-byte\nheader extensions will prevent any RTP packets being sent/received.\n\nBug: webrtc:11713\nChange-Id: Ia0779453d342fa11e06996d9bc2d3c826f3466d3\nReviewed-on: https://webrtc-review.googlesource.com/c/src/+/177980\nReviewed-by: Harald Alvestrand \u003chta@webrtc.org\u003e\nReviewed-by: Taylor \u003cdeadbeef@webrtc.org\u003e\nCommit-Queue: Harald Alvestrand \u003chta@webrtc.org\u003e\nCr-Commit-Position: refs/heads/master@{#33723}\n", "tree_diff": [ { "type": "modify", "old_id": "8a18f8983f926efd8b0b470be5d26a26f9e3208f", "old_mode": 33188, "old_path": "api/rtp_parameters.cc", "new_id": "132c888bd3ff3372a5494057d0f3cc09a333709b", "new_mode": 33188, "new_path": "api/rtp_parameters.cc" }, { "type": "modify", "old_id": "7fe9f2bc838264ba72c7f2eb3325296b7e39a1f8", "old_mode": 33188, "old_path": "api/rtp_parameters.h", "new_id": "5764d9739c3d382c6010719c41e5fef8ae12b833", "new_mode": 33188, "new_path": "api/rtp_parameters.h" }, { "type": "modify", "old_id": "5928cbda6301f8335b7d0a64906b5951390fcd2a", "old_mode": 33188, "old_path": "api/rtp_parameters_unittest.cc", "new_id": "51ad4267483220b4e566ec861105762aca12e4f2", "new_mode": 33188, "new_path": "api/rtp_parameters_unittest.cc" }, { "type": "modify", "old_id": "84769d0f4b0de3152bf80bd7a4264a7e6d072aa7", "old_mode": 33188, "old_path": "modules/rtp_rtcp/source/rtp_packet.cc", "new_id": "a8134fd1241671a58a30b1f94177ead1a5286551", "new_mode": 33188, "new_path": "modules/rtp_rtcp/source/rtp_packet.cc" }, { "type": "modify", "old_id": "f37be6716b09c4bdae4fd484ff58e259285403f8", "old_mode": 33188, "old_path": "pc/channel.cc", "new_id": "872dc5693c17cdb077153d7a2e73bd8fd9b3677d", "new_mode": 33188, "new_path": "pc/channel.cc" }, { "type": "modify", "old_id": "fe3778b6cdaf63f6459bdd05548d53e364de9589", "old_mode": 33188, "old_path": "pc/channel.h", "new_id": "ab8b9b8624f1e22553c41e7852a0034e7223b7bb", "new_mode": 33188, "new_path": "pc/channel.h" }, { "type": "modify", "old_id": "312b1280b187dfbc6c1c3e57fbbe0d64f96418a4", "old_mode": 33188, "old_path": "pc/jsep_transport_controller.cc", "new_id": "1632a37467fe97152df86b683dca1f242932303d", "new_mode": 33188, "new_path": "pc/jsep_transport_controller.cc" }, { "type": "modify", "old_id": "6374f17be1027d1dbf524bfd2e8bf078e2701206", "old_mode": 33188, "old_path": "pc/media_session.cc", "new_id": "e159808ba319dd2a0272f7d59b3446230d2c4117", "new_mode": 33188, "new_path": "pc/media_session.cc" }, { "type": "modify", "old_id": "940d746e5f2c7988108a6b8c5624e2e083a0d924", "old_mode": 33188, "old_path": "pc/media_session_unittest.cc", "new_id": "745e9e495a31d95704687affb41687a48fbb57a8", "new_mode": 33188, "new_path": "pc/media_session_unittest.cc" }, { "type": "modify", "old_id": "53770eaa500639f171621e60a8cc38fdebb613a4", "old_mode": 33188, "old_path": "pc/sdp_offer_answer.cc", "new_id": "833173a00dac81a595de043858b48339f6f4a110", "new_mode": 33188, "new_path": "pc/sdp_offer_answer.cc" }, { "type": "modify", "old_id": "dacf1a21747b82cf329bcbc047b35cdbee835356", "old_mode": 33188, "old_path": "pc/session_description.h", "new_id": "dde404956dc96ddced9ce862dc00bf22a2c48864", "new_mode": 33188, "new_path": "pc/session_description.h" }, { "type": "modify", "old_id": "91c246c66eed27bf346cb7279a6f73d7f888914b", "old_mode": 33188, "old_path": "video/video_send_stream.cc", "new_id": "087ac3cb99796614d985ce220fba607b27595212", "new_mode": 33188, "new_path": "video/video_send_stream.cc" } ] }