commit | b3c9d3da8f3466a1969c2bbee308cb57105720f6 | [log] [tgz] |
---|---|---|
author | Nico Weber <thakis@chromium.org> | Wed Sep 22 15:53:38 2021 |
committer | WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Sep 22 19:45:44 2021 |
tree | 6ee447c449ff84155e273b1e775743c8e6894369 | |
parent | 4c8be521f1c41677a763fed73c94c782aa510ea5 [diff] |
[ios] Fix two rtc_unittests that fail when using lld as linker setExif: would create a CFDictionary using NULL for keyCallBacks and valueCallBacks. This has the effect of comparing the keys of the dictionary by pointer instead of by value. With ld64, this works because it always dedupes identical constant CFSTR("foo") literal, but lld currently doesn't do this. Using kCFTypeDictionaryKeyCallBacks and kCFTypeDictionaryValueCallBacks fixes the problem with lld and is "more correct" in general: Now the dictionary would work with computed CFStrings too, it shows up better in CFShow() output, etc. While here, also fix a memory leak in setExif:. Bug: chromium:1251763 Change-Id: I43c96d2189a4a77fe3bd0dfb3e33623925b0f900 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232760 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/main@{#35067}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See here for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.