)]}'
{
  "commit": "b46083ed6308b95f1e83570342dbe3eb0a54729e",
  "tree": "427a83e74d707fbbe3a50cfbd7f3d9f570f2933c",
  "parents": [
    "696a802332f0e70b062f496d0c869030d58e70d7"
  ],
  "author": {
    "name": "peah",
    "email": "peah@webrtc.org",
    "time": "Tue May 03 14:01:18 2016"
  },
  "committer": {
    "name": "Commit bot",
    "email": "commit-bot@chromium.org",
    "time": "Tue May 03 14:01:27 2016"
  },
  "message": "This CL introduces a new data logging functionality\nto use for the APM. It allows simple and rapid\nadditions of exploratory data logpoints to use\nduring bug investigations and module performance\nanalysis.\nThe new data logging functionality is also in this CL\nused to replace the existing data logging functionality\npresent in the AEC.\n\nAdditional information:\nAs there was an issue with that the build flag for\nactivating this feature was not present in all\ncompilation units that included the feature additional\nchanges were needed. A summary of the changes are\n-The build files were modified to ensure that the\n logging build flag always is set to either 0 or 1\n for compilation units that include the feature.\n-Build-time checks in the appropriate places were added\n to ensure that the above is fulfilled.\n-The build object was added dynamically to the AEC state\n as a pointer to ensure that the size of that state is not\n dependent on whether the logging build flag is set or not.\n-The constructor of the AEC class needed to be modified in\n order to construct the logging object. For this a destructor\n was also needed.\n-An unused method without any declaration was removed in\n order to avoid any issues with the logging flag being set to\n 0 or 1.\n\nThis CL will be immediately followed with an upcoming CL\nthat replaces the logging in echo_cancellation.cc with the\nnew functionality which will ensure that the  logging flag\nis only used in one place within WebRTC, which in turn will\nfully ensure that all compilation units that uses the feature\nalso have the flag properly set.\n\nBUG\u003dwebrtc:5201, webrtc:5298\n\nReview-Url: https://codereview.webrtc.org/1877713002\nCr-Commit-Position: refs/heads/master@{#12607}\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "a3434836d84d9068b739d4c089d90051a80f493a",
      "old_mode": 33188,
      "old_path": "webrtc/modules/audio_processing/BUILD.gn",
      "new_id": "c18c1d80cfe054063253707ad24d3dede9b647bd",
      "new_mode": 33188,
      "new_path": "webrtc/modules/audio_processing/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "aa6cfa820889ebf7951ce7f6f08808b8e1682f6b",
      "old_mode": 33188,
      "old_path": "webrtc/modules/audio_processing/aec/aec_core.cc",
      "new_id": "2a6adde961d4476f2fd0c87b14629032dc5193fe",
      "new_mode": 33188,
      "new_path": "webrtc/modules/audio_processing/aec/aec_core.cc"
    },
    {
      "type": "modify",
      "old_id": "46b748ba83b1a61c4d8185f72372d66236901ef7",
      "old_mode": 33188,
      "old_path": "webrtc/modules/audio_processing/aec/aec_core.h",
      "new_id": "1155bc38b08629ebbb3561d207742f8537210ef8",
      "new_mode": 33188,
      "new_path": "webrtc/modules/audio_processing/aec/aec_core.h"
    },
    {
      "type": "modify",
      "old_id": "c7f91d7da33beb46648b983d59a3278a582c198d",
      "old_mode": 33188,
      "old_path": "webrtc/modules/audio_processing/aec/aec_core_internal.h",
      "new_id": "11e5bb0c400eb2f7556fa8732078a868392fa566",
      "new_mode": 33188,
      "new_path": "webrtc/modules/audio_processing/aec/aec_core_internal.h"
    },
    {
      "type": "modify",
      "old_id": "f963a4e1d30fc76f02160675fff671b63e2d0a5b",
      "old_mode": 33188,
      "old_path": "webrtc/modules/audio_processing/aec/echo_cancellation.cc",
      "new_id": "6b1758a15ade7ce3c8fcb6b559524c3bf1f24e5c",
      "new_mode": 33188,
      "new_path": "webrtc/modules/audio_processing/aec/echo_cancellation.cc"
    },
    {
      "type": "modify",
      "old_id": "b4a6fd8390e6893c99e0a9ce5ec969868b18342b",
      "old_mode": 33188,
      "old_path": "webrtc/modules/audio_processing/aec/echo_cancellation_internal.h",
      "new_id": "188fb576f0b9f7bb15eb1808e6212b9aa9082c3b",
      "new_mode": 33188,
      "new_path": "webrtc/modules/audio_processing/aec/echo_cancellation_internal.h"
    },
    {
      "type": "modify",
      "old_id": "fd41eea48c77fab35c6d64ea7c7616d6b4655bb7",
      "old_mode": 33188,
      "old_path": "webrtc/modules/audio_processing/audio_processing.gypi",
      "new_id": "4ee6c5c3c1e25f751563538ac3d505776a642349",
      "new_mode": 33188,
      "new_path": "webrtc/modules/audio_processing/audio_processing.gypi"
    },
    {
      "type": "delete",
      "old_id": "b062913be28944d098caa378196f5b7d8886945d",
      "old_mode": 33188,
      "old_path": "webrtc/modules/audio_processing/logging/aec_logging.h",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "delete",
      "old_id": "3a434714e1e754bd6fb6c7b2dfd850dac37cf735",
      "old_mode": 33188,
      "old_path": "webrtc/modules/audio_processing/logging/aec_logging_file_handling.cc",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "delete",
      "old_id": "5ec83948726ffda6e535515634578b57ecb2d613",
      "old_mode": 33188,
      "old_path": "webrtc/modules/audio_processing/logging/aec_logging_file_handling.h",
      "new_id": "0000000000000000000000000000000000000000",
      "new_mode": 0,
      "new_path": "/dev/null"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "491196e09729804af564af859146fdb08c9a1fe3",
      "new_mode": 33188,
      "new_path": "webrtc/modules/audio_processing/logging/apm_data_dumper.cc"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "18f9e5e18153282110c046a5cbf449a876107144",
      "new_mode": 33188,
      "new_path": "webrtc/modules/audio_processing/logging/apm_data_dumper.h"
    }
  ]
}