)]}' { "commit": "b62dbbe985c643cf4ee28e4c73c75bb3ef5e4d54", "tree": "6e59ec270ff6d4137bf0bf55a7639923d99eb3a9", "parents": [ "25f6a39181c9162d26c12ceb8af69e405b2da9e5" ], "author": { "name": "kjellander", "email": "kjellander@webrtc.org", "time": "Fri Sep 23 07:38:52 2016" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Fri Sep 23 07:38:58 2016" }, "message": "GN: Change rtc_source_set targets --\u003e rtc_static_library\n\nThis changes most non-test related rtc_source_set targets to be\nrtc_static_library instead. Targets without any .cc files are excluded.\nThis should bring back the build behavior we used to have with GYP\n(i.e. same symbols exported in the libjingle_peerconnection.a file, which\nare used by some downstream projects).\n\nAfter doing an Android build with these changes:\n$ nm --defined-only -g -C out/Release/lib.unstripped/libjingle_peerconnection_so.so | grep -i createpeerconnectionf\n00077c51 T Java_org_webrtc_PeerConnectionFactory_nativeCreatePeerConnectionFactory\n$ nm --defined-only -g -C out/Release/obj/webrtc/api/libjingle_peerconnection.a | grep -i createpeerconnectionf\n00000001 T webrtc::CreatePeerConnectionFactory(rtc::Thread*, rtc::Thread*, rtc::Thread*, webrtc::AudioDeviceModule*, cricket::WebRtcVideoEncoderFactory*, cricket::WebRtcVideoDecoderFactory*)\n00000001 T webrtc::CreatePeerConnectionFactory()\n\nSee https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/cookbook.md#Note-on-static-libraries\nfor more details on this.\n\nNOTICE: This should be further cleaned up in the future, to reduce\nbinary bloat and unnecessary linking time. Right now it\u0027s more\nimportant to restore the desired build output though.\n\nBUG\u003dwebrtc:6410, chromium:630755\n\nReview-Url: https://codereview.webrtc.org/2361623004\nCr-Commit-Position: refs/heads/master@{#14364}\n", "tree_diff": [ { "type": "modify", "old_id": "47b757a237fafa0c8de3bdf438f76edc965af542", "old_mode": 33188, "old_path": "webrtc/BUILD.gn", "new_id": "d4308e12c5c809da5e727770d03d82fef0b716ca", "new_mode": 33188, "new_path": "webrtc/BUILD.gn" }, { "type": "modify", "old_id": "d58371c20d29d59e3dc0d6d12488e57535e8641d", "old_mode": 33188, "old_path": "webrtc/api/BUILD.gn", "new_id": "6fe43a75dc654ea0e4a5684bd42750c53b94c113", "new_mode": 33188, "new_path": "webrtc/api/BUILD.gn" }, { "type": "modify", "old_id": "d29ca8a82ef613d5d660fd2b79e1cc9c9f26bcc7", "old_mode": 33188, "old_path": "webrtc/audio/BUILD.gn", "new_id": "14607cdd739b01f5f288f80727d7b7d836c01940", "new_mode": 33188, "new_path": "webrtc/audio/BUILD.gn" }, { "type": "modify", "old_id": "05a319210a75fb73ef0df9f0ba1ea4696869c20e", "old_mode": 33188, "old_path": "webrtc/call/BUILD.gn", "new_id": "32bcba3abd0893c9bb13beff2152accc1eb3dfa0", "new_mode": 33188, "new_path": "webrtc/call/BUILD.gn" }, { "type": "modify", "old_id": "08a97b2507ffa5690145c30ecc202ddb48d3ec23", "old_mode": 33188, "old_path": "webrtc/common_audio/BUILD.gn", "new_id": "6258fb45527f4a57ef71e40ae70b64bd62866607", "new_mode": 33188, "new_path": "webrtc/common_audio/BUILD.gn" }, { "type": "modify", "old_id": "8b553b2a3c27a389c814936c8265b0f1fd4a7753", "old_mode": 33188, "old_path": "webrtc/common_video/BUILD.gn", "new_id": "845a5eb8af74e00d92f3ffefddcd222fffd79897", "new_mode": 33188, "new_path": "webrtc/common_video/BUILD.gn" }, { "type": "modify", "old_id": "ce995221e15b4c2774c3a575198dcab34e1ab005", "old_mode": 33188, "old_path": "webrtc/examples/BUILD.gn", "new_id": "da50bfd14a50d52c8ecdc450b2cc802d12fb906c", "new_mode": 33188, "new_path": "webrtc/examples/BUILD.gn" }, { "type": "modify", "old_id": "13211ac44dc766fc103f139fb7e1a3169cf16684", "old_mode": 33188, "old_path": "webrtc/libjingle/xmllite/BUILD.gn", "new_id": "496d452bd82d426a091fe1aa7f682c6010a9d131", "new_mode": 33188, "new_path": "webrtc/libjingle/xmllite/BUILD.gn" }, { "type": "modify", "old_id": "43a39aa7eb6024bfe73be75b1a7fb896b496c7bb", "old_mode": 33188, "old_path": "webrtc/libjingle/xmpp/BUILD.gn", "new_id": "879d67236acdb31534b8241aee82ebb7bb43b78c", "new_mode": 33188, "new_path": "webrtc/libjingle/xmpp/BUILD.gn" }, { "type": "modify", "old_id": "e31d7e5d5a9ccda82de4e772bf6a56ac2c0da088", "old_mode": 33188, "old_path": "webrtc/media/BUILD.gn", "new_id": "8a4e8088cce4f05fbcc343cd7b7011effa0f6d43", "new_mode": 33188, "new_path": "webrtc/media/BUILD.gn" }, { "type": "modify", "old_id": "a69206eaa2e7517da6cf65b1f4511aa052416014", "old_mode": 33188, "old_path": "webrtc/modules/audio_coding/BUILD.gn", "new_id": "fceff9b0a191801ea4f9956bc26882d667f131ed", "new_mode": 33188, "new_path": "webrtc/modules/audio_coding/BUILD.gn" }, { "type": "modify", "old_id": "73446bab8699923e6fd4dfe42a51dc5030e68cad", "old_mode": 33188, "old_path": "webrtc/modules/audio_conference_mixer/BUILD.gn", "new_id": "129ff5b5ec86d69aaa4746efb275e9b74d205c09", "new_mode": 33188, "new_path": "webrtc/modules/audio_conference_mixer/BUILD.gn" }, { "type": "modify", "old_id": "27718760c31e5767ced6276150193fb6a08a6f11", "old_mode": 33188, "old_path": "webrtc/modules/audio_device/BUILD.gn", "new_id": "31a02d105342957118341714dc2c9903a0a2508b", "new_mode": 33188, "new_path": "webrtc/modules/audio_device/BUILD.gn" }, { "type": "modify", "old_id": "c0e5bb554723ce044a36d16a68b80ea1ce640eb6", "old_mode": 33188, "old_path": "webrtc/modules/audio_mixer/BUILD.gn", "new_id": "40b9f3b9b1cdf621c7cbb165c7b5f3c65002c30f", "new_mode": 33188, "new_path": "webrtc/modules/audio_mixer/BUILD.gn" }, { "type": "modify", "old_id": "2387c2e85b375f819b50960969716978c14a1240", "old_mode": 33188, "old_path": "webrtc/modules/audio_processing/BUILD.gn", "new_id": "54c33e346c87f0e1f6160ea4e38599cad44a5b14", "new_mode": 33188, "new_path": "webrtc/modules/audio_processing/BUILD.gn" }, { "type": "modify", "old_id": "7f10c5d4ea38b54de0a67b3d0308da8ec3994156", "old_mode": 33188, "old_path": "webrtc/modules/bitrate_controller/BUILD.gn", "new_id": "7bf28e4d73f04de33f3b23a43a5466f760fca01e", "new_mode": 33188, "new_path": "webrtc/modules/bitrate_controller/BUILD.gn" }, { "type": "modify", "old_id": "a07acc5171bc8ff23d4014053117190e6b921546", "old_mode": 33188, "old_path": "webrtc/modules/congestion_controller/BUILD.gn", "new_id": "758fba59d86f156dd76a1353c15d8cb6513c5fcb", "new_mode": 33188, "new_path": "webrtc/modules/congestion_controller/BUILD.gn" }, { "type": "modify", "old_id": "8887ba99c3ecc5c146b5ea6d452a221d0e9da40c", "old_mode": 33188, "old_path": "webrtc/modules/desktop_capture/BUILD.gn", "new_id": "46a768aac5e869ed35fd68d56950090eab48b255", "new_mode": 33188, "new_path": "webrtc/modules/desktop_capture/BUILD.gn" }, { "type": "modify", "old_id": "385052cab464446709668109ffdc772b56bd06d7", "old_mode": 33188, "old_path": "webrtc/modules/media_file/BUILD.gn", "new_id": "f73c44bcacff09157f13dc250acbbd40c8d3ec43", "new_mode": 33188, "new_path": "webrtc/modules/media_file/BUILD.gn" }, { "type": "modify", "old_id": "26ad2b124b94889a519e69eadf9afc67cb8b4610", "old_mode": 33188, "old_path": "webrtc/modules/pacing/BUILD.gn", "new_id": "7a16297329c65fd42e494dd4e5030ea092a812c0", "new_mode": 33188, "new_path": "webrtc/modules/pacing/BUILD.gn" }, { "type": "modify", "old_id": "1e42ce9aa65f46e16260573ee2cc9179ae5353e2", "old_mode": 33188, "old_path": "webrtc/modules/remote_bitrate_estimator/BUILD.gn", "new_id": "ea0e214bdc2f45dd2a735a04c6245e62f036faee", "new_mode": 33188, "new_path": "webrtc/modules/remote_bitrate_estimator/BUILD.gn" }, { "type": "modify", "old_id": "e448af07ca01c7645542f2898fc2825f09a4ec64", "old_mode": 33188, "old_path": "webrtc/modules/rtp_rtcp/BUILD.gn", "new_id": "8b9d4b3c4de53c25df46449f584eeae99826c66b", "new_mode": 33188, "new_path": "webrtc/modules/rtp_rtcp/BUILD.gn" }, { "type": "modify", "old_id": "bb51b133be8b3732487555435ee42916bb54727a", "old_mode": 33188, "old_path": "webrtc/modules/utility/BUILD.gn", "new_id": "4d177760bd9c58d8b05eba2069ff88733eacb883", "new_mode": 33188, "new_path": "webrtc/modules/utility/BUILD.gn" }, { "type": "modify", "old_id": "d6e7dce45a364697d29f7d4f8e1308e853f3a25c", "old_mode": 33188, "old_path": "webrtc/modules/video_capture/BUILD.gn", "new_id": "60573ba4b1c359c9c8f629a052eae2d2280b1c27", "new_mode": 33188, "new_path": "webrtc/modules/video_capture/BUILD.gn" }, { "type": "modify", "old_id": "3db9b029ba506bab2e686bc46baa64ab240d7f31", "old_mode": 33188, "old_path": "webrtc/modules/video_coding/BUILD.gn", "new_id": "d9b392d77ac685b120a51b0322bf585415b179c0", "new_mode": 33188, "new_path": "webrtc/modules/video_coding/BUILD.gn" }, { "type": "modify", "old_id": "2cd60681878cc25853cffa1a17c4d6780a5168b4", "old_mode": 33188, "old_path": "webrtc/modules/video_processing/BUILD.gn", "new_id": "baf2e852e268a788dab8faa36e9fe78370ae9163", "new_mode": 33188, "new_path": "webrtc/modules/video_processing/BUILD.gn" }, { "type": "modify", "old_id": "8e1f37b3ffcc7a9f5d05e607711730303b6c9fa1", "old_mode": 33188, "old_path": "webrtc/p2p/BUILD.gn", "new_id": "526155cf028225c73c51e5b014a861053f7ffd2a", "new_mode": 33188, "new_path": "webrtc/p2p/BUILD.gn" }, { "type": "modify", "old_id": "94b0d94fc8ab46174a2586ef4edd211eea2ef2b0", "old_mode": 33188, "old_path": "webrtc/pc/BUILD.gn", "new_id": "42a933fe81fbfce238dda192ca5c42f7901d2903", "new_mode": 33188, "new_path": "webrtc/pc/BUILD.gn" }, { "type": "modify", "old_id": "70954eee8b5b4ed4d4f2abf32cd2e78c1b414f80", "old_mode": 33188, "old_path": "webrtc/sdk/BUILD.gn", "new_id": "96d8ef7a06d4eefda4c426f36a4b6def35fb89c3", "new_mode": 33188, "new_path": "webrtc/sdk/BUILD.gn" }, { "type": "modify", "old_id": "a9c9fb89090d41869fa676f481573c88ffc708d1", "old_mode": 33188, "old_path": "webrtc/stats/BUILD.gn", "new_id": "896674405a47694471d64a4d40b565fd98abf586", "new_mode": 33188, "new_path": "webrtc/stats/BUILD.gn" }, { "type": "modify", "old_id": "8087f69df79bacf7fa719642327cb864d64207e3", "old_mode": 33188, "old_path": "webrtc/system_wrappers/BUILD.gn", "new_id": "4dd85c24fcab2cde11884b49b477224557de09f7", "new_mode": 33188, "new_path": "webrtc/system_wrappers/BUILD.gn" }, { "type": "modify", "old_id": "5ac393df1c03b4a28db8c5e04d73444640993a57", "old_mode": 33188, "old_path": "webrtc/test/BUILD.gn", "new_id": "249c78cce4a5f176b09713c9ee09f90b8e599fb0", "new_mode": 33188, "new_path": "webrtc/test/BUILD.gn" }, { "type": "modify", "old_id": "0bff7bdd2ba2d3bf6f8c81c08e98469eb5c11562", "old_mode": 33188, "old_path": "webrtc/test/fuzzers/BUILD.gn", "new_id": "4e5d67125e2b96c99a2896583100b31f9bf95668", "new_mode": 33188, "new_path": "webrtc/test/fuzzers/BUILD.gn" }, { "type": "modify", "old_id": "dc4fce255c51a7cbfd05757d37419ccd3e0089d2", "old_mode": 33188, "old_path": "webrtc/tools/BUILD.gn", "new_id": "7d9cd40e01f3dca179e31d5b7ca1aef0fab390d2", "new_mode": 33188, "new_path": "webrtc/tools/BUILD.gn" }, { "type": "modify", "old_id": "b877a248354e77b015cc7d9395a2a4730509ed5a", "old_mode": 33188, "old_path": "webrtc/video/BUILD.gn", "new_id": "14266a63de1669095b4968565e9341e2c67906f4", "new_mode": 33188, "new_path": "webrtc/video/BUILD.gn" }, { "type": "modify", "old_id": "8a8050b7eedeb6757b4fdcbeb6319648ca9d1064", "old_mode": 33188, "old_path": "webrtc/voice_engine/BUILD.gn", "new_id": "8ea5328114944baec0fc50f936b895ecaf64ce44", "new_mode": 33188, "new_path": "webrtc/voice_engine/BUILD.gn" } ] }