)]}'
{
  "commit": "bb55e0bc726724c211e2db93d0cdc8bfbcfd3999",
  "tree": "df4ca08d6c76ec43d15d0d17a237366e34c1e193",
  "parents": [
    "eec1d04aa9590816498095fb3a44180c308351dd"
  ],
  "author": {
    "name": "henrika",
    "email": "henrika@webrtc.org",
    "time": "Wed Nov 20 13:40:33 2019"
  },
  "committer": {
    "name": "Commit Bot",
    "email": "commit-bot@chromium.org",
    "time": "Wed Nov 20 15:02:06 2019"
  },
  "message": "Clarifies identification of default communication device in ADM2\n\nADM2 for Windows is based on the CoreAudioUtil class in Chrome.\nCoreAudioUtil in Chrome does not use a special string to identify\nthe Default Communication device but instead a combination of a\nstring (Default) and a role parameter [1].\n\nWhen CoreAudioUtil was ported to WebRTC, I accidentally added an\ninvalid usage of a unique string to identify the default comm device\nand it can lead to errors since there are then two different ways to\nidentify this device. It will also complicate life when we want to\nmerge changes from Chrome into WebRTC.\n\nThis CL removes usage of AudioDeviceName::kDefaultCommunicationsDeviceId\nin WebRTC to reduce the risk of errors.\n\n[1] https://cs.chromium.org/chromium/src/media/audio/win/core_audio_util_win.cc?q\u003dcore_audio_ut\u0026sq\u003dpackage:chromium\u0026g\u003d0\u0026l\u003d464\n\nExcluding flaky bot win_x86_msvc_dbg and using Tbr.\n\nTbr: thaloun@chromium.org\nNo-Try: True\nBug: webrtc:11107\nChange-Id: Ie6687adbe9c3940a217456e4025967f71d86214c\nReviewed-on: https://webrtc-review.googlesource.com/c/src/+/160047\nCommit-Queue: Henrik Andreassson \u003chenrika@webrtc.org\u003e\nReviewed-by: Henrik Andreassson \u003chenrika@webrtc.org\u003e\nCr-Commit-Position: refs/heads/master@{#29848}\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "92d8ba1bcd69ee6b8217c31451a62670df6cc7d8",
      "old_mode": 33188,
      "old_path": "modules/audio_device/audio_device_name.cc",
      "new_id": "5246c768ffa8fb04a88df1dbd5d001646ab72bf5",
      "new_mode": 33188,
      "new_path": "modules/audio_device/audio_device_name.cc"
    },
    {
      "type": "modify",
      "old_id": "267366344a7843a2e151565bfe9e0d089e4c8c79",
      "old_mode": 33188,
      "old_path": "modules/audio_device/audio_device_name.h",
      "new_id": "06a03fddc12b47b74e83497cd425cf2772098fef",
      "new_mode": 33188,
      "new_path": "modules/audio_device/audio_device_name.h"
    },
    {
      "type": "modify",
      "old_id": "ea57af3062091d6e740f463020438ab3ca522e4b",
      "old_mode": 33188,
      "old_path": "modules/audio_device/win/core_audio_base_win.cc",
      "new_id": "52da075cc796036f84cf5ec0a53b7f47db747146",
      "new_mode": 33188,
      "new_path": "modules/audio_device/win/core_audio_base_win.cc"
    },
    {
      "type": "modify",
      "old_id": "1f60e7618f1e7edb99b26dd993ec8ba70fa9c14f",
      "old_mode": 33188,
      "old_path": "modules/audio_device/win/core_audio_utility_win.cc",
      "new_id": "4aaf155ac878bcaf8662da63c53379d516671246",
      "new_mode": 33188,
      "new_path": "modules/audio_device/win/core_audio_utility_win.cc"
    },
    {
      "type": "modify",
      "old_id": "5a27edb6d4423e7b616931b5c6da6e79a9930555",
      "old_mode": 33188,
      "old_path": "modules/audio_device/win/core_audio_utility_win.h",
      "new_id": "265b8996d7d716dcbfa0dcb092e31e815398aa63",
      "new_mode": 33188,
      "new_path": "modules/audio_device/win/core_audio_utility_win.h"
    },
    {
      "type": "modify",
      "old_id": "52b647dbe1c5f4bbdf34dad380493b64f332f4f5",
      "old_mode": 33188,
      "old_path": "modules/audio_device/win/core_audio_utility_win_unittest.cc",
      "new_id": "9e3a02ff699dd792bf9d6622cf9605242f6f9c7f",
      "new_mode": 33188,
      "new_path": "modules/audio_device/win/core_audio_utility_win_unittest.cc"
    }
  ]
}