)]}'
{
  "commit": "bcd9ca27884944c7c916b0dba0996627b57fb905",
  "tree": "be906163886647e5766e7ae019780899af32402b",
  "parents": [
    "6f7a8dc98f1e340b8da7e4bafc831881dd9f6053"
  ],
  "author": {
    "name": "Zequan Wu",
    "email": "zequanwu@google.com",
    "time": "Tue Jul 07 19:30:59 2026"
  },
  "committer": {
    "name": "webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "email": "webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Wed Jul 08 18:46:41 2026"
  },
  "message": "Fix -Wpointer-bool-conversion warning in FunctionView\n\nLLVM PR 204944 updated Clang\u0027s -Wpointer-bool-conversion and\n-Wtautological-pointer-compare to look through lvalue references to\nfunctions and warn when they are evaluated in a boolean context or\ncompared against null.\nWhen passing a function designator/name without \u0027\u0026\u0027 to\nwebrtc::FunctionView, template argument deduction infers the type as an\nlvalue reference to a function. Previously, FunctionView used a single\nconstructor for both function pointers and function references, which\nchecked \u0027f ? ... : nullptr\u0027. Evaluating a function reference in this\nternary check triggered -Wpointer-bool-conversion.\nThis change splits the constructor into two mutually exclusive\nconstructors:\n1. One for function pointers (using std::is_pointer), retaining the\n   null check.\n2. One for function references (using std::is_function), initializing\n   call_ directly without the null check since function references can\n   never be null.\n\nBug: chromium:531796076\nChange-Id: Ibb798adddb47c5a110232e4caf956eba2a0743fe\nReviewed-on: https://webrtc-review.googlesource.com/c/src/+/488020\nReviewed-by: Danil Chapovalov \u003cdanilchap@webrtc.org\u003e\nCommit-Queue: Zequan Wu \u003czequanwu@google.com\u003e\nReviewed-by: Denise Tell \u003cdct@google.com\u003e\nCr-Commit-Position: refs/heads/main@{#48172}\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "adbb5cdcb323840bb6901acf8722bccc47c26723",
      "old_mode": 33188,
      "old_path": "api/function_view.h",
      "new_id": "1c25bedebd6858e1446bff53bce24d2f8e2881e6",
      "new_mode": 33188,
      "new_path": "api/function_view.h"
    }
  ]
}