)]}' { "commit": "c1b36669db55a17ab7049bd2ea68db27653c097c", "tree": "7b4a67c1facbce1381f49ec05fe9ca304c6a745c", "parents": [ "2988acac0594f3a32109691d554f2912a08d4dc1" ], "author": { "name": "Henrik Boström", "email": "hbos@webrtc.org", "time": "Thu May 23 17:34:59 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu May 23 17:35:07 2019" }, "message": "Revert \"Delete STACK_ARRAY macro, and use of alloca\"\n\nThis reverts commit 74b373f04a69b279e45b0792d86c594cb33d22c1.\n\nReason for revert: This breaks chromium, blocking webrtc from rolling.\n\n...\nIn file included from ../../third_party/webrtc\\rtc_base/strings/string_builder.h:23:\n../../third_party/webrtc\\rtc_base/string_utils.h(54,28): error: implicit conversion loses integer precision: \u0027std::__1::basic_string\u003cwchar_t, std::__1::char_traits\u003cwchar_t\u003e, std::__1::allocator\u003cwchar_t\u003e \u003e::size_type\u0027 (aka \u0027unsigned long long\u0027) to \u0027int\u0027 [-Werror,-Wshorten-64-to-32]\n ws.size());\n\nSee https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8912652299012991936/+/steps/compile__with_patch_/0/stdout\n\nOriginal change\u0027s description:\n\u003e Delete STACK_ARRAY macro, and use of alloca\n\u003e \n\u003e Refactor the few uses of STACK_ARRAY to avoid an extra copy\n\u003e on the stack.\n\u003e \n\u003e Bug: webrtc:6424\n\u003e Change-Id: I5c8f3c0381523db0ead31207d949df9a286c76ba\n\u003e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/137806\n\u003e Commit-Queue: Niels Moller \u003cnisse@webrtc.org\u003e\n\u003e Reviewed-by: Karl Wiberg \u003ckwiberg@webrtc.org\u003e\n\u003e Cr-Commit-Position: refs/heads/master@{#28038}\n\nTBR\u003dkwiberg@webrtc.org,nisse@webrtc.org\n\nChange-Id: I223fceab60855dde363cc9ce8375e8f5cca43c02\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nBug: webrtc:6424\nReviewed-on: https://webrtc-review.googlesource.com/c/src/+/138209\nReviewed-by: Henrik Boström \u003chbos@webrtc.org\u003e\nCommit-Queue: Henrik Boström \u003chbos@webrtc.org\u003e\nCr-Commit-Position: refs/heads/master@{#28043}\n", "tree_diff": [ { "type": "modify", "old_id": "da31ac08b3fd7207fa5eda8a0ccf7c523f027049", "old_mode": 33188, "old_path": "rtc_base/string_encode.cc", "new_id": "7b2eda7051f42d3e233d043e44b7fc32149bbacc", "new_mode": 33188, "new_path": "rtc_base/string_encode.cc" }, { "type": "modify", "old_id": "5b5d33c1486d6f022555c576ddba33e8be76edef", "old_mode": 33188, "old_path": "rtc_base/string_utils.h", "new_id": "bc332846a465eb91f10541e0ad65b8e678bd3bfd", "new_mode": 33188, "new_path": "rtc_base/string_utils.h" } ] }