commit c1dc8abeeb3d38b67a5785e35bcb4a3895d4069c
author Philipp Hancke <phancke@meta.com> Tue Sep 17 15:46:40 2024
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Sep 19 17:49:37 2024
tree 6ba40f859ec74b8b9cd9415ca4f21b2306881a0d
parent 4595711bf590f71a693579a6a7b01a76e2988173

Remove non-span NAL unit splitter and SPS parser

after cleaning up the Chromium dependency

BUG=webrtc:42225170

Change-Id: Icd3934ca51f829c55e061fc1943500435c845a8d
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/362569
Reviewed-by: Sergey Silkin <ssilkin@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Commit-Queue: Philipp Hancke <phancke@meta.com>
Cr-Commit-Position: refs/heads/main@{#43053}

common_video/h264/h264_common.h

diff --git a/common_video/h264/h264_common.h b/common_video/h264/h264_common.h
index e7df02a..0068b78 100644
--- a/common_video/h264/h264_common.h
+++ b/common_video/h264/h264_common.h
@@ -66,12 +66,6 @@
 RTC_EXPORT std::vector<NaluIndex> FindNaluIndices(
     rtc::ArrayView<const uint8_t> buffer);
 
-// TODO: bugs.webrtc.org/42225170 - Deprecate.
-inline std::vector<NaluIndex> FindNaluIndices(const uint8_t* buffer,
-                                              size_t buffer_size) {
-  return FindNaluIndices(rtc::MakeArrayView(buffer, buffer_size));
-}
-
 // Get the NAL type from the header byte immediately following start sequence.
 RTC_EXPORT NaluType ParseNaluType(uint8_t data);
 

common_video/h264/sps_parser.h

diff --git a/common_video/h264/sps_parser.h b/common_video/h264/sps_parser.h
index 7347e6d..49cca71 100644
--- a/common_video/h264/sps_parser.h
+++ b/common_video/h264/sps_parser.h
@@ -44,11 +44,6 @@
 
   // Unpack RBSP and parse SPS state from the supplied buffer.
   static std::optional<SpsState> ParseSps(rtc::ArrayView<const uint8_t> data);
-  // TODO: bugs.webrtc.org/42225170 - Deprecate.
-  static inline std::optional<SpsState> ParseSps(const uint8_t* data,
-                                                 size_t length) {
-    return ParseSps(rtc::MakeArrayView(data, length));
-  }
 
  protected:
   // Parse the SPS state, up till the VUI part, for a buffer where RBSP