)]}'
{
  "commit": "cbf5122333ce2e34572dfba1c3c0e32304362adc",
  "tree": "4f7dd4da0f4f214bfd95fdac6b3c06d0d9a6464e",
  "parents": [
    "8487d3248b51b12435ec7aabb66e1f666ce5de67"
  ],
  "author": {
    "name": "Henrik Boström",
    "email": "hbos@webrtc.org",
    "time": "Mon Sep 16 10:57:42 2024"
  },
  "committer": {
    "name": "WebRTC LUCI CQ",
    "email": "webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Mon Sep 16 11:00:13 2024"
  },
  "message": "Avoid signaling requested_resolution back to the adapting source.\n\nWhen requested_resolution uses a different aspect ratio than the source\nthe encoder will restrict the frame without changing its aspect ratio,\ne.g. a 60x30 input frame that is restricted to 30x30 results in 30x15,\nnot 30x30.\n\nWhile this logic works correctly in isolation, if the source also adapts\nthe frame size based on the sink_wants.requested_resolution that is\nsignaled back to the source, then the source will produce stretched\n30x30 prior to the encoder which happily sends 30x30 not knowing any\nwiser.\n\nThis is incompatible with the spec[1] and makes this WPT[2] fail. The\ncorrect behavior is to NOT signal the requested_resolution back to the\nsource, the encoder already configures the correct resolution so this\nisn\u0027t actually needed and the source shouldn\u0027t need to know this API.\n\nIn order not to break downstream projects, the new behavior is landed\nbehind a flag and both behaviors are tested with TEST_P.\n\nThis unblocks launching scaleResolutionDownTo API on Web. Migrating\nfrom old to new code path and deleting the flag is a follow-up AI:\nwebrtc:366284861.\n\n[1] https://w3c.github.io/webrtc-extensions/#dom-rtcrtpencodingparameters-scaleresolutiondownto\n[2] https://chromium-review.googlesource.com/c/chromium/src/+/5853944\n\n# Relying on previous green runs for confidence due to purple bots atm,\n# see b/367211396\nNOTRY\u003dTrue\nNOPRESUBMIT\u003dTrue\n\nBug: webrtc:366067962, webrtc:366284861\nChange-Id: I7fd1016e9cc6f0b0b9b8c23b0708e521f8e12642\nReviewed-on: https://webrtc-review.googlesource.com/c/src/+/362541\nReviewed-by: Henrik Andreassson \u003chenrika@webrtc.org\u003e\nReviewed-by: Ilya Nikolaevskiy \u003cilnik@webrtc.org\u003e\nCommit-Queue: Henrik Boström \u003chbos@webrtc.org\u003e\nCr-Commit-Position: refs/heads/main@{#43024}\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "c8cb368ce74e21303a186b230273479608f7e1f6",
      "old_mode": 33188,
      "old_path": "api/video/video_stream_encoder_settings.h",
      "new_id": "e49305b37567d108b25e4a1178081478624e5fed",
      "new_mode": 33188,
      "new_path": "api/video/video_stream_encoder_settings.h"
    },
    {
      "type": "modify",
      "old_id": "487845d2dc37bbacac3743a6270fecf50d0096c1",
      "old_mode": 33188,
      "old_path": "media/base/video_adapter.cc",
      "new_id": "bb1515b12bac3415804f5d5ee6c69e21a1a6b4bf",
      "new_mode": 33188,
      "new_path": "media/base/video_adapter.cc"
    },
    {
      "type": "modify",
      "old_id": "da42b2a137554cdfef9261a771b8268c81319eb3",
      "old_mode": 33188,
      "old_path": "video/video_stream_encoder.cc",
      "new_id": "61b94835216c958556c5183fade0f61e20c29675",
      "new_mode": 33188,
      "new_path": "video/video_stream_encoder.cc"
    },
    {
      "type": "modify",
      "old_id": "573b6a545f077a46a0a25f47a65c045b4d57af09",
      "old_mode": 33188,
      "old_path": "video/video_stream_encoder_unittest.cc",
      "new_id": "f5c42126c3e77d67e206be9b7d136cb0fbbb7de8",
      "new_mode": 33188,
      "new_path": "video/video_stream_encoder_unittest.cc"
    }
  ]
}