)]}' { "commit": "cc189177a63ae772a74373343a564d2b8772e8fb", "tree": "544833c33bd8402e5dfbc3567679fd4a91f1d9ec", "parents": [ "39f46810ffad6657e7b352b17d600f4c9c6433e7" ], "author": { "name": "Henrik Andreassson", "email": "henrika@webrtc.org", "time": "Mon May 20 09:01:38 2019" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon May 20 14:28:37 2019" }, "message": "Revert \"Improve spec compliance of SetStreamIDs in RtpSenderInterface\"\n\nThis reverts commit df5731e44d510e9f23a35b77e9e102eb41919bf4.\n\nReason for revert: Breaks WebRTC in Chrome FYI for all platforms.\n\nhttps://ci.chromium.org/p/chromium/builders/webrtc.fyi/WebRTC%20Chromium%20FYI%20Mac%20Tester/2966\n\nOriginal change\u0027s description:\n\u003e Improve spec compliance of SetStreamIDs in RtpSenderInterface\n\u003e\n\u003e This CL makes RtpSender::SetStreamIDs fire fire negotiationneeded\n\u003e event if needed and exposes the method on RtpSenderInterface.\n\u003e\n\u003e This is a spec-compliance change.\n\u003e\n\u003e Bug: webrtc:10129\n\u003e Change-Id: I2b98b92665c847102838b094516a79b24de0e47e\n\u003e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/135121\n\u003e Commit-Queue: Guido Urdaneta \u003cguidou@webrtc.org\u003e\n\u003e Reviewed-by: Steve Anton \u003csteveanton@webrtc.org\u003e\n\u003e Reviewed-by: Henrik Boström \u003chbos@webrtc.org\u003e\n\u003e Cr-Commit-Position: refs/heads/master@{#27974}\n\nTBR\u003dsteveanton@webrtc.org,hbos@webrtc.org,guidou@webrtc.org\n\n# Passing all bots except for flaky webrtc_perf_tests\nNOTRY\u003dTrue\n\nBug: webrtc:10129\nChange-Id: If97317f7a01b34465685fcebbeea0d7576ed7328\nReviewed-on: https://webrtc-review.googlesource.com/c/src/+/137431\nCommit-Queue: Henrik Boström \u003chbos@webrtc.org\u003e\nReviewed-by: Henrik Andreassson \u003chenrika@webrtc.org\u003e\nCr-Commit-Position: refs/heads/master@{#27988}\n", "tree_diff": [ { "type": "modify", "old_id": "850773150e34e0eaf0101b50fa6023958a6868f0", "old_mode": 33188, "old_path": "api/rtp_sender_interface.h", "new_id": "e0a29a33cb7caa1b5e0fbc14d4de898fec005f03", "new_mode": 33188, "new_path": "api/rtp_sender_interface.h" }, { "type": "modify", "old_id": "551b0ed17670be37f5bf00075ebc9c03e3cdaf34", "old_mode": 33188, "old_path": "pc/peer_connection.cc", "new_id": "065247d0132f3043d0e8c67cbb60b72f538eeeed", "new_mode": 33188, "new_path": "pc/peer_connection.cc" }, { "type": "modify", "old_id": "f636c009c7adb0b12795ee9b0284d968f2e5f185", "old_mode": 33188, "old_path": "pc/peer_connection.h", "new_id": "300918583e5495a23db0ff3c07e102a0fa949b3b", "new_mode": 33188, "new_path": "pc/peer_connection.h" }, { "type": "modify", "old_id": "8e99727acd1ebe6418f04e3595bd185c69f6e54b", "old_mode": 33188, "old_path": "pc/peer_connection_rtp_unittest.cc", "new_id": "6925300a717146badd86e526c77da073031d433f", "new_mode": 33188, "new_path": "pc/peer_connection_rtp_unittest.cc" }, { "type": "modify", "old_id": "609703416fd51c5f2712d91bd183d9b85e946d82", "old_mode": 33188, "old_path": "pc/rtp_sender.cc", "new_id": "22957d3ae179a5acbe4495b6cd332743c1384bf4", "new_mode": 33188, "new_path": "pc/rtp_sender.cc" }, { "type": "modify", "old_id": "73c69259136cd31e01fa990042c9af9f5d0837d0", "old_mode": 33188, "old_path": "pc/rtp_sender.h", "new_id": "c786d906d8bca44590eddffb6734c0f1dfb75b82", "new_mode": 33188, "new_path": "pc/rtp_sender.h" }, { "type": "modify", "old_id": "be8c47205bddcec0148fe480ed80d95edd064cdd", "old_mode": 33188, "old_path": "pc/rtp_sender_receiver_unittest.cc", "new_id": "90ca03fa8e38105b7b6ffc79cd0f8d9d6d03c221", "new_mode": 33188, "new_path": "pc/rtp_sender_receiver_unittest.cc" }, { "type": "modify", "old_id": "181dcbb29685287b4709a6498358e6656b3e0227", "old_mode": 33188, "old_path": "pc/test/mock_rtp_sender_internal.h", "new_id": "fa16220e9a5ac1a63d6e9846eb18bb9a6c26e7a3", "new_mode": 33188, "new_path": "pc/test/mock_rtp_sender_internal.h" } ] }