)]}'
{
  "commit": "cd3d29b6fbfc89f6ad8ec59841d5cf887bd38629",
  "tree": "0a7ffb8f0306e5faa903b591b9152fbcb84c2e79",
  "parents": [
    "b4913a549f23bb08460a9a9c8e8e3cf95090092b"
  ],
  "author": {
    "name": "Victor Boivie",
    "email": "boivie@webrtc.org",
    "time": "Sat Mar 09 20:50:42 2024"
  },
  "committer": {
    "name": "WebRTC LUCI CQ",
    "email": "webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Tue Mar 12 10:57:56 2024"
  },
  "message": "pc: Simplify StreamId class\n\nBefore this CL, the StreamId class represented either a valid SCTP\nstream ID, or \"nothing\", which means that it was a wrapped\nabsl::optional. Since created data channels don\u0027t have a SCTP stream ID\nuntil it\u0027s known whether this peer will use odd or even numbers, the\n\"nothing\" value was used for that state.\n\nThis unfortunately made it a bit hard to work with objects of this type,\nas one always had to check if it contained a value. And even if a caller\nwould check this, and then pass the StreamId to a different function,\nthat function would have to do the check itself (often as a RTC_DCHECK)\nsince the passed StreamId always could have that state.\n\nThis CL simply extracts the \"absl::optional\" part of it, forcing holders\nto wrap it in an optional type - when it can be \"nothing\". But allowing\nthe other code to just pass StreamId that can\u0027t be \"nothing\". That\nsimplifies the code a bit, potentially removing some bugs.\n\nBug: chromium:41221056\nChange-Id: I93104cdd5d2f5fc1dbeb9d9dfc4cf361f11a9d68\nReviewed-on: https://webrtc-review.googlesource.com/c/src/+/342440\nReviewed-by: Florent Castelli \u003corphis@webrtc.org\u003e\nReviewed-by: Tomas Gunnarsson \u003ctommi@webrtc.org\u003e\nCommit-Queue: Victor Boivie \u003cboivie@webrtc.org\u003e\nCr-Commit-Position: refs/heads/main@{#41880}\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "93599fdba95c0dbc99aa27105c08d1a5633cf905",
      "old_mode": 33188,
      "old_path": "pc/data_channel_controller.cc",
      "new_id": "208160e1c17248d1659fc86539a9f2f5017ce754",
      "new_mode": 33188,
      "new_path": "pc/data_channel_controller.cc"
    },
    {
      "type": "modify",
      "old_id": "bf3ac03437141f01ff3c9b47e37ad7b4d44c973c",
      "old_mode": 33188,
      "old_path": "pc/data_channel_controller.h",
      "new_id": "d7ac3706b04e6771a33310044a4a58bdd2d47003",
      "new_mode": 33188,
      "new_path": "pc/data_channel_controller.h"
    },
    {
      "type": "modify",
      "old_id": "a27a66c3de6646cfca69de39bcdde352f1e27fd5",
      "old_mode": 33188,
      "old_path": "pc/data_channel_unittest.cc",
      "new_id": "a7d362728a9c9f65742599e4b9f1f2dcae4051b6",
      "new_mode": 33188,
      "new_path": "pc/data_channel_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "8fdbf4cb924455bb36f9544c50a6608c7227cecf",
      "old_mode": 33188,
      "old_path": "pc/sctp_data_channel.cc",
      "new_id": "8aa5fbd974c4862544f6e5bb8bdfd3974a6e70cf",
      "new_mode": 33188,
      "new_path": "pc/sctp_data_channel.cc"
    },
    {
      "type": "modify",
      "old_id": "13bebd4612e51a773e6dff37e527fb3a4c600422",
      "old_mode": 33188,
      "old_path": "pc/sctp_data_channel.h",
      "new_id": "fdbf2053e30d6115a99a2dc9198c09b64e632632",
      "new_mode": 33188,
      "new_path": "pc/sctp_data_channel.h"
    },
    {
      "type": "modify",
      "old_id": "868a8be826e8fcd2293726d7ef35589e59fb3c5b",
      "old_mode": 33188,
      "old_path": "pc/sctp_utils.h",
      "new_id": "c1bf23dd98affb47980b999b83a48d9e8bde216f",
      "new_mode": 33188,
      "new_path": "pc/sctp_utils.h"
    },
    {
      "type": "modify",
      "old_id": "64ad25798392c99e5d495aae9563a39403c72bbb",
      "old_mode": 33188,
      "old_path": "pc/sctp_utils_unittest.cc",
      "new_id": "49d6b09206849f3e237c16895b0f3879a84bad58",
      "new_mode": 33188,
      "new_path": "pc/sctp_utils_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "c489a3432458e7820e937d74fa953fb2b94af5d9",
      "old_mode": 33188,
      "old_path": "pc/test/fake_data_channel_controller.h",
      "new_id": "89cdce738d1da134684415f67c85fd4bff86e7bc",
      "new_mode": 33188,
      "new_path": "pc/test/fake_data_channel_controller.h"
    }
  ]
}