)]}'
{
  "commit": "d2b885fd91909f1b17fb11292a8c989d5d883b22",
  "tree": "a73b904cc39e4688a3f236a169fc0766bc31f10b",
  "parents": [
    "d4b087c6cf50f1843200b1514d20dfc23c7b81cc"
  ],
  "author": {
    "name": "Taylor Brandstetter",
    "email": "deadbeef@webrtc.org",
    "time": "Fri Jul 23 00:41:55 2021"
  },
  "committer": {
    "name": "WebRTC LUCI CQ",
    "email": "webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Fri Jul 23 22:08:00 2021"
  },
  "message": "Fix bug where we assume new m\u003d sections will always be bundled.\n\nA recent change [1] assumes that all new m\u003d sections will share the\nfirst BUNDLE group (if one already exists), which avoids generating\nICE candidates that are ultimately unnecessary. This is fine for JSEP\nendpoints, but it breaks the following scenarios for non-JSEP endpoints:\n\n* Remote offer adding a new m\u003d section that\u0027s not part of any BUNDLE\n  group.\n* Remote offer adding an m\u003d section to the second BUNDLE group.\n\nThe latter is specifically problematic for any application that wants\nto bundle all audio streams in one group and all video streams in\nanother group when using Unified Plan SDP, to replicate the behavior of\nusing Plan B without bundling. It may try to add a video stream only\nfor WebRTC to bundle it with audio.\n\nThis is fixed by doing some minor re-factoring, having BundleManager\nupdate the bundle groups at offer time.\n\nAlso:\n* Added some additional validation for multiple bundle groups in a\n  subsequent offer, since that now becomes relevant.\n* Improved rollback support, because now rolling back an offer may need\n  to not only remove mid-\u003etransport mappings but alter them.\n\n[1]: https://webrtc-review.googlesource.com/c/src/+/221601\n\nBug: webrtc:12906, webrtc:12999\nChange-Id: I4c6e7020c0be33a782d3608dee88e4e2fceb1be1\nReviewed-on: https://webrtc-review.googlesource.com/c/src/+/225642\nReviewed-by: Harald Alvestrand \u003chta@webrtc.org\u003e\nReviewed-by: Henrik Boström \u003chbos@webrtc.org\u003e\nCommit-Queue: Taylor Brandstetter \u003cdeadbeef@webrtc.org\u003e\nCr-Commit-Position: refs/heads/master@{#34544}\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "ce068d99fcbff5fbfb1d7623368c192b1d0d992a",
      "old_mode": 33188,
      "old_path": "pc/jsep_transport_collection.cc",
      "new_id": "98b8cd2a3d09b092d336f1eebd60247b3a97fd9b",
      "new_mode": 33188,
      "new_path": "pc/jsep_transport_collection.cc"
    },
    {
      "type": "modify",
      "old_id": "0dd528d3480cd0c3fd9e4f01ea0f4c42bea57371",
      "old_mode": 33188,
      "old_path": "pc/jsep_transport_collection.h",
      "new_id": "93570379aca9f57694fb43343f432bda708c60a9",
      "new_mode": 33188,
      "new_path": "pc/jsep_transport_collection.h"
    },
    {
      "type": "modify",
      "old_id": "47fddd4e3e344c7d46980ceeb2c7f1efa9f5fce0",
      "old_mode": 33188,
      "old_path": "pc/jsep_transport_controller.cc",
      "new_id": "8b9596b64e4c58ba08bf61adb6d505c564c3459e",
      "new_mode": 33188,
      "new_path": "pc/jsep_transport_controller.cc"
    },
    {
      "type": "modify",
      "old_id": "71b01bffb246568e0dc40de69bfe1394071fb2d4",
      "old_mode": 33188,
      "old_path": "pc/jsep_transport_controller.h",
      "new_id": "3b20bbb5a9055871efc122e55909658642264996",
      "new_mode": 33188,
      "new_path": "pc/jsep_transport_controller.h"
    },
    {
      "type": "modify",
      "old_id": "a06f5804e4a9fce9952f5b28882492e2d89ed6fb",
      "old_mode": 33188,
      "old_path": "pc/jsep_transport_controller_unittest.cc",
      "new_id": "bc7cfebdb93888e3cab444e5b1545d78545fb55a",
      "new_mode": 33188,
      "new_path": "pc/jsep_transport_controller_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "08754c6820802b2401a92a674ec6a7a5a1e7d738",
      "old_mode": 33188,
      "old_path": "pc/peer_connection_bundle_unittest.cc",
      "new_id": "be05af920c83d3895b5b66fa008f6d038b023e33",
      "new_mode": 33188,
      "new_path": "pc/peer_connection_bundle_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "533bd84dbec98ea8f3d3ab16cf6958d4cc516253",
      "old_mode": 33188,
      "old_path": "pc/sdp_offer_answer.cc",
      "new_id": "929736e8c6f4c41b05183b4018597651bf2e067d",
      "new_mode": 33188,
      "new_path": "pc/sdp_offer_answer.cc"
    }
  ]
}
