)]}' { "commit": "dc364e5bc2f75733a26652dafe34034fec82bcc4", "tree": "8578b27289d5d42d45b4b624653b1fb52abb4ab0", "parents": [ "fd05d6f504cac0681149ce2834b8e0acfd944fc4" ], "author": { "name": "Björn Terelius", "email": "terelius@google.com", "time": "Tue Jul 27 22:03:35 2021" }, "committer": { "name": "WebRTC LUCI CQ", "email": "webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com", "time": "Wed Jul 28 00:11:43 2021" }, "message": "Revert \"Fix bug where we assume new m\u003d sections will always be bundled.\"\n\nThis reverts commit d2b885fd91909f1b17fb11292a8c989d5d883b22.\n\nReason for revert: Speculative revert for Chromium importer\n\nOriginal change\u0027s description:\n\u003e Fix bug where we assume new m\u003d sections will always be bundled.\n\u003e\n\u003e A recent change [1] assumes that all new m\u003d sections will share the\n\u003e first BUNDLE group (if one already exists), which avoids generating\n\u003e ICE candidates that are ultimately unnecessary. This is fine for JSEP\n\u003e endpoints, but it breaks the following scenarios for non-JSEP endpoints:\n\u003e\n\u003e * Remote offer adding a new m\u003d section that\u0027s not part of any BUNDLE\n\u003e group.\n\u003e * Remote offer adding an m\u003d section to the second BUNDLE group.\n\u003e\n\u003e The latter is specifically problematic for any application that wants\n\u003e to bundle all audio streams in one group and all video streams in\n\u003e another group when using Unified Plan SDP, to replicate the behavior of\n\u003e using Plan B without bundling. It may try to add a video stream only\n\u003e for WebRTC to bundle it with audio.\n\u003e\n\u003e This is fixed by doing some minor re-factoring, having BundleManager\n\u003e update the bundle groups at offer time.\n\u003e\n\u003e Also:\n\u003e * Added some additional validation for multiple bundle groups in a\n\u003e subsequent offer, since that now becomes relevant.\n\u003e * Improved rollback support, because now rolling back an offer may need\n\u003e to not only remove mid-\u003etransport mappings but alter them.\n\u003e\n\u003e [1]: https://webrtc-review.googlesource.com/c/src/+/221601\n\u003e\n\u003e Bug: webrtc:12906, webrtc:12999\n\u003e Change-Id: I4c6e7020c0be33a782d3608dee88e4e2fceb1be1\n\u003e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/225642\n\u003e Reviewed-by: Harald Alvestrand \u003chta@webrtc.org\u003e\n\u003e Reviewed-by: Henrik Boström \u003chbos@webrtc.org\u003e\n\u003e Commit-Queue: Taylor Brandstetter \u003cdeadbeef@webrtc.org\u003e\n\u003e Cr-Commit-Position: refs/heads/master@{#34544}\n\n# Not skipping CQ checks because original CL landed \u003e 1 day ago.\n\nBug: webrtc:12906, webrtc:12999\nChange-Id: I00179d7573f322ad539ff16cad1f85320cfb2270\nReviewed-on: https://webrtc-review.googlesource.com/c/src/+/227081\nReviewed-by: Björn Terelius \u003cterelius@google.com\u003e\nReviewed-by: Taylor Brandstetter \u003cdeadbeef@webrtc.org\u003e\nCommit-Queue: Taylor Brandstetter \u003cdeadbeef@webrtc.org\u003e\nCr-Commit-Position: refs/heads/master@{#34578}\n", "tree_diff": [ { "type": "modify", "old_id": "98b8cd2a3d09b092d336f1eebd60247b3a97fd9b", "old_mode": 33188, "old_path": "pc/jsep_transport_collection.cc", "new_id": "ce068d99fcbff5fbfb1d7623368c192b1d0d992a", "new_mode": 33188, "new_path": "pc/jsep_transport_collection.cc" }, { "type": "modify", "old_id": "93570379aca9f57694fb43343f432bda708c60a9", "old_mode": 33188, "old_path": "pc/jsep_transport_collection.h", "new_id": "0dd528d3480cd0c3fd9e4f01ea0f4c42bea57371", "new_mode": 33188, "new_path": "pc/jsep_transport_collection.h" }, { "type": "modify", "old_id": "8b9596b64e4c58ba08bf61adb6d505c564c3459e", "old_mode": 33188, "old_path": "pc/jsep_transport_controller.cc", "new_id": "47fddd4e3e344c7d46980ceeb2c7f1efa9f5fce0", "new_mode": 33188, "new_path": "pc/jsep_transport_controller.cc" }, { "type": "modify", "old_id": "3b20bbb5a9055871efc122e55909658642264996", "old_mode": 33188, "old_path": "pc/jsep_transport_controller.h", "new_id": "71b01bffb246568e0dc40de69bfe1394071fb2d4", "new_mode": 33188, "new_path": "pc/jsep_transport_controller.h" }, { "type": "modify", "old_id": "bc7cfebdb93888e3cab444e5b1545d78545fb55a", "old_mode": 33188, "old_path": "pc/jsep_transport_controller_unittest.cc", "new_id": "a06f5804e4a9fce9952f5b28882492e2d89ed6fb", "new_mode": 33188, "new_path": "pc/jsep_transport_controller_unittest.cc" }, { "type": "modify", "old_id": "be05af920c83d3895b5b66fa008f6d038b023e33", "old_mode": 33188, "old_path": "pc/peer_connection_bundle_unittest.cc", "new_id": "08754c6820802b2401a92a674ec6a7a5a1e7d738", "new_mode": 33188, "new_path": "pc/peer_connection_bundle_unittest.cc" }, { "type": "modify", "old_id": "929736e8c6f4c41b05183b4018597651bf2e067d", "old_mode": 33188, "old_path": "pc/sdp_offer_answer.cc", "new_id": "533bd84dbec98ea8f3d3ab16cf6958d4cc516253", "new_mode": 33188, "new_path": "pc/sdp_offer_answer.cc" } ] }