)]}' { "commit": "e309651f3330bc56ee0e504d833e639a613d725d", "tree": "1818be103da526e5af883a77539bafc1ef71cdc4", "parents": [ "a5e07cc3db44bcb31b142ca33cd6130a8f25ba6e" ], "author": { "name": "Jonas Oreland", "email": "jonaso@webrtc.org", "time": "Wed May 27 07:01:05 2020" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Wed May 27 08:42:10 2020" }, "message": "Don\u0027t SetNeedsIceRestartFlag if widening candidate filter when surface_ice_candidates_on_ice_transport_type_changed\n\nThis patch fixes a minor bug in the implementation of\nsurface_ice_candidates_on_ice_transport_type_changed. The existing\nimplementation correctly handles the surfacing, but accidentally also\nset the SetNeedsIceRestartFlag, which made _next_ offer contain\na ice restart.\n\nModified existing testcase to verify this.\n\nBug: webrtc:8939\nChange-Id: If566e3249296467668627e5941495f6036cbd903\nReviewed-on: https://webrtc-review.googlesource.com/c/src/+/176127\nCommit-Queue: Jonas Oreland \u003cjonaso@webrtc.org\u003e\nReviewed-by: Harald Alvestrand \u003chta@webrtc.org\u003e\nCr-Commit-Position: refs/heads/master@{#31363}\n", "tree_diff": [ { "type": "modify", "old_id": "a3cf9370e2f9365d5a77c8577baf6355c8451c5b", "old_mode": 33188, "old_path": "p2p/base/p2p_transport_channel_unittest.cc", "new_id": "ea8d66f890a8826beef4afb5dadedaf45c82e9f9", "new_mode": 33188, "new_path": "p2p/base/p2p_transport_channel_unittest.cc" }, { "type": "modify", "old_id": "05e7b95591e0c322286b720d4ed96bf56e2ddeb4", "old_mode": 33188, "old_path": "pc/peer_connection.cc", "new_id": "967fd27889334cf02d493c8233114ca0fded471d", "new_mode": 33188, "new_path": "pc/peer_connection.cc" }, { "type": "modify", "old_id": "2fa4fb6adeac7cf98b437c1022768b57633c0e84", "old_mode": 33188, "old_path": "pc/peer_connection_integrationtest.cc", "new_id": "f947fe5e77f5338b86c6157ebb8e946c7e97b1c4", "new_mode": 33188, "new_path": "pc/peer_connection_integrationtest.cc" } ] }