commit edbae5e0ac5be950a8c4372d420c8229bdc7f161
author denicija <denicija@webrtc.org> Fri Sep 30 07:21:11 2016
committer Commit bot <commit-bot@chromium.org> Fri Sep 30 07:21:28 2016
tree f08bfed9e2948ab39bbcc4bc8bbf0a9bed8f6569
parent eb5040ae44886af0ce3ed33b5c1dffd20c211f95

Remove Crit::Scope lock by using atomic bool property.

The clang static analyzer seems unable to resolve cpp locks in ObjC code.
As of current time, the clang analyzer has known limitations documented
http://clang.llvm.org/docs/ThreadSafetyAnalysis.html#known-limitations.
From the documentation: "The analysis currently does not do any checking
inside constructors or destructors.
In other words, every constructor and destructor is treated
as if it was annotated with NO_THREAD_SAFETY_ANALYSIS."
This is 'probably' why the analyzer is unable to resolve the lock when
used in ObjC land (the cpp works fine).
The lock can be removed by using atomic property instead.
It's not on performance critical path and we expect updates on just one queue and reads from others. That's why the thread assurance atomic properties bring is enough.
The CL removes rtc_sdk_peerconnection_objc_warnings_config as well as it's no longer needed.

BUG=webrtc:6308

Review-Url: https://codereview.webrtc.org/2372513004
Cr-Commit-Position: refs/heads/master@{#14450}