commit f80cf814353d11a9f22bef5ce5e8868f2c72f0d0
author Jesús de Vicente Peña <devicentepena@webrtc.org> Tue Jun 20 13:14:30 2023
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Jun 20 14:46:44 2023
tree 93f4291694a7d405a0828b3ade4819c41440609b
parent ff58aed67835fd2644c3a1798056ddd233186c31

Changing the pre echo configuration default.

Bug: webrtc:14205
Change-Id: I17add3bf19c599f170ffe98d0da0a561794591c1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/309481
Commit-Queue: Jesus de Vicente Pena <devicentepena@webrtc.org>
Reviewed-by: Per Åhgren <peah@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#40319}

modules/audio_processing/aec3/matched_filter.cc

diff --git a/modules/audio_processing/aec3/matched_filter.cc b/modules/audio_processing/aec3/matched_filter.cc
index af30ff1..edaa2a4 100644
--- a/modules/audio_processing/aec3/matched_filter.cc
+++ b/modules/audio_processing/aec3/matched_filter.cc
@@ -109,14 +109,16 @@
 }
 
 webrtc::MatchedFilter::PreEchoConfiguration FetchPreEchoConfiguration() {
-  float threshold = 0.5f;
-  int mode = 0;
+  constexpr float kDefaultThreshold = 0.5f;
+  constexpr int kDefaultMode = 3;
+  float threshold = kDefaultThreshold;
+  int mode = kDefaultMode;
   const std::string pre_echo_configuration_field_trial =
       webrtc::field_trial::FindFullName("WebRTC-Aec3PreEchoConfiguration");
   webrtc::FieldTrialParameter<double> threshold_field_trial_parameter(
-      /*key=*/"threshold", /*default_value=*/threshold);
+      /*key=*/"threshold", /*default_value=*/kDefaultThreshold);
   webrtc::FieldTrialParameter<int> mode_field_trial_parameter(
-      /*key=*/"mode", /*default_value=*/mode);
+      /*key=*/"mode", /*default_value=*/kDefaultMode);
   webrtc::ParseFieldTrial(
       {&threshold_field_trial_parameter, &mode_field_trial_parameter},
       pre_echo_configuration_field_trial);

modules/audio_processing/aec3/matched_filter_unittest.cc

diff --git a/modules/audio_processing/aec3/matched_filter_unittest.cc b/modules/audio_processing/aec3/matched_filter_unittest.cc
index 0a04c78..3f26cc1 100644
--- a/modules/audio_processing/aec3/matched_filter_unittest.cc
+++ b/modules/audio_processing/aec3/matched_filter_unittest.cc
@@ -584,7 +584,7 @@
 
 TEST(MatchedFilterFieldTrialTest, WrongPreEchoConfigurationTest) {
   constexpr float kDefaultThreshold = 0.5f;
-  constexpr int kDefaultMode = 0;
+  constexpr int kDefaultMode = 3;
   float threshold_in = -0.1f;
   int mode_in = 5;
   rtc::StringBuilder field_trial_name;