)]}'
{
  "commit": "242e22b055940be70b1df3031e2363b0d02397b2",
  "tree": "e31ee03305b8d61fdc1b63f304556b14dd9ac219",
  "parents": [
    "1f629232d5f852452499104c28e7d61c7b0b8c77"
  ],
  "author": {
    "name": "Erik Språng",
    "email": "sprang@webrtc.org",
    "time": "Mon May 11 08:17:43 2015"
  },
  "committer": {
    "name": "Erik Språng",
    "email": "sprang@webrtc.org",
    "time": "Mon May 11 08:17:46 2015"
  },
  "message": "Refactor RTCP sender\n\nThe main purpose of this CL is to clean up RTCPSender::PrepareRTCP, but\nit has quite a few ramifications. Notable changes:\n\n* Removed the rtcpPacketTypeFlags bit vector and don\u0027t assume\n  RTCPPacketType values have a single unique bit set. This will allow\n  making this an enum class once rtcp_receiver has been overhauled.\n\n* Flags are now stored in a map that is a member of the class. This\n  meant we could remove some bool flags (eg send_remb_) which was\n  previously masked into rtcpPacketTypeFlags and then masked out again\n  when testing if a remb packet should be sent.\n\n* Make all build methods, eg. BuildREMB(), have the same signature.\n  An RtcpContext struct was introduced for this purpose. This allowed\n  the use of a map from RTCPPacketType to method pointer. Instead of\n  18 consecutive if-statements, there is now a single loop.\n  The context class also allowed some simplifications in the build\n  methods themselves.\n\n* A few minor simplifications and cleanups.\n\nThe next step is to gradually replace the builder methods with the\nbuilders from the new RtcpPacket classes.\n\nBUG\u003d2450\nR\u003dasapersson@webrtc.org, pbos@webrtc.org\n\nReview URL: https://webrtc-codereview.appspot.com/48329004\n\nCr-Commit-Position: refs/heads/master@{#9166}\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "fb47a2bb0fe92dd13b62138975f6bf05d07e0c76",
      "old_mode": 33188,
      "old_path": "webrtc/modules/rtp_rtcp/interface/rtp_rtcp.h",
      "new_id": "34ab74e71ae4984144a7e46fa5f17a1cae034ee1",
      "new_mode": 33188,
      "new_path": "webrtc/modules/rtp_rtcp/interface/rtp_rtcp.h"
    },
    {
      "type": "modify",
      "old_id": "8431fe3b508955a72813e1390d250559d9c62eec",
      "old_mode": 33188,
      "old_path": "webrtc/modules/rtp_rtcp/interface/rtp_rtcp_defines.h",
      "new_id": "1587762763b636d5faf22e962af4f25fd728e97e",
      "new_mode": 33188,
      "new_path": "webrtc/modules/rtp_rtcp/interface/rtp_rtcp_defines.h"
    },
    {
      "type": "modify",
      "old_id": "0097d56e977657958b61f13346e5e8a6bc8aed66",
      "old_mode": 33188,
      "old_path": "webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h",
      "new_id": "0a4ceef1bd71b5823556f10daf61560b6352357c",
      "new_mode": 33188,
      "new_path": "webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h"
    },
    {
      "type": "modify",
      "old_id": "f50ce1782b17809e20480c4a89da83a529a159e1",
      "old_mode": 33188,
      "old_path": "webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc",
      "new_id": "55974bf74bdef493491579a698ed4f8dec038149",
      "new_mode": 33188,
      "new_path": "webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc"
    },
    {
      "type": "modify",
      "old_id": "b8cdbe801e3cd4121ff285bf463d33eabffc018a",
      "old_mode": 33188,
      "old_path": "webrtc/modules/rtp_rtcp/source/rtcp_sender.cc",
      "new_id": "e2ad3f0cc392b506dc604e13bcb259e01b2d810e",
      "new_mode": 33188,
      "new_path": "webrtc/modules/rtp_rtcp/source/rtcp_sender.cc"
    },
    {
      "type": "modify",
      "old_id": "dbdee0c126474b364eb1d0673754ce5baef5b743",
      "old_mode": 33188,
      "old_path": "webrtc/modules/rtp_rtcp/source/rtcp_sender.h",
      "new_id": "57fbe2b7a73668a9842c7eb60bcee15fb6278d54",
      "new_mode": 33188,
      "new_path": "webrtc/modules/rtp_rtcp/source/rtcp_sender.h"
    },
    {
      "type": "modify",
      "old_id": "04233896329bff8945ed5c2082495486d959e21c",
      "old_mode": 33188,
      "old_path": "webrtc/modules/rtp_rtcp/source/rtcp_utility.cc",
      "new_id": "4e37cf3716d916c7ecb1bfd6185b1790dfa15f5f",
      "new_mode": 33188,
      "new_path": "webrtc/modules/rtp_rtcp/source/rtcp_utility.cc"
    },
    {
      "type": "modify",
      "old_id": "804e8b94783791d493184641b62493ea67ca1b86",
      "old_mode": 33188,
      "old_path": "webrtc/modules/rtp_rtcp/source/rtcp_utility.h",
      "new_id": "fcafe5960ee883fa04c4d17164fd1ed89b43ea81",
      "new_mode": 33188,
      "new_path": "webrtc/modules/rtp_rtcp/source/rtcp_utility.h"
    },
    {
      "type": "modify",
      "old_id": "559f726da7eaafa94cfb5e74926d4c467ac9d4c4",
      "old_mode": 33188,
      "old_path": "webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc",
      "new_id": "935929558e79695a27ea92358bc8f4a112296959",
      "new_mode": 33188,
      "new_path": "webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc"
    },
    {
      "type": "modify",
      "old_id": "d7267e7b70d8981ab45327732b0a7c6af9b0c9e8",
      "old_mode": 33188,
      "old_path": "webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h",
      "new_id": "e8c9a21485009251d974acfb221e77306d0970ee",
      "new_mode": 33188,
      "new_path": "webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h"
    },
    {
      "type": "modify",
      "old_id": "3eb05a9b84e3ebf26a254b53eb5cf0e3e576f5e9",
      "old_mode": 33188,
      "old_path": "webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc",
      "new_id": "3cff2a4d3f9d52a5341faeae1bd12f383420338f",
      "new_mode": 33188,
      "new_path": "webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "b9e430fe9fa0fece5237bcc49d9d7f440ea07755",
      "old_mode": 33188,
      "old_path": "webrtc/test/rtcp_packet_parser.cc",
      "new_id": "8ce249e0b6f4f0185cad17488464c437101971b1",
      "new_mode": 33188,
      "new_path": "webrtc/test/rtcp_packet_parser.cc"
    },
    {
      "type": "modify",
      "old_id": "fc1aefc872e28297f6afe49e020ed41f635ae9a6",
      "old_mode": 33188,
      "old_path": "webrtc/video/call_perf_tests.cc",
      "new_id": "5df1fd3ff45e4decc34cba1d1d0e44e19e23ad4d",
      "new_mode": 33188,
      "new_path": "webrtc/video/call_perf_tests.cc"
    },
    {
      "type": "modify",
      "old_id": "1b4e990cd1d6bb0929394572b01664ca6f7ce718",
      "old_mode": 33188,
      "old_path": "webrtc/video/end_to_end_tests.cc",
      "new_id": "6236483bf74f98d46c304e5cbb55ce783be743f9",
      "new_mode": 33188,
      "new_path": "webrtc/video/end_to_end_tests.cc"
    },
    {
      "type": "modify",
      "old_id": "547c811797f20fa52daba050ee0b9918f2ca915b",
      "old_mode": 33188,
      "old_path": "webrtc/video/video_send_stream_tests.cc",
      "new_id": "a02e8782f0869383373be8bf173d43633efd84cc",
      "new_mode": 33188,
      "new_path": "webrtc/video/video_send_stream_tests.cc"
    }
  ]
}