)]}'
{
  "commit": "3e113438b10cffee6239aa85ac3ec08369dc6113",
  "tree": "ca74e8a3b8b1e92ecf57ea4592a10222cf4c2741",
  "parents": [
    "d5d0540b86978aa7c121a37f9d8a232091498199"
  ],
  "author": {
    "name": "Patrik Höglund",
    "email": "phoglund@webrtc.org",
    "time": "Fri Dec 15 13:40:10 2017"
  },
  "committer": {
    "name": "Commit Bot",
    "email": "commit-bot@chromium.org",
    "time": "Fri Dec 15 14:33:26 2017"
  },
  "message": "Fix circular dependencies in webrtc_common.\n\nOne reason for the circular deps is that common_types.h is a\nhistorical dumping ground for various structs and defines that\nare believed to be generally useful. I tried moving things out\nthat did not appear to be used downstream (StreamCounters,\nRtpCounters etc) and moved the things that seemed used\n(RtpHeader + supporting structs) to a new file api/rtp_headers.h.\nThis makes their place in the api more clear while moving out\nthe things that don\u0027t belong in the API in the first place.\n\nI had to extract out typedefs.h from webrtc_common to resolve\nanother circular dependency. I believe checks includes typedefs,\nbut common depends on checks.\n\nBug: webrtc:7745\nChange-Id: I725d49616b1ec0cdc8b74be7c078f7a4d46f084b\nReviewed-on: https://webrtc-review.googlesource.com/33001\nCommit-Queue: Patrik Höglund \u003cphoglund@webrtc.org\u003e\nReviewed-by: Karl Wiberg \u003ckwiberg@webrtc.org\u003e\nCr-Commit-Position: refs/heads/master@{#21295}",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "ac4ef805512b36d45dc39d059d9f06bd49a0e882",
      "old_mode": 33188,
      "old_path": ".gn",
      "new_id": "5e3c6ca9aff260bc8fb5d763a77a61de24e27d4d",
      "new_mode": 33188,
      "new_path": ".gn"
    },
    {
      "type": "modify",
      "old_id": "6153e4fd92c42d85292bb98ac96078083ec4b07d",
      "old_mode": 33188,
      "old_path": "BUILD.gn",
      "new_id": "9b4248baabbfa753b91907745888ea2d8e61d7dd",
      "new_mode": 33188,
      "new_path": "BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "592039f68fa71a59c77b77e5b06867d5ffa3fbd2",
      "old_mode": 33188,
      "old_path": "api/BUILD.gn",
      "new_id": "94dd86507fe4ecefb83f1ca082a093848e8e0e2d",
      "new_mode": 33188,
      "new_path": "api/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "d2c074d8c5a0aa64f44542abb109a4b1e67f05e5",
      "old_mode": 33188,
      "old_path": "api/audio_codecs/BUILD.gn",
      "new_id": "01dc12459eeb3cff9eed0ae15b12b8938a082757",
      "new_mode": 33188,
      "new_path": "api/audio_codecs/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "3c58fad9fdd4797e3ef80ceeeb4168d82fd76371",
      "old_mode": 33188,
      "old_path": "api/ortc/rtptransportinterface.h",
      "new_id": "716a297c54eba3a3f11bf2bd8c5ec1399a904dde",
      "new_mode": 33188,
      "new_path": "api/ortc/rtptransportinterface.h"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "a0b1a15cbbeb332f2041ddad4e1194ecd50a66cf",
      "new_mode": 33188,
      "new_path": "api/rtp_headers.cc"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "2624a33e5f5ddb966815851c16deba22fabee22a",
      "new_mode": 33188,
      "new_path": "api/rtp_headers.h"
    },
    {
      "type": "modify",
      "old_id": "f3cb7f13fdece0a104162fc826fd2bf6fea17d92",
      "old_mode": 33188,
      "old_path": "api/video_codecs/BUILD.gn",
      "new_id": "6f3623db566aee4ac3c47c6ac7037f6d1194d32c",
      "new_mode": 33188,
      "new_path": "api/video_codecs/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "f38e0ebb8d3b8ef2ddf29f2d370faf822347b2ad",
      "old_mode": 33188,
      "old_path": "audio/utility/BUILD.gn",
      "new_id": "4e017103c414c724f8aaaf28cbb82f664b426393",
      "new_mode": 33188,
      "new_path": "audio/utility/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "82f6ca1dc164e8baa2b27c92675e240bc442cb0a",
      "old_mode": 33188,
      "old_path": "call/BUILD.gn",
      "new_id": "6f936b853ed4095090347da5971d79edab76a27c",
      "new_mode": 33188,
      "new_path": "call/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "a0b7a11d3a42a0b12d2760c853ed83a406eccc34",
      "old_mode": 33188,
      "old_path": "call/flexfec_receive_stream.h",
      "new_id": "98ce3510959f7d31db4eee35352a2ce97889b0cb",
      "new_mode": 33188,
      "new_path": "call/flexfec_receive_stream.h"
    },
    {
      "type": "modify",
      "old_id": "0adbdf31337d542dac27a22cf831596b8f1c1be8",
      "old_mode": 33188,
      "old_path": "call/rtcp_demuxer.cc",
      "new_id": "0e78ddea186a519c9e8fa171155c43bda0b671cc",
      "new_mode": 33188,
      "new_path": "call/rtcp_demuxer.cc"
    },
    {
      "type": "modify",
      "old_id": "dd5aa5514735e0d45834e72912de76b9ec2f22f9",
      "old_mode": 33188,
      "old_path": "call/rtcp_demuxer_unittest.cc",
      "new_id": "0e1c95b9f5cb9f99ca5492985bc7755a0867fc05",
      "new_mode": 33188,
      "new_path": "call/rtcp_demuxer_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "de6f71290182a4f8f8069698b44c89cd91984153",
      "old_mode": 33188,
      "old_path": "call/video_receive_stream.h",
      "new_id": "924d69a5292508db4bceb3b8dd3cf3a68fa23892",
      "new_mode": 33188,
      "new_path": "call/video_receive_stream.h"
    },
    {
      "type": "modify",
      "old_id": "e57307d3a928ecc1cec8a51514fc427201e38157",
      "old_mode": 33188,
      "old_path": "call/video_send_stream.h",
      "new_id": "890a767dfe26363c1540c31232df2ee8d31e4a8a",
      "new_mode": 33188,
      "new_path": "call/video_send_stream.h"
    },
    {
      "type": "modify",
      "old_id": "f601731db33fd5be2967b672ca456926eaea838b",
      "old_mode": 33188,
      "old_path": "common_audio/BUILD.gn",
      "new_id": "27287ec9665bc3172ba4131f9e1e5db19f9075e7",
      "new_mode": 33188,
      "new_path": "common_audio/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "f1b2f1e13ed77618b025243c061db144a6c17390",
      "old_mode": 33188,
      "old_path": "common_types.cc",
      "new_id": "07f77b77778446ed49ccd9b44f966d8ba3fad3b2",
      "new_mode": 33188,
      "new_path": "common_types.cc"
    },
    {
      "type": "modify",
      "old_id": "21fdf56fe0ed98d8ee6fc5b8e360df4aadb185d0",
      "old_mode": 33188,
      "old_path": "common_types.h",
      "new_id": "9f1ad8f9f79da7251d4ad62d8b2f4c82991c6598",
      "new_mode": 33188,
      "new_path": "common_types.h"
    },
    {
      "type": "modify",
      "old_id": "188d5e5260cad82f670010c717b0caf311209891",
      "old_mode": 33188,
      "old_path": "common_video/include/video_frame.h",
      "new_id": "0c145fa322c23753edd2b9fc0a96a5cd6e3cb936",
      "new_mode": 33188,
      "new_path": "common_video/include/video_frame.h"
    },
    {
      "type": "modify",
      "old_id": "0ab9bc8859282fcdf43afa6e8fe172bc882a5c79",
      "old_mode": 33188,
      "old_path": "examples/BUILD.gn",
      "new_id": "4e733d06bc5d56c0b379640ef6862a0a84aec025",
      "new_mode": 33188,
      "new_path": "examples/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "bfa20aa3e1eddcecab7447fc785ed49802d50ef4",
      "old_mode": 33188,
      "old_path": "logging/BUILD.gn",
      "new_id": "981231b09bc1e079f7eda193d1578598534dc43b",
      "new_mode": 33188,
      "new_path": "logging/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "e43ee7e0deb0f00619e27fc9b6b56c79803e397a",
      "old_mode": 33188,
      "old_path": "logging/rtc_event_log/rtc_stream_config.h",
      "new_id": "771ba66c6a448eb98500b686cd1a71d629088e72",
      "new_mode": 33188,
      "new_path": "logging/rtc_event_log/rtc_stream_config.h"
    },
    {
      "type": "modify",
      "old_id": "ac03a7d082b091632cfe25b07f5a90c8923e3c41",
      "old_mode": 33188,
      "old_path": "media/BUILD.gn",
      "new_id": "227133913f9cecc36e19bd04d11a24111ef010a0",
      "new_mode": 33188,
      "new_path": "media/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "91fe33e8ac269ff52341cc744f0f8441daa07c53",
      "old_mode": 33188,
      "old_path": "media/base/mediachannel.h",
      "new_id": "5768944122b0c3fe0916500a5f59cab97ed9fa48",
      "new_mode": 33188,
      "new_path": "media/base/mediachannel.h"
    },
    {
      "type": "modify",
      "old_id": "2c1a0427a1269593f12d7d1e29da4861c088ddaa",
      "old_mode": 33188,
      "old_path": "modules/BUILD.gn",
      "new_id": "33394f41330c1adc6d0315ceeecac15b25c6ba34",
      "new_mode": 33188,
      "new_path": "modules/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "9c674d4ead2aee4a8d5cfb9d82bd1b376d0d2c3d",
      "old_mode": 33188,
      "old_path": "modules/audio_coding/BUILD.gn",
      "new_id": "6365d562c8837679221ea65f6520bace3478ba39",
      "new_mode": 33188,
      "new_path": "modules/audio_coding/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "00ed7cdbfadb933f34d5b1dcea0b9d221197497e",
      "old_mode": 33188,
      "old_path": "modules/audio_coding/neteq/include/neteq.h",
      "new_id": "0d47f21a0651e2addca3138a68d0ccf23d6bab1a",
      "new_mode": 33188,
      "new_path": "modules/audio_coding/neteq/include/neteq.h"
    },
    {
      "type": "modify",
      "old_id": "a72f7d1899b8a39f38f104640127825f034dcb87",
      "old_mode": 33188,
      "old_path": "modules/audio_coding/neteq/tools/packet.h",
      "new_id": "94d45c5b2d910d90607869ddd707d645c04f67ea",
      "new_mode": 33188,
      "new_path": "modules/audio_coding/neteq/tools/packet.h"
    },
    {
      "type": "modify",
      "old_id": "b705f8346d86e18cd831d234131d6ed09f0b6dec",
      "old_mode": 33188,
      "old_path": "modules/audio_coding/neteq/tools/rtp_generator.h",
      "new_id": "3b3cca939e9b5ae53a13ba1a03ca763f9a0af60c",
      "new_mode": 33188,
      "new_path": "modules/audio_coding/neteq/tools/rtp_generator.h"
    },
    {
      "type": "modify",
      "old_id": "3174ee907b5e0fa8b12452185c8e3a9f8ed510fc",
      "old_mode": 33188,
      "old_path": "modules/audio_device/BUILD.gn",
      "new_id": "6c1914619fb7252072478846381bc8e6c95f2db1",
      "new_mode": 33188,
      "new_path": "modules/audio_device/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "cffd1a89018d7d0e47205550177ff9f9f82cdc20",
      "old_mode": 33188,
      "old_path": "modules/audio_mixer/BUILD.gn",
      "new_id": "13183984d7ed8fc3590200d9f5aae0124637c739",
      "new_mode": 33188,
      "new_path": "modules/audio_mixer/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "b190f0222fef41dbd8a2e957d95e9f6fa074df8d",
      "old_mode": 33188,
      "old_path": "modules/audio_processing/BUILD.gn",
      "new_id": "d8790760f9268e68c32a5a987afb309387fd34a3",
      "new_mode": 33188,
      "new_path": "modules/audio_processing/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "9cedd6e8c222eb97ff37e058a830c9b0a70214be",
      "old_mode": 33188,
      "old_path": "modules/audio_processing/test/conversational_speech/BUILD.gn",
      "new_id": "00e4730abf688acd0980f5a2aad7f834386a2c0e",
      "new_mode": 33188,
      "new_path": "modules/audio_processing/test/conversational_speech/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "58d2e253b4e28f62772fecbc5bc439b1d8dedf05",
      "old_mode": 33188,
      "old_path": "modules/congestion_controller/BUILD.gn",
      "new_id": "c014934c0c961b31a570886c1ab8fc43a5c2eddb",
      "new_mode": 33188,
      "new_path": "modules/congestion_controller/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "277683a4db454efa07022d40f01c8ec9ade0ea2c",
      "old_mode": 33188,
      "old_path": "modules/desktop_capture/BUILD.gn",
      "new_id": "8e8d92dc5cae7d88a334db4d4fe6b5e96bacb50d",
      "new_mode": 33188,
      "new_path": "modules/desktop_capture/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "1d89c7d070eea07c897d2194e813d68cc2cc9d40",
      "old_mode": 33188,
      "old_path": "modules/include/module_common_types.h",
      "new_id": "94ccbdc1580a30d14df1d26bb9afbc354fb752a1",
      "new_mode": 33188,
      "new_path": "modules/include/module_common_types.h"
    },
    {
      "type": "modify",
      "old_id": "a3f33127994ca6b5279c7dbbd791aff4d1a8cf25",
      "old_mode": 33188,
      "old_path": "modules/media_file/BUILD.gn",
      "new_id": "589b2818cc1c95729fc9885c74a2ddc94993ce6e",
      "new_mode": 33188,
      "new_path": "modules/media_file/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "428a99ec0404ccc5f8b00ff38a663d8978efcf05",
      "old_mode": 33188,
      "old_path": "modules/pacing/BUILD.gn",
      "new_id": "6b76c643bd06499c5e2132659d256d18b8646ba2",
      "new_mode": 33188,
      "new_path": "modules/pacing/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "f0fac54376e2ad8bf2b1b4cf08b8dfb9035b98ee",
      "old_mode": 33188,
      "old_path": "modules/remote_bitrate_estimator/BUILD.gn",
      "new_id": "a5dd014e242372055a0a79ce0f1094e3a46de4bc",
      "new_mode": 33188,
      "new_path": "modules/remote_bitrate_estimator/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "e3f35b8c4e69f0e392ea6b13f2ea8cb0b240db9d",
      "old_mode": 33188,
      "old_path": "modules/rtp_rtcp/BUILD.gn",
      "new_id": "4ae32cd92c78d3f57cc82a3343323f38e845f02e",
      "new_mode": 33188,
      "new_path": "modules/rtp_rtcp/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "ee7dbbbd8d3464ce28b38f3cc7f81d9748c40fda",
      "old_mode": 33188,
      "old_path": "modules/rtp_rtcp/include/receive_statistics.h",
      "new_id": "55c2c056e724dc9652b79ac308453c6da51231b8",
      "new_mode": 33188,
      "new_path": "modules/rtp_rtcp/include/receive_statistics.h"
    },
    {
      "type": "modify",
      "old_id": "af3714b25e85390460ed8eba6a6cabbd12a7e75e",
      "old_mode": 33188,
      "old_path": "modules/rtp_rtcp/include/rtp_rtcp_defines.cc",
      "new_id": "d9b082bd903e34cc1444050dc3af3e9e39999157",
      "new_mode": 33188,
      "new_path": "modules/rtp_rtcp/include/rtp_rtcp_defines.cc"
    },
    {
      "type": "modify",
      "old_id": "37ef332e5251056b6d4e327a81cc7b4a9c03f79d",
      "old_mode": 33188,
      "old_path": "modules/rtp_rtcp/include/rtp_rtcp_defines.h",
      "new_id": "97a2a98ff75939a6b3c6e224e059345e02ed136e",
      "new_mode": 33188,
      "new_path": "modules/rtp_rtcp/include/rtp_rtcp_defines.h"
    },
    {
      "type": "modify",
      "old_id": "7002fd284e9fa35bdd7f4e14609dc5bfbf499044",
      "old_mode": 33188,
      "old_path": "modules/utility/BUILD.gn",
      "new_id": "e3de364f16a47292dbe21b5ad7821d25eb68bc5e",
      "new_mode": 33188,
      "new_path": "modules/utility/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "f5dfa05eba42d6039311c4b4287a70e0ff04bedc",
      "old_mode": 33188,
      "old_path": "modules/video_capture/BUILD.gn",
      "new_id": "29530533952377739165666ac1fe3b876f0e8382",
      "new_mode": 33188,
      "new_path": "modules/video_capture/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "4e4ab75a304e6a6048178e139878c881bfc67fc4",
      "old_mode": 33188,
      "old_path": "modules/video_coding/BUILD.gn",
      "new_id": "02b0a1be3bf8760bbb7aa28adcc0e5e21fa7e596",
      "new_mode": 33188,
      "new_path": "modules/video_coding/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "e6b91560c8382ccb0718327b8da67dd4c62a3273",
      "old_mode": 33188,
      "old_path": "p2p/BUILD.gn",
      "new_id": "cd54b7d5cc9953180d778f54d11936b7c42f5bca",
      "new_mode": 33188,
      "new_path": "p2p/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "225f7f47423c172726ab4ba66e82220464d972a4",
      "old_mode": 33188,
      "old_path": "pc/BUILD.gn",
      "new_id": "536dd23a0328113405f0c4048cc64ffb93493394",
      "new_mode": 33188,
      "new_path": "pc/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "e64e4442dda7739bb1ffb601a62e88d4e716e607",
      "old_mode": 33188,
      "old_path": "rtc_base/BUILD.gn",
      "new_id": "0949f4e6c97e598c688ff1cbe5d9ffc11609a72c",
      "new_mode": 33188,
      "new_path": "rtc_base/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "2b6d850f6fcf2d3ffabd0c18a25062f328e860d8",
      "old_mode": 33188,
      "old_path": "rtc_tools/BUILD.gn",
      "new_id": "771d6d90e4d9588e8249bca56a118ba15e57eb7a",
      "new_mode": 33188,
      "new_path": "rtc_tools/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "8657203e23d667bc57de9c6f5c15db6edaf4c76f",
      "old_mode": 33188,
      "old_path": "sdk/android/BUILD.gn",
      "new_id": "3faca81f36a5c8740aa1b572810087e9c315ae71",
      "new_mode": 33188,
      "new_path": "sdk/android/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "dc2baf62dab0e1d5f6606a31cc9ed6b00c441064",
      "old_mode": 33188,
      "old_path": "system_wrappers/BUILD.gn",
      "new_id": "f999e211b759affb0ed3b74569513d4489229055",
      "new_mode": 33188,
      "new_path": "system_wrappers/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "e963ecf39c66dcc9d6b1a79265c7c14e50af40df",
      "old_mode": 33188,
      "old_path": "system_wrappers/include/ntp_time.h",
      "new_id": "1c321841bdf6a95b25a04ff656f3ec772c236c8a",
      "new_mode": 33188,
      "new_path": "system_wrappers/include/ntp_time.h"
    },
    {
      "type": "modify",
      "old_id": "98c74e9ea244cae17e49b9249634af8142470ccb",
      "old_mode": 33188,
      "old_path": "test/BUILD.gn",
      "new_id": "8841ae08068d34a636b3286bff79c9561b309990",
      "new_mode": 33188,
      "new_path": "test/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "475aeaa5bd1fc217e43108eb18a8488ddd2d31aa",
      "old_mode": 33188,
      "old_path": "test/fuzzers/BUILD.gn",
      "new_id": "19d1302087f93a981936f038ba3ea311cd5dbb25",
      "new_mode": 33188,
      "new_path": "test/fuzzers/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "95b6e31dae4dc248c4f5545976e061ddb780d5a5",
      "old_mode": 33188,
      "old_path": "video/BUILD.gn",
      "new_id": "fe03c9add47bde5b62ef02c377083f098a908b6b",
      "new_mode": 33188,
      "new_path": "video/BUILD.gn"
    },
    {
      "type": "modify",
      "old_id": "31d95fdf6b7cca91f727715ce81c01fec76918e6",
      "old_mode": 33188,
      "old_path": "voice_engine/BUILD.gn",
      "new_id": "e99393172fdd409857a411647eb83df9d5dc272a",
      "new_mode": 33188,
      "new_path": "voice_engine/BUILD.gn"
    }
  ]
}
