)]}' { "commit": "509e4fe8e697d55bc15bd65d6129b847d8a7bb66", "tree": "d089f3f29612109831e8f2d23928c134a293b6a2", "parents": [ "d7ac0a9bcc5e9ff0eaf575ae3c886c0df92978f9" ], "author": { "name": "magjed", "email": "magjed@webrtc.org", "time": "Fri Nov 18 09:34:11 2016" }, "committer": { "name": "Commit bot", "email": "commit-bot@chromium.org", "time": "Fri Nov 18 09:34:14 2016" }, "message": "Reland of Stop using hardcoded payload types for video codecs (patchset #1 id:1 of https://codereview.webrtc.org/2513633002/ )\n\nReason for revert:\nThe WebRtcBrowserTest.NegotiateUnsupportedVideoCodec test has been fixed in Chromium with the following change:\n function removeVideoCodec(offerSdp) {\n- offerSdp \u003d offerSdp.replace(\u0027a\u003drtpmap:100 VP8/90000\\r\\n\u0027,\n- \u0027a\u003drtpmap:100 XVP8/90000\\r\\n\u0027);\n+ offerSdp \u003d offerSdp.replace(/a\u003drtpmap:(\\d+)\\ VP8\\/90000\\r\\n/,\n+ \u0027a\u003drtpmap:$1 XVP8/90000\\r\\n\u0027);\n return offerSdp;\n }\n\nOriginal issue\u0027s description:\n\u003e Revert of Stop using hardcoded payload types for video codecs (patchset #6 id:210001 of https://codereview.webrtc.org/2493133002/ )\n\u003e\n\u003e Reason for revert:\n\u003e Breaks chromium.fyi test:\n\u003e WebRtcBrowserTest.NegotiateUnsupportedVideoCodec\n\u003e\n\u003e Original issue\u0027s description:\n\u003e \u003e Stop using hardcoded payload types for video codecs\n\u003e \u003e\n\u003e \u003e This CL stops using hardcoded payload types for different video codecs\n\u003e \u003e and will dynamically assign them payload types incrementally from 96 to\n\u003e \u003e 127 instead.\n\u003e \u003e\n\u003e \u003e This CL:\n\u003e \u003e * Replaces \u0027std::vector\u003cVideoCodec\u003e DefaultVideoCodecList()\u0027 in\n\u003e \u003e webrtcvideoengine2.cc with an explicit WebRtcVideoEncoderFactory for\n\u003e \u003e internally supported software codecs instead. The purpose is to\n\u003e \u003e streamline the payload type assignment in webrtcvideoengine2.cc which\n\u003e \u003e will now have two encoder factories of the same\n\u003e \u003e WebRtcVideoEncoderFactory type; one internal and one external.\n\u003e \u003e * Removes webrtc::VideoEncoder::EncoderType and use cricket::VideoCodec\n\u003e \u003e instead.\n\u003e \u003e * Removes \u0027static VideoEncoder* Create(EncoderType codec_type)\u0027 and\n\u003e \u003e moves the create function to the internal encoder factory instead.\n\u003e \u003e * Removes video_encoder.cc. webrtc::VideoEncoder is now just an\n\u003e \u003e interface without any static functions.\n\u003e \u003e * The function GetSupportedCodecs in webrtcvideoengine2.cc unifies\n\u003e \u003e the internal and external codecs and assigns them payload types\n\u003e \u003e incrementally from 96 to 127.\n\u003e \u003e * Updates webrtcvideoengine2_unittest.cc and removes assumptions about\n\u003e \u003e what payload types will be used.\n\u003e \u003e\n\u003e \u003e BUG\u003dwebrtc:6677,webrtc:6705\n\u003e \u003e R\u003dhta@webrtc.org, ossu@webrtc.org, stefan@webrtc.org\n\u003e \u003e\n\u003e \u003e Committed: https://crrev.com/42043b95872b51321f508bf255d804ce3dff366b\n\u003e \u003e Cr-Commit-Position: refs/heads/master@{#15135}\n\u003e\n\u003e TBR\u003dhta@webrtc.org,stefan@webrtc.org,ossu@webrtc.org\n\u003e # Skipping CQ checks because original CL landed less than 1 days ago.\n\u003e NOPRESUBMIT\u003dtrue\n\u003e NOTREECHECKS\u003dtrue\n\u003e NOTRY\u003dtrue\n\u003e BUG\u003dwebrtc:6677,webrtc:6705\n\u003e\n\u003e Committed: https://crrev.com/eacbaea920797ff751ca83050d140821f5055591\n\u003e Cr-Commit-Position: refs/heads/master@{#15140}\n\nTBR\u003dhta@webrtc.org,stefan@webrtc.org,ossu@webrtc.org\n# Skipping CQ checks because original CL landed less than 1 days ago.\nNOPRESUBMIT\u003dtrue\nNOTREECHECKS\u003dtrue\nNOTRY\u003dtrue\nBUG\u003dwebrtc:6677,webrtc:6705\n\nReview-Url: https://codereview.webrtc.org/2511933002\nCr-Commit-Position: refs/heads/master@{#15148}\n", "tree_diff": [ { "type": "modify", "old_id": "6fcb0fbe3609441f5bac643d25d5c6f152241db3", "old_mode": 33188, "old_path": "webrtc/api/android/jni/androidmediaencoder_jni.cc", "new_id": "d5998c032c6132c71cd9e84cf68594bb010665c9", "new_mode": 33188, "new_path": "webrtc/api/android/jni/androidmediaencoder_jni.cc" }, { "type": "modify", "old_id": "3c6643f2aac384dd2ac623b2a3ee7eef61abd9f9", "old_mode": 33188, "old_path": "webrtc/api/webrtcsdp_unittest.cc", "new_id": "7941323d973d264cad8b4c92adb573c129e94e4b", "new_mode": 33188, "new_path": "webrtc/api/webrtcsdp_unittest.cc" }, { "type": "modify", "old_id": "c3d173aac8b6e34cb05e906b3faa7f76f31605ca", "old_mode": 33188, "old_path": "webrtc/media/BUILD.gn", "new_id": "590450bd296f0ab0ff97ab4e63e86b9a08ea423d", "new_mode": 33188, "new_path": "webrtc/media/BUILD.gn" }, { "type": "modify", "old_id": "5acd8cdb019b05d315618ede8908d67f7cf6ad82", "old_mode": 33188, "old_path": "webrtc/media/base/mediaconstants.cc", "new_id": "bce252195a24e69bbab1d3d56b0ff5dfe2cd665e", "new_mode": 33188, "new_path": "webrtc/media/base/mediaconstants.cc" }, { "type": "modify", "old_id": "02a7ba239eba79ccedfeabba74beae44ad8b7732", "old_mode": 33188, "old_path": "webrtc/media/base/mediaconstants.h", "new_id": "70080c3a0841fd55a671e9d12506475626f9f367", "new_mode": 33188, "new_path": "webrtc/media/base/mediaconstants.h" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "4c9801544744c4b61fb3fcdb434217bab48954c6", "new_mode": 33188, "new_path": "webrtc/media/engine/internalencoderfactory.cc" }, { "type": "add", "old_id": "0000000000000000000000000000000000000000", "old_mode": 0, "old_path": "/dev/null", "new_id": "909fa0ff2f53175b465e2235d9b39974e94be19d", "new_mode": 33188, "new_path": "webrtc/media/engine/internalencoderfactory.h" }, { "type": "modify", "old_id": "477c7ab0931572ebeb86b1b9ff49df1e3365272b", "old_mode": 33188, "old_path": "webrtc/media/engine/payload_type_mapper.cc", "new_id": "0d449c4e4320872b2bb2674f492877af980838a1", "new_mode": 33188, "new_path": "webrtc/media/engine/payload_type_mapper.cc" }, { "type": "modify", "old_id": "6ff8c0f658aec862c3c84fb07e4d48d2281d9299", "old_mode": 33188, "old_path": "webrtc/media/engine/payload_type_mapper_unittest.cc", "new_id": "628eb0cc91038ce636c1ba52843d509fd1a62b5a", "new_mode": 33188, "new_path": "webrtc/media/engine/payload_type_mapper_unittest.cc" }, { "type": "modify", "old_id": "cc37a91736e9e1df696e32ecbba445ff0bd43c4b", "old_mode": 33188, "old_path": "webrtc/media/engine/videoencodersoftwarefallbackwrapper.cc", "new_id": "0de15b3d8fd94d94e6d87a4e60a352e241563ac2", "new_mode": 33188, "new_path": "webrtc/media/engine/videoencodersoftwarefallbackwrapper.cc" }, { "type": "modify", "old_id": "5d81f4ac1e0322a6e8d55cbda7cfc27e2527007d", "old_mode": 33188, "old_path": "webrtc/media/engine/videoencodersoftwarefallbackwrapper.h", "new_id": "05e815df46954f7cedd347edac3e8c2d980dd2a1", "new_mode": 33188, "new_path": "webrtc/media/engine/videoencodersoftwarefallbackwrapper.h" }, { "type": "modify", "old_id": "42d6b473cd8a99872d4199a15ab1889febe9b01e", "old_mode": 33188, "old_path": "webrtc/media/engine/videoencodersoftwarefallbackwrapper_unittest.cc", "new_id": "ca06e9256d67c843be61b7730d47675ced1b43b7", "new_mode": 33188, "new_path": "webrtc/media/engine/videoencodersoftwarefallbackwrapper_unittest.cc" }, { "type": "modify", "old_id": "5238348478eb24de59dec34c24f7d10a0792474e", "old_mode": 33188, "old_path": "webrtc/media/engine/webrtcvideoengine2.cc", "new_id": "2016cf6d6fcf56a66bec7f0b042888b84aa97b57", "new_mode": 33188, "new_path": "webrtc/media/engine/webrtcvideoengine2.cc" }, { "type": "modify", "old_id": "28dfb9773a284ada65aa405bc6db3eb6bf0c4ea5", "old_mode": 33188, "old_path": "webrtc/media/engine/webrtcvideoengine2.h", "new_id": "546799ec88b0ba8344613929042e0408b972a5e3", "new_mode": 33188, "new_path": "webrtc/media/engine/webrtcvideoengine2.h" }, { "type": "modify", "old_id": "19b7d644cd8942ea702158e08efef53adccf5e3f", "old_mode": 33188, "old_path": "webrtc/media/engine/webrtcvideoengine2_unittest.cc", "new_id": "70de26711a93871df73b41c364b4263a80a14e90", "new_mode": 33188, "new_path": "webrtc/media/engine/webrtcvideoengine2_unittest.cc" }, { "type": "modify", "old_id": "7b6dd8f8e7c639535714664f647a75bfc98783c3", "old_mode": 33188, "old_path": "webrtc/video/BUILD.gn", "new_id": "5f9f75c1ef109463c65e8659faa2163bb12aca33", "new_mode": 33188, "new_path": "webrtc/video/BUILD.gn" }, { "type": "modify", "old_id": "3ff3bd23f51fafae5d3fb4ca54e887bc30f0adbe", "old_mode": 33188, "old_path": "webrtc/video/end_to_end_tests.cc", "new_id": "d93dd247d1da3c16e775bb66bed129ebc12a3d24", "new_mode": 33188, "new_path": "webrtc/video/end_to_end_tests.cc" }, { "type": "delete", "old_id": "f4e8156528bc288fb300bf2daed4461a3ec668d0", "old_mode": 33188, "old_path": "webrtc/video/video_encoder.cc", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "modify", "old_id": "d0624c0a522404e409e7ef8b1778c6f0d881bc76", "old_mode": 33188, "old_path": "webrtc/video/video_quality_test.cc", "new_id": "42f24046b2adcd96d33fa6813a8492f6af47e0a5", "new_mode": 33188, "new_path": "webrtc/video/video_quality_test.cc" }, { "type": "modify", "old_id": "c9d8f76549c5c3b4ea6de4957d055728905d66ab", "old_mode": 33188, "old_path": "webrtc/video/video_send_stream_tests.cc", "new_id": "cc76b13515a54c33a7dce5667c03691b28f8b40b", "new_mode": 33188, "new_path": "webrtc/video/video_send_stream_tests.cc" }, { "type": "modify", "old_id": "3a997176a980b6aafc9fda79dfe8de89c84cb7f3", "old_mode": 33188, "old_path": "webrtc/video_encoder.h", "new_id": "f8a04f2e74a9056bf5dbdc4b676e820e83c1ac8a", "new_mode": 33188, "new_path": "webrtc/video_encoder.h" } ] }