)]}'
{
  "commit": "55cdc29b9d7259d17ccc281855dd21adc51ca957",
  "tree": "22f0804c2450df05a0516210d03daed70265d681",
  "parents": [
    "3abf8be1806e5d1cb913108b68056a1189187b19"
  ],
  "author": {
    "name": "Henrik Boström",
    "email": "hbos@webrtc.org",
    "time": "Wed Jan 17 09:32:23 2024"
  },
  "committer": {
    "name": "WebRTC LUCI CQ",
    "email": "webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Fri Jan 19 07:21:51 2024"
  },
  "message": "Reland \"[Stats] Attribute::ToString(), to replace member ValueToString/ToJson.\"\n\nThis is a reland of commit 54be7084e0861a0179a5fccd0b27edf7d7994bbb\n\nOriginal change\u0027s description:\n\u003e [Stats] Attribute::ToString(), to replace member ValueToString/ToJson.\n\u003e\n\u003e Delete RTCStatsMember\u003cT\u003e::ValueToString() and ValueToJson() in favor of\n\u003e Attribute::ToString().\n\u003e\n\u003e The difference between \"ToString\" and \"ToJson\" is that the \"ToJson\"\n\u003e version converts 64-bit integers and doubles to floating points with no\n\u003e more than ~15 digits of precision as to not exceed JSON\u0027s precision\n\u003e limitations. So only in edge cases of really large numbers or numbers\n\u003e with a silly number of digits will the two methods produce different\n\u003e results. Also JSON puts \u0027\\\"\u0027 around map key names, e.g. \"{\\\"foo\\\":123}\"\n\u003e as opposed to \"{foo:123}\".\n\u003e\n\u003e Going forward we see no reason to maintain two different string\n\u003e converted paths that are this similar, so we only implement one\n\u003e Attribute::ToString() method which does what \"ToJson\" did.\n\u003e\n\u003e In the next CL we can delete RTCStatsMember\u003cT\u003e.\n\u003e\n\u003e Bug: webrtc:15164\n\u003e Change-Id: Iaa8cf3bf14b40dc44664f75989832469603131c5\n\u003e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/334640\n\u003e Commit-Queue: Henrik Boström \u003chbos@webrtc.org\u003e\n\u003e Reviewed-by: Evan Shrubsole \u003ceshr@google.com\u003e\n\u003e Reviewed-by: Harald Alvestrand \u003chta@webrtc.org\u003e\n\u003e Cr-Commit-Position: refs/heads/main@{#41544}\n\nBug: webrtc:15164\nChange-Id: If34509ebf3d7c0291442ae11596e7c2d3978fb64\nReviewed-on: https://webrtc-review.googlesource.com/c/src/+/335240\nReviewed-by: Henrik Boström \u003chbos@webrtc.org\u003e\nCommit-Queue: Mirko Bonadei \u003cmbonadei@webrtc.org\u003e\nCr-Commit-Position: refs/heads/main@{#41566}\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "fdedc74082087ce1e5ecb6ea0ca21631577fc5c9",
      "old_mode": 33188,
      "old_path": "api/stats/attribute.h",
      "new_id": "dd21a985df2003614d56372060331c94c4126b0e",
      "new_mode": 33188,
      "new_path": "api/stats/attribute.h"
    },
    {
      "type": "modify",
      "old_id": "d2aa539cf559bb17a2a45c6d7c42be6c00c790fd",
      "old_mode": 33188,
      "old_path": "api/stats/rtc_stats_member.h",
      "new_id": "bf9cc0f4007f37126ccd26b0b954757557d998c0",
      "new_mode": 33188,
      "new_path": "api/stats/rtc_stats_member.h"
    },
    {
      "type": "modify",
      "old_id": "0fd3c27f7d2b84cc41c7ce0fde978dbae717aaec",
      "old_mode": 33188,
      "old_path": "pc/peer_connection_rampup_tests.cc",
      "new_id": "e45821b31f14eeab0892bab2120c5c8d19d72661",
      "new_mode": 33188,
      "new_path": "pc/peer_connection_rampup_tests.cc"
    },
    {
      "type": "modify",
      "old_id": "762dad6fcddb4bd7e2b8d8f79d4b0d36b19a5918",
      "old_mode": 33188,
      "old_path": "pc/rtc_stats_integrationtest.cc",
      "new_id": "002f9d34b5b8aeab3fb28730041b09a589bf027e",
      "new_mode": 33188,
      "new_path": "pc/rtc_stats_integrationtest.cc"
    },
    {
      "type": "modify",
      "old_id": "76956e25b828006ac4272eb53e13a1cb8f99a33b",
      "old_mode": 33188,
      "old_path": "stats/attribute.cc",
      "new_id": "fab948b1bdaf49b837b3e04c72a053e008ded1cc",
      "new_mode": 33188,
      "new_path": "stats/attribute.cc"
    },
    {
      "type": "modify",
      "old_id": "ea87379b95f1b934349c2bd0f376e9ff692456d0",
      "old_mode": 33188,
      "old_path": "stats/rtc_stats.cc",
      "new_id": "e7d72ee3a3fca012840c99577501c238e542d755",
      "new_mode": 33188,
      "new_path": "stats/rtc_stats.cc"
    },
    {
      "type": "modify",
      "old_id": "d7a3f6ccd2d818c24476e3f3c5f8a98d12093b67",
      "old_mode": 33188,
      "old_path": "stats/rtc_stats_member.cc",
      "new_id": "3f91988ed0fc3d49d1194498d8f48f763dd71da2",
      "new_mode": 33188,
      "new_path": "stats/rtc_stats_member.cc"
    },
    {
      "type": "modify",
      "old_id": "8837da7ce9e59497371f157657553342703e9c3b",
      "old_mode": 33188,
      "old_path": "stats/rtc_stats_unittest.cc",
      "new_id": "40b05d79db15e3d87d229d072cb510746a6a15cc",
      "new_mode": 33188,
      "new_path": "stats/rtc_stats_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "3ae7fda04bf1bbb173f01f05ed0ef11fce56bff2",
      "old_mode": 33188,
      "old_path": "test/pc/e2e/analyzer/video/video_quality_metrics_reporter.cc",
      "new_id": "e66624127dc4f2c224a407ce79778f031b42d98c",
      "new_mode": 33188,
      "new_path": "test/pc/e2e/analyzer/video/video_quality_metrics_reporter.cc"
    }
  ]
}
