)]}'
{
  "commit": "57574ea577a7306bb93447e7b8d0f11e88c654ce",
  "tree": "f81c665a11922b303558f3f08739e63ccf33dda5",
  "parents": [
    "dfb9e8b02c441170a5927266d6defac790e22204"
  ],
  "author": {
    "name": "Mirko Bonadei",
    "email": "mbonadei@webrtc.org",
    "time": "Fri Aug 12 13:38:43 2022"
  },
  "committer": {
    "name": "WebRTC LUCI CQ",
    "email": "webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Fri Aug 12 19:54:33 2022"
  },
  "message": "Fix potentially negative Timestamp in logs.\n\nThis bug was activated by [1] when we started to store the timestamp\nin the webrtc::Timestamp class (causing an RTC_DCHECK to trigger) but\nit has been in the codebase for long time (but without using\nwebrtc::Timestamp the RTC_DCHECK was not triggered).\n\nBasically, LogStartTime() can be called externally to create a baseline\nfor logging but if that is not the case, LogMessage should call it [2]\nand initialise the baseline.\n\nThis was happening in reverse order, causing the first LogMessage to\ncall LogStartTime() after the SystemTimeMillis(), causing a negative\ntime difference that when gets wrapped into webrtc::Timestamp triggers\nthe RTC_DCHECK [3].\n\n\n[1] - https://webrtc-review.googlesource.com/c/src/+/269249\n[2] - https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/rtc_base/logging.h;l\u003d493-497;drc\u003d821b92a66ed661714cc21020b5a045fcd18d0176\n[3] - https://source.chromium.org/chromium/chromium/src/+/main:third_party/webrtc/rtc_base/units/unit_base.h;l\u003d122;drc\u003d6dcd43f1e4f2f3ec0bd844cd45e011e9c4d16e38\n\nBug: b/238157120\nChange-Id: I891799316503030c0df5e10e759a61dfc5e1ab3c\nReviewed-on: https://webrtc-review.googlesource.com/c/src/+/271582\nReviewed-by: Tomas Gunnarsson \u003ctommi@webrtc.org\u003e\nCommit-Queue: Tomas Gunnarsson \u003ctommi@webrtc.org\u003e\nCr-Commit-Position: refs/heads/main@{#37770}\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "798c059fb32c8ee5a50a565d5091497e4f79c30a",
      "old_mode": 33188,
      "old_path": "rtc_base/logging.cc",
      "new_id": "4bc9183d97fa1be6de7e558675287ef665720708",
      "new_mode": 33188,
      "new_path": "rtc_base/logging.cc"
    }
  ]
}