)]}' { "commit": "59844ce57e1fe318fc0cf23b1a7ff52f5a8c257e", "tree": "bc5d937241d725dfd98c282b25f55fa9ff96f633", "parents": [ "7852d291c9623f81c4045ea3a2889bb907be3240" ], "author": { "name": "Qingsi Wang", "email": "qingsi@webrtc.org", "time": "Thu Nov 01 04:45:53 2018" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Thu Nov 01 04:46:02 2018" }, "message": "Revert \"Use the factory instead of using the builtin code path in `VideoCodecInitializer`.\"\n\nThis reverts commit be142178aaf6ab4089b4d81c88c3d59c12cca567.\n\nReason for revert: breaking internal projects\n\nOriginal change\u0027s description:\n\u003e Use the factory instead of using the builtin code path in `VideoCodecInitializer`.\n\u003e \n\u003e Bug: webrtc:9513\n\u003e Change-Id: Ia299ae1044a3ff4c91e208200938cba540bdcea6\n\u003e Reviewed-on: https://webrtc-review.googlesource.com/c/94782\n\u003e Commit-Queue: Jiawei Ou \u003couj@fb.com\u003e\n\u003e Reviewed-by: Kári Helgason \u003ckthelgason@webrtc.org\u003e\n\u003e Reviewed-by: Sami Kalliomäki \u003csakal@webrtc.org\u003e\n\u003e Reviewed-by: Sebastian Jansson \u003csrte@webrtc.org\u003e\n\u003e Reviewed-by: Anders Carlsson \u003candersc@webrtc.org\u003e\n\u003e Reviewed-by: Seth Hampson \u003cshampson@webrtc.org\u003e\n\u003e Reviewed-by: Erik Språng \u003csprang@webrtc.org\u003e\n\u003e Reviewed-by: Niels Moller \u003cnisse@webrtc.org\u003e\n\u003e Reviewed-by: Rasmus Brandt \u003cbrandtr@webrtc.org\u003e\n\u003e Cr-Commit-Position: refs/heads/master@{#25456}\n\nTBR\u003dbrandtr@webrtc.org,magjed@webrtc.org,sakal@webrtc.org,nisse@webrtc.org,andersc@webrtc.org,tommi@webrtc.org,kthelgason@webrtc.org,sprang@webrtc.org,srte@webrtc.org,perkj@webrtc.org,tkchin@webrtc.org,shampson@webrtc.org,glaznev@webrtc.org,ouj@fb.com,qingsi@webrtc.org\n\nChange-Id: I8040ccabe3ae6464d72c7696adb663c1dd275b63\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nBug: webrtc:9513\nReviewed-on: https://webrtc-review.googlesource.com/c/108980\nReviewed-by: Qingsi Wang \u003cqingsi@webrtc.org\u003e\nCommit-Queue: Qingsi Wang \u003cqingsi@webrtc.org\u003e\nCr-Commit-Position: refs/heads/master@{#25459}", "tree_diff": [ { "type": "modify", "old_id": "4d6622f2c7b36a985e9bea3c07e214ca44d1c5bd", "old_mode": 33188, "old_path": "api/BUILD.gn", "new_id": "7e74c1a164053fbaad83f74413e577236911ec20", "new_mode": 33188, "new_path": "api/BUILD.gn" }, { "type": "delete", "old_id": "0cae061ab75dcd667570dbb7cf333cf5506f1f84", "old_mode": 33188, "old_path": "api/test/mock_video_bitrate_allocator_factory.h", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "modify", "old_id": "b184dd1ab20e029761d1136905b03af40d7db6ae", "old_mode": 33188, "old_path": "api/video/BUILD.gn", "new_id": "e3c41361486c94ac55250667837f46dc51fce1c3", "new_mode": 33188, "new_path": "api/video/BUILD.gn" }, { "type": "modify", "old_id": "37c1de7015f21b3a85d69bf20b0330cbaccfd9c6", "old_mode": 33188, "old_path": "api/video/video_stream_encoder_settings.h", "new_id": "b67f33c982dbbecc08b18774b548bf0d89fc5831", "new_mode": 33188, "new_path": "api/video/video_stream_encoder_settings.h" }, { "type": "modify", "old_id": "7e84dff4dcb8491da5caad351da633a4c86c0414", "old_mode": 33188, "old_path": "call/BUILD.gn", "new_id": "0b65c3c60aa17a9dc88a44176401cc114a4f7f56", "new_mode": 33188, "new_path": "call/BUILD.gn" }, { "type": "modify", "old_id": "56b7c626a31e2163c118e14c543f0bf2cc7a3481", "old_mode": 33188, "old_path": "call/bitrate_estimator_tests.cc", "new_id": "bab73e4814873aaea06817d6bfb075b747b05b1a", "new_mode": 33188, "new_path": "call/bitrate_estimator_tests.cc" }, { "type": "modify", "old_id": "f66527b60456e8084235cc843e044e1881bc8978", "old_mode": 33188, "old_path": "call/call_perf_tests.cc", "new_id": "acc6af0ed05a2dedd2c5de174b4f8d4e1f1293e5", "new_mode": 33188, "new_path": "call/call_perf_tests.cc" }, { "type": "modify", "old_id": "6ad1b7f621345f8a20a4d757b04ac13bbf7dd1bb", "old_mode": 33188, "old_path": "examples/BUILD.gn", "new_id": "cd931b4beb62875e8a2f11ab16c13bc6b2d90502", "new_mode": 33188, "new_path": "examples/BUILD.gn" }, { "type": "modify", "old_id": "f63616a6113baf0b76c653c51f12cd784787b4f3", "old_mode": 33188, "old_path": "examples/androidnativeapi/BUILD.gn", "new_id": "5568eb11dde3ebf3b951b02a62aa6855132865e1", "new_mode": 33188, "new_path": "examples/androidnativeapi/BUILD.gn" }, { "type": "modify", "old_id": "747b3d9009a071fe422800c7d63fcfda8559c4a0", "old_mode": 33188, "old_path": "examples/androidnativeapi/jni/androidcallclient.cc", "new_id": "005f369a6d104622dddb0bdbef8071a812f21233", "new_mode": 33188, "new_path": "examples/androidnativeapi/jni/androidcallclient.cc" }, { "type": "modify", "old_id": "c7b2af42123e495d7e72ae66cecfd157e32381d2", "old_mode": 33188, "old_path": "examples/objcnativeapi/objc/objccallclient.mm", "new_id": "c384da3ef8cbbb776dd05fc54055c2099db111cf", "new_mode": 33188, "new_path": "examples/objcnativeapi/objc/objccallclient.mm" }, { "type": "modify", "old_id": "bcebd3d65a90b589e954276ec9c028d40afd24b1", "old_mode": 33188, "old_path": "media/BUILD.gn", "new_id": "8eaa23ce021745fe350c7a96df4c00709a645af0", "new_mode": 33188, "new_path": "media/BUILD.gn" }, { "type": "modify", "old_id": "8cb4e9d192e74c3fa8cd766b095e5880c16ad732", "old_mode": 33188, "old_path": "media/engine/fakewebrtccall.cc", "new_id": "ce99b9c1034c09215408948836e4c9443112af42", "new_mode": 33188, "new_path": "media/engine/fakewebrtccall.cc" }, { "type": "modify", "old_id": "87b9d2cfbcca70e26e5af0afe5e4ee98e19da693", "old_mode": 33188, "old_path": "media/engine/webrtcmediaengine.cc", "new_id": "e60c592a3fabeed12eb58fed9a6b6ecd67fdf035", "new_mode": 33188, "new_path": "media/engine/webrtcmediaengine.cc" }, { "type": "modify", "old_id": "1032003bc3ccaeb6ceff0650b8706e51d7ba2bc1", "old_mode": 33188, "old_path": "media/engine/webrtcmediaengine.h", "new_id": "d82eccf9dc347faf96f8631fdf264b9022173af9", "new_mode": 33188, "new_path": "media/engine/webrtcmediaengine.h" }, { "type": "modify", "old_id": "9a6a3722a69363fbc24e004c808b49b56026f13c", "old_mode": 33188, "old_path": "media/engine/webrtcmediaengine_unittest.cc", "new_id": "4fa9a6b5ee35d89cbfc6854919d1bf44ad539640", "new_mode": 33188, "new_path": "media/engine/webrtcmediaengine_unittest.cc" }, { "type": "modify", "old_id": "16e105cbc3de0641d66151b29f433a4eca16a879", "old_mode": 33188, "old_path": "media/engine/webrtcvideoengine.cc", "new_id": "d0f12c04f81d9befafe1f97f2aef477cdacdc5da", "new_mode": 33188, "new_path": "media/engine/webrtcvideoengine.cc" }, { "type": "modify", "old_id": "f2ef903203723678792ebea984adf7d957de8e0c", "old_mode": 33188, "old_path": "media/engine/webrtcvideoengine.h", "new_id": "083fc9f41d128cb7db400d269bc3e532570f9be6", "new_mode": 33188, "new_path": "media/engine/webrtcvideoengine.h" }, { "type": "modify", "old_id": "9044bc6e66016f91f0e52ca4fa5a7932f8116a8a", "old_mode": 33188, "old_path": "media/engine/webrtcvideoengine_unittest.cc", "new_id": "36a0e14a387408f971ef2e5784497bd86e854bdf", "new_mode": 33188, "new_path": "media/engine/webrtcvideoengine_unittest.cc" }, { "type": "modify", "old_id": "246fed2852735233bbbe77b78d29e82ec65ea6c7", "old_mode": 33188, "old_path": "modules/video_coding/BUILD.gn", "new_id": "b92f775ddc4e1f8b7f979d31295d78b52235617f", "new_mode": 33188, "new_path": "modules/video_coding/BUILD.gn" }, { "type": "modify", "old_id": "69582660f91188bab809dae344149f1a6fc9f5c4", "old_mode": 33188, "old_path": "modules/video_coding/codecs/test/videoprocessor.cc", "new_id": "5e980cdcf1acc8155f841e4f7e047793ba206d74", "new_mode": 33188, "new_path": "modules/video_coding/codecs/test/videoprocessor.cc" }, { "type": "modify", "old_id": "e979f9c86776e2b9edbe746bd6d95823dbc923d8", "old_mode": 33188, "old_path": "modules/video_coding/include/video_codec_initializer.h", "new_id": "ee70810f62ed73d358491b17216ca3210713b7b9", "new_mode": 33188, "new_path": "modules/video_coding/include/video_codec_initializer.h" }, { "type": "modify", "old_id": "86a5ab2a4820994fd7402874e9f34f2bbe2ef381", "old_mode": 33188, "old_path": "modules/video_coding/video_codec_initializer.cc", "new_id": "e7125ce2782313f8fbc2606b96dbe46ab3ec4e5c", "new_mode": 33188, "new_path": "modules/video_coding/video_codec_initializer.cc" }, { "type": "modify", "old_id": "ceff1ebaf7427bf928fe7e6adbe03c530a187ce3", "old_mode": 33188, "old_path": "modules/video_coding/video_codec_initializer_unittest.cc", "new_id": "335ca6b33219b63f25f9d12dedea84d2033e0624", "new_mode": 33188, "new_path": "modules/video_coding/video_codec_initializer_unittest.cc" }, { "type": "modify", "old_id": "1460f6abbc30baef41589afd2bc33d188854dd91", "old_mode": 33188, "old_path": "modules/video_coding/video_coding_impl.cc", "new_id": "a061c18fd70e222ecccb742fa075df31516c2509", "new_mode": 33188, "new_path": "modules/video_coding/video_coding_impl.cc" }, { "type": "modify", "old_id": "d6531f03988ef556293e89ec313c9a6ee54a3dca", "old_mode": 33188, "old_path": "pc/BUILD.gn", "new_id": "7663f8b2f277312113de7a4a047ccfd012ff1958", "new_mode": 33188, "new_path": "pc/BUILD.gn" }, { "type": "rename", "old_id": "70f6ad04cbe2520d9342d4979f95a7402a22d652", "old_mode": 33188, "old_path": "api/video/builtin_video_bitrate_allocator_factory.cc", "new_id": "46d7daea6fa98af7f00a9bfff415f999f8b79e34", "new_mode": 33188, "new_path": "pc/builtin_video_bitrate_allocator_factory.cc", "score": 96 }, { "type": "rename", "old_id": "ac880a0863e8ce42c14637de7d7b0a4b398dcdb7", "old_mode": 33188, "old_path": "api/video/builtin_video_bitrate_allocator_factory.h", "new_id": "60f2afcbaba127814d635bae42f003ad3020fe47", "new_mode": 33188, "new_path": "pc/builtin_video_bitrate_allocator_factory.h", "score": 76 }, { "type": "modify", "old_id": "71ee2a1cd04ccb8235992e214632afb52ef87e9c", "old_mode": 33188, "old_path": "pc/createpeerconnectionfactory.cc", "new_id": "b1db69091bac9549371fe12e99eb63bcae210e7c", "new_mode": 33188, "new_path": "pc/createpeerconnectionfactory.cc" }, { "type": "modify", "old_id": "87a4c8571f27435f585fbda99a6dc0f783cdb59f", "old_mode": 33188, "old_path": "pc/peerconnection_integrationtest.cc", "new_id": "236a8bb97dcba09dd1849e21bf266f6103183cce", "new_mode": 33188, "new_path": "pc/peerconnection_integrationtest.cc" }, { "type": "modify", "old_id": "535dacfe3a6226b578a14eff57a6b1f277bffd40", "old_mode": 33188, "old_path": "pc/peerconnection_jsep_unittest.cc", "new_id": "7de0a3ff14a4ab97a98cbc767a9398cc7fa888b1", "new_mode": 33188, "new_path": "pc/peerconnection_jsep_unittest.cc" }, { "type": "modify", "old_id": "0f855494006a1c1c6aa8b6c03c589afcfa33f91c", "old_mode": 33188, "old_path": "pc/peerconnectioninterface_unittest.cc", "new_id": "c4cf081886d5339bb84e5cad12788a76e2bc9745", "new_mode": 33188, "new_path": "pc/peerconnectioninterface_unittest.cc" }, { "type": "modify", "old_id": "38b6f078258abd19e18830a1dbdec3f3df4a6847", "old_mode": 33188, "old_path": "sdk/BUILD.gn", "new_id": "f703918081a9d9ba52082db1c59113b87cfd4b63", "new_mode": 33188, "new_path": "sdk/BUILD.gn" }, { "type": "modify", "old_id": "d7f3da808e00e4635e672eb5f47c519dc1e04ff5", "old_mode": 33188, "old_path": "sdk/android/BUILD.gn", "new_id": "c513a66d451fb099f9a7beb164b529eb2fe9d8a4", "new_mode": 33188, "new_path": "sdk/android/BUILD.gn" }, { "type": "modify", "old_id": "4392d804fd70f9f82eaa43e67f5d429b28f816ff", "old_mode": 33188, "old_path": "sdk/android/native_unittests/peerconnection/peerconnectionfactory_unittest.cc", "new_id": "747786090cdebe217143d61149f11ecb41704814", "new_mode": 33188, "new_path": "sdk/android/native_unittests/peerconnection/peerconnectionfactory_unittest.cc" }, { "type": "modify", "old_id": "5d10907c7b6f09e230e625e8e2bafdcb1e99192b", "old_mode": 33188, "old_path": "sdk/android/src/jni/pc/media.cc", "new_id": "dba85fbffa11688a48a26ccc546e9f445c4d82e9", "new_mode": 33188, "new_path": "sdk/android/src/jni/pc/media.cc" }, { "type": "modify", "old_id": "d6014a65fec78df658928f962b780d18d7fc821f", "old_mode": 33188, "old_path": "sdk/android/src/jni/pc/media.h", "new_id": "8a0bb5217432eedc092d2a5501920f8a60c26409", "new_mode": 33188, "new_path": "sdk/android/src/jni/pc/media.h" }, { "type": "modify", "old_id": "1f937070dd768c73c8c5a08395bc114af547c40d", "old_mode": 33188, "old_path": "sdk/android/src/jni/pc/null_media.cc", "new_id": "c59c476d51bf9bcb079a33e1475188fec0020a60", "new_mode": 33188, "new_path": "sdk/android/src/jni/pc/null_media.cc" }, { "type": "modify", "old_id": "aaf1d0d10b9046ae813c1064cb61ed79cc2b8b9c", "old_mode": 33188, "old_path": "sdk/android/src/jni/pc/null_video.cc", "new_id": "0e0b80d4612f25e874b90d8ea5a722403164674a", "new_mode": 33188, "new_path": "sdk/android/src/jni/pc/null_video.cc" }, { "type": "modify", "old_id": "de3a6e951b559680ef8ca6499cbcec9a9f0a8b9d", "old_mode": 33188, "old_path": "sdk/android/src/jni/pc/peerconnectionfactory.cc", "new_id": "148375e3d6395cd02ce69fa071fee802389b554c", "new_mode": 33188, "new_path": "sdk/android/src/jni/pc/peerconnectionfactory.cc" }, { "type": "modify", "old_id": "e125db206dc56f5753818a1ceffdc40f108df577", "old_mode": 33188, "old_path": "sdk/android/src/jni/pc/video.cc", "new_id": "dd10fd51cb6ad5f4f770f288b27fafbd7fc083dd", "new_mode": 33188, "new_path": "sdk/android/src/jni/pc/video.cc" }, { "type": "modify", "old_id": "96a33bc12521deb548c51ed33c128acae8529b25", "old_mode": 33188, "old_path": "sdk/android/src/jni/pc/video.h", "new_id": "183770b8206283902f79b35f6073b6eaf79e98fb", "new_mode": 33188, "new_path": "sdk/android/src/jni/pc/video.h" }, { "type": "modify", "old_id": "dfe035af773aa1ea7a3f601ea50e8938eb3815d3", "old_mode": 33188, "old_path": "sdk/objc/api/peerconnection/RTCPeerConnectionFactory.mm", "new_id": "48476f2368f0145240deb50e454ce6938979cfe4", "new_mode": 33188, "new_path": "sdk/objc/api/peerconnection/RTCPeerConnectionFactory.mm" }, { "type": "modify", "old_id": "c1caf52154c029f3cdffd5a0164bd340f51875ee", "old_mode": 33188, "old_path": "test/BUILD.gn", "new_id": "c7218b66a1f0265390d1dafa9877998aad404521", "new_mode": 33188, "new_path": "test/BUILD.gn" }, { "type": "modify", "old_id": "7d782503daae0a03c76505ae02e2d3780eca67ff", "old_mode": 33188, "old_path": "test/call_test.cc", "new_id": "286807e50321e4659331fd3e2cbb4303b70b4be5", "new_mode": 33188, "new_path": "test/call_test.cc" }, { "type": "modify", "old_id": "674244ec6c37da732f6733a8f174a2b71918a67d", "old_mode": 33188, "old_path": "test/call_test.h", "new_id": "8bd87e41a94f579126af2083beed31e77b58f383", "new_mode": 33188, "new_path": "test/call_test.h" }, { "type": "modify", "old_id": "7a34d0b2e52beb83e40eb9b5059ec3dc73771463", "old_mode": 33188, "old_path": "test/scenario/BUILD.gn", "new_id": "f3746b8ff92de4b8cf4b6f0485d7bbcc6a44c424", "new_mode": 33188, "new_path": "test/scenario/BUILD.gn" }, { "type": "modify", "old_id": "4f0078a9da07e0717967073dc14f2b339955904a", "old_mode": 33188, "old_path": "test/scenario/video_stream.cc", "new_id": "071ce0a3912e523009ec7980511c79fa64d9e319", "new_mode": 33188, "new_path": "test/scenario/video_stream.cc" }, { "type": "modify", "old_id": "e984a075dd306d99d547cb05d4751292ca5721bb", "old_mode": 33188, "old_path": "test/scenario/video_stream.h", "new_id": "1b5b20a8ca4d2d1139baad5019b7d74ce20e9ad5", "new_mode": 33188, "new_path": "test/scenario/video_stream.h" }, { "type": "modify", "old_id": "4c705514f470efa270e85da1df111afc7afdf741", "old_mode": 33188, "old_path": "video/BUILD.gn", "new_id": "33dcbe64856ea30bb544ae3840f7670a7a429f5e", "new_mode": 33188, "new_path": "video/BUILD.gn" }, { "type": "modify", "old_id": "265b05250f5a805fe2e76a7b4cd640a1a236aed2", "old_mode": 33188, "old_path": "video/end_to_end_tests/bandwidth_tests.cc", "new_id": "4c8f12c481a92748e4404f07ee2eedcc0d85c098", "new_mode": 33188, "new_path": "video/end_to_end_tests/bandwidth_tests.cc" }, { "type": "modify", "old_id": "5d5da65ca8f7f80512ecc0f6a80dd56ea5efbf3f", "old_mode": 33188, "old_path": "video/end_to_end_tests/multi_stream_tester.cc", "new_id": "4590c25dcbda31ed90a48dfeb4695f34197dd0c5", "new_mode": 33188, "new_path": "video/end_to_end_tests/multi_stream_tester.cc" }, { "type": "modify", "old_id": "db9280f8b5c4915963ec1793050b5d16635c8b2c", "old_mode": 33188, "old_path": "video/video_quality_test.cc", "new_id": "15579d855bb3457244228b1f52afdd58aa7e2f8e", "new_mode": 33188, "new_path": "video/video_quality_test.cc" }, { "type": "modify", "old_id": "f67e65bc13797428c0cc7cc61ca678a526870ebc", "old_mode": 33188, "old_path": "video/video_quality_test.h", "new_id": "92796f303a1a2cbdb2e32118e065dd6d5913d9eb", "new_mode": 33188, "new_path": "video/video_quality_test.h" }, { "type": "modify", "old_id": "fc4c03e89155dce78d2ab55b7754036098ca37ff", "old_mode": 33188, "old_path": "video/video_send_stream.cc", "new_id": "799931235c8984df14e849f075fe4f10cc137507", "new_mode": 33188, "new_path": "video/video_send_stream.cc" }, { "type": "modify", "old_id": "4e73ffbf851b6b628bb7748b9b4440d45b82005b", "old_mode": 33188, "old_path": "video/video_stream_encoder.cc", "new_id": "6f734fb9d162e905eac0bc5bf1e8c523c4c65942", "new_mode": 33188, "new_path": "video/video_stream_encoder.cc" }, { "type": "modify", "old_id": "1c8edc258e72bb529a0b32bf3bfbde36a229bf06", "old_mode": 33188, "old_path": "video/video_stream_encoder_unittest.cc", "new_id": "4b9de7ba6093c5888e9e3538837af961c563706c", "new_mode": 33188, "new_path": "video/video_stream_encoder_unittest.cc" } ] }