)]}'
{
  "commit": "bdb0fe42bc46d190ca45fc5a6658eddbfa5eead5",
  "tree": "e96c7fd5d00ce0047d350ece894e6ad951acb475",
  "parents": [
    "d902d58b0af39883bf2bf50c0f00be339857ee53"
  ],
  "author": {
    "name": "Mirko Bonadei",
    "email": "mbonadei@webrtc.org",
    "time": "Fri May 18 13:52:11 2018"
  },
  "committer": {
    "name": "Commit Bot",
    "email": "commit-bot@chromium.org",
    "time": "Mon May 21 07:51:55 2018"
  },
  "message": "Reland \"Adding absl includes and defines to rtc_* templates.\"\n\nThis reverts commit 85cb19fec7caf558dee7a09aafabe01c5ac78f3f.\n\nReason for revert: The new version of Abseil should fix the previous\nissue.\n\nOriginal change\u0027s description:\n\u003e Revert \"Reland \"Adding absl includes and defines to rtc_* templates.\"\"\n\u003e \n\u003e This reverts commit 9632112a16d70a146e917db4de761e6253dfc364.\n\u003e \n\u003e Reason for revert: It breaks the WebRTC roll into Chromium.\n\u003e https://chromium-review.googlesource.com/c/chromium/src/+/1061476\n\u003e \n\u003e Original change\u0027s description:\n\u003e \u003e Reland \"Adding absl includes and defines to rtc_* templates.\"\n\u003e \u003e \n\u003e \u003e This reverts commit d161eda477491b2b97fb3f26d229c625a2a0e9b8.\n\u003e \u003e \n\u003e \u003e Reason for revert: The problem with iOS trybots should be fixed.\n\u003e \u003e \n\u003e \u003e Original change\u0027s description:\n\u003e \u003e \u003e Revert \"Adding absl includes and defines to rtc_* templates.\"\n\u003e \u003e \u003e\n\u003e \u003e \u003e This reverts commit 9d8f3850f4c4faad5dc5ab32ab6f2c9c43df7b6c.\n\u003e \u003e \u003e\n\u003e \u003e \u003e Reason for revert: Breaks some trybots: https://build.chromium.org/p/client.webrtc/builders/iOS64%20Release/builds/12793.\n\u003e \u003e \u003e\n\u003e \u003e \u003e Original change\u0027s description:\n\u003e \u003e \u003e \u003e Adding absl includes and defines to rtc_* templates.\n\u003e \u003e \u003e \u003e\n\u003e \u003e \u003e \u003e This CL implicitly adds the -I compiler flag and absl macros to WebRTC\n\u003e \u003e \u003e \u003e templates. In order to include absl headers using relative paths, WebRTC\n\u003e \u003e \u003e \u003e needs to ensure that all its build targets are able to see absl headers.\n\u003e \u003e \u003e \u003e\n\u003e \u003e \u003e \u003e This can also be done with public_deps, but WebRTC is trying to avoid\n\u003e \u003e \u003e \u003e it because it creates problems with other build systems. Given this\n\u003e \u003e \u003e \u003e constraint, using rtc_* templates is the most reliable solution.\n\u003e \u003e \u003e \u003e\n\u003e \u003e \u003e \u003e Please note that rtc_* templates are adding absl includes and defines\n\u003e \u003e \u003e \u003e as public_configs, this means that build targets with WebRTC targets\n\u003e \u003e \u003e \u003e in their public_deps will propagate these configs following the GN\n\u003e \u003e \u003e \u003e guideline.\n\u003e \u003e \u003e \u003e\n\u003e \u003e \u003e \u003e Bug: webrtc:8821\n\u003e \u003e \u003e \u003e Change-Id: I4aa594a524f4bd045bcb3e80d76cc27f06fe01d7\n\u003e \u003e \u003e \u003e Reviewed-on: https://webrtc-review.googlesource.com/70367\n\u003e \u003e \u003e \u003e Reviewed-by: Patrik Höglund \u003cphoglund@webrtc.org\u003e\n\u003e \u003e \u003e \u003e Commit-Queue: Mirko Bonadei \u003cmbonadei@webrtc.org\u003e\n\u003e \u003e \u003e \u003e Cr-Commit-Position: refs/heads/master@{#22927}\n\u003e \u003e \u003e\n\u003e \u003e \u003e TBR\u003dphoglund@webrtc.org,mbonadei@webrtc.org\n\u003e \u003e \u003e\n\u003e \u003e \u003e Change-Id: Id8e1f881c57553386566eb1970f6b9f8632cab37\n\u003e \u003e \u003e No-Presubmit: true\n\u003e \u003e \u003e No-Tree-Checks: true\n\u003e \u003e \u003e No-Try: true\n\u003e \u003e \u003e Bug: webrtc:8821\n\u003e \u003e \u003e Reviewed-on: https://webrtc-review.googlesource.com/71000\n\u003e \u003e \u003e Reviewed-by: Mirko Bonadei \u003cmbonadei@webrtc.org\u003e\n\u003e \u003e \u003e Commit-Queue: Mirko Bonadei \u003cmbonadei@webrtc.org\u003e\n\u003e \u003e \u003e Cr-Commit-Position: refs/heads/master@{#22928}\n\u003e \u003e \n\u003e \u003e TBR\u003dphoglund@webrtc.org,mbonadei@webrtc.org\n\u003e \u003e \n\u003e \u003e Bug: webrtc:8821\n\u003e \u003e Change-Id: I6ee2eda97bbcd4c9be25c9c4073272192b0373f8\n\u003e \u003e Reviewed-on: https://webrtc-review.googlesource.com/71700\n\u003e \u003e Reviewed-by: Patrik Höglund \u003cphoglund@webrtc.org\u003e\n\u003e \u003e Reviewed-by: Mirko Bonadei \u003cmbonadei@webrtc.org\u003e\n\u003e \u003e Commit-Queue: Mirko Bonadei \u003cmbonadei@webrtc.org\u003e\n\u003e \u003e Cr-Commit-Position: refs/heads/master@{#23251}\n\u003e \n\u003e TBR\u003dphoglund@webrtc.org,mbonadei@webrtc.org\n\u003e \n\u003e Change-Id: I61fb749797314ca514691b341c66f7f39ef45491\n\u003e No-Presubmit: true\n\u003e No-Tree-Checks: true\n\u003e No-Try: true\n\u003e Bug: webrtc:8821\n\u003e Reviewed-on: https://webrtc-review.googlesource.com/77220\n\u003e Reviewed-by: Mirko Bonadei \u003cmbonadei@webrtc.org\u003e\n\u003e Commit-Queue: Mirko Bonadei \u003cmbonadei@webrtc.org\u003e\n\u003e Cr-Commit-Position: refs/heads/master@{#23264}\n\nTBR\u003dphoglund@webrtc.org,mbonadei@webrtc.org\n\n# Not skipping CQ checks because original CL landed \u003e 1 day ago.\n\nBug: webrtc:8821\nChange-Id: I71dea953a002a0d526949c627653bcad0c6518fc\nReviewed-on: https://webrtc-review.googlesource.com/77781\nReviewed-by: Mirko Bonadei \u003cmbonadei@webrtc.org\u003e\nCommit-Queue: Mirko Bonadei \u003cmbonadei@webrtc.org\u003e\nCr-Commit-Position: refs/heads/master@{#23317}",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "95c24d4968d6d235d6539c9c1a600e0a80a78479",
      "old_mode": 33188,
      "old_path": "webrtc.gni",
      "new_id": "123e2c225d068c8bb65cba492b64c0cdad5bafce",
      "new_mode": 33188,
      "new_path": "webrtc.gni"
    }
  ]
}