)]}'
{
  "commit": "ccc87ea3c625e43ab138e00ba2ef1a2d99756199",
  "tree": "17dffc8bc1d1c1e64819ae2c62fd554966f7a340",
  "parents": [
    "d0b8e8e4ee78a3bf5577f9b215e273098790f59f"
  ],
  "author": {
    "name": "Henrik Boström",
    "email": "hbos@webrtc.org",
    "time": "Thu Jun 15 13:17:45 2023"
  },
  "committer": {
    "name": "WebRTC LUCI CQ",
    "email": "webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com",
    "time": "Thu Jun 15 16:11:27 2023"
  },
  "message": "[Stats] Remove enum-like structs in favor of strings.\n\nDue to a limitation of RTCStatsMember\u003cT\u003e not supporting enums, as well\nas the fact that in JavaScript enums are represented as basic strings,\nthe stats enums have always been represented by T\u003dstd::string.\n\nNow that we have WebIDL-ified[1] all RTCStats dictionaries and enum\nvalues are simply string-copied (example: [2]) it seems safe to assume\nthat \"stats enums are just strings\" is here to stay.\n\nTherefore there is little value in having C++ structs that look like\nenums so I\u0027m deleting those in favor of std::string operator\u003d\u003d()\ncomparisons, e.g. `if (rtp_stream.kind \u003d\u003d \"audio\")`. This removes some\nlines of code from our code base.\n\nI mostly want to get rid of these because they were taking up about 20%\nof the rtcstats_objects.h real estate...\n\n[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/peerconnection/rtc_stats_report.idl\n[2] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/peerconnection/rtc_stats_report.cc;l\u003d667;drc\u003dcf34e84c9df94256abfb1716ba075ed203975755\n\nBug: webrtc:15245\nChange-Id: Iaf0827d7aecebc1cc02976a61663d5298d684f07\nReviewed-on: https://webrtc-review.googlesource.com/c/src/+/308680\nCommit-Queue: Henrik Boström \u003chbos@webrtc.org\u003e\nReviewed-by: Harald Alvestrand \u003chta@webrtc.org\u003e\nCr-Commit-Position: refs/heads/main@{#40295}\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "58ca165d82236769e8d0c17b9785fdd2ee3ab6df",
      "old_mode": 33188,
      "old_path": "api/stats/rtcstats_objects.h",
      "new_id": "36013928ec751f52f9e585370f94baf69cd7f07e",
      "new_mode": 33188,
      "new_path": "api/stats/rtcstats_objects.h"
    },
    {
      "type": "modify",
      "old_id": "a71b5138659623fad2d8fe66085b891e3b16a7bb",
      "old_mode": 33188,
      "old_path": "pc/peer_connection_bundle_unittest.cc",
      "new_id": "7edbe893167b1f2d579b6e8b98860f5fff25bb27",
      "new_mode": 33188,
      "new_path": "pc/peer_connection_bundle_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "48e854252aebff6b9184f5ac8d3f311311bc650f",
      "old_mode": 33188,
      "old_path": "pc/rtc_stats_collector.cc",
      "new_id": "8cba02b5cedd0fc2da9ae04cde837f546d6a9d4c",
      "new_mode": 33188,
      "new_path": "pc/rtc_stats_collector.cc"
    },
    {
      "type": "modify",
      "old_id": "a8111bf8b21fb9e42af945737f377cf98a650800",
      "old_mode": 33188,
      "old_path": "pc/rtc_stats_collector_unittest.cc",
      "new_id": "a9f326f96a540ee2acba93254534af0d6d52beb4",
      "new_mode": 33188,
      "new_path": "pc/rtc_stats_collector_unittest.cc"
    },
    {
      "type": "modify",
      "old_id": "67cb1c58f2e905a2c704dcad67e6c73899a4821f",
      "old_mode": 33188,
      "old_path": "stats/rtcstats_objects.cc",
      "new_id": "31720ad33f5f39c98fe7573c80ca0b0c685c5dc9",
      "new_mode": 33188,
      "new_path": "stats/rtcstats_objects.cc"
    },
    {
      "type": "modify",
      "old_id": "49e165795ad0274201a4718052cc8e5ce113341e",
      "old_mode": 33188,
      "old_path": "test/pc/e2e/analyzer/audio/default_audio_quality_analyzer.cc",
      "new_id": "09fd7c8a82e892ca5de38f32ff965b0108f300b7",
      "new_mode": 33188,
      "new_path": "test/pc/e2e/analyzer/audio/default_audio_quality_analyzer.cc"
    },
    {
      "type": "modify",
      "old_id": "224eb0c59f99c2edfe81f4a3164e705d252f3f9a",
      "old_mode": 33188,
      "old_path": "test/pc/e2e/analyzer/video/video_quality_metrics_reporter.cc",
      "new_id": "817b3caad0cd8c2803a450396ea8850e2de0b990",
      "new_mode": 33188,
      "new_path": "test/pc/e2e/analyzer/video/video_quality_metrics_reporter.cc"
    },
    {
      "type": "modify",
      "old_id": "549eafd95a62af527f18d8a011311673b84db73e",
      "old_mode": 33188,
      "old_path": "test/pc/e2e/cross_media_metrics_reporter.cc",
      "new_id": "aad5946c9fb0c378de49301688bc6dc3ad11de9e",
      "new_mode": 33188,
      "new_path": "test/pc/e2e/cross_media_metrics_reporter.cc"
    }
  ]
}