Include-what-you-use rtc_event_log_visualizer/
Bug: webrtc:42226242
Change-Id: Ie485095f3ee78b37c51e03730a64e898c95444e8
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/352600
Reviewed-by: Jeremy Leconte <jleconte@google.com>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#42398}
diff --git a/rtc_tools/BUILD.gn b/rtc_tools/BUILD.gn
index c3d3571..6e12b59 100644
--- a/rtc_tools/BUILD.gn
+++ b/rtc_tools/BUILD.gn
@@ -353,6 +353,7 @@
]
deps = [
":chart_proto",
+ "../api:candidate",
"../api:dtls_transport_interface",
"../api:function_view",
"../api:make_ref_counted",
@@ -442,6 +443,7 @@
"//rtc_base/system:file_wrapper",
"//test:fileutils",
"//test:test_support",
+ "//third_party/abseil-cpp/absl/types:optional",
]
}
}
@@ -488,9 +490,11 @@
"rtc_event_log_visualizer/main.cc",
]
deps = [
+ ":chart_proto",
":event_log_visualizer_utils",
"../api/neteq:neteq_api",
"../api/rtc_event_log",
+ "../api/units:time_delta",
"../logging:rtc_event_log_parser",
"../modules/audio_coding:neteq",
"../modules/rtp_rtcp:rtp_rtcp_format",
@@ -504,6 +508,7 @@
"//third_party/abseil-cpp/absl/flags:parse",
"//third_party/abseil-cpp/absl/flags:usage",
"//third_party/abseil-cpp/absl/strings",
+ "//third_party/abseil-cpp/absl/types:optional",
]
}
diff --git a/rtc_tools/rtc_event_log_visualizer/analyzer.cc b/rtc_tools/rtc_event_log_visualizer/analyzer.cc
index 4ae0f9d..0b882f4 100644
--- a/rtc_tools/rtc_event_log_visualizer/analyzer.cc
+++ b/rtc_tools/rtc_event_log_visualizer/analyzer.cc
@@ -27,6 +27,7 @@
#include "absl/functional/bind_front.h"
#include "absl/strings/string_view.h"
#include "absl/types/optional.h"
+#include "api/candidate.h"
#include "api/dtls_transport_interface.h"
#include "api/environment/environment_factory.h"
#include "api/function_view.h"
diff --git a/rtc_tools/rtc_event_log_visualizer/analyzer.h b/rtc_tools/rtc_event_log_visualizer/analyzer.h
index a29454e..2505673 100644
--- a/rtc_tools/rtc_event_log_visualizer/analyzer.h
+++ b/rtc_tools/rtc_event_log_visualizer/analyzer.h
@@ -13,6 +13,7 @@
#include <cstdint>
#include <cstdio>
+#include <functional>
#include <map>
#include <string>
#include <vector>
@@ -20,6 +21,7 @@
#include "api/function_view.h"
#include "logging/rtc_event_log/rtc_event_log_parser.h"
#include "modules/rtp_rtcp/source/rtcp_packet/report_block.h"
+#include "rtc_base/checks.h"
#include "rtc_tools/rtc_event_log_visualizer/analyzer_common.h"
#include "rtc_tools/rtc_event_log_visualizer/plot_base.h"
diff --git a/rtc_tools/rtc_event_log_visualizer/analyzer_bindings.cc b/rtc_tools/rtc_event_log_visualizer/analyzer_bindings.cc
index f63bfe4..0766615 100644
--- a/rtc_tools/rtc_event_log_visualizer/analyzer_bindings.cc
+++ b/rtc_tools/rtc_event_log_visualizer/analyzer_bindings.cc
@@ -12,11 +12,11 @@
#include <cstddef>
#include <cstdint>
+#include <cstring>
#include <iostream>
#include <string>
#include <vector>
-#include "absl/strings/match.h"
#include "absl/strings/string_view.h"
#include "api/units/time_delta.h"
#include "logging/rtc_event_log/rtc_event_log_parser.h"
diff --git a/rtc_tools/rtc_event_log_visualizer/analyzer_bindings_unittest.cc b/rtc_tools/rtc_event_log_visualizer/analyzer_bindings_unittest.cc
index f7e240b..5d61845 100644
--- a/rtc_tools/rtc_event_log_visualizer/analyzer_bindings_unittest.cc
+++ b/rtc_tools/rtc_event_log_visualizer/analyzer_bindings_unittest.cc
@@ -10,12 +10,15 @@
#include "rtc_tools/rtc_event_log_visualizer/analyzer_bindings.h"
+#include <cstddef>
+#include <cstdint>
+#include <cstring>
#include <string>
#include <vector>
+#include "absl/types/optional.h"
#include "rtc_base/protobuf_utils.h"
#include "rtc_base/system/file_wrapper.h"
-#include "test/gmock.h"
#include "test/gtest.h"
#include "test/testsupport/file_utils.h"
diff --git a/rtc_tools/rtc_event_log_visualizer/main.cc b/rtc_tools/rtc_event_log_visualizer/main.cc
index 8cc4496..feded78 100644
--- a/rtc_tools/rtc_event_log_visualizer/main.cc
+++ b/rtc_tools/rtc_event_log_visualizer/main.cc
@@ -26,17 +26,20 @@
#include "absl/flags/usage.h"
#include "absl/flags/usage_config.h"
#include "absl/strings/match.h"
+#include "absl/strings/string_view.h"
+#include "absl/types/optional.h"
#include "api/neteq/neteq.h"
-#include "api/rtc_event_log/rtc_event_log.h"
+#include "api/units/time_delta.h"
#include "logging/rtc_event_log/rtc_event_log_parser.h"
-#include "modules/rtp_rtcp/source/rtcp_packet/report_block.h"
#include "rtc_base/checks.h"
#include "rtc_base/logging.h"
#include "rtc_tools/rtc_event_log_visualizer/alerts.h"
#include "rtc_tools/rtc_event_log_visualizer/analyze_audio.h"
#include "rtc_tools/rtc_event_log_visualizer/analyzer.h"
+#include "rtc_tools/rtc_event_log_visualizer/analyzer_common.h"
#include "rtc_tools/rtc_event_log_visualizer/conversational_speech_en.h"
#include "rtc_tools/rtc_event_log_visualizer/plot_base.h"
+#include "rtc_tools/rtc_event_log_visualizer/proto/chart.pb.h"
#include "system_wrappers/include/field_trial.h"
ABSL_FLAG(std::string,
diff --git a/rtc_tools/rtc_event_log_visualizer/plot_base.cc b/rtc_tools/rtc_event_log_visualizer/plot_base.cc
index 597a22c..ddfa5e05 100644
--- a/rtc_tools/rtc_event_log_visualizer/plot_base.cc
+++ b/rtc_tools/rtc_event_log_visualizer/plot_base.cc
@@ -20,6 +20,8 @@
#include "absl/strings/string_view.h"
#include "rtc_base/checks.h"
+#include "rtc_tools/rtc_event_log_visualizer/proto/chart.pb.h"
+#include "rtc_tools/rtc_event_log_visualizer/proto/chart_enums.pb.h"
namespace webrtc {