)]}' { "commit": "5fbad340b3ec0f0b63206fbf31216e4f8968a0db", "tree": "680719da58132b177b4b879af4d8cc50b36d4c54", "parents": [ "070722c9c7f15d71d2bcdbf82c8315de4a566d35" ], "author": { "name": "eladalon", "email": "eladalon@webrtc.org", "time": "Tue Sep 05 15:15:02 2017" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Sep 05 15:15:02 2017" }, "message": "Reland of Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread (patchset #1 id:1 of https://codereview.webrtc.org/3010143002/ )\n\nReason for revert:\nI will fix and reland.\n\nOriginal issue\u0027s description:\n\u003e Revert of Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread (patchset #18 id:340001 of https://codereview.webrtc.org/3007473002/ )\n\u003e\n\u003e Reason for revert:\n\u003e Breaks google3 project.\n\u003e\n\u003e Original issue\u0027s description:\n\u003e \u003e Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread\n\u003e \u003e\n\u003e \u003e Make RtcEventLogImpl to use a TaskQueue instead of a helper-thread. This will eventually allow us to run multiple log sessions on a single task-queue.\n\u003e \u003e\n\u003e \u003e BUG\u003dwebrtc:8142, webrtc:8143, webrtc:8145\n\u003e \u003e\n\u003e \u003e Review-Url: https://codereview.webrtc.org/3007473002\n\u003e \u003e Cr-Commit-Position: refs/heads/master@{#19666}\n\u003e \u003e Committed: https://chromium.googlesource.com/external/webrtc/+/f33cee7534f0469330b6b7aa57f84eec4b082598\n\u003e\n\u003e TBR\u003dterelius@webrtc.org,nisse@webrtc.org,eladalon@webrtc.org\n\u003e # Skipping CQ checks because original CL landed less than 1 days ago.\n\u003e NOPRESUBMIT\u003dtrue\n\u003e NOTREECHECKS\u003dtrue\n\u003e NOTRY\u003dtrue\n\u003e BUG\u003dwebrtc:8142, webrtc:8143, webrtc:8145\n\u003e\n\u003e Review-Url: https://codereview.webrtc.org/3010143002\n\u003e Cr-Commit-Position: refs/heads/master@{#19672}\n\u003e Committed: https://chromium.googlesource.com/external/webrtc/+/3eac8002db8fdf5124026d5377a1f3ec1d16bb0d\n\nTBR\u003dterelius@webrtc.org,nisse@webrtc.org,charujain@webrtc.org\n# Skipping CQ checks because original CL landed less than 1 days ago.\nNOPRESUBMIT\u003dtrue\nNOTREECHECKS\u003dtrue\nNOTRY\u003dtrue\nBUG\u003dwebrtc:8142, webrtc:8143, webrtc:8145\n\nReview-Url: https://codereview.webrtc.org/3005153002\nCr-Original-Commit-Position: refs/heads/master@{#19690}\nCr-Mirrored-From: https://chromium.googlesource.com/external/webrtc\nCr-Mirrored-Commit: d67cefbbeab0a092d1fa250c811c25733dced043\n", "tree_diff": [ { "type": "modify", "old_id": "6b1e549d3031a4eef4a90eca361b2895010f8dbe", "old_mode": 33188, "old_path": "logging/BUILD.gn", "new_id": "fac7e3d9b451364a40718fbf625d1b1bceda7674", "new_mode": 33188, "new_path": "logging/BUILD.gn" }, { "type": "modify", "old_id": "e661e679828dc401ede7bfbce978fd09ae040a7b", "old_mode": 33188, "old_path": "logging/rtc_event_log/rtc_event_log.cc", "new_id": "d1cad894147000bdd3f6b85a64ae28c876af23bb", "new_mode": 33188, "new_path": "logging/rtc_event_log/rtc_event_log.cc" }, { "type": "modify", "old_id": "d26dccbea96b2058521f31dd083753171639e861", "old_mode": 33188, "old_path": "logging/rtc_event_log/rtc_event_log.h", "new_id": "087f5d9b77a3cad2d3ba0124f78d049ac5d4efa2", "new_mode": 33188, "new_path": "logging/rtc_event_log/rtc_event_log.h" }, { "type": "delete", "old_id": "a98336fa521ff06eac2225614f0991fa29f1c810", "old_mode": 33188, "old_path": "logging/rtc_event_log/rtc_event_log_helper_thread.cc", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "delete", "old_id": "0d9ad4dc96ad77beb657b7bd7768d1b1f7a35dbe", "old_mode": 33188, "old_path": "logging/rtc_event_log/rtc_event_log_helper_thread.h", "new_id": "0000000000000000000000000000000000000000", "new_mode": 0, "new_path": "/dev/null" }, { "type": "modify", "old_id": "e22a09ece06998d12cd2db9dba82c4f0231b368c", "old_mode": 33188, "old_path": "pc/peerconnection.cc", "new_id": "99b87c0012edbe2400f172f08822588199966c35", "new_mode": 33188, "new_path": "pc/peerconnection.cc" }, { "type": "modify", "old_id": "d4ee405f1a3e55d0c9d6205510b4e831e94c9cea", "old_mode": 33188, "old_path": "pc/peerconnectionfactory.cc", "new_id": "6da4669773dc597f77be92c1a5a07c626ae3066d", "new_mode": 33188, "new_path": "pc/peerconnectionfactory.cc" }, { "type": "modify", "old_id": "ebd301693467a80cb19c1ec0062cc12bba8037ee", "old_mode": 33188, "old_path": "pc/peerconnectionfactory.h", "new_id": "82440e7275d19e551b94f1a74ff26913c5d51210", "new_mode": 33188, "new_path": "pc/peerconnectionfactory.h" } ] }