)]}' { "commit": "7a09c455d655a68b4f7661e2ee03e9dadf5f705d", "tree": "b2c06d406f6cd4781fb6ffe954262e25f87951c8", "parents": [ "19cf6be7a10df36d40272b8cf9064c2a390d0f50" ], "author": { "name": "mbonadei", "email": "mbonadei@webrtc.org", "time": "Mon Sep 04 14:19:15 2017" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Mon Sep 04 14:19:15 2017" }, "message": "Revert of Decoupling rtc_base from Obj-C code (patchset #8 id:140001 of https://codereview.webrtc.org/3001623003/ )\n\nReason for revert:\nIt breaks a downstream project.\n\nOriginal issue\u0027s description:\n\u003e Decoupling rtc_base from Obj-C code\n\u003e\n\u003e The goal of this CL is to separate Obj-C/Obj-C++ code from targets which have\n\u003e also C++ code (see https://bugs.chromium.org/p/webrtc/issues/detail?id\u003d7743\n\u003e for more information).\n\u003e\n\u003e To achieve this we have created 2 targets (rtc_base_objc and rtc_base_generic)\n\u003e and rtc_base will act as a proxy between these targets (this way we can avoid a\n\u003e circular dependency between rtc_base_generic and rtc_base_objc).\n\u003e\n\u003e BUG\u003dwebrtc:7743\n\u003e\n\u003e Review-Url: https://codereview.webrtc.org/3001623003\n\u003e Cr-Commit-Position: refs/heads/master@{#19661}\n\u003e Committed: https://chromium.googlesource.com/external/webrtc/+/a0a5b98937de0f0bf90e17011d2cbc8c632cb409\n\nTBR\u003dkjellander@webrtc.org,kwiberg@webrtc.org\n# Skipping CQ checks because original CL landed less than 1 days ago.\nNOPRESUBMIT\u003dtrue\nNOTREECHECKS\u003dtrue\nNOTRY\u003dtrue\nBUG\u003dwebrtc:7743\n\nReview-Url: https://codereview.webrtc.org/3008103002\nCr-Original-Commit-Position: refs/heads/master@{#19664}\nCr-Mirrored-From: https://chromium.googlesource.com/external/webrtc\nCr-Mirrored-Commit: 791a8f611da8cc6b0668ccc03bf7525e6ba72a46\n", "tree_diff": [ { "type": "modify", "old_id": "3cb7766629652d0d48d02652f8088e520d780c00", "old_mode": 33188, "old_path": "rtc_base/BUILD.gn", "new_id": "1914b27439ce921317a7a958c0e46dc708c731d3", "new_mode": 33188, "new_path": "rtc_base/BUILD.gn" } ] }