tree cd88c8839f3878909c4dcac1aa3f2efac98169cb
parent 2964c89493a09e30b2fb0a54aaccfcb19815fdff
author andersc <andersc@webrtc.org> 1505294316 -0700
committer Commit Bot <commit-bot@chromium.org> 1505294316 +0000

Fix retain cycles in RTCUIApplicationStatusObserver.

These retain cycles are theoretical since the singleton is supposed to
live for the lifetime of the application.

These measures were removed earlier when the object was turned into
a singleton in a previous CL, see
https://chromium-review.googlesource.com/c/external/webrtc/+/527442/3..4/webrtc/sdk/objc/Framework/Classes/Common/RTCUIApplicationStatusObserver.m

The weak self handling and unused dealloc method is mostly noise and
can make a casual reader think that the object will have a limited
life cycle, i.e. the code may initially look like something it is not,
which could possibly be less readable. On the other hand, for people
looking out for potential retain cycles, the code may be distracting
since it looks like it may be leaking.

BUG=b/65558647

Review-Url: https://codereview.webrtc.org/3013023002
Cr-Original-Commit-Position: refs/heads/master@{#19811}
Cr-Mirrored-From: https://chromium.googlesource.com/external/webrtc
Cr-Mirrored-Commit: 4090f380e58beb4e192691ca50643eef3aadd25d