)]}' { "commit": "acbc4e85a16871c84c13e4abf75ae217ea84fdbc", "tree": "a9d803bf93c5efbf6bc39cc76dba75ec4fa306d1", "parents": [ "4fbd3df7147b21498c20afef7044e1456ec9f337" ], "author": { "name": "magjed", "email": "magjed@webrtc.org", "time": "Tue Sep 12 11:42:15 2017" }, "committer": { "name": "Commit Bot", "email": "commit-bot@chromium.org", "time": "Tue Sep 12 11:42:15 2017" }, "message": "Simplify passing video coded factories in media engine\n\nWe soon want to be able to pass in a new type of video codec factories,\nsee issue 7925 for more information. We currently plumb these video\ncodec factories in a clumsy way from the media engine to the video\nengine, which will require us to update a lot of places when we add\nnew video codec factory types. This CL cleans up the way we pass in\nvideo codec factories to make it easier to add the new factory types.\n\nIn particular, this CL:\n * Updates WebRtcVideoEngine to take the video codec factories as\n arguments in ctor instead of in SetExternalVideoCodec functions.\n * Remove the Init() function from the vidoe engines - this function is\n not used.\n * Update CompositeMediaEngine to take generic variadic arguments, so we\n can send different arguments for different engines, without having to\n update this class.\n * Simplify ownership of video codec factories in WebRtcVideoEngine.\n WebRtcVideoEngine outlives WebRtcVideoChannel,\n WebRtcVideoSendStream and WebRtcVideoReceiveStream, so it can\n keep ownership without having to share ownership with these classes.\n\nBUG\u003dwebrtc:7925\n\nReview-Url: https://codereview.webrtc.org/3008043002\nCr-Original-Commit-Position: refs/heads/master@{#19794}\nCr-Mirrored-From: https://chromium.googlesource.com/external/webrtc\nCr-Mirrored-Commit: 2475ae2e4cdbb7cbfa2a4801cbc36ff7eb73aacd\n", "tree_diff": [ { "type": "modify", "old_id": "0b080afde748bcf7bc0aced14033f2341c58fed8", "old_mode": 33188, "old_path": "media/base/fakemediaengine.h", "new_id": "921623cb03a61b241b7879b999c3cee324976ac0", "new_mode": 33188, "new_path": "media/base/fakemediaengine.h" }, { "type": "modify", "old_id": "8ce60753d0822214bceae38e7e7397100384c45a", "old_mode": 33188, "old_path": "media/base/mediaengine.h", "new_id": "52a55f93bb4c1c5d738d2da4f373bb0171d76cfd", "new_mode": 33188, "new_path": "media/base/mediaengine.h" }, { "type": "modify", "old_id": "77062ecf4910bd58834f9807eb5fc0808631201d", "old_mode": 33188, "old_path": "media/base/videoengine_unittest.h", "new_id": "64fda56849a4998d3fa0b5b39401d6aac3b1bc64", "new_mode": 33188, "new_path": "media/base/videoengine_unittest.h" }, { "type": "modify", "old_id": "2fe87f4badb9348a0e2d26345bc2d2b5635c1e71", "old_mode": 33188, "old_path": "media/engine/nullwebrtcvideoengine.h", "new_id": "9c687b9db744ac85ca4366a0e2f17862c4532e41", "new_mode": 33188, "new_path": "media/engine/nullwebrtcvideoengine.h" }, { "type": "modify", "old_id": "e1a2964722171c6db2e09fc61752efd88e367297", "old_mode": 33188, "old_path": "media/engine/nullwebrtcvideoengine_unittest.cc", "new_id": "5fa7b011f26361702c3713054358229d14c289d6", "new_mode": 33188, "new_path": "media/engine/nullwebrtcvideoengine_unittest.cc" }, { "type": "modify", "old_id": "774b6b7f905948697e4d8750896427d127ea5758", "old_mode": 33188, "old_path": "media/engine/webrtcmediaengine.cc", "new_id": "3a61ad73bb6c9057970052d6dfa6917b5bd0aa44", "new_mode": 33188, "new_path": "media/engine/webrtcmediaengine.cc" }, { "type": "modify", "old_id": "284eb9a643e61846ede8557a69fa8274cb166925", "old_mode": 33188, "old_path": "media/engine/webrtcvideoengine.cc", "new_id": "a21f63359dafef87d3e43d26e18a72ed614279ca", "new_mode": 33188, "new_path": "media/engine/webrtcvideoengine.cc" }, { "type": "modify", "old_id": "e61f42228dd68817fc2cf8467a2d9d79a092bdab", "old_mode": 33188, "old_path": "media/engine/webrtcvideoengine.h", "new_id": "8c8aefb140662ebf274a1c37860e3a408b2accde", "new_mode": 33188, "new_path": "media/engine/webrtcvideoengine.h" }, { "type": "modify", "old_id": "1306082abf8715b2733109ce4c3f2ad4c1f884cd", "old_mode": 33188, "old_path": "media/engine/webrtcvideoengine_unittest.cc", "new_id": "683ccd5747f3c34676596434c61c55be5eabbbf6", "new_mode": 33188, "new_path": "media/engine/webrtcvideoengine_unittest.cc" } ] }