commit 845bb7319679c15dcc94f1aaa5bc8c6ea245e9b0
author Steve Anton <steveanton@webrtc.org> Tue Dec 05 20:50:26 2017
committer Commit Bot <commit-bot@chromium.org> Wed Dec 06 18:12:06 2017
tree f1c98a98fd16dda69be41ffe1cbb134a3e597cdc
parent 91bd263006ba0bd3bc6a3a9826cbc98c0434d75b

Fix clang style errors in api/jsep.h

In this case, clang style forbids inline definitions for virtual
functions.

Bug: webrtc:163
Change-Id: Id924cadb0a1d32e12cdb691c57fbda5f5b022638
Reviewed-on: https://webrtc-review.googlesource.com/29441
Reviewed-by: Peter Thatcher <pthatcher@webrtc.org>
Reviewed-by: Zhi Huang <zhihuang@webrtc.org>
Commit-Queue: Steve Anton <steveanton@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#21126}

api/BUILD.gn

diff --git a/api/BUILD.gn b/api/BUILD.gn
index 8e8b44e..cc4de43 100644
--- a/api/BUILD.gn
+++ b/api/BUILD.gn
@@ -41,6 +41,7 @@
     "cryptoparams.h",
     "datachannelinterface.h",
     "dtmfsenderinterface.h",
+    "jsep.cc",
     "jsep.h",
     "jsepicecandidate.h",
     "jsepsessiondescription.h",

api/jsep.cc

diff --git a/api/jsep.cc b/api/jsep.cc
new file mode 100644
index 0000000..1f4afba
--- /dev/null
+++ b/api/jsep.cc
@@ -0,0 +1,24 @@
+/*
+ *  Copyright 2017 The WebRTC project authors. All Rights Reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#include "api/jsep.h"
+
+namespace webrtc {
+
+std::string IceCandidateInterface::server_url() const {
+  return "";
+}
+
+size_t SessionDescriptionInterface::RemoveCandidates(
+    const std::vector<cricket::Candidate>& candidates) {
+  return 0;
+}
+
+}  // namespace webrtc

api/jsep.h

diff --git a/api/jsep.h b/api/jsep.h
index c05f382..581f689 100644
--- a/api/jsep.h
+++ b/api/jsep.h
@@ -64,7 +64,7 @@
   // The URL of the ICE server which this candidate was gathered from.
   // TODO(zhihuang): Remove the default implementation once the subclasses
   // implement this method.
-  virtual std::string server_url() const { return ""; }
+  virtual std::string server_url() const;
   // Creates a SDP-ized form of this candidate.
   virtual bool ToString(std::string* out) const = 0;
 };
@@ -155,7 +155,7 @@
   //
   // Returns the number of candidates removed.
   virtual size_t RemoveCandidates(
-      const std::vector<cricket::Candidate>& candidates) { return 0; }
+      const std::vector<cricket::Candidate>& candidates);
 
   // Returns the number of m= sections in the session description.
   virtual size_t number_of_mediasections() const = 0;
@@ -200,7 +200,7 @@
   virtual void OnFailure(const std::string& error) = 0;
 
  protected:
-  ~CreateSessionDescriptionObserver() {}
+  ~CreateSessionDescriptionObserver() override = default;
 };
 
 // SetLocalDescription and SetRemoteDescription callback interface.
@@ -210,7 +210,7 @@
   virtual void OnFailure(const std::string& error) = 0;
 
  protected:
-  ~SetSessionDescriptionObserver() {}
+  ~SetSessionDescriptionObserver() override = default;
 };
 
 }  // namespace webrtc