Enable clang::find_bad_constructs for examples/androidnativeapi.
This CL removes //build/config/clang:find_bad_constructs from the
suppressed_configs list, which means that clang:find_bad_constructs
is now enabled on these translation units.
Bug: webrtc:9251, webrtc:163
Change-Id: I9f3c3ce78aa82cbf68f34999b0a7fa9507fe5154
Reviewed-on: https://webrtc-review.googlesource.com/89741
Reviewed-by: Sami Kalliomäki <sakal@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24059}diff --git a/examples/androidnativeapi/BUILD.gn b/examples/androidnativeapi/BUILD.gn
index 7be09b7..6a6209d 100644
--- a/examples/androidnativeapi/BUILD.gn
+++ b/examples/androidnativeapi/BUILD.gn
@@ -43,11 +43,6 @@
suppressed_configs += [ "//build/config/android:hide_all_but_jni_onload" ]
configs += [ "//build/config/android:hide_all_but_jni" ]
- if (is_clang) {
- # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
- suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
- }
-
deps = [
":generated_jni",
"//api:libjingle_peerconnection_api",
diff --git a/examples/androidnativeapi/jni/androidcallclient.cc b/examples/androidnativeapi/jni/androidcallclient.cc
index 3b19629..005f369 100644
--- a/examples/androidnativeapi/jni/androidcallclient.cc
+++ b/examples/androidnativeapi/jni/androidcallclient.cc
@@ -80,6 +80,8 @@
CreatePeerConnectionFactory();
}
+AndroidCallClient::~AndroidCallClient() = default;
+
void AndroidCallClient::Call(JNIEnv* env,
const webrtc::JavaRef<jobject>& cls,
const webrtc::JavaRef<jobject>& local_sink,
diff --git a/examples/androidnativeapi/jni/androidcallclient.h b/examples/androidnativeapi/jni/androidcallclient.h
index a0507e3..d456e9c 100644
--- a/examples/androidnativeapi/jni/androidcallclient.h
+++ b/examples/androidnativeapi/jni/androidcallclient.h
@@ -28,6 +28,7 @@
class AndroidCallClient {
public:
AndroidCallClient();
+ ~AndroidCallClient();
void Call(JNIEnv* env,
const webrtc::JavaRef<jobject>& cls,
