commit b471c905a4db9261bb0c768d8f2ce4c9f6b14da2
author Mirko Bonadei <mbonadei@webrtc.org> Wed Jul 18 12:11:27 2018
committer Commit Bot <commit-bot@chromium.org> Wed Jul 18 13:41:45 2018
tree e4ce9a168d8d6a6fc6cad870c020f7ff4875fe13
parent 06f66c72600e58438ba9caf9f523e00a519ef3c0

Enabling clang::find_bad_constructs for modules/pacing.

This CL removes //build/config/clang:find_bad_constructs from the
suppressed_configs list, which means that clang:find_bad_constructs
is now enabled on these translation units.

Bug: webrtc:9251, webrtc:163
Change-Id: I118156a4f9b00d8c4c4f199a5af50c494e31c34a
Reviewed-on: https://webrtc-review.googlesource.com/89343
Reviewed-by: Stefan Holmer <stefan@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#24020}

modules/pacing/BUILD.gn

diff --git a/modules/pacing/BUILD.gn b/modules/pacing/BUILD.gn
index 3083b3f..f035c7f 100644
--- a/modules/pacing/BUILD.gn
+++ b/modules/pacing/BUILD.gn
@@ -25,11 +25,6 @@
     "round_robin_packet_queue.h",
   ]
 
-  if (!build_with_chromium && is_clang) {
-    # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
-    suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
-  }
-
   deps = [
     ":interval_budget",
     "..:module_api",
@@ -60,11 +55,6 @@
     "interval_budget.h",
   ]
 
-  if (!build_with_chromium && is_clang) {
-    # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
-    suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
-  }
-
   deps = [
     #  "../../:typedefs",
     "../../:webrtc_common",
@@ -99,11 +89,6 @@
       "../rtp_rtcp:mock_rtp_rtcp",
       "../rtp_rtcp:rtp_rtcp_format",
     ]
-
-    if (!build_with_chromium && is_clang) {
-      # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
-      suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
-    }
   }
 
   rtc_source_set("mock_paced_sender") {

modules/pacing/bitrate_prober.cc

diff --git a/modules/pacing/bitrate_prober.cc b/modules/pacing/bitrate_prober.cc
index 2ad4524..cbf1d2b 100644
--- a/modules/pacing/bitrate_prober.cc
+++ b/modules/pacing/bitrate_prober.cc
@@ -47,6 +47,8 @@
 
 BitrateProber::BitrateProber() : BitrateProber(nullptr) {}
 
+BitrateProber::~BitrateProber() = default;
+
 BitrateProber::BitrateProber(RtcEventLog* event_log)
     : probing_state_(ProbingState::kDisabled),
       next_probe_time_ms_(-1),

modules/pacing/bitrate_prober.h

diff --git a/modules/pacing/bitrate_prober.h b/modules/pacing/bitrate_prober.h
index abef732..816eb0d 100644
--- a/modules/pacing/bitrate_prober.h
+++ b/modules/pacing/bitrate_prober.h
@@ -25,6 +25,7 @@
  public:
   BitrateProber();
   explicit BitrateProber(RtcEventLog* event_log);
+  ~BitrateProber();
 
   void SetEnabled(bool enable);
 

modules/pacing/round_robin_packet_queue.cc

diff --git a/modules/pacing/round_robin_packet_queue.cc b/modules/pacing/round_robin_packet_queue.cc
index 80f9ea7..2a16b4b 100644
--- a/modules/pacing/round_robin_packet_queue.cc
+++ b/modules/pacing/round_robin_packet_queue.cc
@@ -18,6 +18,7 @@
 namespace webrtc {
 
 RoundRobinPacketQueue::Stream::Stream() : bytes(0) {}
+RoundRobinPacketQueue::Stream::Stream(const Stream& stream) = default;
 RoundRobinPacketQueue::Stream::~Stream() {}
 
 RoundRobinPacketQueue::RoundRobinPacketQueue(const Clock* clock)

modules/pacing/round_robin_packet_queue.h

diff --git a/modules/pacing/round_robin_packet_queue.h b/modules/pacing/round_robin_packet_queue.h
index 8351b80..5dd68cd 100644
--- a/modules/pacing/round_robin_packet_queue.h
+++ b/modules/pacing/round_robin_packet_queue.h
@@ -59,6 +59,7 @@
 
   struct Stream {
     Stream();
+    Stream(const Stream&);
 
     virtual ~Stream();