Markus Handell | b4e96d4 | 2021-11-05 11:00:55 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (c) 2021 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
| 11 | #include "video/frame_cadence_adapter.h" |
| 12 | |
Per K | e975b44 | 2024-03-27 10:28:44 | [diff] [blame] | 13 | #include <cstdint> |
| 14 | #include <memory> |
Markus Handell | b4e96d4 | 2021-11-05 11:00:55 | [diff] [blame] | 15 | #include <utility> |
| 16 | #include <vector> |
| 17 | |
Danil Chapovalov | 95eeaa7 | 2022-07-06 08:14:29 | [diff] [blame] | 18 | #include "absl/functional/any_invocable.h" |
Zhaoliang Ma | f089d7e | 2024-01-08 02:44:15 | [diff] [blame] | 19 | #include "api/metronome/test/fake_metronome.h" |
Markus Handell | 90a7e2c | 2021-12-29 22:32:30 | [diff] [blame] | 20 | #include "api/task_queue/default_task_queue_factory.h" |
Markus Handell | 28c7180 | 2021-11-08 09:11:55 | [diff] [blame] | 21 | #include "api/task_queue/task_queue_base.h" |
Markus Handell | 8d87c46 | 2021-12-16 10:37:16 | [diff] [blame] | 22 | #include "api/task_queue/task_queue_factory.h" |
Danil Chapovalov | 95eeaa7 | 2022-07-06 08:14:29 | [diff] [blame] | 23 | #include "api/units/time_delta.h" |
Markus Handell | 8d87c46 | 2021-12-16 10:37:16 | [diff] [blame] | 24 | #include "api/units/timestamp.h" |
Markus Handell | b4e96d4 | 2021-11-05 11:00:55 | [diff] [blame] | 25 | #include "api/video/nv12_buffer.h" |
| 26 | #include "api/video/video_frame.h" |
Markus Handell | 90a7e2c | 2021-12-29 22:32:30 | [diff] [blame] | 27 | #include "rtc_base/event.h" |
Markus Handell | f2827c4 | 2023-09-02 07:41:10 | [diff] [blame] | 28 | #include "rtc_base/logging.h" |
Markus Handell | ee22543 | 2021-11-29 11:35:12 | [diff] [blame] | 29 | #include "rtc_base/rate_statistics.h" |
Markus Handell | e864dec | 2024-08-07 14:11:18 | [diff] [blame] | 30 | #include "rtc_base/task_queue_for_test.h" |
Markus Handell | 29dd8d8 | 2021-12-15 11:19:15 | [diff] [blame] | 31 | #include "rtc_base/time_utils.h" |
Markus Handell | b4e96d4 | 2021-11-05 11:00:55 | [diff] [blame] | 32 | #include "system_wrappers/include/metrics.h" |
Markus Handell | 29dd8d8 | 2021-12-15 11:19:15 | [diff] [blame] | 33 | #include "system_wrappers/include/ntp_time.h" |
Markus Handell | 90a7e2c | 2021-12-29 22:32:30 | [diff] [blame] | 34 | #include "system_wrappers/include/sleep.h" |
Markus Handell | b4e96d4 | 2021-11-05 11:00:55 | [diff] [blame] | 35 | #include "test/gmock.h" |
| 36 | #include "test/gtest.h" |
Jonas Oreland | 8ca0613 | 2022-03-14 11:52:48 | [diff] [blame] | 37 | #include "test/scoped_key_value_config.h" |
Markus Handell | 28c7180 | 2021-11-08 09:11:55 | [diff] [blame] | 38 | #include "test/time_controller/simulated_time_controller.h" |
Markus Handell | b4e96d4 | 2021-11-05 11:00:55 | [diff] [blame] | 39 | |
| 40 | namespace webrtc { |
| 41 | namespace { |
| 42 | |
Markus Handell | 9a478b5 | 2021-11-18 15:07:01 | [diff] [blame] | 43 | using ::testing::_; |
Markus Handell | b4e96d4 | 2021-11-05 11:00:55 | [diff] [blame] | 44 | using ::testing::ElementsAre; |
henrika | b7ec057 | 2024-01-09 09:48:52 | [diff] [blame] | 45 | using ::testing::InSequence; |
Markus Handell | 29dd8d8 | 2021-12-15 11:19:15 | [diff] [blame] | 46 | using ::testing::Invoke; |
Markus Handell | 8fa8619 | 2023-08-31 09:59:06 | [diff] [blame] | 47 | using ::testing::InvokeWithoutArgs; |
Markus Handell | b4e96d4 | 2021-11-05 11:00:55 | [diff] [blame] | 48 | using ::testing::Mock; |
henrika | b7ec057 | 2024-01-09 09:48:52 | [diff] [blame] | 49 | using ::testing::NiceMock; |
Markus Handell | b4e96d4 | 2021-11-05 11:00:55 | [diff] [blame] | 50 | using ::testing::Pair; |
Markus Handell | cb237f8 | 2021-12-29 20:31:57 | [diff] [blame] | 51 | using ::testing::Values; |
Markus Handell | b4e96d4 | 2021-11-05 11:00:55 | [diff] [blame] | 52 | |
| 53 | VideoFrame CreateFrame() { |
| 54 | return VideoFrame::Builder() |
| 55 | .set_video_frame_buffer( |
| 56 | rtc::make_ref_counted<NV12Buffer>(/*width=*/16, /*height=*/16)) |
| 57 | .build(); |
| 58 | } |
| 59 | |
Markus Handell | 29dd8d8 | 2021-12-15 11:19:15 | [diff] [blame] | 60 | VideoFrame CreateFrameWithTimestamps( |
| 61 | GlobalSimulatedTimeController* time_controller) { |
| 62 | return VideoFrame::Builder() |
| 63 | .set_video_frame_buffer( |
| 64 | rtc::make_ref_counted<NV12Buffer>(/*width=*/16, /*height=*/16)) |
| 65 | .set_ntp_time_ms(time_controller->GetClock()->CurrentNtpInMilliseconds()) |
| 66 | .set_timestamp_us(time_controller->GetClock()->CurrentTime().us()) |
| 67 | .build(); |
| 68 | } |
| 69 | |
Jonas Oreland | 8ca0613 | 2022-03-14 11:52:48 | [diff] [blame] | 70 | std::unique_ptr<FrameCadenceAdapterInterface> CreateAdapter( |
Jonas Oreland | e62c2f2 | 2022-03-29 09:04:48 | [diff] [blame] | 71 | const FieldTrialsView& field_trials, |
Jonas Oreland | 8ca0613 | 2022-03-14 11:52:48 | [diff] [blame] | 72 | Clock* clock) { |
Zhaoliang Ma | f089d7e | 2024-01-08 02:44:15 | [diff] [blame] | 73 | return FrameCadenceAdapterInterface::Create( |
| 74 | clock, TaskQueueBase::Current(), /*metronome=*/nullptr, |
| 75 | /*worker_queue=*/nullptr, field_trials); |
Markus Handell | 28c7180 | 2021-11-08 09:11:55 | [diff] [blame] | 76 | } |
| 77 | |
Markus Handell | b4e96d4 | 2021-11-05 11:00:55 | [diff] [blame] | 78 | class MockCallback : public FrameCadenceAdapterInterface::Callback { |
| 79 | public: |
Markus Handell | 84c016a | 2023-11-23 12:41:44 | [diff] [blame] | 80 | MOCK_METHOD(void, OnFrame, (Timestamp, bool, const VideoFrame&), (override)); |
Markus Handell | b4e96d4 | 2021-11-05 11:00:55 | [diff] [blame] | 81 | MOCK_METHOD(void, OnDiscardedFrame, (), (override)); |
Markus Handell | 818e7fb | 2021-12-30 12:01:33 | [diff] [blame] | 82 | MOCK_METHOD(void, RequestRefreshFrame, (), (override)); |
Markus Handell | b4e96d4 | 2021-11-05 11:00:55 | [diff] [blame] | 83 | }; |
| 84 | |
Markus Handell | 9a478b5 | 2021-11-18 15:07:01 | [diff] [blame] | 85 | TEST(FrameCadenceAdapterTest, CountsOutstandingFramesToProcess) { |
Jonas Oreland | 8ca0613 | 2022-03-14 11:52:48 | [diff] [blame] | 86 | test::ScopedKeyValueConfig no_field_trials; |
Markus Handell | 9a478b5 | 2021-11-18 15:07:01 | [diff] [blame] | 87 | GlobalSimulatedTimeController time_controller(Timestamp::Millis(1)); |
| 88 | MockCallback callback; |
Jonas Oreland | 8ca0613 | 2022-03-14 11:52:48 | [diff] [blame] | 89 | auto adapter = CreateAdapter(no_field_trials, time_controller.GetClock()); |
Markus Handell | 9a478b5 | 2021-11-18 15:07:01 | [diff] [blame] | 90 | adapter->Initialize(&callback); |
Markus Handell | 84c016a | 2023-11-23 12:41:44 | [diff] [blame] | 91 | EXPECT_CALL(callback, OnFrame(_, true, _)).Times(1); |
| 92 | EXPECT_CALL(callback, OnFrame(_, false, _)).Times(1); |
Markus Handell | 9a478b5 | 2021-11-18 15:07:01 | [diff] [blame] | 93 | auto frame = CreateFrame(); |
| 94 | adapter->OnFrame(frame); |
| 95 | adapter->OnFrame(frame); |
| 96 | time_controller.AdvanceTime(TimeDelta::Zero()); |
Markus Handell | 84c016a | 2023-11-23 12:41:44 | [diff] [blame] | 97 | EXPECT_CALL(callback, OnFrame(_, false, _)).Times(1); |
Markus Handell | 9a478b5 | 2021-11-18 15:07:01 | [diff] [blame] | 98 | adapter->OnFrame(frame); |
| 99 | time_controller.AdvanceTime(TimeDelta::Zero()); |
| 100 | } |
| 101 | |
Markus Handell | ee22543 | 2021-11-29 11:35:12 | [diff] [blame] | 102 | TEST(FrameCadenceAdapterTest, FrameRateFollowsRateStatisticsByDefault) { |
Jonas Oreland | 8ca0613 | 2022-03-14 11:52:48 | [diff] [blame] | 103 | test::ScopedKeyValueConfig no_field_trials; |
Philipp Hancke | a204ad2 | 2022-07-08 16:43:25 | [diff] [blame] | 104 | GlobalSimulatedTimeController time_controller(Timestamp::Zero()); |
Jonas Oreland | 8ca0613 | 2022-03-14 11:52:48 | [diff] [blame] | 105 | auto adapter = CreateAdapter(no_field_trials, time_controller.GetClock()); |
Per K | e975b44 | 2024-03-27 10:28:44 | [diff] [blame] | 106 | MockCallback callback; |
| 107 | adapter->Initialize(&callback); |
Markus Handell | ee22543 | 2021-11-29 11:35:12 | [diff] [blame] | 108 | |
| 109 | // Create an "oracle" rate statistics which should be followed on a sequence |
| 110 | // of frames. |
| 111 | RateStatistics rate( |
| 112 | FrameCadenceAdapterInterface::kFrameRateAveragingWindowSizeMs, 1000); |
| 113 | |
| 114 | for (int frame = 0; frame != 10; ++frame) { |
| 115 | time_controller.AdvanceTime(TimeDelta::Millis(10)); |
Per K | e975b44 | 2024-03-27 10:28:44 | [diff] [blame] | 116 | absl::optional<int64_t> expected_fps = |
| 117 | rate.Rate(time_controller.GetClock()->TimeInMilliseconds()); |
Markus Handell | ee22543 | 2021-11-29 11:35:12 | [diff] [blame] | 118 | rate.Update(1, time_controller.GetClock()->TimeInMilliseconds()); |
Per K | e975b44 | 2024-03-27 10:28:44 | [diff] [blame] | 119 | // FrameCadanceAdapter::OnFrame post the frame to another sequence. |
| 120 | adapter->OnFrame(CreateFrameWithTimestamps(&time_controller)); |
| 121 | time_controller.AdvanceTime(TimeDelta::Millis(0)); |
| 122 | EXPECT_EQ(expected_fps, adapter->GetInputFrameRateFps()) |
Markus Handell | ee22543 | 2021-11-29 11:35:12 | [diff] [blame] | 123 | << " failed for frame " << frame; |
| 124 | } |
| 125 | } |
| 126 | |
Markus Handell | ee22543 | 2021-11-29 11:35:12 | [diff] [blame] | 127 | TEST(FrameCadenceAdapterTest, FrameRateFollowsMaxFpsWhenZeroHertzActivated) { |
Philipp Hancke | a204ad2 | 2022-07-08 16:43:25 | [diff] [blame] | 128 | GlobalSimulatedTimeController time_controller(Timestamp::Zero()); |
Markus Handell | a57229b | 2024-04-16 08:40:45 | [diff] [blame] | 129 | test::ScopedKeyValueConfig no_field_trials; |
| 130 | auto adapter = CreateAdapter(no_field_trials, time_controller.GetClock()); |
Per K | e975b44 | 2024-03-27 10:28:44 | [diff] [blame] | 131 | MockCallback callback; |
| 132 | adapter->Initialize(&callback); |
Markus Handell | 8d87c46 | 2021-12-16 10:37:16 | [diff] [blame] | 133 | adapter->SetZeroHertzModeEnabled( |
| 134 | FrameCadenceAdapterInterface::ZeroHertzModeParams{}); |
Markus Handell | ee22543 | 2021-11-29 11:35:12 | [diff] [blame] | 135 | adapter->OnConstraintsChanged(VideoTrackSourceConstraints{0, 1}); |
| 136 | for (int frame = 0; frame != 10; ++frame) { |
| 137 | time_controller.AdvanceTime(TimeDelta::Millis(10)); |
Per K | e975b44 | 2024-03-27 10:28:44 | [diff] [blame] | 138 | // FrameCadanceAdapter::OnFrame post the frame to another sequence. |
| 139 | adapter->OnFrame(CreateFrameWithTimestamps(&time_controller)); |
| 140 | time_controller.AdvanceTime(TimeDelta::Millis(0)); |
Markus Handell | ee22543 | 2021-11-29 11:35:12 | [diff] [blame] | 141 | EXPECT_EQ(adapter->GetInputFrameRateFps(), 1u); |
| 142 | } |
| 143 | } |
| 144 | |
henrika | 644025c | 2023-11-07 17:22:02 | [diff] [blame] | 145 | TEST(FrameCadenceAdapterTest, ZeroHertzAdapterSupportsMaxFpsChange) { |
henrika | 644025c | 2023-11-07 17:22:02 | [diff] [blame] | 146 | GlobalSimulatedTimeController time_controller(Timestamp::Zero()); |
Markus Handell | a57229b | 2024-04-16 08:40:45 | [diff] [blame] | 147 | test::ScopedKeyValueConfig no_field_trials; |
| 148 | auto adapter = CreateAdapter(no_field_trials, time_controller.GetClock()); |
henrika | 644025c | 2023-11-07 17:22:02 | [diff] [blame] | 149 | MockCallback callback; |
| 150 | adapter->Initialize(&callback); |
| 151 | adapter->SetZeroHertzModeEnabled( |
| 152 | FrameCadenceAdapterInterface::ZeroHertzModeParams{}); |
| 153 | adapter->OnConstraintsChanged(VideoTrackSourceConstraints{0, 1}); |
| 154 | time_controller.AdvanceTime(TimeDelta::Zero()); |
| 155 | EXPECT_EQ(adapter->GetInputFrameRateFps(), 1u); |
| 156 | adapter->OnFrame(CreateFrame()); |
| 157 | time_controller.AdvanceTime(TimeDelta::Seconds(1)); |
| 158 | adapter->OnConstraintsChanged(VideoTrackSourceConstraints{0, 2}); |
| 159 | time_controller.AdvanceTime(TimeDelta::Zero()); |
| 160 | EXPECT_EQ(adapter->GetInputFrameRateFps(), 2u); |
| 161 | adapter->OnFrame(CreateFrame()); |
| 162 | // Ensure that the max_fps has been changed from 1 to 2 fps even if it was |
| 163 | // changed while zero hertz was already active. |
| 164 | EXPECT_CALL(callback, OnFrame); |
| 165 | time_controller.AdvanceTime(TimeDelta::Millis(500)); |
| 166 | } |
| 167 | |
Markus Handell | ee22543 | 2021-11-29 11:35:12 | [diff] [blame] | 168 | TEST(FrameCadenceAdapterTest, |
| 169 | FrameRateFollowsRateStatisticsAfterZeroHertzDeactivated) { |
Philipp Hancke | a204ad2 | 2022-07-08 16:43:25 | [diff] [blame] | 170 | GlobalSimulatedTimeController time_controller(Timestamp::Zero()); |
Markus Handell | a57229b | 2024-04-16 08:40:45 | [diff] [blame] | 171 | test::ScopedKeyValueConfig no_field_trials; |
| 172 | auto adapter = CreateAdapter(no_field_trials, time_controller.GetClock()); |
Per K | e975b44 | 2024-03-27 10:28:44 | [diff] [blame] | 173 | MockCallback callback; |
| 174 | adapter->Initialize(&callback); |
Markus Handell | 8d87c46 | 2021-12-16 10:37:16 | [diff] [blame] | 175 | adapter->SetZeroHertzModeEnabled( |
| 176 | FrameCadenceAdapterInterface::ZeroHertzModeParams{}); |
Markus Handell | ee22543 | 2021-11-29 11:35:12 | [diff] [blame] | 177 | adapter->OnConstraintsChanged(VideoTrackSourceConstraints{0, 1}); |
| 178 | RateStatistics rate( |
| 179 | FrameCadenceAdapterInterface::kFrameRateAveragingWindowSizeMs, 1000); |
| 180 | constexpr int MAX = 10; |
| 181 | for (int frame = 0; frame != MAX; ++frame) { |
| 182 | time_controller.AdvanceTime(TimeDelta::Millis(10)); |
| 183 | rate.Update(1, time_controller.GetClock()->TimeInMilliseconds()); |
Per K | e975b44 | 2024-03-27 10:28:44 | [diff] [blame] | 184 | adapter->OnFrame(CreateFrameWithTimestamps(&time_controller)); |
| 185 | time_controller.AdvanceTime(TimeDelta::Millis(0)); |
Markus Handell | ee22543 | 2021-11-29 11:35:12 | [diff] [blame] | 186 | } |
| 187 | // Turn off zero hertz on the next-last frame; after the last frame we |
| 188 | // should see a value that tracks the rate oracle. |
Markus Handell | 8d87c46 | 2021-12-16 10:37:16 | [diff] [blame] | 189 | adapter->SetZeroHertzModeEnabled(absl::nullopt); |
Markus Handell | ee22543 | 2021-11-29 11:35:12 | [diff] [blame] | 190 | // Last frame. |
| 191 | time_controller.AdvanceTime(TimeDelta::Millis(10)); |
Per K | e975b44 | 2024-03-27 10:28:44 | [diff] [blame] | 192 | adapter->OnFrame(CreateFrameWithTimestamps(&time_controller)); |
| 193 | time_controller.AdvanceTime(TimeDelta::Millis(0)); |
Markus Handell | ee22543 | 2021-11-29 11:35:12 | [diff] [blame] | 194 | |
| 195 | EXPECT_EQ(rate.Rate(time_controller.GetClock()->TimeInMilliseconds()), |
| 196 | adapter->GetInputFrameRateFps()); |
| 197 | } |
| 198 | |
Markus Handell | 29dd8d8 | 2021-12-15 11:19:15 | [diff] [blame] | 199 | TEST(FrameCadenceAdapterTest, ForwardsFramesDelayed) { |
Markus Handell | 29dd8d8 | 2021-12-15 11:19:15 | [diff] [blame] | 200 | MockCallback callback; |
Philipp Hancke | a204ad2 | 2022-07-08 16:43:25 | [diff] [blame] | 201 | GlobalSimulatedTimeController time_controller(Timestamp::Zero()); |
Markus Handell | a57229b | 2024-04-16 08:40:45 | [diff] [blame] | 202 | test::ScopedKeyValueConfig no_field_trials; |
| 203 | auto adapter = CreateAdapter(no_field_trials, time_controller.GetClock()); |
Markus Handell | 29dd8d8 | 2021-12-15 11:19:15 | [diff] [blame] | 204 | adapter->Initialize(&callback); |
Markus Handell | 8d87c46 | 2021-12-16 10:37:16 | [diff] [blame] | 205 | adapter->SetZeroHertzModeEnabled( |
| 206 | FrameCadenceAdapterInterface::ZeroHertzModeParams{}); |
Markus Handell | 29dd8d8 | 2021-12-15 11:19:15 | [diff] [blame] | 207 | adapter->OnConstraintsChanged(VideoTrackSourceConstraints{0, 1}); |
| 208 | constexpr int kNumFrames = 3; |
| 209 | NtpTime original_ntp_time = time_controller.GetClock()->CurrentNtpTime(); |
| 210 | auto frame = CreateFrameWithTimestamps(&time_controller); |
| 211 | int64_t original_timestamp_us = frame.timestamp_us(); |
| 212 | for (int index = 0; index != kNumFrames; ++index) { |
| 213 | EXPECT_CALL(callback, OnFrame).Times(0); |
| 214 | adapter->OnFrame(frame); |
| 215 | EXPECT_CALL(callback, OnFrame) |
Markus Handell | 84c016a | 2023-11-23 12:41:44 | [diff] [blame] | 216 | .WillOnce(Invoke([&](Timestamp post_time, bool, |
Markus Handell | 29dd8d8 | 2021-12-15 11:19:15 | [diff] [blame] | 217 | const VideoFrame& frame) { |
| 218 | EXPECT_EQ(post_time, time_controller.GetClock()->CurrentTime()); |
| 219 | EXPECT_EQ(frame.timestamp_us(), |
| 220 | original_timestamp_us + index * rtc::kNumMicrosecsPerSec); |
| 221 | EXPECT_EQ(frame.ntp_time_ms(), original_ntp_time.ToMs() + |
| 222 | index * rtc::kNumMillisecsPerSec); |
| 223 | })); |
| 224 | time_controller.AdvanceTime(TimeDelta::Seconds(1)); |
| 225 | frame = CreateFrameWithTimestamps(&time_controller); |
| 226 | } |
| 227 | } |
| 228 | |
Markus Handell | 8fa8619 | 2023-08-31 09:59:06 | [diff] [blame] | 229 | TEST(FrameCadenceAdapterTest, DelayedProcessingUnderSlightContention) { |
Markus Handell | 8fa8619 | 2023-08-31 09:59:06 | [diff] [blame] | 230 | GlobalSimulatedTimeController time_controller(Timestamp::Zero()); |
Markus Handell | a57229b | 2024-04-16 08:40:45 | [diff] [blame] | 231 | test::ScopedKeyValueConfig no_field_trials; |
| 232 | auto adapter = CreateAdapter(no_field_trials, time_controller.GetClock()); |
Markus Handell | 8fa8619 | 2023-08-31 09:59:06 | [diff] [blame] | 233 | MockCallback callback; |
| 234 | adapter->Initialize(&callback); |
| 235 | adapter->SetZeroHertzModeEnabled( |
| 236 | FrameCadenceAdapterInterface::ZeroHertzModeParams{}); |
| 237 | adapter->OnConstraintsChanged(VideoTrackSourceConstraints{0, 1}); |
| 238 | |
| 239 | // Expect frame delivery at 1 sec despite target sequence not running |
| 240 | // callbacks for the time skipped. |
| 241 | constexpr TimeDelta time_skipped = TimeDelta::Millis(999); |
| 242 | EXPECT_CALL(callback, OnFrame).WillOnce(InvokeWithoutArgs([&] { |
| 243 | EXPECT_EQ(time_controller.GetClock()->CurrentTime(), |
| 244 | Timestamp::Zero() + TimeDelta::Seconds(1)); |
| 245 | })); |
| 246 | adapter->OnFrame(CreateFrame()); |
| 247 | time_controller.SkipForwardBy(time_skipped); |
| 248 | time_controller.AdvanceTime(TimeDelta::Seconds(1) - time_skipped); |
| 249 | } |
| 250 | |
| 251 | TEST(FrameCadenceAdapterTest, DelayedProcessingUnderHeavyContention) { |
Markus Handell | 8fa8619 | 2023-08-31 09:59:06 | [diff] [blame] | 252 | GlobalSimulatedTimeController time_controller(Timestamp::Zero()); |
Markus Handell | a57229b | 2024-04-16 08:40:45 | [diff] [blame] | 253 | test::ScopedKeyValueConfig no_field_trials; |
| 254 | auto adapter = CreateAdapter(no_field_trials, time_controller.GetClock()); |
Markus Handell | 8fa8619 | 2023-08-31 09:59:06 | [diff] [blame] | 255 | MockCallback callback; |
| 256 | adapter->Initialize(&callback); |
| 257 | adapter->SetZeroHertzModeEnabled( |
| 258 | FrameCadenceAdapterInterface::ZeroHertzModeParams{}); |
| 259 | adapter->OnConstraintsChanged(VideoTrackSourceConstraints{0, 1}); |
| 260 | |
| 261 | // Expect frame delivery at origin + `time_skipped` when the target sequence |
| 262 | // is not running callbacks for the initial 1+ sec. |
| 263 | constexpr TimeDelta time_skipped = |
| 264 | TimeDelta::Seconds(1) + TimeDelta::Micros(1); |
| 265 | EXPECT_CALL(callback, OnFrame).WillOnce(InvokeWithoutArgs([&] { |
| 266 | EXPECT_EQ(time_controller.GetClock()->CurrentTime(), |
| 267 | Timestamp::Zero() + time_skipped); |
| 268 | })); |
| 269 | adapter->OnFrame(CreateFrame()); |
| 270 | time_controller.SkipForwardBy(time_skipped); |
henrika | b7ec057 | 2024-01-09 09:48:52 | [diff] [blame] | 271 | time_controller.AdvanceTime(TimeDelta::Zero()); |
Markus Handell | 8fa8619 | 2023-08-31 09:59:06 | [diff] [blame] | 272 | } |
| 273 | |
Markus Handell | 29dd8d8 | 2021-12-15 11:19:15 | [diff] [blame] | 274 | TEST(FrameCadenceAdapterTest, RepeatsFramesDelayed) { |
| 275 | // Logic in the frame cadence adapter avoids modifying frame NTP and render |
| 276 | // timestamps if these timestamps looks unset, which is the case when the |
| 277 | // clock is initialized running from 0. For this reason we choose the |
| 278 | // `time_controller` initialization constant to something arbitrary which is |
| 279 | // not 0. |
Markus Handell | 29dd8d8 | 2021-12-15 11:19:15 | [diff] [blame] | 280 | MockCallback callback; |
| 281 | GlobalSimulatedTimeController time_controller(Timestamp::Millis(47892223)); |
Markus Handell | a57229b | 2024-04-16 08:40:45 | [diff] [blame] | 282 | test::ScopedKeyValueConfig no_field_trials; |
| 283 | auto adapter = CreateAdapter(no_field_trials, time_controller.GetClock()); |
Markus Handell | 29dd8d8 | 2021-12-15 11:19:15 | [diff] [blame] | 284 | adapter->Initialize(&callback); |
Markus Handell | 8d87c46 | 2021-12-16 10:37:16 | [diff] [blame] | 285 | adapter->SetZeroHertzModeEnabled( |
| 286 | FrameCadenceAdapterInterface::ZeroHertzModeParams{}); |
Markus Handell | 29dd8d8 | 2021-12-15 11:19:15 | [diff] [blame] | 287 | adapter->OnConstraintsChanged(VideoTrackSourceConstraints{0, 1}); |
| 288 | NtpTime original_ntp_time = time_controller.GetClock()->CurrentNtpTime(); |
| 289 | |
| 290 | // Send one frame, expect 2 subsequent repeats. |
| 291 | auto frame = CreateFrameWithTimestamps(&time_controller); |
| 292 | int64_t original_timestamp_us = frame.timestamp_us(); |
| 293 | adapter->OnFrame(frame); |
| 294 | |
| 295 | EXPECT_CALL(callback, OnFrame) |
Markus Handell | 84c016a | 2023-11-23 12:41:44 | [diff] [blame] | 296 | .WillOnce(Invoke([&](Timestamp post_time, bool, const VideoFrame& frame) { |
Markus Handell | 29dd8d8 | 2021-12-15 11:19:15 | [diff] [blame] | 297 | EXPECT_EQ(post_time, time_controller.GetClock()->CurrentTime()); |
| 298 | EXPECT_EQ(frame.timestamp_us(), original_timestamp_us); |
| 299 | EXPECT_EQ(frame.ntp_time_ms(), original_ntp_time.ToMs()); |
| 300 | })); |
| 301 | time_controller.AdvanceTime(TimeDelta::Seconds(1)); |
| 302 | Mock::VerifyAndClearExpectations(&callback); |
| 303 | |
| 304 | EXPECT_CALL(callback, OnFrame) |
Markus Handell | 84c016a | 2023-11-23 12:41:44 | [diff] [blame] | 305 | .WillOnce(Invoke([&](Timestamp post_time, bool, const VideoFrame& frame) { |
Markus Handell | 29dd8d8 | 2021-12-15 11:19:15 | [diff] [blame] | 306 | EXPECT_EQ(post_time, time_controller.GetClock()->CurrentTime()); |
| 307 | EXPECT_EQ(frame.timestamp_us(), |
| 308 | original_timestamp_us + rtc::kNumMicrosecsPerSec); |
| 309 | EXPECT_EQ(frame.ntp_time_ms(), |
| 310 | original_ntp_time.ToMs() + rtc::kNumMillisecsPerSec); |
| 311 | })); |
| 312 | time_controller.AdvanceTime(TimeDelta::Seconds(1)); |
| 313 | Mock::VerifyAndClearExpectations(&callback); |
| 314 | |
| 315 | EXPECT_CALL(callback, OnFrame) |
Markus Handell | 84c016a | 2023-11-23 12:41:44 | [diff] [blame] | 316 | .WillOnce(Invoke([&](Timestamp post_time, bool, const VideoFrame& frame) { |
Markus Handell | 29dd8d8 | 2021-12-15 11:19:15 | [diff] [blame] | 317 | EXPECT_EQ(post_time, time_controller.GetClock()->CurrentTime()); |
| 318 | EXPECT_EQ(frame.timestamp_us(), |
| 319 | original_timestamp_us + 2 * rtc::kNumMicrosecsPerSec); |
| 320 | EXPECT_EQ(frame.ntp_time_ms(), |
| 321 | original_ntp_time.ToMs() + 2 * rtc::kNumMillisecsPerSec); |
| 322 | })); |
| 323 | time_controller.AdvanceTime(TimeDelta::Seconds(1)); |
| 324 | } |
| 325 | |
| 326 | TEST(FrameCadenceAdapterTest, |
| 327 | RepeatsFramesWithoutTimestampsWithUnsetTimestamps) { |
| 328 | // Logic in the frame cadence adapter avoids modifying frame NTP and render |
| 329 | // timestamps if these timestamps looks unset, which is the case when the |
| 330 | // clock is initialized running from 0. In this test we deliberately don't set |
| 331 | // it to zero, but select unset timestamps in the frames (via CreateFrame()) |
| 332 | // and verify that the timestamp modifying logic doesn't depend on the current |
| 333 | // time. |
Markus Handell | 29dd8d8 | 2021-12-15 11:19:15 | [diff] [blame] | 334 | MockCallback callback; |
| 335 | GlobalSimulatedTimeController time_controller(Timestamp::Millis(4711)); |
Markus Handell | a57229b | 2024-04-16 08:40:45 | [diff] [blame] | 336 | test::ScopedKeyValueConfig no_field_trials; |
| 337 | auto adapter = CreateAdapter(no_field_trials, time_controller.GetClock()); |
Markus Handell | 29dd8d8 | 2021-12-15 11:19:15 | [diff] [blame] | 338 | adapter->Initialize(&callback); |
Markus Handell | 8d87c46 | 2021-12-16 10:37:16 | [diff] [blame] | 339 | adapter->SetZeroHertzModeEnabled( |
| 340 | FrameCadenceAdapterInterface::ZeroHertzModeParams{}); |
Markus Handell | 29dd8d8 | 2021-12-15 11:19:15 | [diff] [blame] | 341 | adapter->OnConstraintsChanged(VideoTrackSourceConstraints{0, 1}); |
| 342 | |
| 343 | // Send one frame, expect a repeat. |
| 344 | adapter->OnFrame(CreateFrame()); |
| 345 | EXPECT_CALL(callback, OnFrame) |
Markus Handell | 84c016a | 2023-11-23 12:41:44 | [diff] [blame] | 346 | .WillOnce(Invoke([&](Timestamp post_time, bool, const VideoFrame& frame) { |
Markus Handell | 29dd8d8 | 2021-12-15 11:19:15 | [diff] [blame] | 347 | EXPECT_EQ(post_time, time_controller.GetClock()->CurrentTime()); |
| 348 | EXPECT_EQ(frame.timestamp_us(), 0); |
| 349 | EXPECT_EQ(frame.ntp_time_ms(), 0); |
| 350 | })); |
| 351 | time_controller.AdvanceTime(TimeDelta::Seconds(1)); |
| 352 | Mock::VerifyAndClearExpectations(&callback); |
| 353 | EXPECT_CALL(callback, OnFrame) |
Markus Handell | 84c016a | 2023-11-23 12:41:44 | [diff] [blame] | 354 | .WillOnce(Invoke([&](Timestamp post_time, bool, const VideoFrame& frame) { |
Markus Handell | 29dd8d8 | 2021-12-15 11:19:15 | [diff] [blame] | 355 | EXPECT_EQ(post_time, time_controller.GetClock()->CurrentTime()); |
| 356 | EXPECT_EQ(frame.timestamp_us(), 0); |
| 357 | EXPECT_EQ(frame.ntp_time_ms(), 0); |
| 358 | })); |
| 359 | time_controller.AdvanceTime(TimeDelta::Seconds(1)); |
| 360 | } |
| 361 | |
| 362 | TEST(FrameCadenceAdapterTest, StopsRepeatingFramesDelayed) { |
| 363 | // At 1s, the initially scheduled frame appears. |
| 364 | // At 2s, the repeated initial frame appears. |
| 365 | // At 2.5s, we schedule another new frame. |
| 366 | // At 3.5s, we receive this frame. |
Markus Handell | 29dd8d8 | 2021-12-15 11:19:15 | [diff] [blame] | 367 | MockCallback callback; |
Philipp Hancke | a204ad2 | 2022-07-08 16:43:25 | [diff] [blame] | 368 | GlobalSimulatedTimeController time_controller(Timestamp::Zero()); |
Markus Handell | a57229b | 2024-04-16 08:40:45 | [diff] [blame] | 369 | test::ScopedKeyValueConfig no_field_trials; |
| 370 | auto adapter = CreateAdapter(no_field_trials, time_controller.GetClock()); |
Markus Handell | 29dd8d8 | 2021-12-15 11:19:15 | [diff] [blame] | 371 | adapter->Initialize(&callback); |
Markus Handell | 8d87c46 | 2021-12-16 10:37:16 | [diff] [blame] | 372 | adapter->SetZeroHertzModeEnabled( |
| 373 | FrameCadenceAdapterInterface::ZeroHertzModeParams{}); |
Markus Handell | 29dd8d8 | 2021-12-15 11:19:15 | [diff] [blame] | 374 | adapter->OnConstraintsChanged(VideoTrackSourceConstraints{0, 1}); |
| 375 | NtpTime original_ntp_time = time_controller.GetClock()->CurrentNtpTime(); |
| 376 | |
| 377 | // Send one frame, expect 1 subsequent repeat. |
| 378 | adapter->OnFrame(CreateFrameWithTimestamps(&time_controller)); |
| 379 | EXPECT_CALL(callback, OnFrame).Times(2); |
| 380 | time_controller.AdvanceTime(TimeDelta::Seconds(2.5)); |
| 381 | Mock::VerifyAndClearExpectations(&callback); |
| 382 | |
| 383 | // Send the new frame at 2.5s, which should appear after 3.5s. |
| 384 | adapter->OnFrame(CreateFrameWithTimestamps(&time_controller)); |
| 385 | EXPECT_CALL(callback, OnFrame) |
Markus Handell | 84c016a | 2023-11-23 12:41:44 | [diff] [blame] | 386 | .WillOnce(Invoke([&](Timestamp, bool, const VideoFrame& frame) { |
Markus Handell | 29dd8d8 | 2021-12-15 11:19:15 | [diff] [blame] | 387 | EXPECT_EQ(frame.timestamp_us(), 5 * rtc::kNumMicrosecsPerSec / 2); |
| 388 | EXPECT_EQ(frame.ntp_time_ms(), |
| 389 | original_ntp_time.ToMs() + 5u * rtc::kNumMillisecsPerSec / 2); |
| 390 | })); |
| 391 | time_controller.AdvanceTime(TimeDelta::Seconds(1)); |
| 392 | } |
| 393 | |
Markus Handell | 2e0f4f0 | 2021-12-21 18:14:58 | [diff] [blame] | 394 | TEST(FrameCadenceAdapterTest, RequestsRefreshFrameOnKeyFrameRequestWhenNew) { |
Markus Handell | 2e0f4f0 | 2021-12-21 18:14:58 | [diff] [blame] | 395 | MockCallback callback; |
Philipp Hancke | a204ad2 | 2022-07-08 16:43:25 | [diff] [blame] | 396 | GlobalSimulatedTimeController time_controller(Timestamp::Zero()); |
Markus Handell | a57229b | 2024-04-16 08:40:45 | [diff] [blame] | 397 | test::ScopedKeyValueConfig no_field_trials; |
| 398 | auto adapter = CreateAdapter(no_field_trials, time_controller.GetClock()); |
Markus Handell | 2e0f4f0 | 2021-12-21 18:14:58 | [diff] [blame] | 399 | adapter->Initialize(&callback); |
| 400 | adapter->SetZeroHertzModeEnabled( |
| 401 | FrameCadenceAdapterInterface::ZeroHertzModeParams{}); |
Markus Handell | f5a5079 | 2022-06-16 12:25:15 | [diff] [blame] | 402 | constexpr int kMaxFps = 10; |
| 403 | adapter->OnConstraintsChanged(VideoTrackSourceConstraints{0, kMaxFps}); |
Markus Handell | 818e7fb | 2021-12-30 12:01:33 | [diff] [blame] | 404 | EXPECT_CALL(callback, RequestRefreshFrame); |
Markus Handell | f5a5079 | 2022-06-16 12:25:15 | [diff] [blame] | 405 | time_controller.AdvanceTime( |
| 406 | TimeDelta::Seconds(1) * |
| 407 | FrameCadenceAdapterInterface::kOnDiscardedFrameRefreshFramePeriod / |
| 408 | kMaxFps); |
Markus Handell | 818e7fb | 2021-12-30 12:01:33 | [diff] [blame] | 409 | adapter->ProcessKeyFrameRequest(); |
Markus Handell | 2e0f4f0 | 2021-12-21 18:14:58 | [diff] [blame] | 410 | } |
| 411 | |
| 412 | TEST(FrameCadenceAdapterTest, IgnoresKeyFrameRequestShortlyAfterFrame) { |
Markus Handell | 2e0f4f0 | 2021-12-21 18:14:58 | [diff] [blame] | 413 | MockCallback callback; |
Philipp Hancke | a204ad2 | 2022-07-08 16:43:25 | [diff] [blame] | 414 | GlobalSimulatedTimeController time_controller(Timestamp::Zero()); |
Markus Handell | a57229b | 2024-04-16 08:40:45 | [diff] [blame] | 415 | test::ScopedKeyValueConfig no_field_trials; |
| 416 | auto adapter = CreateAdapter(no_field_trials, time_controller.GetClock()); |
Markus Handell | 2e0f4f0 | 2021-12-21 18:14:58 | [diff] [blame] | 417 | adapter->Initialize(&callback); |
| 418 | adapter->SetZeroHertzModeEnabled( |
| 419 | FrameCadenceAdapterInterface::ZeroHertzModeParams{}); |
| 420 | adapter->OnConstraintsChanged(VideoTrackSourceConstraints{0, 10}); |
| 421 | adapter->OnFrame(CreateFrame()); |
| 422 | time_controller.AdvanceTime(TimeDelta::Zero()); |
Markus Handell | 818e7fb | 2021-12-30 12:01:33 | [diff] [blame] | 423 | EXPECT_CALL(callback, RequestRefreshFrame).Times(0); |
| 424 | adapter->ProcessKeyFrameRequest(); |
Markus Handell | 2e0f4f0 | 2021-12-21 18:14:58 | [diff] [blame] | 425 | } |
| 426 | |
Markus Handell | f7f0b21 | 2022-05-24 16:39:39 | [diff] [blame] | 427 | TEST(FrameCadenceAdapterTest, RequestsRefreshFramesUntilArrival) { |
Markus Handell | f7f0b21 | 2022-05-24 16:39:39 | [diff] [blame] | 428 | MockCallback callback; |
Philipp Hancke | a204ad2 | 2022-07-08 16:43:25 | [diff] [blame] | 429 | GlobalSimulatedTimeController time_controller(Timestamp::Zero()); |
Markus Handell | a57229b | 2024-04-16 08:40:45 | [diff] [blame] | 430 | test::ScopedKeyValueConfig no_field_trials; |
| 431 | auto adapter = CreateAdapter(no_field_trials, time_controller.GetClock()); |
Markus Handell | f7f0b21 | 2022-05-24 16:39:39 | [diff] [blame] | 432 | adapter->Initialize(&callback); |
| 433 | adapter->SetZeroHertzModeEnabled( |
| 434 | FrameCadenceAdapterInterface::ZeroHertzModeParams{}); |
| 435 | constexpr int kMaxFps = 10; |
| 436 | adapter->OnConstraintsChanged(VideoTrackSourceConstraints{0, kMaxFps}); |
| 437 | |
Markus Handell | f5a5079 | 2022-06-16 12:25:15 | [diff] [blame] | 438 | // We should see max_fps + 1 - |
| 439 | // FrameCadenceAdapterInterface::kOnDiscardedFrameRefreshFramePeriod refresh |
| 440 | // frame requests during the one second we wait until we send a single frame, |
| 441 | // after which refresh frame requests should cease (we should see no such |
| 442 | // requests during a second). |
| 443 | EXPECT_CALL(callback, RequestRefreshFrame) |
| 444 | .Times(kMaxFps + 1 - |
| 445 | FrameCadenceAdapterInterface::kOnDiscardedFrameRefreshFramePeriod); |
Markus Handell | f7f0b21 | 2022-05-24 16:39:39 | [diff] [blame] | 446 | time_controller.AdvanceTime(TimeDelta::Seconds(1)); |
| 447 | Mock::VerifyAndClearExpectations(&callback); |
| 448 | adapter->OnFrame(CreateFrame()); |
| 449 | EXPECT_CALL(callback, RequestRefreshFrame).Times(0); |
| 450 | time_controller.AdvanceTime(TimeDelta::Seconds(1)); |
| 451 | } |
| 452 | |
Markus Handell | f5a5079 | 2022-06-16 12:25:15 | [diff] [blame] | 453 | TEST(FrameCadenceAdapterTest, RequestsRefreshAfterFrameDrop) { |
Markus Handell | f5a5079 | 2022-06-16 12:25:15 | [diff] [blame] | 454 | MockCallback callback; |
Philipp Hancke | a204ad2 | 2022-07-08 16:43:25 | [diff] [blame] | 455 | GlobalSimulatedTimeController time_controller(Timestamp::Zero()); |
Markus Handell | a57229b | 2024-04-16 08:40:45 | [diff] [blame] | 456 | test::ScopedKeyValueConfig no_field_trials; |
| 457 | auto adapter = CreateAdapter(no_field_trials, time_controller.GetClock()); |
Markus Handell | f5a5079 | 2022-06-16 12:25:15 | [diff] [blame] | 458 | adapter->Initialize(&callback); |
| 459 | adapter->SetZeroHertzModeEnabled( |
| 460 | FrameCadenceAdapterInterface::ZeroHertzModeParams{}); |
| 461 | constexpr int kMaxFps = 10; |
| 462 | adapter->OnConstraintsChanged(VideoTrackSourceConstraints{0, kMaxFps}); |
| 463 | |
| 464 | EXPECT_CALL(callback, RequestRefreshFrame).Times(0); |
| 465 | |
| 466 | // Send a frame through to cancel the initial delayed timer waiting for first |
| 467 | // frame entry. |
| 468 | adapter->OnFrame(CreateFrame()); |
| 469 | time_controller.AdvanceTime(TimeDelta::Seconds(1)); |
| 470 | Mock::VerifyAndClearExpectations(&callback); |
| 471 | |
| 472 | // Send a dropped frame indication without any following frames received. |
| 473 | // After FrameCadenceAdapterInterface::kOnDiscardedFrameRefreshFramePeriod |
| 474 | // frame periods, we should receive a first refresh request. |
| 475 | adapter->OnDiscardedFrame(); |
| 476 | EXPECT_CALL(callback, RequestRefreshFrame); |
| 477 | time_controller.AdvanceTime( |
| 478 | TimeDelta::Seconds(1) * |
| 479 | FrameCadenceAdapterInterface::kOnDiscardedFrameRefreshFramePeriod / |
| 480 | kMaxFps); |
| 481 | Mock::VerifyAndClearExpectations(&callback); |
| 482 | |
| 483 | // We will now receive a refresh frame request for every frame period. |
| 484 | EXPECT_CALL(callback, RequestRefreshFrame).Times(kMaxFps); |
| 485 | time_controller.AdvanceTime(TimeDelta::Seconds(1)); |
| 486 | Mock::VerifyAndClearExpectations(&callback); |
| 487 | |
| 488 | // After a frame is passed the requests will cease. |
| 489 | EXPECT_CALL(callback, RequestRefreshFrame).Times(0); |
| 490 | adapter->OnFrame(CreateFrame()); |
| 491 | time_controller.AdvanceTime(TimeDelta::Seconds(1)); |
| 492 | } |
| 493 | |
| 494 | TEST(FrameCadenceAdapterTest, OmitsRefreshAfterFrameDropWithTimelyFrameEntry) { |
Markus Handell | f5a5079 | 2022-06-16 12:25:15 | [diff] [blame] | 495 | MockCallback callback; |
Philipp Hancke | a204ad2 | 2022-07-08 16:43:25 | [diff] [blame] | 496 | GlobalSimulatedTimeController time_controller(Timestamp::Zero()); |
Markus Handell | a57229b | 2024-04-16 08:40:45 | [diff] [blame] | 497 | test::ScopedKeyValueConfig no_field_trials; |
| 498 | auto adapter = CreateAdapter(no_field_trials, time_controller.GetClock()); |
Markus Handell | f5a5079 | 2022-06-16 12:25:15 | [diff] [blame] | 499 | adapter->Initialize(&callback); |
| 500 | adapter->SetZeroHertzModeEnabled( |
| 501 | FrameCadenceAdapterInterface::ZeroHertzModeParams{}); |
| 502 | constexpr int kMaxFps = 10; |
| 503 | adapter->OnConstraintsChanged(VideoTrackSourceConstraints{0, kMaxFps}); |
| 504 | |
| 505 | // Send a frame through to cancel the initial delayed timer waiting for first |
| 506 | // frame entry. |
| 507 | EXPECT_CALL(callback, RequestRefreshFrame).Times(0); |
| 508 | adapter->OnFrame(CreateFrame()); |
| 509 | time_controller.AdvanceTime(TimeDelta::Seconds(1)); |
| 510 | Mock::VerifyAndClearExpectations(&callback); |
| 511 | |
| 512 | // Send a frame drop indication. No refresh frames should be requested |
| 513 | // until FrameCadenceAdapterInterface::kOnDiscardedFrameRefreshFramePeriod |
| 514 | // intervals pass. Stop short of this. |
| 515 | EXPECT_CALL(callback, RequestRefreshFrame).Times(0); |
| 516 | adapter->OnDiscardedFrame(); |
| 517 | time_controller.AdvanceTime( |
| 518 | TimeDelta::Seconds(1) * |
| 519 | FrameCadenceAdapterInterface::kOnDiscardedFrameRefreshFramePeriod / |
| 520 | kMaxFps - |
| 521 | TimeDelta::Micros(1)); |
| 522 | Mock::VerifyAndClearExpectations(&callback); |
| 523 | |
| 524 | // Send a frame. The timer to request the refresh frame should be cancelled by |
| 525 | // the reception, so no refreshes should be requested. |
| 526 | EXPECT_CALL(callback, RequestRefreshFrame).Times(0); |
| 527 | adapter->OnFrame(CreateFrame()); |
| 528 | time_controller.AdvanceTime(TimeDelta::Seconds(1)); |
| 529 | Mock::VerifyAndClearExpectations(&callback); |
| 530 | } |
| 531 | |
Markus Handell | 5a77e51 | 2022-09-01 12:51:50 | [diff] [blame] | 532 | TEST(FrameCadenceAdapterTest, AcceptsUnconfiguredLayerFeedback) { |
| 533 | // This is a regression test for bugs.webrtc.org/14417. |
Markus Handell | 5a77e51 | 2022-09-01 12:51:50 | [diff] [blame] | 534 | MockCallback callback; |
| 535 | GlobalSimulatedTimeController time_controller(Timestamp::Zero()); |
Markus Handell | a57229b | 2024-04-16 08:40:45 | [diff] [blame] | 536 | test::ScopedKeyValueConfig no_field_trials; |
| 537 | auto adapter = CreateAdapter(no_field_trials, time_controller.GetClock()); |
Markus Handell | 5a77e51 | 2022-09-01 12:51:50 | [diff] [blame] | 538 | adapter->Initialize(&callback); |
| 539 | adapter->SetZeroHertzModeEnabled( |
| 540 | FrameCadenceAdapterInterface::ZeroHertzModeParams{.num_simulcast_layers = |
| 541 | 1}); |
| 542 | constexpr int kMaxFps = 10; |
| 543 | adapter->OnConstraintsChanged(VideoTrackSourceConstraints{0, kMaxFps}); |
| 544 | time_controller.AdvanceTime(TimeDelta::Zero()); |
| 545 | |
| 546 | adapter->UpdateLayerQualityConvergence(2, false); |
| 547 | adapter->UpdateLayerStatus(2, false); |
| 548 | } |
| 549 | |
Markus Handell | fb98b01 | 2023-09-13 22:31:11 | [diff] [blame] | 550 | TEST(FrameCadenceAdapterTest, IgnoresDropInducedCallbacksPostDestruction) { |
Markus Handell | fb98b01 | 2023-09-13 22:31:11 | [diff] [blame] | 551 | auto callback = std::make_unique<MockCallback>(); |
| 552 | GlobalSimulatedTimeController time_controller(Timestamp::Zero()); |
| 553 | auto queue = time_controller.GetTaskQueueFactory()->CreateTaskQueue( |
| 554 | "queue", TaskQueueFactory::Priority::NORMAL); |
Markus Handell | a57229b | 2024-04-16 08:40:45 | [diff] [blame] | 555 | test::ScopedKeyValueConfig no_field_trials; |
Markus Handell | fb98b01 | 2023-09-13 22:31:11 | [diff] [blame] | 556 | auto adapter = FrameCadenceAdapterInterface::Create( |
Zhaoliang Ma | f089d7e | 2024-01-08 02:44:15 | [diff] [blame] | 557 | time_controller.GetClock(), queue.get(), /*metronome=*/nullptr, |
Markus Handell | a57229b | 2024-04-16 08:40:45 | [diff] [blame] | 558 | /*worker_queue=*/nullptr, no_field_trials); |
Markus Handell | fb98b01 | 2023-09-13 22:31:11 | [diff] [blame] | 559 | queue->PostTask([&adapter, &callback] { |
| 560 | adapter->Initialize(callback.get()); |
| 561 | adapter->SetZeroHertzModeEnabled( |
| 562 | FrameCadenceAdapterInterface::ZeroHertzModeParams{}); |
| 563 | }); |
| 564 | time_controller.AdvanceTime(TimeDelta::Zero()); |
| 565 | constexpr int kMaxFps = 10; |
| 566 | adapter->OnConstraintsChanged(VideoTrackSourceConstraints{0, kMaxFps}); |
| 567 | adapter->OnDiscardedFrame(); |
| 568 | time_controller.AdvanceTime(TimeDelta::Zero()); |
| 569 | callback = nullptr; |
| 570 | queue->PostTask([adapter = std::move(adapter)]() mutable {}); |
| 571 | time_controller.AdvanceTime(3 * TimeDelta::Seconds(1) / kMaxFps); |
| 572 | } |
| 573 | |
Zhaoliang Ma | f089d7e | 2024-01-08 02:44:15 | [diff] [blame] | 574 | TEST(FrameCadenceAdapterTest, EncodeFramesAreAlignedWithMetronomeTick) { |
Zhaoliang Ma | f089d7e | 2024-01-08 02:44:15 | [diff] [blame] | 575 | GlobalSimulatedTimeController time_controller(Timestamp::Zero()); |
| 576 | // Here the metronome interval is 33ms, because the metronome is not |
| 577 | // infrequent then the encode tasks are aligned with the tick period. |
| 578 | static constexpr TimeDelta kTickPeriod = TimeDelta::Millis(33); |
| 579 | auto queue = time_controller.GetTaskQueueFactory()->CreateTaskQueue( |
| 580 | "queue", TaskQueueFactory::Priority::NORMAL); |
| 581 | auto worker_queue = time_controller.GetTaskQueueFactory()->CreateTaskQueue( |
| 582 | "work_queue", TaskQueueFactory::Priority::NORMAL); |
Markus Handell | e864dec | 2024-08-07 14:11:18 | [diff] [blame] | 583 | test::FakeMetronome metronome(kTickPeriod); |
Markus Handell | a57229b | 2024-04-16 08:40:45 | [diff] [blame] | 584 | test::ScopedKeyValueConfig no_field_trials; |
Zhaoliang Ma | f089d7e | 2024-01-08 02:44:15 | [diff] [blame] | 585 | auto adapter = FrameCadenceAdapterInterface::Create( |
| 586 | time_controller.GetClock(), queue.get(), &metronome, worker_queue.get(), |
Markus Handell | a57229b | 2024-04-16 08:40:45 | [diff] [blame] | 587 | no_field_trials); |
Zhaoliang Ma | f089d7e | 2024-01-08 02:44:15 | [diff] [blame] | 588 | MockCallback callback; |
| 589 | adapter->Initialize(&callback); |
| 590 | auto frame = CreateFrame(); |
| 591 | |
| 592 | // `callback->OnFrame()` would not be called if only 32ms went by after |
| 593 | // `adapter->OnFrame()`. |
| 594 | EXPECT_CALL(callback, OnFrame(_, false, _)).Times(0); |
| 595 | adapter->OnFrame(frame); |
| 596 | time_controller.AdvanceTime(TimeDelta::Millis(32)); |
| 597 | Mock::VerifyAndClearExpectations(&callback); |
| 598 | |
| 599 | // `callback->OnFrame()` should be called if 33ms went by after |
| 600 | // `adapter->OnFrame()`. |
| 601 | EXPECT_CALL(callback, OnFrame(_, false, _)).Times(1); |
| 602 | time_controller.AdvanceTime(TimeDelta::Millis(1)); |
| 603 | Mock::VerifyAndClearExpectations(&callback); |
| 604 | |
| 605 | // `callback->OnFrame()` would not be called if only 32ms went by after |
| 606 | // `adapter->OnFrame()`. |
| 607 | EXPECT_CALL(callback, OnFrame(_, false, _)).Times(0); |
| 608 | // Send two frame before next tick. |
| 609 | adapter->OnFrame(frame); |
| 610 | adapter->OnFrame(frame); |
| 611 | time_controller.AdvanceTime(TimeDelta::Millis(32)); |
| 612 | Mock::VerifyAndClearExpectations(&callback); |
| 613 | |
| 614 | // `callback->OnFrame()` should be called if 33ms went by after |
| 615 | // `adapter->OnFrame()`. |
| 616 | EXPECT_CALL(callback, OnFrame(_, false, _)).Times(2); |
| 617 | time_controller.AdvanceTime(TimeDelta::Millis(1)); |
| 618 | Mock::VerifyAndClearExpectations(&callback); |
| 619 | |
| 620 | // Change the metronome tick period to 67ms (15Hz). |
| 621 | metronome.SetTickPeriod(TimeDelta::Millis(67)); |
| 622 | // Expect the encode would happen immediately. |
| 623 | EXPECT_CALL(callback, OnFrame(_, false, _)).Times(1); |
| 624 | adapter->OnFrame(frame); |
| 625 | time_controller.AdvanceTime(TimeDelta::Zero()); |
| 626 | Mock::VerifyAndClearExpectations(&callback); |
| 627 | |
| 628 | // Change the metronome tick period to 16ms (60Hz). |
| 629 | metronome.SetTickPeriod(TimeDelta::Millis(16)); |
| 630 | // Expect the encode would not happen if only 15ms went by after |
| 631 | // `adapter->OnFrame()`. |
| 632 | EXPECT_CALL(callback, OnFrame(_, false, _)).Times(0); |
| 633 | adapter->OnFrame(frame); |
| 634 | time_controller.AdvanceTime(TimeDelta::Millis(15)); |
| 635 | Mock::VerifyAndClearExpectations(&callback); |
| 636 | // `callback->OnFrame()` should be called if 16ms went by after |
| 637 | // `adapter->OnFrame()`. |
| 638 | EXPECT_CALL(callback, OnFrame(_, false, _)).Times(1); |
| 639 | time_controller.AdvanceTime(TimeDelta::Millis(1)); |
| 640 | Mock::VerifyAndClearExpectations(&callback); |
| 641 | |
| 642 | rtc::Event finalized; |
| 643 | queue->PostTask([&] { |
| 644 | adapter = nullptr; |
| 645 | finalized.Set(); |
| 646 | }); |
| 647 | finalized.Wait(rtc::Event::kForever); |
| 648 | } |
| 649 | |
Markus Handell | e864dec | 2024-08-07 14:11:18 | [diff] [blame] | 650 | TEST(FrameCadenceAdapterTest, ShutdownUnderMetronome) { |
| 651 | // Regression test for crbug.com/356423094. |
| 652 | // The current thread takes the role of worker queue. |
| 653 | GlobalSimulatedTimeController time_controller(Timestamp::Zero()); |
| 654 | static constexpr TimeDelta kTickPeriod = TimeDelta::Millis(100); |
| 655 | auto queue = time_controller.GetTaskQueueFactory()->CreateTaskQueue( |
| 656 | "queue", TaskQueueFactory::Priority::NORMAL); |
| 657 | test::FakeMetronome metronome(kTickPeriod); |
| 658 | test::ScopedKeyValueConfig no_field_trials; |
| 659 | auto adapter = FrameCadenceAdapterInterface::Create( |
| 660 | time_controller.GetClock(), queue.get(), &metronome, |
| 661 | TaskQueueBase::Current(), no_field_trials); |
| 662 | MockCallback callback; |
| 663 | EXPECT_CALL(callback, OnFrame).Times(0); |
| 664 | adapter->Initialize(&callback); |
| 665 | |
| 666 | // Pass a frame, this is expected to trigger an encode call in the future. |
| 667 | adapter->OnFrame(CreateFrame()); |
| 668 | |
| 669 | // Then post destruction of the adapter and destroy the encode queue from the |
| 670 | // worker (i.e. current). |
| 671 | SendTask(queue.get(), [&] { adapter = nullptr; }); |
| 672 | queue = nullptr; |
| 673 | |
| 674 | // Now that we advance time, there should be no encoding happening. |
| 675 | time_controller.AdvanceTime(TimeDelta::Millis(100)); |
| 676 | } |
| 677 | |
Markus Handell | cb237f8 | 2021-12-29 20:31:57 | [diff] [blame] | 678 | class FrameCadenceAdapterSimulcastLayersParamTest |
| 679 | : public ::testing::TestWithParam<int> { |
| 680 | public: |
| 681 | static constexpr int kMaxFpsHz = 8; |
| 682 | static constexpr TimeDelta kMinFrameDelay = |
| 683 | TimeDelta::Millis(1000 / kMaxFpsHz); |
| 684 | static constexpr TimeDelta kIdleFrameDelay = |
| 685 | FrameCadenceAdapterInterface::kZeroHertzIdleRepeatRatePeriod; |
Markus Handell | 2e0f4f0 | 2021-12-21 18:14:58 | [diff] [blame] | 686 | |
Markus Handell | cb237f8 | 2021-12-29 20:31:57 | [diff] [blame] | 687 | FrameCadenceAdapterSimulcastLayersParamTest() { |
| 688 | adapter_->Initialize(&callback_); |
| 689 | adapter_->OnConstraintsChanged(VideoTrackSourceConstraints{0, kMaxFpsHz}); |
| 690 | time_controller_.AdvanceTime(TimeDelta::Zero()); |
| 691 | adapter_->SetZeroHertzModeEnabled( |
| 692 | FrameCadenceAdapterInterface::ZeroHertzModeParams{}); |
Markus Handell | 5a77e51 | 2022-09-01 12:51:50 | [diff] [blame] | 693 | const size_t num_spatial_layers = GetParam(); |
Markus Handell | cb237f8 | 2021-12-29 20:31:57 | [diff] [blame] | 694 | adapter_->SetZeroHertzModeEnabled( |
| 695 | FrameCadenceAdapterInterface::ZeroHertzModeParams{num_spatial_layers}); |
| 696 | } |
| 697 | |
| 698 | int NumSpatialLayers() const { return GetParam(); } |
| 699 | |
| 700 | protected: |
Markus Handell | a57229b | 2024-04-16 08:40:45 | [diff] [blame] | 701 | test::ScopedKeyValueConfig no_field_trials_; |
Markus Handell | cb237f8 | 2021-12-29 20:31:57 | [diff] [blame] | 702 | MockCallback callback_; |
Philipp Hancke | a204ad2 | 2022-07-08 16:43:25 | [diff] [blame] | 703 | GlobalSimulatedTimeController time_controller_{Timestamp::Zero()}; |
Markus Handell | cb237f8 | 2021-12-29 20:31:57 | [diff] [blame] | 704 | const std::unique_ptr<FrameCadenceAdapterInterface> adapter_{ |
Markus Handell | a57229b | 2024-04-16 08:40:45 | [diff] [blame] | 705 | CreateAdapter(no_field_trials_, time_controller_.GetClock())}; |
Markus Handell | cb237f8 | 2021-12-29 20:31:57 | [diff] [blame] | 706 | }; |
| 707 | |
| 708 | TEST_P(FrameCadenceAdapterSimulcastLayersParamTest, |
| 709 | LayerReconfigurationResetsConvergenceInfo) { |
| 710 | // Assumes layer reconfiguration has just happened. |
| 711 | // Verify the state is unconverged. |
| 712 | adapter_->OnFrame(CreateFrame()); |
| 713 | EXPECT_CALL(callback_, OnFrame).Times(kMaxFpsHz); |
| 714 | time_controller_.AdvanceTime(kMaxFpsHz * kMinFrameDelay); |
Markus Handell | 2e0f4f0 | 2021-12-21 18:14:58 | [diff] [blame] | 715 | } |
| 716 | |
Markus Handell | cb237f8 | 2021-12-29 20:31:57 | [diff] [blame] | 717 | TEST_P(FrameCadenceAdapterSimulcastLayersParamTest, |
| 718 | IgnoresKeyFrameRequestWhileShortRepeating) { |
| 719 | // Plot: |
| 720 | // 1. 0 * kMinFrameDelay: Start unconverged. Frame -> adapter. |
| 721 | // 2. 1 * kMinFrameDelay: Frame -> callback. |
| 722 | // 3. 2 * kMinFrameDelay: 1st short repeat. |
| 723 | // Since we're unconverged we assume the process continues. |
| 724 | adapter_->OnFrame(CreateFrame()); |
| 725 | time_controller_.AdvanceTime(2 * kMinFrameDelay); |
Markus Handell | 818e7fb | 2021-12-30 12:01:33 | [diff] [blame] | 726 | EXPECT_CALL(callback_, RequestRefreshFrame).Times(0); |
| 727 | adapter_->ProcessKeyFrameRequest(); |
Markus Handell | cb237f8 | 2021-12-29 20:31:57 | [diff] [blame] | 728 | |
| 729 | // Expect short repeating as ususal. |
| 730 | EXPECT_CALL(callback_, OnFrame).Times(8); |
| 731 | time_controller_.AdvanceTime(8 * kMinFrameDelay); |
| 732 | } |
| 733 | |
| 734 | TEST_P(FrameCadenceAdapterSimulcastLayersParamTest, |
| 735 | IgnoresKeyFrameRequestJustBeforeIdleRepeating) { |
| 736 | // (Only for > 0 spatial layers as we assume not converged with 0 layers) |
| 737 | if (NumSpatialLayers() == 0) |
| 738 | return; |
| 739 | |
| 740 | // Plot: |
| 741 | // 1. 0 * kMinFrameDelay: Start converged. Frame -> adapter. |
| 742 | // 2. 1 * kMinFrameDelay: Frame -> callback. New repeat scheduled at |
| 743 | // (kMaxFpsHz + 1) * kMinFrameDelay. |
| 744 | // 3. kMaxFpsHz * kMinFrameDelay: Process keyframe. |
| 745 | // 4. (kMaxFpsHz + N) * kMinFrameDelay (1 <= N <= kMaxFpsHz): Short repeats |
| 746 | // due to not converged. |
| 747 | for (int i = 0; i != NumSpatialLayers(); i++) { |
| 748 | adapter_->UpdateLayerStatus(i, /*enabled=*/true); |
| 749 | adapter_->UpdateLayerQualityConvergence(i, /*converged=*/true); |
| 750 | } |
| 751 | adapter_->OnFrame(CreateFrame()); |
| 752 | time_controller_.AdvanceTime(kIdleFrameDelay); |
Markus Handell | 2e0f4f0 | 2021-12-21 18:14:58 | [diff] [blame] | 753 | |
| 754 | // We process the key frame request kMinFrameDelay before the first idle |
Markus Handell | cb237f8 | 2021-12-29 20:31:57 | [diff] [blame] | 755 | // repeat should happen. The resulting repeats should happen spaced by |
| 756 | // kMinFrameDelay before we get new convergence info. |
Markus Handell | 818e7fb | 2021-12-30 12:01:33 | [diff] [blame] | 757 | EXPECT_CALL(callback_, RequestRefreshFrame).Times(0); |
| 758 | adapter_->ProcessKeyFrameRequest(); |
Markus Handell | cb237f8 | 2021-12-29 20:31:57 | [diff] [blame] | 759 | EXPECT_CALL(callback_, OnFrame).Times(kMaxFpsHz); |
| 760 | time_controller_.AdvanceTime(kMaxFpsHz * kMinFrameDelay); |
Markus Handell | 2e0f4f0 | 2021-12-21 18:14:58 | [diff] [blame] | 761 | } |
| 762 | |
Markus Handell | cb237f8 | 2021-12-29 20:31:57 | [diff] [blame] | 763 | TEST_P(FrameCadenceAdapterSimulcastLayersParamTest, |
| 764 | IgnoresKeyFrameRequestShortRepeatsBeforeIdleRepeat) { |
| 765 | // (Only for > 0 spatial layers as we assume not converged with 0 layers) |
| 766 | if (NumSpatialLayers() == 0) |
| 767 | return; |
| 768 | // Plot: |
| 769 | // 1. 0 * kMinFrameDelay: Start converged. Frame -> adapter. |
| 770 | // 2. 1 * kMinFrameDelay: Frame -> callback. New repeat scheduled at |
| 771 | // (kMaxFpsHz + 1) * kMinFrameDelay. |
| 772 | // 3. 2 * kMinFrameDelay: Process keyframe. |
| 773 | // 4. (2 + N) * kMinFrameDelay (1 <= N <= kMaxFpsHz): Short repeats due to not |
| 774 | // converged. |
| 775 | for (int i = 0; i != NumSpatialLayers(); i++) { |
| 776 | adapter_->UpdateLayerStatus(i, /*enabled=*/true); |
| 777 | adapter_->UpdateLayerQualityConvergence(i, /*converged=*/true); |
| 778 | } |
| 779 | adapter_->OnFrame(CreateFrame()); |
| 780 | time_controller_.AdvanceTime(2 * kMinFrameDelay); |
Markus Handell | 2e0f4f0 | 2021-12-21 18:14:58 | [diff] [blame] | 781 | |
Markus Handell | cb237f8 | 2021-12-29 20:31:57 | [diff] [blame] | 782 | // We process the key frame request (kMaxFpsHz - 1) * kMinFrameDelay before |
| 783 | // the first idle repeat should happen. The resulting repeats should happen |
| 784 | // spaced kMinFrameDelay before we get new convergence info. |
Markus Handell | 818e7fb | 2021-12-30 12:01:33 | [diff] [blame] | 785 | EXPECT_CALL(callback_, RequestRefreshFrame).Times(0); |
| 786 | adapter_->ProcessKeyFrameRequest(); |
Markus Handell | cb237f8 | 2021-12-29 20:31:57 | [diff] [blame] | 787 | EXPECT_CALL(callback_, OnFrame).Times(kMaxFpsHz); |
| 788 | time_controller_.AdvanceTime(kMaxFpsHz * kMinFrameDelay); |
Markus Handell | 2e0f4f0 | 2021-12-21 18:14:58 | [diff] [blame] | 789 | } |
| 790 | |
Markus Handell | cb237f8 | 2021-12-29 20:31:57 | [diff] [blame] | 791 | INSTANTIATE_TEST_SUITE_P(, |
| 792 | FrameCadenceAdapterSimulcastLayersParamTest, |
| 793 | Values(0, 1, 2)); |
Markus Handell | e59fee8 | 2021-12-23 08:29:23 | [diff] [blame] | 794 | |
Markus Handell | 8d87c46 | 2021-12-16 10:37:16 | [diff] [blame] | 795 | class ZeroHertzLayerQualityConvergenceTest : public ::testing::Test { |
| 796 | public: |
| 797 | static constexpr TimeDelta kMinFrameDelay = TimeDelta::Millis(100); |
| 798 | static constexpr TimeDelta kIdleFrameDelay = |
| 799 | FrameCadenceAdapterInterface::kZeroHertzIdleRepeatRatePeriod; |
henrika | 8f16ce9 | 2023-12-04 13:03:52 | [diff] [blame] | 800 | // Restricts non-idle repeat rate to 5 fps (default is 10 fps); |
| 801 | static constexpr int kRestrictedMaxFps = 5; |
Markus Handell | 8d87c46 | 2021-12-16 10:37:16 | [diff] [blame] | 802 | |
| 803 | ZeroHertzLayerQualityConvergenceTest() { |
| 804 | adapter_->Initialize(&callback_); |
| 805 | adapter_->SetZeroHertzModeEnabled( |
| 806 | FrameCadenceAdapterInterface::ZeroHertzModeParams{ |
| 807 | /*num_simulcast_layers=*/2}); |
| 808 | adapter_->OnConstraintsChanged(VideoTrackSourceConstraints{ |
| 809 | /*min_fps=*/0, /*max_fps=*/TimeDelta::Seconds(1) / kMinFrameDelay}); |
| 810 | time_controller_.AdvanceTime(TimeDelta::Zero()); |
| 811 | } |
| 812 | |
| 813 | void PassFrame() { adapter_->OnFrame(CreateFrame()); } |
| 814 | |
| 815 | void ExpectFrameEntriesAtDelaysFromNow( |
| 816 | std::initializer_list<TimeDelta> list) { |
| 817 | Timestamp origin = time_controller_.GetClock()->CurrentTime(); |
| 818 | for (auto delay : list) { |
Markus Handell | 84c016a | 2023-11-23 12:41:44 | [diff] [blame] | 819 | EXPECT_CALL(callback_, OnFrame(origin + delay, false, _)); |
Markus Handell | 8d87c46 | 2021-12-16 10:37:16 | [diff] [blame] | 820 | time_controller_.AdvanceTime(origin + delay - |
| 821 | time_controller_.GetClock()->CurrentTime()); |
| 822 | } |
| 823 | } |
| 824 | |
Danil Chapovalov | 95eeaa7 | 2022-07-06 08:14:29 | [diff] [blame] | 825 | void ScheduleDelayed(TimeDelta delay, absl::AnyInvocable<void() &&> task) { |
| 826 | TaskQueueBase::Current()->PostDelayedTask(std::move(task), delay); |
Markus Handell | 8d87c46 | 2021-12-16 10:37:16 | [diff] [blame] | 827 | } |
| 828 | |
| 829 | protected: |
Markus Handell | a57229b | 2024-04-16 08:40:45 | [diff] [blame] | 830 | test::ScopedKeyValueConfig no_field_trials_; |
Markus Handell | 8d87c46 | 2021-12-16 10:37:16 | [diff] [blame] | 831 | MockCallback callback_; |
Philipp Hancke | a204ad2 | 2022-07-08 16:43:25 | [diff] [blame] | 832 | GlobalSimulatedTimeController time_controller_{Timestamp::Zero()}; |
Markus Handell | 8d87c46 | 2021-12-16 10:37:16 | [diff] [blame] | 833 | std::unique_ptr<FrameCadenceAdapterInterface> adapter_{ |
Markus Handell | a57229b | 2024-04-16 08:40:45 | [diff] [blame] | 834 | CreateAdapter(no_field_trials_, time_controller_.GetClock())}; |
Markus Handell | 8d87c46 | 2021-12-16 10:37:16 | [diff] [blame] | 835 | }; |
| 836 | |
Markus Handell | e59fee8 | 2021-12-23 08:29:23 | [diff] [blame] | 837 | TEST_F(ZeroHertzLayerQualityConvergenceTest, InitialStateUnconverged) { |
| 838 | // As the layer count is just configured, assume we start out as unconverged. |
Markus Handell | 8d87c46 | 2021-12-16 10:37:16 | [diff] [blame] | 839 | PassFrame(); |
| 840 | ExpectFrameEntriesAtDelaysFromNow({ |
Markus Handell | e59fee8 | 2021-12-23 08:29:23 | [diff] [blame] | 841 | 1 * kMinFrameDelay, // Original frame emitted |
| 842 | 2 * kMinFrameDelay, // Short repeats. |
| 843 | 3 * kMinFrameDelay, // ... |
Markus Handell | 8d87c46 | 2021-12-16 10:37:16 | [diff] [blame] | 844 | }); |
| 845 | } |
| 846 | |
| 847 | TEST_F(ZeroHertzLayerQualityConvergenceTest, UnconvergedAfterLayersEnabled) { |
| 848 | // With newly enabled layers we assume quality is unconverged. |
| 849 | adapter_->UpdateLayerStatus(0, /*enabled=*/true); |
| 850 | adapter_->UpdateLayerStatus(1, /*enabled=*/true); |
| 851 | PassFrame(); |
| 852 | ExpectFrameEntriesAtDelaysFromNow({ |
| 853 | kMinFrameDelay, // Original frame emitted |
| 854 | 2 * kMinFrameDelay, // Unconverged repeats. |
| 855 | 3 * kMinFrameDelay, // ... |
| 856 | }); |
| 857 | } |
| 858 | |
| 859 | TEST_F(ZeroHertzLayerQualityConvergenceTest, |
| 860 | RepeatsPassedFramesUntilConvergence) { |
| 861 | ScheduleDelayed(TimeDelta::Zero(), [&] { |
| 862 | adapter_->UpdateLayerStatus(0, /*enabled=*/true); |
| 863 | adapter_->UpdateLayerStatus(1, /*enabled=*/true); |
| 864 | PassFrame(); |
| 865 | }); |
| 866 | ScheduleDelayed(2.5 * kMinFrameDelay, [&] { |
| 867 | adapter_->UpdateLayerQualityConvergence(/*spatial_index=*/1, true); |
| 868 | }); |
| 869 | ScheduleDelayed(3.5 * kMinFrameDelay, [&] { |
| 870 | adapter_->UpdateLayerQualityConvergence(/*spatial_index=*/0, true); |
| 871 | }); |
| 872 | ScheduleDelayed(8 * kMinFrameDelay, [&] { PassFrame(); }); |
| 873 | ScheduleDelayed(9.5 * kMinFrameDelay, [&] { |
| 874 | adapter_->UpdateLayerQualityConvergence(/*spatial_index=*/0, true); |
| 875 | }); |
| 876 | ScheduleDelayed(10.5 * kMinFrameDelay, [&] { |
| 877 | adapter_->UpdateLayerQualityConvergence(/*spatial_index=*/1, true); |
| 878 | }); |
| 879 | ExpectFrameEntriesAtDelaysFromNow({ |
| 880 | kMinFrameDelay, // Original frame emitted |
| 881 | 2 * kMinFrameDelay, // Repeat from kMinFrameDelay. |
| 882 | |
| 883 | // 2.5 * kMinFrameDelay: Converged in layer 1, layer 0 still unconverged. |
| 884 | 3 * kMinFrameDelay, // Repeat from 2 * kMinFrameDelay. |
| 885 | |
| 886 | // 3.5 * kMinFrameDelay: Converged in layer 0 as well. |
| 887 | 4 * kMinFrameDelay, // Repeat from 3 * kMinFrameDelay. An idle repeat is |
| 888 | // scheduled for kIdleFrameDelay + 3 * |
| 889 | // kMinFrameDelay. |
| 890 | |
| 891 | // A new frame is passed at 8 * kMinFrameDelay. |
| 892 | 9 * kMinFrameDelay, // Original frame emitted |
| 893 | |
| 894 | // 9.5 * kMinFrameDelay: Converged in layer 0, layer 1 still unconverged. |
| 895 | 10 * kMinFrameDelay, // Repeat from 9 * kMinFrameDelay. |
| 896 | // 10.5 * kMinFrameDelay: Converged in layer 0 as well. |
| 897 | 11 * kMinFrameDelay, // Idle repeats from 1000. |
| 898 | 11 * kMinFrameDelay + kIdleFrameDelay, // ... |
| 899 | 11 * kMinFrameDelay + 2 * kIdleFrameDelay, // ... |
| 900 | // ... |
| 901 | }); |
| 902 | } |
| 903 | |
henrika | 8f16ce9 | 2023-12-04 13:03:52 | [diff] [blame] | 904 | TEST_F(ZeroHertzLayerQualityConvergenceTest, |
| 905 | UnconvergedRepeatRateAdaptsDownWhenRestricted) { |
| 906 | PassFrame(); |
| 907 | ScheduleDelayed(1.5 * kMinFrameDelay, [&] { |
| 908 | adapter_->UpdateVideoSourceRestrictions(kRestrictedMaxFps); |
| 909 | }); |
| 910 | ExpectFrameEntriesAtDelaysFromNow({ |
| 911 | 1 * kMinFrameDelay, // Original frame emitted at non-restricted rate. |
| 912 | |
| 913 | // 1.5 * kMinFrameDelay: restricts max fps to 5 fps which should result |
| 914 | // in a new non-idle repeat delay of 2 * kMinFrameDelay. |
| 915 | 2 * kMinFrameDelay, // Unconverged repeat at non-restricted rate. |
| 916 | 4 * kMinFrameDelay, // Unconverged repeats at restricted rate. This |
| 917 | // happens 2 * kMinFrameDelay after the last frame. |
| 918 | 6 * kMinFrameDelay, // ... |
| 919 | }); |
| 920 | } |
| 921 | |
| 922 | TEST_F(ZeroHertzLayerQualityConvergenceTest, |
| 923 | UnconvergedRepeatRateAdaptsUpWhenGoingFromRestrictedToUnrestricted) { |
| 924 | PassFrame(); |
| 925 | ScheduleDelayed(1.5 * kMinFrameDelay, [&] { |
| 926 | adapter_->UpdateVideoSourceRestrictions(kRestrictedMaxFps); |
| 927 | }); |
| 928 | ScheduleDelayed(5.5 * kMinFrameDelay, [&] { |
| 929 | adapter_->UpdateVideoSourceRestrictions(absl::nullopt); |
| 930 | }); |
| 931 | ExpectFrameEntriesAtDelaysFromNow({ |
| 932 | 1 * kMinFrameDelay, // Original frame emitted at non-restricted rate. |
| 933 | |
| 934 | // 1.5 * kMinFrameDelay: restricts max fps to 5 fps which should result |
| 935 | // in a new non-idle repeat delay of 2 * kMinFrameDelay. |
| 936 | 2 * kMinFrameDelay, // Unconverged repeat at non-restricted rate. |
| 937 | 4 * kMinFrameDelay, // Unconverged repeat at restricted rate. |
| 938 | |
| 939 | // 5.5 * kMinFrameDelay: removes frame-rate restriction and we should |
| 940 | // then go back to 10 fps as unconverged repeat rate. |
| 941 | 6 * kMinFrameDelay, // Last unconverged repeat at restricted rate. |
| 942 | 7 * kMinFrameDelay, // Back to unconverged repeat at non-restricted rate. |
| 943 | 8 * kMinFrameDelay, // We are now unrestricted. |
| 944 | 9 * kMinFrameDelay, // ... |
| 945 | }); |
| 946 | } |
| 947 | |
| 948 | TEST_F(ZeroHertzLayerQualityConvergenceTest, |
| 949 | UnconvergedRepeatRateMaintainsRestrictionOnReconfigureToHigherMaxFps) { |
| 950 | PassFrame(); |
| 951 | ScheduleDelayed(1.5 * kMinFrameDelay, [&] { |
| 952 | adapter_->UpdateVideoSourceRestrictions(kRestrictedMaxFps); |
| 953 | }); |
| 954 | ScheduleDelayed(2.5 * kMinFrameDelay, [&] { |
| 955 | adapter_->OnConstraintsChanged(VideoTrackSourceConstraints{ |
| 956 | /*min_fps=*/0, /*max_fps=*/2 * TimeDelta::Seconds(1) / kMinFrameDelay}); |
| 957 | }); |
| 958 | ScheduleDelayed(3 * kMinFrameDelay, [&] { PassFrame(); }); |
| 959 | ScheduleDelayed(8 * kMinFrameDelay, [&] { |
| 960 | adapter_->OnConstraintsChanged(VideoTrackSourceConstraints{ |
| 961 | /*min_fps=*/0, |
| 962 | /*max_fps=*/0.2 * TimeDelta::Seconds(1) / kMinFrameDelay}); |
| 963 | }); |
| 964 | ScheduleDelayed(9 * kMinFrameDelay, [&] { PassFrame(); }); |
| 965 | ExpectFrameEntriesAtDelaysFromNow({ |
| 966 | 1 * kMinFrameDelay, // Original frame emitted at non-restricted rate. |
| 967 | |
| 968 | // 1.5 * kMinFrameDelay: restricts max fps to 5 fps which should result |
| 969 | // in a new non-idle repeat delay of 2 * kMinFrameDelay. |
| 970 | 2 * kMinFrameDelay, // Unconverged repeat at non-restricted rate. |
| 971 | |
| 972 | // 2.5 * kMinFrameDelay: new constraint asks for max rate of 20 fps. |
| 973 | // The 0Hz adapter is reconstructed for 20 fps but inherits the current |
| 974 | // restriction for rate of non-converged frames of 5 fps. |
| 975 | |
| 976 | // A new frame is passed at 3 * kMinFrameDelay. The previous repeat |
| 977 | // cadence was stopped by the change in constraints. |
| 978 | 3.5 * kMinFrameDelay, // Original frame emitted at non-restricted 20 fps. |
| 979 | // The delay is 0.5 * kMinFrameDelay. |
| 980 | 5.5 * kMinFrameDelay, // Unconverged repeat at restricted rate. |
| 981 | // The delay is 2 * kMinFrameDelay when restricted. |
| 982 | 7.5 * kMinFrameDelay, // ... |
| 983 | |
| 984 | // 8 * kMinFrameDelay: new constraint asks for max rate of 2 fps. |
| 985 | // The 0Hz adapter is reconstructed for 2 fps and will therefore not obey |
| 986 | // the current restriction for rate of non-converged frames of 5 fps |
| 987 | // since the new max rate is lower. |
| 988 | |
| 989 | // A new frame is passed at 9 * kMinFrameDelay. The previous repeat |
| 990 | // cadence was stopped by the change in constraints. |
| 991 | 14 * kMinFrameDelay, // Original frame emitted at non-restricted 2 fps. |
| 992 | // The delay is 5 * kMinFrameDelay. |
| 993 | 19 * kMinFrameDelay, // Unconverged repeat at non-restricted rate. |
| 994 | 24 * kMinFrameDelay, // ... |
| 995 | }); |
| 996 | } |
| 997 | |
Markus Handell | b4e96d4 | 2021-11-05 11:00:55 | [diff] [blame] | 998 | class FrameCadenceAdapterMetricsTest : public ::testing::Test { |
| 999 | public: |
Markus Handell | 28c7180 | 2021-11-08 09:11:55 | [diff] [blame] | 1000 | FrameCadenceAdapterMetricsTest() : time_controller_(Timestamp::Millis(1)) { |
| 1001 | metrics::Reset(); |
| 1002 | } |
| 1003 | void DepleteTaskQueues() { time_controller_.AdvanceTime(TimeDelta::Zero()); } |
| 1004 | |
Markus Handell | 9a478b5 | 2021-11-18 15:07:01 | [diff] [blame] | 1005 | protected: |
Markus Handell | 28c7180 | 2021-11-08 09:11:55 | [diff] [blame] | 1006 | GlobalSimulatedTimeController time_controller_; |
Markus Handell | b4e96d4 | 2021-11-05 11:00:55 | [diff] [blame] | 1007 | }; |
| 1008 | |
Markus Handell | 9d04a78 | 2022-05-12 16:38:57 | [diff] [blame] | 1009 | TEST_F(FrameCadenceAdapterMetricsTest, RecordsTimeUntilFirstFrame) { |
| 1010 | MockCallback callback; |
| 1011 | test::ScopedKeyValueConfig no_field_trials; |
| 1012 | auto adapter = CreateAdapter(no_field_trials, time_controller_.GetClock()); |
| 1013 | adapter->Initialize(&callback); |
| 1014 | adapter->SetZeroHertzModeEnabled( |
| 1015 | FrameCadenceAdapterInterface::ZeroHertzModeParams{}); |
| 1016 | adapter->OnConstraintsChanged(VideoTrackSourceConstraints{0, 5.0}); |
| 1017 | time_controller_.AdvanceTime(TimeDelta::Millis(666)); |
| 1018 | adapter->OnFrame(CreateFrame()); |
| 1019 | DepleteTaskQueues(); |
| 1020 | EXPECT_THAT( |
| 1021 | metrics::Samples("WebRTC.Screenshare.ZeroHz.TimeUntilFirstFrameMs"), |
| 1022 | ElementsAre(Pair(666, 1))); |
| 1023 | } |
| 1024 | |
Per K | e975b44 | 2024-03-27 10:28:44 | [diff] [blame] | 1025 | TEST_F(FrameCadenceAdapterMetricsTest, |
| 1026 | RecordsFrameTimestampMonotonicallyIncreasing) { |
| 1027 | MockCallback callback; |
| 1028 | test::ScopedKeyValueConfig no_field_trials; |
| 1029 | std::unique_ptr<FrameCadenceAdapterInterface> adapter = |
| 1030 | CreateAdapter(no_field_trials, time_controller_.GetClock()); |
| 1031 | adapter->Initialize(&callback); |
| 1032 | time_controller_.AdvanceTime(TimeDelta::Millis(666)); |
| 1033 | adapter->OnFrame(CreateFrameWithTimestamps(&time_controller_)); |
| 1034 | adapter->OnFrame(CreateFrameWithTimestamps(&time_controller_)); |
| 1035 | time_controller_.AdvanceTime(TimeDelta::Zero()); |
| 1036 | adapter = nullptr; |
| 1037 | DepleteTaskQueues(); |
| 1038 | EXPECT_THAT(metrics::Samples( |
| 1039 | "WebRTC.Video.InputFrameTimestampMonotonicallyIncreasing"), |
| 1040 | ElementsAre(Pair(false, 1))); |
| 1041 | } |
| 1042 | |
Markus Handell | 90a7e2c | 2021-12-29 22:32:30 | [diff] [blame] | 1043 | TEST(FrameCadenceAdapterRealTimeTest, TimestampsDoNotDrift) { |
| 1044 | // This regression test must be performed in realtime because of limitations |
| 1045 | // in GlobalSimulatedTimeController. |
| 1046 | // |
| 1047 | // We sleep for a long while in OnFrame when a repeat was scheduled which |
| 1048 | // should reflect in accordingly increased ntp_time_ms() and timestamp_us() in |
| 1049 | // the repeated frames. |
| 1050 | auto factory = CreateDefaultTaskQueueFactory(); |
| 1051 | auto queue = |
| 1052 | factory->CreateTaskQueue("test", TaskQueueFactory::Priority::NORMAL); |
Markus Handell | 90a7e2c | 2021-12-29 22:32:30 | [diff] [blame] | 1053 | MockCallback callback; |
| 1054 | Clock* clock = Clock::GetRealTimeClock(); |
| 1055 | std::unique_ptr<FrameCadenceAdapterInterface> adapter; |
| 1056 | int frame_counter = 0; |
| 1057 | int64_t original_ntp_time_ms; |
| 1058 | int64_t original_timestamp_us; |
| 1059 | rtc::Event event; |
Markus Handell | a57229b | 2024-04-16 08:40:45 | [diff] [blame] | 1060 | test::ScopedKeyValueConfig no_field_trials; |
Danil Chapovalov | 95eeaa7 | 2022-07-06 08:14:29 | [diff] [blame] | 1061 | queue->PostTask([&] { |
Markus Handell | a57229b | 2024-04-16 08:40:45 | [diff] [blame] | 1062 | adapter = CreateAdapter(no_field_trials, clock); |
Markus Handell | 90a7e2c | 2021-12-29 22:32:30 | [diff] [blame] | 1063 | adapter->Initialize(&callback); |
| 1064 | adapter->SetZeroHertzModeEnabled( |
| 1065 | FrameCadenceAdapterInterface::ZeroHertzModeParams{}); |
| 1066 | adapter->OnConstraintsChanged(VideoTrackSourceConstraints{0, 30}); |
| 1067 | auto frame = CreateFrame(); |
| 1068 | original_ntp_time_ms = clock->CurrentNtpInMilliseconds(); |
| 1069 | frame.set_ntp_time_ms(original_ntp_time_ms); |
| 1070 | original_timestamp_us = clock->CurrentTime().us(); |
| 1071 | frame.set_timestamp_us(original_timestamp_us); |
| 1072 | constexpr int kSleepMs = rtc::kNumMillisecsPerSec / 2; |
| 1073 | EXPECT_CALL(callback, OnFrame) |
| 1074 | .WillRepeatedly( |
Markus Handell | 84c016a | 2023-11-23 12:41:44 | [diff] [blame] | 1075 | Invoke([&](Timestamp, bool, const VideoFrame& incoming_frame) { |
Markus Handell | 90a7e2c | 2021-12-29 22:32:30 | [diff] [blame] | 1076 | ++frame_counter; |
| 1077 | // Avoid the first OnFrame and sleep on the second. |
| 1078 | if (frame_counter == 2) { |
| 1079 | SleepMs(kSleepMs); |
| 1080 | } else if (frame_counter == 3) { |
| 1081 | EXPECT_GE(incoming_frame.ntp_time_ms(), |
| 1082 | original_ntp_time_ms + kSleepMs); |
| 1083 | EXPECT_GE(incoming_frame.timestamp_us(), |
| 1084 | original_timestamp_us + kSleepMs); |
| 1085 | event.Set(); |
| 1086 | } |
| 1087 | })); |
| 1088 | adapter->OnFrame(frame); |
Danil Chapovalov | 95eeaa7 | 2022-07-06 08:14:29 | [diff] [blame] | 1089 | }); |
Markus Handell | 90a7e2c | 2021-12-29 22:32:30 | [diff] [blame] | 1090 | event.Wait(rtc::Event::kForever); |
| 1091 | rtc::Event finalized; |
Danil Chapovalov | 95eeaa7 | 2022-07-06 08:14:29 | [diff] [blame] | 1092 | queue->PostTask([&] { |
Markus Handell | 90a7e2c | 2021-12-29 22:32:30 | [diff] [blame] | 1093 | adapter = nullptr; |
| 1094 | finalized.Set(); |
Danil Chapovalov | 95eeaa7 | 2022-07-06 08:14:29 | [diff] [blame] | 1095 | }); |
Markus Handell | 90a7e2c | 2021-12-29 22:32:30 | [diff] [blame] | 1096 | finalized.Wait(rtc::Event::kForever); |
| 1097 | } |
| 1098 | |
Markus Handell | f2827c4 | 2023-09-02 07:41:10 | [diff] [blame] | 1099 | // TODO(bugs.webrtc.org/15462) Disable ScheduledRepeatAllowsForSlowEncode for |
| 1100 | // TaskQueueLibevent. |
| 1101 | #if defined(WEBRTC_ENABLE_LIBEVENT) |
| 1102 | #define MAYBE_ScheduledRepeatAllowsForSlowEncode \ |
| 1103 | DISABLED_ScheduledRepeatAllowsForSlowEncode |
| 1104 | #else |
| 1105 | #define MAYBE_ScheduledRepeatAllowsForSlowEncode \ |
| 1106 | ScheduledRepeatAllowsForSlowEncode |
| 1107 | #endif |
| 1108 | |
| 1109 | TEST(FrameCadenceAdapterRealTimeTest, |
| 1110 | MAYBE_ScheduledRepeatAllowsForSlowEncode) { |
| 1111 | // This regression test must be performed in realtime because of limitations |
| 1112 | // in GlobalSimulatedTimeController. |
| 1113 | // |
| 1114 | // We sleep for a long while (but less than max fps) in the first repeated |
| 1115 | // OnFrame (frame 2). This should not lead to a belated second repeated |
| 1116 | // OnFrame (frame 3). |
| 1117 | auto factory = CreateDefaultTaskQueueFactory(); |
| 1118 | auto queue = |
| 1119 | factory->CreateTaskQueue("test", TaskQueueFactory::Priority::NORMAL); |
Markus Handell | f2827c4 | 2023-09-02 07:41:10 | [diff] [blame] | 1120 | MockCallback callback; |
| 1121 | Clock* clock = Clock::GetRealTimeClock(); |
| 1122 | std::unique_ptr<FrameCadenceAdapterInterface> adapter; |
| 1123 | int frame_counter = 0; |
| 1124 | rtc::Event event; |
| 1125 | absl::optional<Timestamp> start_time; |
Markus Handell | a57229b | 2024-04-16 08:40:45 | [diff] [blame] | 1126 | test::ScopedKeyValueConfig no_field_trials; |
Markus Handell | f2827c4 | 2023-09-02 07:41:10 | [diff] [blame] | 1127 | queue->PostTask([&] { |
Markus Handell | a57229b | 2024-04-16 08:40:45 | [diff] [blame] | 1128 | adapter = CreateAdapter(no_field_trials, clock); |
Markus Handell | f2827c4 | 2023-09-02 07:41:10 | [diff] [blame] | 1129 | adapter->Initialize(&callback); |
| 1130 | adapter->SetZeroHertzModeEnabled( |
| 1131 | FrameCadenceAdapterInterface::ZeroHertzModeParams{}); |
| 1132 | adapter->OnConstraintsChanged(VideoTrackSourceConstraints{0, 2}); |
| 1133 | auto frame = CreateFrame(); |
| 1134 | constexpr int kSleepMs = 400; |
| 1135 | constexpr TimeDelta kAllowedBelate = TimeDelta::Millis(150); |
| 1136 | EXPECT_CALL(callback, OnFrame) |
| 1137 | .WillRepeatedly(InvokeWithoutArgs([&, kAllowedBelate] { |
| 1138 | ++frame_counter; |
| 1139 | // Avoid the first OnFrame and sleep on the second. |
| 1140 | if (frame_counter == 2) { |
| 1141 | start_time = clock->CurrentTime(); |
| 1142 | SleepMs(kSleepMs); |
| 1143 | } else if (frame_counter == 3) { |
| 1144 | TimeDelta diff = |
| 1145 | clock->CurrentTime() - (*start_time + TimeDelta::Millis(500)); |
| 1146 | RTC_LOG(LS_ERROR) |
| 1147 | << "Difference in when frame should vs is appearing: " << diff; |
| 1148 | EXPECT_LT(diff, kAllowedBelate); |
| 1149 | event.Set(); |
| 1150 | } |
| 1151 | })); |
| 1152 | adapter->OnFrame(frame); |
| 1153 | }); |
| 1154 | event.Wait(rtc::Event::kForever); |
| 1155 | rtc::Event finalized; |
| 1156 | queue->PostTask([&] { |
| 1157 | adapter = nullptr; |
| 1158 | finalized.Set(); |
| 1159 | }); |
| 1160 | finalized.Wait(rtc::Event::kForever); |
| 1161 | } |
| 1162 | |
henrika | b7ec057 | 2024-01-09 09:48:52 | [diff] [blame] | 1163 | class ZeroHertzQueueOverloadTest : public ::testing::Test { |
| 1164 | public: |
| 1165 | static constexpr int kMaxFps = 10; |
| 1166 | |
| 1167 | ZeroHertzQueueOverloadTest() { |
| 1168 | Initialize(); |
| 1169 | metrics::Reset(); |
| 1170 | } |
| 1171 | |
| 1172 | void Initialize() { |
| 1173 | adapter_->Initialize(&callback_); |
| 1174 | adapter_->SetZeroHertzModeEnabled( |
| 1175 | FrameCadenceAdapterInterface::ZeroHertzModeParams{ |
| 1176 | /*num_simulcast_layers=*/1}); |
| 1177 | adapter_->OnConstraintsChanged( |
| 1178 | VideoTrackSourceConstraints{/*min_fps=*/0, kMaxFps}); |
| 1179 | time_controller_.AdvanceTime(TimeDelta::Zero()); |
| 1180 | } |
| 1181 | |
| 1182 | void ScheduleDelayed(TimeDelta delay, absl::AnyInvocable<void() &&> task) { |
| 1183 | TaskQueueBase::Current()->PostDelayedTask(std::move(task), delay); |
| 1184 | } |
| 1185 | |
| 1186 | void PassFrame() { adapter_->OnFrame(CreateFrame()); } |
| 1187 | |
| 1188 | void AdvanceTime(TimeDelta duration) { |
| 1189 | time_controller_.AdvanceTime(duration); |
| 1190 | } |
| 1191 | |
| 1192 | void SkipForwardBy(TimeDelta duration) { |
| 1193 | time_controller_.SkipForwardBy(duration); |
| 1194 | } |
| 1195 | |
| 1196 | Timestamp CurrentTime() { return time_controller_.GetClock()->CurrentTime(); } |
| 1197 | |
| 1198 | protected: |
| 1199 | test::ScopedKeyValueConfig field_trials_; |
| 1200 | NiceMock<MockCallback> callback_; |
| 1201 | GlobalSimulatedTimeController time_controller_{Timestamp::Zero()}; |
| 1202 | std::unique_ptr<FrameCadenceAdapterInterface> adapter_{ |
| 1203 | CreateAdapter(field_trials_, time_controller_.GetClock())}; |
| 1204 | }; |
| 1205 | |
| 1206 | TEST_F(ZeroHertzQueueOverloadTest, |
| 1207 | ForwardedFramesDuringTooLongEncodeTimeAreFlaggedWithQueueOverload) { |
| 1208 | InSequence s; |
| 1209 | PassFrame(); |
| 1210 | EXPECT_CALL(callback_, OnFrame(_, false, _)).WillOnce(InvokeWithoutArgs([&] { |
| 1211 | PassFrame(); |
| 1212 | PassFrame(); |
| 1213 | PassFrame(); |
| 1214 | SkipForwardBy(TimeDelta::Millis(301)); |
| 1215 | })); |
| 1216 | EXPECT_CALL(callback_, OnFrame(_, true, _)).Times(3); |
| 1217 | AdvanceTime(TimeDelta::Millis(100)); |
| 1218 | EXPECT_THAT(metrics::Samples("WebRTC.Screenshare.ZeroHz.QueueOverload"), |
| 1219 | ElementsAre(Pair(false, 1), Pair(true, 3))); |
| 1220 | } |
| 1221 | |
| 1222 | TEST_F(ZeroHertzQueueOverloadTest, |
| 1223 | ForwardedFramesAfterOverloadBurstAreNotFlaggedWithQueueOverload) { |
| 1224 | InSequence s; |
| 1225 | PassFrame(); |
| 1226 | EXPECT_CALL(callback_, OnFrame(_, false, _)).WillOnce(InvokeWithoutArgs([&] { |
| 1227 | PassFrame(); |
| 1228 | PassFrame(); |
| 1229 | PassFrame(); |
| 1230 | SkipForwardBy(TimeDelta::Millis(301)); |
| 1231 | })); |
| 1232 | EXPECT_CALL(callback_, OnFrame(_, true, _)).Times(3); |
| 1233 | AdvanceTime(TimeDelta::Millis(100)); |
| 1234 | EXPECT_CALL(callback_, OnFrame(_, false, _)).Times(2); |
| 1235 | PassFrame(); |
| 1236 | PassFrame(); |
| 1237 | AdvanceTime(TimeDelta::Millis(100)); |
| 1238 | EXPECT_THAT(metrics::Samples("WebRTC.Screenshare.ZeroHz.QueueOverload"), |
| 1239 | ElementsAre(Pair(false, 3), Pair(true, 3))); |
| 1240 | } |
| 1241 | |
| 1242 | TEST_F(ZeroHertzQueueOverloadTest, |
| 1243 | ForwardedFramesDuringNormalEncodeTimeAreNotFlaggedWithQueueOverload) { |
| 1244 | InSequence s; |
| 1245 | PassFrame(); |
| 1246 | EXPECT_CALL(callback_, OnFrame(_, false, _)).WillOnce(InvokeWithoutArgs([&] { |
| 1247 | PassFrame(); |
| 1248 | PassFrame(); |
| 1249 | PassFrame(); |
| 1250 | // Long but not too long encode time. |
| 1251 | SkipForwardBy(TimeDelta::Millis(99)); |
| 1252 | })); |
| 1253 | EXPECT_CALL(callback_, OnFrame(_, false, _)).Times(3); |
| 1254 | AdvanceTime(TimeDelta::Millis(199)); |
| 1255 | EXPECT_THAT(metrics::Samples("WebRTC.Screenshare.ZeroHz.QueueOverload"), |
| 1256 | ElementsAre(Pair(false, 4))); |
| 1257 | } |
| 1258 | |
| 1259 | TEST_F( |
| 1260 | ZeroHertzQueueOverloadTest, |
| 1261 | AvoidSettingQueueOverloadAndSendRepeatWhenNoNewPacketsWhileTooLongEncode) { |
| 1262 | // Receive one frame only and let OnFrame take such a long time that an |
| 1263 | // overload normally is warranted. But the fact that no new frames arrive |
| 1264 | // while being blocked should trigger a non-idle repeat to ensure that the |
| 1265 | // video stream does not freeze and queue overload should be false. |
| 1266 | PassFrame(); |
| 1267 | EXPECT_CALL(callback_, OnFrame(_, false, _)) |
| 1268 | .WillOnce( |
| 1269 | InvokeWithoutArgs([&] { SkipForwardBy(TimeDelta::Millis(101)); })) |
| 1270 | .WillOnce(InvokeWithoutArgs([&] { |
| 1271 | // Non-idle repeat. |
| 1272 | EXPECT_EQ(CurrentTime(), Timestamp::Zero() + TimeDelta::Millis(201)); |
| 1273 | })); |
| 1274 | AdvanceTime(TimeDelta::Millis(100)); |
| 1275 | EXPECT_THAT(metrics::Samples("WebRTC.Screenshare.ZeroHz.QueueOverload"), |
| 1276 | ElementsAre(Pair(false, 2))); |
| 1277 | } |
| 1278 | |
| 1279 | TEST_F(ZeroHertzQueueOverloadTest, |
| 1280 | EnterFastRepeatAfterQueueOverloadWhenReceivedOnlyOneFrameDuringEncode) { |
| 1281 | InSequence s; |
| 1282 | // - Forward one frame frame during high load which triggers queue overload. |
| 1283 | // - Receive only one new frame while being blocked and verify that the |
| 1284 | // cancelled repeat was for the first frame and not the second. |
| 1285 | // - Fast repeat mode should happen after second frame. |
| 1286 | PassFrame(); |
| 1287 | EXPECT_CALL(callback_, OnFrame(_, false, _)).WillOnce(InvokeWithoutArgs([&] { |
| 1288 | PassFrame(); |
| 1289 | SkipForwardBy(TimeDelta::Millis(101)); |
| 1290 | })); |
| 1291 | EXPECT_CALL(callback_, OnFrame(_, true, _)); |
| 1292 | AdvanceTime(TimeDelta::Millis(100)); |
| 1293 | |
| 1294 | // Fast repeats should take place from here on. |
| 1295 | EXPECT_CALL(callback_, OnFrame(_, false, _)).Times(5); |
| 1296 | AdvanceTime(TimeDelta::Millis(500)); |
| 1297 | EXPECT_THAT(metrics::Samples("WebRTC.Screenshare.ZeroHz.QueueOverload"), |
| 1298 | ElementsAre(Pair(false, 6), Pair(true, 1))); |
| 1299 | } |
| 1300 | |
| 1301 | TEST_F(ZeroHertzQueueOverloadTest, |
| 1302 | QueueOverloadIsDisabledForZeroHerzWhenKillSwitchIsEnabled) { |
| 1303 | webrtc::test::ScopedKeyValueConfig field_trials( |
| 1304 | field_trials_, "WebRTC-ZeroHertzQueueOverload/Disabled/"); |
| 1305 | adapter_.reset(); |
| 1306 | adapter_ = CreateAdapter(field_trials, time_controller_.GetClock()); |
| 1307 | Initialize(); |
| 1308 | |
| 1309 | // Same as ForwardedFramesDuringTooLongEncodeTimeAreFlaggedWithQueueOverload |
| 1310 | // but this time the queue overload mechanism is disabled. |
| 1311 | InSequence s; |
| 1312 | PassFrame(); |
| 1313 | EXPECT_CALL(callback_, OnFrame(_, false, _)).WillOnce(InvokeWithoutArgs([&] { |
| 1314 | PassFrame(); |
| 1315 | PassFrame(); |
| 1316 | PassFrame(); |
| 1317 | SkipForwardBy(TimeDelta::Millis(301)); |
| 1318 | })); |
| 1319 | EXPECT_CALL(callback_, OnFrame(_, false, _)).Times(3); |
| 1320 | AdvanceTime(TimeDelta::Millis(100)); |
| 1321 | EXPECT_EQ(metrics::NumSamples("WebRTC.Screenshare.ZeroHz.QueueOverload"), 0); |
| 1322 | } |
| 1323 | |
Markus Handell | b4e96d4 | 2021-11-05 11:00:55 | [diff] [blame] | 1324 | } // namespace |
| 1325 | } // namespace webrtc |