mflodman@webrtc.org | 02270cd | 2015-02-06 13:10:19 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
Jonas Olsson | a4d8737 | 2019-07-05 17:08:33 | [diff] [blame] | 11 | #include "call/rtp_video_sender.h" |
| 12 | |
Sebastian Jansson | 3d4d94a | 2020-01-14 13:25:41 | [diff] [blame] | 13 | #include <atomic> |
kwiberg | 27f982b | 2016-03-01 19:52:33 | [diff] [blame] | 14 | #include <memory> |
Åsa Persson | 4bece9a | 2017-10-06 08:04:04 | [diff] [blame] | 15 | #include <string> |
Sebastian Jansson | 3d4d94a | 2020-01-14 13:25:41 | [diff] [blame] | 16 | |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 17 | #include "call/rtp_transport_controller_send.h" |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 18 | #include "modules/rtp_rtcp/include/rtp_rtcp_defines.h" |
| 19 | #include "modules/rtp_rtcp/source/byte_io.h" |
| 20 | #include "modules/rtp_rtcp/source/rtcp_packet/nack.h" |
Danil Chapovalov | 2272f20 | 2020-02-18 11:09:43 | [diff] [blame] | 21 | #include "modules/rtp_rtcp/source/rtp_dependency_descriptor_extension.h" |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 22 | #include "modules/rtp_rtcp/source/rtp_packet.h" |
Stefan Holmer | 64be7fa | 2018-10-04 13:21:55 | [diff] [blame] | 23 | #include "modules/video_coding/fec_controller_default.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 04:47:31 | [diff] [blame] | 24 | #include "modules/video_coding/include/video_codec_interface.h" |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 25 | #include "rtc_base/rate_limiter.h" |
Åsa Persson | 4bece9a | 2017-10-06 08:04:04 | [diff] [blame] | 26 | #include "test/field_trial.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 04:47:31 | [diff] [blame] | 27 | #include "test/gmock.h" |
| 28 | #include "test/gtest.h" |
Marina Ciocea | 1148fd5 | 2020-04-29 20:39:13 | [diff] [blame] | 29 | #include "test/mock_frame_transformer.h" |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 30 | #include "test/mock_transport.h" |
Sebastian Jansson | 3d4d94a | 2020-01-14 13:25:41 | [diff] [blame] | 31 | #include "test/scenario/scenario.h" |
Erik Språng | 00cc836 | 2019-11-25 11:21:46 | [diff] [blame] | 32 | #include "test/time_controller/simulated_time_controller.h" |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 33 | #include "video/send_delay_stats.h" |
| 34 | #include "video/send_statistics_proxy.h" |
mflodman@webrtc.org | 02270cd | 2015-02-06 13:10:19 | [diff] [blame] | 35 | |
| 36 | using ::testing::_; |
mflodman@webrtc.org | 02270cd | 2015-02-06 13:10:19 | [diff] [blame] | 37 | using ::testing::NiceMock; |
Niels Möller | 949f0fd | 2019-01-29 08:44:24 | [diff] [blame] | 38 | using ::testing::SaveArg; |
Danil Chapovalov | 2272f20 | 2020-02-18 11:09:43 | [diff] [blame] | 39 | using ::testing::SizeIs; |
mflodman@webrtc.org | 02270cd | 2015-02-06 13:10:19 | [diff] [blame] | 40 | |
| 41 | namespace webrtc { |
Åsa Persson | 4bece9a | 2017-10-06 08:04:04 | [diff] [blame] | 42 | namespace { |
| 43 | const int8_t kPayloadType = 96; |
| 44 | const uint32_t kSsrc1 = 12345; |
| 45 | const uint32_t kSsrc2 = 23456; |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 46 | const uint32_t kRtxSsrc1 = 34567; |
| 47 | const uint32_t kRtxSsrc2 = 45678; |
Åsa Persson | 4bece9a | 2017-10-06 08:04:04 | [diff] [blame] | 48 | const int16_t kInitialPictureId1 = 222; |
| 49 | const int16_t kInitialPictureId2 = 44; |
Niels Möller | bb894ff | 2018-03-15 11:28:53 | [diff] [blame] | 50 | const int16_t kInitialTl0PicIdx1 = 99; |
| 51 | const int16_t kInitialTl0PicIdx2 = 199; |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 52 | const int64_t kRetransmitWindowSizeMs = 500; |
Erik Språng | 845c6aa | 2019-05-29 11:02:24 | [diff] [blame] | 53 | const int kTransportsSequenceExtensionId = 7; |
Danil Chapovalov | 2272f20 | 2020-02-18 11:09:43 | [diff] [blame] | 54 | const int kDependencyDescriptorExtensionId = 8; |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 55 | |
| 56 | class MockRtcpIntraFrameObserver : public RtcpIntraFrameObserver { |
| 57 | public: |
Danil Chapovalov | 9a5efe9 | 2020-05-14 20:06:18 | [diff] [blame] | 58 | MOCK_METHOD(void, OnReceivedIntraFrameRequest, (uint32_t), (override)); |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 59 | }; |
| 60 | |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 61 | RtpSenderObservers CreateObservers( |
| 62 | RtcpRttStats* rtcp_rtt_stats, |
| 63 | RtcpIntraFrameObserver* intra_frame_callback, |
Henrik Boström | 87e3f9d | 2019-05-27 08:44:24 | [diff] [blame] | 64 | ReportBlockDataObserver* report_block_data_observer, |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 65 | StreamDataCountersCallback* rtp_stats, |
| 66 | BitrateStatisticsObserver* bitrate_observer, |
| 67 | FrameCountObserver* frame_count_observer, |
| 68 | RtcpPacketTypeCounterObserver* rtcp_type_observer, |
| 69 | SendSideDelayObserver* send_delay_observer, |
Stefan Holmer | 64be7fa | 2018-10-04 13:21:55 | [diff] [blame] | 70 | SendPacketObserver* send_packet_observer) { |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 71 | RtpSenderObservers observers; |
| 72 | observers.rtcp_rtt_stats = rtcp_rtt_stats; |
| 73 | observers.intra_frame_callback = intra_frame_callback; |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 74 | observers.rtcp_loss_notification_observer = nullptr; |
Henrik Boström | 87e3f9d | 2019-05-27 08:44:24 | [diff] [blame] | 75 | observers.report_block_data_observer = report_block_data_observer; |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 76 | observers.rtp_stats = rtp_stats; |
| 77 | observers.bitrate_observer = bitrate_observer; |
| 78 | observers.frame_count_observer = frame_count_observer; |
| 79 | observers.rtcp_type_observer = rtcp_type_observer; |
| 80 | observers.send_delay_observer = send_delay_observer; |
| 81 | observers.send_packet_observer = send_packet_observer; |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 82 | return observers; |
| 83 | } |
| 84 | |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 85 | BitrateConstraints GetBitrateConfig() { |
| 86 | BitrateConstraints bitrate_config; |
| 87 | bitrate_config.min_bitrate_bps = 30000; |
| 88 | bitrate_config.start_bitrate_bps = 300000; |
| 89 | bitrate_config.max_bitrate_bps = 3000000; |
| 90 | return bitrate_config; |
| 91 | } |
| 92 | |
| 93 | VideoSendStream::Config CreateVideoSendStreamConfig( |
| 94 | Transport* transport, |
| 95 | const std::vector<uint32_t>& ssrcs, |
| 96 | const std::vector<uint32_t>& rtx_ssrcs, |
| 97 | int payload_type) { |
| 98 | VideoSendStream::Config config(transport); |
| 99 | config.rtp.ssrcs = ssrcs; |
| 100 | config.rtp.rtx.ssrcs = rtx_ssrcs; |
| 101 | config.rtp.payload_type = payload_type; |
| 102 | config.rtp.rtx.payload_type = payload_type + 1; |
| 103 | config.rtp.nack.rtp_history_ms = 1000; |
Erik Språng | 845c6aa | 2019-05-29 11:02:24 | [diff] [blame] | 104 | config.rtp.extensions.emplace_back(RtpExtension::kTransportSequenceNumberUri, |
| 105 | kTransportsSequenceExtensionId); |
Danil Chapovalov | d0321c5 | 2021-09-14 10:58:51 | [diff] [blame] | 106 | config.rtp.extensions.emplace_back(RtpDependencyDescriptorExtension::Uri(), |
Danil Chapovalov | 2272f20 | 2020-02-18 11:09:43 | [diff] [blame] | 107 | kDependencyDescriptorExtensionId); |
Danil Chapovalov | 748550d | 2021-04-29 09:42:54 | [diff] [blame] | 108 | config.rtp.extmap_allow_mixed = true; |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 109 | return config; |
| 110 | } |
| 111 | |
Stefan Holmer | 9416ef8 | 2018-07-19 08:34:38 | [diff] [blame] | 112 | class RtpVideoSenderTestFixture { |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 113 | public: |
Stefan Holmer | 9416ef8 | 2018-07-19 08:34:38 | [diff] [blame] | 114 | RtpVideoSenderTestFixture( |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 115 | const std::vector<uint32_t>& ssrcs, |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 116 | const std::vector<uint32_t>& rtx_ssrcs, |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 117 | int payload_type, |
Niels Möller | 949f0fd | 2019-01-29 08:44:24 | [diff] [blame] | 118 | const std::map<uint32_t, RtpPayloadState>& suspended_payload_states, |
Marina Ciocea | dc69fd2 | 2020-04-10 18:19:14 | [diff] [blame] | 119 | FrameCountObserver* frame_count_observer, |
| 120 | rtc::scoped_refptr<FrameTransformerInterface> frame_transformer) |
Danil Chapovalov | 0c626af | 2020-02-10 10:16:00 | [diff] [blame] | 121 | : time_controller_(Timestamp::Millis(1000000)), |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 122 | config_(CreateVideoSendStreamConfig(&transport_, |
| 123 | ssrcs, |
| 124 | rtx_ssrcs, |
| 125 | payload_type)), |
Erik Språng | 00cc836 | 2019-11-25 11:21:46 | [diff] [blame] | 126 | send_delay_stats_(time_controller_.GetClock()), |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 127 | bitrate_config_(GetBitrateConfig()), |
Danil Chapovalov | a68eb8c | 2020-02-17 15:13:14 | [diff] [blame] | 128 | transport_controller_( |
| 129 | time_controller_.GetClock(), |
| 130 | &event_log_, |
| 131 | nullptr, |
| 132 | nullptr, |
| 133 | bitrate_config_, |
| 134 | time_controller_.CreateProcessThread("PacerThread"), |
| 135 | time_controller_.GetTaskQueueFactory(), |
| 136 | &field_trials_), |
Erik Språng | 00cc836 | 2019-11-25 11:21:46 | [diff] [blame] | 137 | stats_proxy_(time_controller_.GetClock(), |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 138 | config_, |
| 139 | VideoEncoderConfig::ContentType::kRealtimeVideo), |
Erik Språng | 00cc836 | 2019-11-25 11:21:46 | [diff] [blame] | 140 | retransmission_rate_limiter_(time_controller_.GetClock(), |
| 141 | kRetransmitWindowSizeMs) { |
Erik Språng | 7703f23 | 2020-09-14 09:03:13 | [diff] [blame] | 142 | transport_controller_.EnsureStarted(); |
Mirko Bonadei | f18f920 | 2019-12-10 13:24:56 | [diff] [blame] | 143 | std::map<uint32_t, RtpState> suspended_ssrcs; |
| 144 | router_ = std::make_unique<RtpVideoSender>( |
| 145 | time_controller_.GetClock(), suspended_ssrcs, suspended_payload_states, |
| 146 | config_.rtp, config_.rtcp_report_interval_ms, &transport_, |
Niels Möller | 98d9c30 | 2020-12-16 10:53:09 | [diff] [blame] | 147 | CreateObservers(nullptr, &encoder_feedback_, &stats_proxy_, |
Danil Chapovalov | f01c2c9 | 2021-05-14 13:39:23 | [diff] [blame] | 148 | &stats_proxy_, &stats_proxy_, frame_count_observer, |
| 149 | &stats_proxy_, &stats_proxy_, &send_delay_stats_), |
Mirko Bonadei | f18f920 | 2019-12-10 13:24:56 | [diff] [blame] | 150 | &transport_controller_, &event_log_, &retransmission_rate_limiter_, |
| 151 | std::make_unique<FecControllerDefault>(time_controller_.GetClock()), |
Marina Ciocea | dc69fd2 | 2020-04-10 18:19:14 | [diff] [blame] | 152 | nullptr, CryptoOptions{}, frame_transformer); |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 153 | } |
Marina Ciocea | dc69fd2 | 2020-04-10 18:19:14 | [diff] [blame] | 154 | |
| 155 | RtpVideoSenderTestFixture( |
| 156 | const std::vector<uint32_t>& ssrcs, |
| 157 | const std::vector<uint32_t>& rtx_ssrcs, |
| 158 | int payload_type, |
| 159 | const std::map<uint32_t, RtpPayloadState>& suspended_payload_states, |
| 160 | FrameCountObserver* frame_count_observer) |
| 161 | : RtpVideoSenderTestFixture(ssrcs, |
| 162 | rtx_ssrcs, |
| 163 | payload_type, |
| 164 | suspended_payload_states, |
| 165 | frame_count_observer, |
| 166 | /*frame_transformer=*/nullptr) {} |
| 167 | |
Niels Möller | 949f0fd | 2019-01-29 08:44:24 | [diff] [blame] | 168 | RtpVideoSenderTestFixture( |
| 169 | const std::vector<uint32_t>& ssrcs, |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 170 | const std::vector<uint32_t>& rtx_ssrcs, |
Niels Möller | 949f0fd | 2019-01-29 08:44:24 | [diff] [blame] | 171 | int payload_type, |
| 172 | const std::map<uint32_t, RtpPayloadState>& suspended_payload_states) |
| 173 | : RtpVideoSenderTestFixture(ssrcs, |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 174 | rtx_ssrcs, |
Niels Möller | 949f0fd | 2019-01-29 08:44:24 | [diff] [blame] | 175 | payload_type, |
| 176 | suspended_payload_states, |
Marina Ciocea | dc69fd2 | 2020-04-10 18:19:14 | [diff] [blame] | 177 | /*frame_count_observer=*/nullptr, |
| 178 | /*frame_transformer=*/nullptr) {} |
Mirko Bonadei | f18f920 | 2019-12-10 13:24:56 | [diff] [blame] | 179 | |
Stefan Holmer | 9416ef8 | 2018-07-19 08:34:38 | [diff] [blame] | 180 | RtpVideoSender* router() { return router_.get(); } |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 181 | MockTransport& transport() { return transport_; } |
Markus Handell | 486cc55 | 2019-12-03 13:37:28 | [diff] [blame] | 182 | void AdvanceTime(TimeDelta delta) { time_controller_.AdvanceTime(delta); } |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 183 | |
| 184 | private: |
| 185 | NiceMock<MockTransport> transport_; |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 186 | NiceMock<MockRtcpIntraFrameObserver> encoder_feedback_; |
Erik Språng | 00cc836 | 2019-11-25 11:21:46 | [diff] [blame] | 187 | GlobalSimulatedTimeController time_controller_; |
Danil Chapovalov | 83bbe91 | 2019-08-07 10:24:53 | [diff] [blame] | 188 | RtcEventLogNull event_log_; |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 189 | VideoSendStream::Config config_; |
| 190 | SendDelayStats send_delay_stats_; |
| 191 | BitrateConstraints bitrate_config_; |
Erik Språng | 662678d | 2019-11-15 16:18:52 | [diff] [blame] | 192 | const FieldTrialBasedConfig field_trials_; |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 193 | RtpTransportControllerSend transport_controller_; |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 194 | SendStatisticsProxy stats_proxy_; |
| 195 | RateLimiter retransmission_rate_limiter_; |
Stefan Holmer | 9416ef8 | 2018-07-19 08:34:38 | [diff] [blame] | 196 | std::unique_ptr<RtpVideoSender> router_; |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 197 | }; |
Jakob Ivarsson | 9a12ee5 | 2020-11-26 15:04:18 | [diff] [blame] | 198 | |
| 199 | BitrateAllocationUpdate CreateBitrateAllocationUpdate(int target_bitrate_bps) { |
| 200 | BitrateAllocationUpdate update; |
| 201 | update.target_bitrate = DataRate::BitsPerSec(target_bitrate_bps); |
| 202 | update.round_trip_time = TimeDelta::Zero(); |
| 203 | return update; |
| 204 | } |
| 205 | |
Åsa Persson | 4bece9a | 2017-10-06 08:04:04 | [diff] [blame] | 206 | } // namespace |
mflodman@webrtc.org | 02270cd | 2015-02-06 13:10:19 | [diff] [blame] | 207 | |
Sebastian Jansson | 6347029 | 2019-02-01 09:13:43 | [diff] [blame] | 208 | TEST(RtpVideoSenderTest, SendOnOneModule) { |
Niels Möller | 663844d | 2019-02-14 15:15:54 | [diff] [blame] | 209 | constexpr uint8_t kPayload = 'a'; |
kjellander | 02b3d27 | 2016-04-20 12:05:54 | [diff] [blame] | 210 | EncodedImage encoded_image; |
Niels Möller | 2377588 | 2018-08-16 08:24:12 | [diff] [blame] | 211 | encoded_image.SetTimestamp(1); |
kjellander | 02b3d27 | 2016-04-20 12:05:54 | [diff] [blame] | 212 | encoded_image.capture_time_ms_ = 2; |
Niels Möller | 8f7ce22 | 2019-03-21 14:43:58 | [diff] [blame] | 213 | encoded_image._frameType = VideoFrameType::kVideoFrameKey; |
Niels Möller | 4d504c7 | 2019-06-18 13:56:56 | [diff] [blame] | 214 | encoded_image.SetEncodedData(EncodedImageBuffer::Create(&kPayload, 1)); |
kjellander | 02b3d27 | 2016-04-20 12:05:54 | [diff] [blame] | 215 | |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 216 | RtpVideoSenderTestFixture test({kSsrc1}, {kRtxSsrc1}, kPayloadType, {}); |
Danil Chapovalov | 383f2cf | 2020-08-12 09:06:53 | [diff] [blame] | 217 | EXPECT_NE(EncodedImageCallback::Result::OK, |
| 218 | test.router()->OnEncodedImage(encoded_image, nullptr).error); |
mflodman@webrtc.org | 02270cd | 2015-02-06 13:10:19 | [diff] [blame] | 219 | |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 220 | test.router()->SetActive(true); |
Danil Chapovalov | 383f2cf | 2020-08-12 09:06:53 | [diff] [blame] | 221 | EXPECT_EQ(EncodedImageCallback::Result::OK, |
| 222 | test.router()->OnEncodedImage(encoded_image, nullptr).error); |
mflodman@webrtc.org | 02270cd | 2015-02-06 13:10:19 | [diff] [blame] | 223 | |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 224 | test.router()->SetActive(false); |
Danil Chapovalov | 383f2cf | 2020-08-12 09:06:53 | [diff] [blame] | 225 | EXPECT_NE(EncodedImageCallback::Result::OK, |
| 226 | test.router()->OnEncodedImage(encoded_image, nullptr).error); |
mflodman@webrtc.org | 02270cd | 2015-02-06 13:10:19 | [diff] [blame] | 227 | |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 228 | test.router()->SetActive(true); |
Danil Chapovalov | 383f2cf | 2020-08-12 09:06:53 | [diff] [blame] | 229 | EXPECT_EQ(EncodedImageCallback::Result::OK, |
| 230 | test.router()->OnEncodedImage(encoded_image, nullptr).error); |
mflodman@webrtc.org | 02270cd | 2015-02-06 13:10:19 | [diff] [blame] | 231 | } |
| 232 | |
Sebastian Jansson | 6347029 | 2019-02-01 09:13:43 | [diff] [blame] | 233 | TEST(RtpVideoSenderTest, SendSimulcastSetActive) { |
Niels Möller | 663844d | 2019-02-14 15:15:54 | [diff] [blame] | 234 | constexpr uint8_t kPayload = 'a'; |
Niels Möller | d3b8c63 | 2018-08-27 13:33:42 | [diff] [blame] | 235 | EncodedImage encoded_image_1; |
| 236 | encoded_image_1.SetTimestamp(1); |
| 237 | encoded_image_1.capture_time_ms_ = 2; |
Niels Möller | 8f7ce22 | 2019-03-21 14:43:58 | [diff] [blame] | 238 | encoded_image_1._frameType = VideoFrameType::kVideoFrameKey; |
Niels Möller | 4d504c7 | 2019-06-18 13:56:56 | [diff] [blame] | 239 | encoded_image_1.SetEncodedData(EncodedImageBuffer::Create(&kPayload, 1)); |
kjellander | 02b3d27 | 2016-04-20 12:05:54 | [diff] [blame] | 240 | |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 241 | RtpVideoSenderTestFixture test({kSsrc1, kSsrc2}, {kRtxSsrc1, kRtxSsrc2}, |
| 242 | kPayloadType, {}); |
mflodman@webrtc.org | 02270cd | 2015-02-06 13:10:19 | [diff] [blame] | 243 | |
Niels Möller | d3b8c63 | 2018-08-27 13:33:42 | [diff] [blame] | 244 | CodecSpecificInfo codec_info; |
Niels Möller | d3b8c63 | 2018-08-27 13:33:42 | [diff] [blame] | 245 | codec_info.codecType = kVideoCodecVP8; |
mflodman@webrtc.org | 02270cd | 2015-02-06 13:10:19 | [diff] [blame] | 246 | |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 247 | test.router()->SetActive(true); |
sergeyu | 2cb155a | 2016-11-04 18:39:29 | [diff] [blame] | 248 | EXPECT_EQ(EncodedImageCallback::Result::OK, |
Danil Chapovalov | 383f2cf | 2020-08-12 09:06:53 | [diff] [blame] | 249 | test.router()->OnEncodedImage(encoded_image_1, &codec_info).error); |
mflodman@webrtc.org | 02270cd | 2015-02-06 13:10:19 | [diff] [blame] | 250 | |
Niels Möller | d3b8c63 | 2018-08-27 13:33:42 | [diff] [blame] | 251 | EncodedImage encoded_image_2(encoded_image_1); |
| 252 | encoded_image_2.SetSpatialIndex(1); |
sergeyu | 2cb155a | 2016-11-04 18:39:29 | [diff] [blame] | 253 | EXPECT_EQ(EncodedImageCallback::Result::OK, |
Danil Chapovalov | 383f2cf | 2020-08-12 09:06:53 | [diff] [blame] | 254 | test.router()->OnEncodedImage(encoded_image_2, &codec_info).error); |
mflodman@webrtc.org | 02270cd | 2015-02-06 13:10:19 | [diff] [blame] | 255 | |
mflodman@webrtc.org | 50e2816 | 2015-02-23 07:45:11 | [diff] [blame] | 256 | // Inactive. |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 257 | test.router()->SetActive(false); |
sergeyu | 2cb155a | 2016-11-04 18:39:29 | [diff] [blame] | 258 | EXPECT_NE(EncodedImageCallback::Result::OK, |
Danil Chapovalov | 383f2cf | 2020-08-12 09:06:53 | [diff] [blame] | 259 | test.router()->OnEncodedImage(encoded_image_1, &codec_info).error); |
sergeyu | 2cb155a | 2016-11-04 18:39:29 | [diff] [blame] | 260 | EXPECT_NE(EncodedImageCallback::Result::OK, |
Danil Chapovalov | 383f2cf | 2020-08-12 09:06:53 | [diff] [blame] | 261 | test.router()->OnEncodedImage(encoded_image_2, &codec_info).error); |
mflodman@webrtc.org | 02270cd | 2015-02-06 13:10:19 | [diff] [blame] | 262 | } |
| 263 | |
Seth Hampson | cc7125f | 2018-02-02 16:46:16 | [diff] [blame] | 264 | // Tests how setting individual rtp modules to active affects the overall |
| 265 | // behavior of the payload router. First sets one module to active and checks |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 266 | // that outgoing data can be sent on this module, and checks that no data can |
| 267 | // be sent if both modules are inactive. |
Sebastian Jansson | 6347029 | 2019-02-01 09:13:43 | [diff] [blame] | 268 | TEST(RtpVideoSenderTest, SendSimulcastSetActiveModules) { |
Niels Möller | 663844d | 2019-02-14 15:15:54 | [diff] [blame] | 269 | constexpr uint8_t kPayload = 'a'; |
Niels Möller | d3b8c63 | 2018-08-27 13:33:42 | [diff] [blame] | 270 | EncodedImage encoded_image_1; |
| 271 | encoded_image_1.SetTimestamp(1); |
| 272 | encoded_image_1.capture_time_ms_ = 2; |
Niels Möller | 8f7ce22 | 2019-03-21 14:43:58 | [diff] [blame] | 273 | encoded_image_1._frameType = VideoFrameType::kVideoFrameKey; |
Niels Möller | 4d504c7 | 2019-06-18 13:56:56 | [diff] [blame] | 274 | encoded_image_1.SetEncodedData(EncodedImageBuffer::Create(&kPayload, 1)); |
Niels Möller | 77536a2 | 2019-01-15 07:50:01 | [diff] [blame] | 275 | |
Niels Möller | d3b8c63 | 2018-08-27 13:33:42 | [diff] [blame] | 276 | EncodedImage encoded_image_2(encoded_image_1); |
| 277 | encoded_image_2.SetSpatialIndex(1); |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 278 | |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 279 | RtpVideoSenderTestFixture test({kSsrc1, kSsrc2}, {kRtxSsrc1, kRtxSsrc2}, |
| 280 | kPayloadType, {}); |
Niels Möller | d3b8c63 | 2018-08-27 13:33:42 | [diff] [blame] | 281 | CodecSpecificInfo codec_info; |
Niels Möller | d3b8c63 | 2018-08-27 13:33:42 | [diff] [blame] | 282 | codec_info.codecType = kVideoCodecVP8; |
Seth Hampson | cc7125f | 2018-02-02 16:46:16 | [diff] [blame] | 283 | |
| 284 | // Only setting one stream to active will still set the payload router to |
| 285 | // active and allow sending data on the active stream. |
| 286 | std::vector<bool> active_modules({true, false}); |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 287 | test.router()->SetActiveModules(active_modules); |
Seth Hampson | cc7125f | 2018-02-02 16:46:16 | [diff] [blame] | 288 | EXPECT_EQ(EncodedImageCallback::Result::OK, |
Danil Chapovalov | 383f2cf | 2020-08-12 09:06:53 | [diff] [blame] | 289 | test.router()->OnEncodedImage(encoded_image_1, &codec_info).error); |
Seth Hampson | cc7125f | 2018-02-02 16:46:16 | [diff] [blame] | 290 | |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 291 | // Setting both streams to inactive will turn the payload router to |
| 292 | // inactive. |
Seth Hampson | cc7125f | 2018-02-02 16:46:16 | [diff] [blame] | 293 | active_modules = {false, false}; |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 294 | test.router()->SetActiveModules(active_modules); |
Seth Hampson | cc7125f | 2018-02-02 16:46:16 | [diff] [blame] | 295 | // An incoming encoded image will not ask the module to send outgoing data |
| 296 | // because the payload router is inactive. |
Seth Hampson | cc7125f | 2018-02-02 16:46:16 | [diff] [blame] | 297 | EXPECT_NE(EncodedImageCallback::Result::OK, |
Danil Chapovalov | 383f2cf | 2020-08-12 09:06:53 | [diff] [blame] | 298 | test.router()->OnEncodedImage(encoded_image_1, &codec_info).error); |
Seth Hampson | cc7125f | 2018-02-02 16:46:16 | [diff] [blame] | 299 | EXPECT_NE(EncodedImageCallback::Result::OK, |
Danil Chapovalov | 383f2cf | 2020-08-12 09:06:53 | [diff] [blame] | 300 | test.router()->OnEncodedImage(encoded_image_1, &codec_info).error); |
Seth Hampson | cc7125f | 2018-02-02 16:46:16 | [diff] [blame] | 301 | } |
| 302 | |
Sebastian Jansson | 6347029 | 2019-02-01 09:13:43 | [diff] [blame] | 303 | TEST(RtpVideoSenderTest, CreateWithNoPreviousStates) { |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 304 | RtpVideoSenderTestFixture test({kSsrc1, kSsrc2}, {kRtxSsrc1, kRtxSsrc2}, |
| 305 | kPayloadType, {}); |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 306 | test.router()->SetActive(true); |
Åsa Persson | 4bece9a | 2017-10-06 08:04:04 | [diff] [blame] | 307 | |
| 308 | std::map<uint32_t, RtpPayloadState> initial_states = |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 309 | test.router()->GetRtpPayloadStates(); |
Åsa Persson | 4bece9a | 2017-10-06 08:04:04 | [diff] [blame] | 310 | EXPECT_EQ(2u, initial_states.size()); |
| 311 | EXPECT_NE(initial_states.find(kSsrc1), initial_states.end()); |
| 312 | EXPECT_NE(initial_states.find(kSsrc2), initial_states.end()); |
| 313 | } |
| 314 | |
Sebastian Jansson | 6347029 | 2019-02-01 09:13:43 | [diff] [blame] | 315 | TEST(RtpVideoSenderTest, CreateWithPreviousStates) { |
philipel | 25d31ec | 2018-08-08 14:33:01 | [diff] [blame] | 316 | const int64_t kState1SharedFrameId = 123; |
| 317 | const int64_t kState2SharedFrameId = 234; |
Åsa Persson | 4bece9a | 2017-10-06 08:04:04 | [diff] [blame] | 318 | RtpPayloadState state1; |
| 319 | state1.picture_id = kInitialPictureId1; |
Niels Möller | bb894ff | 2018-03-15 11:28:53 | [diff] [blame] | 320 | state1.tl0_pic_idx = kInitialTl0PicIdx1; |
philipel | 25d31ec | 2018-08-08 14:33:01 | [diff] [blame] | 321 | state1.shared_frame_id = kState1SharedFrameId; |
Åsa Persson | 4bece9a | 2017-10-06 08:04:04 | [diff] [blame] | 322 | RtpPayloadState state2; |
| 323 | state2.picture_id = kInitialPictureId2; |
Niels Möller | bb894ff | 2018-03-15 11:28:53 | [diff] [blame] | 324 | state2.tl0_pic_idx = kInitialTl0PicIdx2; |
philipel | 25d31ec | 2018-08-08 14:33:01 | [diff] [blame] | 325 | state2.shared_frame_id = kState2SharedFrameId; |
Åsa Persson | 4bece9a | 2017-10-06 08:04:04 | [diff] [blame] | 326 | std::map<uint32_t, RtpPayloadState> states = {{kSsrc1, state1}, |
| 327 | {kSsrc2, state2}}; |
| 328 | |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 329 | RtpVideoSenderTestFixture test({kSsrc1, kSsrc2}, {kRtxSsrc1, kRtxSsrc2}, |
| 330 | kPayloadType, states); |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 331 | test.router()->SetActive(true); |
Åsa Persson | 4bece9a | 2017-10-06 08:04:04 | [diff] [blame] | 332 | |
| 333 | std::map<uint32_t, RtpPayloadState> initial_states = |
Stefan Holmer | dbdb3a0 | 2018-07-17 14:03:46 | [diff] [blame] | 334 | test.router()->GetRtpPayloadStates(); |
Åsa Persson | 4bece9a | 2017-10-06 08:04:04 | [diff] [blame] | 335 | EXPECT_EQ(2u, initial_states.size()); |
| 336 | EXPECT_EQ(kInitialPictureId1, initial_states[kSsrc1].picture_id); |
Niels Möller | bb894ff | 2018-03-15 11:28:53 | [diff] [blame] | 337 | EXPECT_EQ(kInitialTl0PicIdx1, initial_states[kSsrc1].tl0_pic_idx); |
Åsa Persson | 4bece9a | 2017-10-06 08:04:04 | [diff] [blame] | 338 | EXPECT_EQ(kInitialPictureId2, initial_states[kSsrc2].picture_id); |
Niels Möller | bb894ff | 2018-03-15 11:28:53 | [diff] [blame] | 339 | EXPECT_EQ(kInitialTl0PicIdx2, initial_states[kSsrc2].tl0_pic_idx); |
philipel | 25d31ec | 2018-08-08 14:33:01 | [diff] [blame] | 340 | EXPECT_EQ(kState2SharedFrameId, initial_states[kSsrc1].shared_frame_id); |
| 341 | EXPECT_EQ(kState2SharedFrameId, initial_states[kSsrc2].shared_frame_id); |
Åsa Persson | 4bece9a | 2017-10-06 08:04:04 | [diff] [blame] | 342 | } |
Niels Möller | 949f0fd | 2019-01-29 08:44:24 | [diff] [blame] | 343 | |
Sebastian Jansson | 6347029 | 2019-02-01 09:13:43 | [diff] [blame] | 344 | TEST(RtpVideoSenderTest, FrameCountCallbacks) { |
Niels Möller | 949f0fd | 2019-01-29 08:44:24 | [diff] [blame] | 345 | class MockFrameCountObserver : public FrameCountObserver { |
| 346 | public: |
Danil Chapovalov | 9a5efe9 | 2020-05-14 20:06:18 | [diff] [blame] | 347 | MOCK_METHOD(void, |
| 348 | FrameCountUpdated, |
| 349 | (const FrameCounts& frame_counts, uint32_t ssrc), |
| 350 | (override)); |
Niels Möller | 949f0fd | 2019-01-29 08:44:24 | [diff] [blame] | 351 | } callback; |
| 352 | |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 353 | RtpVideoSenderTestFixture test({kSsrc1}, {kRtxSsrc1}, kPayloadType, {}, |
| 354 | &callback); |
Niels Möller | 949f0fd | 2019-01-29 08:44:24 | [diff] [blame] | 355 | |
Niels Möller | 663844d | 2019-02-14 15:15:54 | [diff] [blame] | 356 | constexpr uint8_t kPayload = 'a'; |
Niels Möller | 949f0fd | 2019-01-29 08:44:24 | [diff] [blame] | 357 | EncodedImage encoded_image; |
| 358 | encoded_image.SetTimestamp(1); |
| 359 | encoded_image.capture_time_ms_ = 2; |
Niels Möller | 8f7ce22 | 2019-03-21 14:43:58 | [diff] [blame] | 360 | encoded_image._frameType = VideoFrameType::kVideoFrameKey; |
Niels Möller | 4d504c7 | 2019-06-18 13:56:56 | [diff] [blame] | 361 | encoded_image.SetEncodedData(EncodedImageBuffer::Create(&kPayload, 1)); |
Niels Möller | 949f0fd | 2019-01-29 08:44:24 | [diff] [blame] | 362 | |
Niels Möller | 8f7ce22 | 2019-03-21 14:43:58 | [diff] [blame] | 363 | encoded_image._frameType = VideoFrameType::kVideoFrameKey; |
Niels Möller | 949f0fd | 2019-01-29 08:44:24 | [diff] [blame] | 364 | |
| 365 | // No callbacks when not active. |
| 366 | EXPECT_CALL(callback, FrameCountUpdated).Times(0); |
Danil Chapovalov | 383f2cf | 2020-08-12 09:06:53 | [diff] [blame] | 367 | EXPECT_NE(EncodedImageCallback::Result::OK, |
| 368 | test.router()->OnEncodedImage(encoded_image, nullptr).error); |
Mirko Bonadei | 6a489f2 | 2019-04-09 13:11:12 | [diff] [blame] | 369 | ::testing::Mock::VerifyAndClearExpectations(&callback); |
Niels Möller | 949f0fd | 2019-01-29 08:44:24 | [diff] [blame] | 370 | |
| 371 | test.router()->SetActive(true); |
| 372 | |
| 373 | FrameCounts frame_counts; |
| 374 | EXPECT_CALL(callback, FrameCountUpdated(_, kSsrc1)) |
| 375 | .WillOnce(SaveArg<0>(&frame_counts)); |
Danil Chapovalov | 383f2cf | 2020-08-12 09:06:53 | [diff] [blame] | 376 | EXPECT_EQ(EncodedImageCallback::Result::OK, |
| 377 | test.router()->OnEncodedImage(encoded_image, nullptr).error); |
Niels Möller | 949f0fd | 2019-01-29 08:44:24 | [diff] [blame] | 378 | |
| 379 | EXPECT_EQ(1, frame_counts.key_frames); |
| 380 | EXPECT_EQ(0, frame_counts.delta_frames); |
| 381 | |
Mirko Bonadei | 6a489f2 | 2019-04-09 13:11:12 | [diff] [blame] | 382 | ::testing::Mock::VerifyAndClearExpectations(&callback); |
Niels Möller | 949f0fd | 2019-01-29 08:44:24 | [diff] [blame] | 383 | |
Niels Möller | 8f7ce22 | 2019-03-21 14:43:58 | [diff] [blame] | 384 | encoded_image._frameType = VideoFrameType::kVideoFrameDelta; |
Niels Möller | 949f0fd | 2019-01-29 08:44:24 | [diff] [blame] | 385 | EXPECT_CALL(callback, FrameCountUpdated(_, kSsrc1)) |
| 386 | .WillOnce(SaveArg<0>(&frame_counts)); |
Danil Chapovalov | 383f2cf | 2020-08-12 09:06:53 | [diff] [blame] | 387 | EXPECT_EQ(EncodedImageCallback::Result::OK, |
| 388 | test.router()->OnEncodedImage(encoded_image, nullptr).error); |
Niels Möller | 949f0fd | 2019-01-29 08:44:24 | [diff] [blame] | 389 | |
| 390 | EXPECT_EQ(1, frame_counts.key_frames); |
| 391 | EXPECT_EQ(1, frame_counts.delta_frames); |
| 392 | } |
| 393 | |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 394 | // Integration test verifying that ack of packet via TransportFeedback means |
Erik Språng | 845c6aa | 2019-05-29 11:02:24 | [diff] [blame] | 395 | // that the packet is removed from RtpPacketHistory and won't be retransmitted |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 396 | // again. |
| 397 | TEST(RtpVideoSenderTest, DoesNotRetrasmitAckedPackets) { |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 398 | RtpVideoSenderTestFixture test({kSsrc1, kSsrc2}, {kRtxSsrc1, kRtxSsrc2}, |
| 399 | kPayloadType, {}); |
| 400 | test.router()->SetActive(true); |
| 401 | |
| 402 | constexpr uint8_t kPayload = 'a'; |
| 403 | EncodedImage encoded_image; |
| 404 | encoded_image.SetTimestamp(1); |
| 405 | encoded_image.capture_time_ms_ = 2; |
| 406 | encoded_image._frameType = VideoFrameType::kVideoFrameKey; |
Niels Möller | 4d504c7 | 2019-06-18 13:56:56 | [diff] [blame] | 407 | encoded_image.SetEncodedData(EncodedImageBuffer::Create(&kPayload, 1)); |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 408 | |
| 409 | // Send two tiny images, mapping to two RTP packets. Capture sequence numbers. |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 410 | std::vector<uint16_t> rtp_sequence_numbers; |
| 411 | std::vector<uint16_t> transport_sequence_numbers; |
| 412 | EXPECT_CALL(test.transport(), SendRtp) |
| 413 | .Times(2) |
Danil Chapovalov | a68eb8c | 2020-02-17 15:13:14 | [diff] [blame] | 414 | .WillRepeatedly([&rtp_sequence_numbers, &transport_sequence_numbers]( |
| 415 | const uint8_t* packet, size_t length, |
| 416 | const PacketOptions& options) { |
| 417 | RtpPacket rtp_packet; |
| 418 | EXPECT_TRUE(rtp_packet.Parse(packet, length)); |
| 419 | rtp_sequence_numbers.push_back(rtp_packet.SequenceNumber()); |
| 420 | transport_sequence_numbers.push_back(options.packet_id); |
| 421 | return true; |
| 422 | }); |
Danil Chapovalov | 383f2cf | 2020-08-12 09:06:53 | [diff] [blame] | 423 | EXPECT_EQ(EncodedImageCallback::Result::OK, |
| 424 | test.router()->OnEncodedImage(encoded_image, nullptr).error); |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 425 | encoded_image.SetTimestamp(2); |
| 426 | encoded_image.capture_time_ms_ = 3; |
Danil Chapovalov | 383f2cf | 2020-08-12 09:06:53 | [diff] [blame] | 427 | EXPECT_EQ(EncodedImageCallback::Result::OK, |
| 428 | test.router()->OnEncodedImage(encoded_image, nullptr).error); |
Erik Språng | bd7046c | 2019-05-07 21:54:29 | [diff] [blame] | 429 | |
Danil Chapovalov | 0c626af | 2020-02-10 10:16:00 | [diff] [blame] | 430 | test.AdvanceTime(TimeDelta::Millis(33)); |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 431 | |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 432 | // Construct a NACK message for requesting retransmission of both packet. |
| 433 | rtcp::Nack nack; |
| 434 | nack.SetMediaSsrc(kSsrc1); |
| 435 | nack.SetPacketIds(rtp_sequence_numbers); |
| 436 | rtc::Buffer nack_buffer = nack.Build(); |
| 437 | |
| 438 | std::vector<uint16_t> retransmitted_rtp_sequence_numbers; |
| 439 | EXPECT_CALL(test.transport(), SendRtp) |
| 440 | .Times(2) |
Danil Chapovalov | a68eb8c | 2020-02-17 15:13:14 | [diff] [blame] | 441 | .WillRepeatedly([&retransmitted_rtp_sequence_numbers]( |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 442 | const uint8_t* packet, size_t length, |
| 443 | const PacketOptions& options) { |
| 444 | RtpPacket rtp_packet; |
| 445 | EXPECT_TRUE(rtp_packet.Parse(packet, length)); |
| 446 | EXPECT_EQ(rtp_packet.Ssrc(), kRtxSsrc1); |
| 447 | // Capture the retransmitted sequence number from the RTX header. |
| 448 | rtc::ArrayView<const uint8_t> payload = rtp_packet.payload(); |
| 449 | retransmitted_rtp_sequence_numbers.push_back( |
| 450 | ByteReader<uint16_t>::ReadBigEndian(payload.data())); |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 451 | return true; |
| 452 | }); |
| 453 | test.router()->DeliverRtcp(nack_buffer.data(), nack_buffer.size()); |
Danil Chapovalov | 0c626af | 2020-02-10 10:16:00 | [diff] [blame] | 454 | test.AdvanceTime(TimeDelta::Millis(33)); |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 455 | |
| 456 | // Verify that both packets were retransmitted. |
| 457 | EXPECT_EQ(retransmitted_rtp_sequence_numbers, rtp_sequence_numbers); |
| 458 | |
| 459 | // Simulate transport feedback indicating fist packet received, next packet |
Erik Språng | 00cc836 | 2019-11-25 11:21:46 | [diff] [blame] | 460 | // lost (not other way around as that would trigger early retransmit). |
Sebastian Jansson | f298855 | 2019-10-29 16:18:51 | [diff] [blame] | 461 | StreamFeedbackObserver::StreamPacketInfo lost_packet_feedback; |
Erik Språng | 00cc836 | 2019-11-25 11:21:46 | [diff] [blame] | 462 | lost_packet_feedback.rtp_sequence_number = rtp_sequence_numbers[0]; |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 463 | lost_packet_feedback.ssrc = kSsrc1; |
Sebastian Jansson | f298855 | 2019-10-29 16:18:51 | [diff] [blame] | 464 | lost_packet_feedback.received = false; |
Erik Språng | 6a0a559 | 2021-06-15 17:04:24 | [diff] [blame] | 465 | lost_packet_feedback.is_retransmission = false; |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 466 | |
Erik Språng | 00cc836 | 2019-11-25 11:21:46 | [diff] [blame] | 467 | StreamFeedbackObserver::StreamPacketInfo received_packet_feedback; |
| 468 | received_packet_feedback.rtp_sequence_number = rtp_sequence_numbers[1]; |
| 469 | received_packet_feedback.ssrc = kSsrc1; |
| 470 | received_packet_feedback.received = true; |
Erik Språng | 6a0a559 | 2021-06-15 17:04:24 | [diff] [blame] | 471 | lost_packet_feedback.is_retransmission = false; |
Erik Språng | 00cc836 | 2019-11-25 11:21:46 | [diff] [blame] | 472 | |
Sebastian Jansson | f298855 | 2019-10-29 16:18:51 | [diff] [blame] | 473 | test.router()->OnPacketFeedbackVector( |
Erik Språng | 00cc836 | 2019-11-25 11:21:46 | [diff] [blame] | 474 | {lost_packet_feedback, received_packet_feedback}); |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 475 | |
| 476 | // Advance time to make sure retransmission would be allowed and try again. |
| 477 | // This time the retransmission should not happen for the first packet since |
| 478 | // the history has been notified of the ack and removed the packet. The |
| 479 | // second packet, included in the feedback but not marked as received, should |
| 480 | // still be retransmitted. |
Danil Chapovalov | 0c626af | 2020-02-10 10:16:00 | [diff] [blame] | 481 | test.AdvanceTime(TimeDelta::Millis(33)); |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 482 | EXPECT_CALL(test.transport(), SendRtp) |
Danil Chapovalov | a68eb8c | 2020-02-17 15:13:14 | [diff] [blame] | 483 | .WillOnce([&lost_packet_feedback](const uint8_t* packet, size_t length, |
| 484 | const PacketOptions& options) { |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 485 | RtpPacket rtp_packet; |
| 486 | EXPECT_TRUE(rtp_packet.Parse(packet, length)); |
| 487 | EXPECT_EQ(rtp_packet.Ssrc(), kRtxSsrc1); |
| 488 | // Capture the retransmitted sequence number from the RTX header. |
| 489 | rtc::ArrayView<const uint8_t> payload = rtp_packet.payload(); |
| 490 | EXPECT_EQ(lost_packet_feedback.rtp_sequence_number, |
| 491 | ByteReader<uint16_t>::ReadBigEndian(payload.data())); |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 492 | return true; |
| 493 | }); |
| 494 | test.router()->DeliverRtcp(nack_buffer.data(), nack_buffer.size()); |
Danil Chapovalov | 0c626af | 2020-02-10 10:16:00 | [diff] [blame] | 495 | test.AdvanceTime(TimeDelta::Millis(33)); |
Erik Språng | 490d76c | 2019-05-07 16:29:15 | [diff] [blame] | 496 | } |
Erik Språng | 845c6aa | 2019-05-29 11:02:24 | [diff] [blame] | 497 | |
Sebastian Jansson | 3d4d94a | 2020-01-14 13:25:41 | [diff] [blame] | 498 | // This tests that we utilize transport wide feedback to retransmit lost |
| 499 | // packets. This is tested by dropping all ordirary packets from a "lossy" |
| 500 | // stream send along with an secondary untouched stream. The transport wide |
| 501 | // feedback packets from the secondary stream allows the sending side to |
| 502 | // detect and retreansmit the lost packets from the lossy stream. |
| 503 | TEST(RtpVideoSenderTest, RetransmitsOnTransportWideLossInfo) { |
| 504 | int rtx_packets; |
| 505 | test::Scenario s(test_info_); |
| 506 | test::CallClientConfig call_conf; |
| 507 | // Keeping the bitrate fixed to avoid RTX due to probing. |
Danil Chapovalov | cad3e0e | 2020-02-17 17:46:07 | [diff] [blame] | 508 | call_conf.transport.rates.max_rate = DataRate::KilobitsPerSec(300); |
| 509 | call_conf.transport.rates.start_rate = DataRate::KilobitsPerSec(300); |
Sebastian Jansson | 3d4d94a | 2020-01-14 13:25:41 | [diff] [blame] | 510 | test::NetworkSimulationConfig net_conf; |
Danil Chapovalov | cad3e0e | 2020-02-17 17:46:07 | [diff] [blame] | 511 | net_conf.bandwidth = DataRate::KilobitsPerSec(300); |
Sebastian Jansson | 3d4d94a | 2020-01-14 13:25:41 | [diff] [blame] | 512 | auto send_node = s.CreateSimulationNode(net_conf); |
Tommi | 3c9bcc1 | 2020-04-15 14:45:47 | [diff] [blame] | 513 | auto* callee = s.CreateClient("return", call_conf); |
Sebastian Jansson | 3d4d94a | 2020-01-14 13:25:41 | [diff] [blame] | 514 | auto* route = s.CreateRoutes(s.CreateClient("send", call_conf), {send_node}, |
Tommi | 3c9bcc1 | 2020-04-15 14:45:47 | [diff] [blame] | 515 | callee, {s.CreateSimulationNode(net_conf)}); |
Sebastian Jansson | 3d4d94a | 2020-01-14 13:25:41 | [diff] [blame] | 516 | |
| 517 | test::VideoStreamConfig lossy_config; |
| 518 | lossy_config.source.framerate = 5; |
| 519 | auto* lossy = s.CreateVideoStream(route->forward(), lossy_config); |
| 520 | // The secondary stream acts a driver for transport feedback messages, |
| 521 | // ensuring that lost packets on the lossy stream are retransmitted. |
| 522 | s.CreateVideoStream(route->forward(), test::VideoStreamConfig()); |
| 523 | |
| 524 | send_node->router()->SetFilter([&](const EmulatedIpPacket& packet) { |
| 525 | RtpPacket rtp; |
| 526 | if (rtp.Parse(packet.data)) { |
| 527 | // Drops all regular packets for the lossy stream and counts all RTX |
| 528 | // packets. Since no packets are let trough, NACKs can't be triggered |
| 529 | // by the receiving side. |
| 530 | if (lossy->send()->UsingSsrc(rtp.Ssrc())) { |
| 531 | return false; |
| 532 | } else if (lossy->send()->UsingRtxSsrc(rtp.Ssrc())) { |
| 533 | ++rtx_packets; |
| 534 | } |
| 535 | } |
| 536 | return true; |
| 537 | }); |
| 538 | |
| 539 | // Run for a short duration and reset counters to avoid counting RTX packets |
| 540 | // from initial probing. |
Danil Chapovalov | 0c626af | 2020-02-10 10:16:00 | [diff] [blame] | 541 | s.RunFor(TimeDelta::Seconds(1)); |
Sebastian Jansson | 3d4d94a | 2020-01-14 13:25:41 | [diff] [blame] | 542 | rtx_packets = 0; |
Tommi | 3c9bcc1 | 2020-04-15 14:45:47 | [diff] [blame] | 543 | int decoded_baseline = 0; |
| 544 | callee->SendTask([&decoded_baseline, &lossy]() { |
| 545 | decoded_baseline = lossy->receive()->GetStats().frames_decoded; |
| 546 | }); |
Danil Chapovalov | 0c626af | 2020-02-10 10:16:00 | [diff] [blame] | 547 | s.RunFor(TimeDelta::Seconds(1)); |
Sebastian Jansson | 3d4d94a | 2020-01-14 13:25:41 | [diff] [blame] | 548 | // We expect both that RTX packets were sent and that an appropriate number of |
| 549 | // frames were received. This is somewhat redundant but reduces the risk of |
| 550 | // false positives in future regressions (e.g. RTX is send due to probing). |
| 551 | EXPECT_GE(rtx_packets, 1); |
Tommi | 3c9bcc1 | 2020-04-15 14:45:47 | [diff] [blame] | 552 | int frames_decoded = 0; |
| 553 | callee->SendTask([&decoded_baseline, &frames_decoded, &lossy]() { |
| 554 | frames_decoded = |
| 555 | lossy->receive()->GetStats().frames_decoded - decoded_baseline; |
| 556 | }); |
Sebastian Jansson | 3d4d94a | 2020-01-14 13:25:41 | [diff] [blame] | 557 | EXPECT_EQ(frames_decoded, 5); |
| 558 | } |
| 559 | |
Erik Språng | 845c6aa | 2019-05-29 11:02:24 | [diff] [blame] | 560 | // Integration test verifying that retransmissions are sent for packets which |
| 561 | // can be detected as lost early, using transport wide feedback. |
| 562 | TEST(RtpVideoSenderTest, EarlyRetransmits) { |
Erik Språng | 845c6aa | 2019-05-29 11:02:24 | [diff] [blame] | 563 | RtpVideoSenderTestFixture test({kSsrc1, kSsrc2}, {kRtxSsrc1, kRtxSsrc2}, |
| 564 | kPayloadType, {}); |
| 565 | test.router()->SetActive(true); |
| 566 | |
Niels Möller | b9bfe65 | 2019-10-03 06:43:53 | [diff] [blame] | 567 | const uint8_t kPayload[1] = {'a'}; |
Erik Språng | 845c6aa | 2019-05-29 11:02:24 | [diff] [blame] | 568 | EncodedImage encoded_image; |
| 569 | encoded_image.SetTimestamp(1); |
| 570 | encoded_image.capture_time_ms_ = 2; |
| 571 | encoded_image._frameType = VideoFrameType::kVideoFrameKey; |
Niels Möller | b9bfe65 | 2019-10-03 06:43:53 | [diff] [blame] | 572 | encoded_image.SetEncodedData( |
| 573 | EncodedImageBuffer::Create(kPayload, sizeof(kPayload))); |
Erik Språng | 845c6aa | 2019-05-29 11:02:24 | [diff] [blame] | 574 | encoded_image.SetSpatialIndex(0); |
| 575 | |
| 576 | CodecSpecificInfo codec_specific; |
| 577 | codec_specific.codecType = VideoCodecType::kVideoCodecGeneric; |
| 578 | |
| 579 | // Send two tiny images, mapping to single RTP packets. Capture sequence |
| 580 | // numbers. |
Erik Språng | 845c6aa | 2019-05-29 11:02:24 | [diff] [blame] | 581 | uint16_t frame1_rtp_sequence_number = 0; |
| 582 | uint16_t frame1_transport_sequence_number = 0; |
| 583 | EXPECT_CALL(test.transport(), SendRtp) |
Danil Chapovalov | a68eb8c | 2020-02-17 15:13:14 | [diff] [blame] | 584 | .WillOnce( |
| 585 | [&frame1_rtp_sequence_number, &frame1_transport_sequence_number]( |
| 586 | const uint8_t* packet, size_t length, |
| 587 | const PacketOptions& options) { |
| 588 | RtpPacket rtp_packet; |
| 589 | EXPECT_TRUE(rtp_packet.Parse(packet, length)); |
| 590 | frame1_rtp_sequence_number = rtp_packet.SequenceNumber(); |
| 591 | frame1_transport_sequence_number = options.packet_id; |
| 592 | EXPECT_EQ(rtp_packet.Ssrc(), kSsrc1); |
| 593 | return true; |
| 594 | }); |
Danil Chapovalov | 383f2cf | 2020-08-12 09:06:53 | [diff] [blame] | 595 | EXPECT_EQ(test.router()->OnEncodedImage(encoded_image, &codec_specific).error, |
Erik Språng | 845c6aa | 2019-05-29 11:02:24 | [diff] [blame] | 596 | EncodedImageCallback::Result::OK); |
Erik Språng | 845c6aa | 2019-05-29 11:02:24 | [diff] [blame] | 597 | |
Danil Chapovalov | 0c626af | 2020-02-10 10:16:00 | [diff] [blame] | 598 | test.AdvanceTime(TimeDelta::Millis(33)); |
Erik Språng | 845c6aa | 2019-05-29 11:02:24 | [diff] [blame] | 599 | |
| 600 | uint16_t frame2_rtp_sequence_number = 0; |
| 601 | uint16_t frame2_transport_sequence_number = 0; |
| 602 | encoded_image.SetSpatialIndex(1); |
| 603 | EXPECT_CALL(test.transport(), SendRtp) |
Danil Chapovalov | a68eb8c | 2020-02-17 15:13:14 | [diff] [blame] | 604 | .WillOnce( |
| 605 | [&frame2_rtp_sequence_number, &frame2_transport_sequence_number]( |
| 606 | const uint8_t* packet, size_t length, |
| 607 | const PacketOptions& options) { |
| 608 | RtpPacket rtp_packet; |
| 609 | EXPECT_TRUE(rtp_packet.Parse(packet, length)); |
| 610 | frame2_rtp_sequence_number = rtp_packet.SequenceNumber(); |
| 611 | frame2_transport_sequence_number = options.packet_id; |
| 612 | EXPECT_EQ(rtp_packet.Ssrc(), kSsrc2); |
| 613 | return true; |
| 614 | }); |
Danil Chapovalov | 383f2cf | 2020-08-12 09:06:53 | [diff] [blame] | 615 | EXPECT_EQ(test.router()->OnEncodedImage(encoded_image, &codec_specific).error, |
Erik Språng | 845c6aa | 2019-05-29 11:02:24 | [diff] [blame] | 616 | EncodedImageCallback::Result::OK); |
Danil Chapovalov | 0c626af | 2020-02-10 10:16:00 | [diff] [blame] | 617 | test.AdvanceTime(TimeDelta::Millis(33)); |
Erik Språng | 845c6aa | 2019-05-29 11:02:24 | [diff] [blame] | 618 | |
| 619 | EXPECT_NE(frame1_transport_sequence_number, frame2_transport_sequence_number); |
| 620 | |
| 621 | // Inject a transport feedback where the packet for the first frame is lost, |
| 622 | // expect a retransmission for it. |
| 623 | EXPECT_CALL(test.transport(), SendRtp) |
Danil Chapovalov | a68eb8c | 2020-02-17 15:13:14 | [diff] [blame] | 624 | .WillOnce([&frame1_rtp_sequence_number](const uint8_t* packet, |
| 625 | size_t length, |
| 626 | const PacketOptions& options) { |
Erik Språng | 845c6aa | 2019-05-29 11:02:24 | [diff] [blame] | 627 | RtpPacket rtp_packet; |
| 628 | EXPECT_TRUE(rtp_packet.Parse(packet, length)); |
Sebastian Jansson | f298855 | 2019-10-29 16:18:51 | [diff] [blame] | 629 | EXPECT_EQ(rtp_packet.Ssrc(), kRtxSsrc1); |
Erik Språng | 845c6aa | 2019-05-29 11:02:24 | [diff] [blame] | 630 | |
| 631 | // Retransmitted sequence number from the RTX header should match |
| 632 | // the lost packet. |
| 633 | rtc::ArrayView<const uint8_t> payload = rtp_packet.payload(); |
| 634 | EXPECT_EQ(ByteReader<uint16_t>::ReadBigEndian(payload.data()), |
| 635 | frame1_rtp_sequence_number); |
Erik Språng | 845c6aa | 2019-05-29 11:02:24 | [diff] [blame] | 636 | return true; |
| 637 | }); |
| 638 | |
Sebastian Jansson | f298855 | 2019-10-29 16:18:51 | [diff] [blame] | 639 | StreamFeedbackObserver::StreamPacketInfo first_packet_feedback; |
Erik Språng | 845c6aa | 2019-05-29 11:02:24 | [diff] [blame] | 640 | first_packet_feedback.rtp_sequence_number = frame1_rtp_sequence_number; |
| 641 | first_packet_feedback.ssrc = kSsrc1; |
Sebastian Jansson | f298855 | 2019-10-29 16:18:51 | [diff] [blame] | 642 | first_packet_feedback.received = false; |
Erik Språng | 6a0a559 | 2021-06-15 17:04:24 | [diff] [blame] | 643 | first_packet_feedback.is_retransmission = false; |
Erik Språng | 845c6aa | 2019-05-29 11:02:24 | [diff] [blame] | 644 | |
Sebastian Jansson | f298855 | 2019-10-29 16:18:51 | [diff] [blame] | 645 | StreamFeedbackObserver::StreamPacketInfo second_packet_feedback; |
| 646 | second_packet_feedback.rtp_sequence_number = frame2_rtp_sequence_number; |
| 647 | second_packet_feedback.ssrc = kSsrc2; |
| 648 | second_packet_feedback.received = true; |
Erik Språng | 6a0a559 | 2021-06-15 17:04:24 | [diff] [blame] | 649 | first_packet_feedback.is_retransmission = false; |
Erik Språng | 845c6aa | 2019-05-29 11:02:24 | [diff] [blame] | 650 | |
Sebastian Jansson | f298855 | 2019-10-29 16:18:51 | [diff] [blame] | 651 | test.router()->OnPacketFeedbackVector( |
| 652 | {first_packet_feedback, second_packet_feedback}); |
Erik Språng | 845c6aa | 2019-05-29 11:02:24 | [diff] [blame] | 653 | |
| 654 | // Wait for pacer to run and send the RTX packet. |
Danil Chapovalov | 0c626af | 2020-02-10 10:16:00 | [diff] [blame] | 655 | test.AdvanceTime(TimeDelta::Millis(33)); |
Erik Språng | 845c6aa | 2019-05-29 11:02:24 | [diff] [blame] | 656 | } |
Sebastian Jansson | cf41eb1 | 2019-06-10 09:30:59 | [diff] [blame] | 657 | |
Danil Chapovalov | 2272f20 | 2020-02-18 11:09:43 | [diff] [blame] | 658 | TEST(RtpVideoSenderTest, SupportsDependencyDescriptor) { |
Danil Chapovalov | 2272f20 | 2020-02-18 11:09:43 | [diff] [blame] | 659 | RtpVideoSenderTestFixture test({kSsrc1}, {}, kPayloadType, {}); |
| 660 | test.router()->SetActive(true); |
| 661 | |
| 662 | RtpHeaderExtensionMap extensions; |
| 663 | extensions.Register<RtpDependencyDescriptorExtension>( |
| 664 | kDependencyDescriptorExtensionId); |
| 665 | std::vector<RtpPacket> sent_packets; |
| 666 | ON_CALL(test.transport(), SendRtp) |
| 667 | .WillByDefault([&](const uint8_t* packet, size_t length, |
| 668 | const PacketOptions& options) { |
| 669 | sent_packets.emplace_back(&extensions); |
| 670 | EXPECT_TRUE(sent_packets.back().Parse(packet, length)); |
| 671 | return true; |
| 672 | }); |
| 673 | |
| 674 | const uint8_t kPayload[1] = {'a'}; |
| 675 | EncodedImage encoded_image; |
| 676 | encoded_image.SetTimestamp(1); |
| 677 | encoded_image.capture_time_ms_ = 2; |
| 678 | encoded_image.SetEncodedData( |
| 679 | EncodedImageBuffer::Create(kPayload, sizeof(kPayload))); |
| 680 | |
| 681 | CodecSpecificInfo codec_specific; |
| 682 | codec_specific.codecType = VideoCodecType::kVideoCodecGeneric; |
| 683 | codec_specific.template_structure.emplace(); |
| 684 | codec_specific.template_structure->num_decode_targets = 1; |
| 685 | codec_specific.template_structure->templates = { |
Danil Chapovalov | 24263f4 | 2020-06-11 11:23:45 | [diff] [blame] | 686 | FrameDependencyTemplate().T(0).Dtis("S"), |
| 687 | FrameDependencyTemplate().T(0).Dtis("S").FrameDiffs({2}), |
| 688 | FrameDependencyTemplate().T(1).Dtis("D").FrameDiffs({1}), |
Danil Chapovalov | 2272f20 | 2020-02-18 11:09:43 | [diff] [blame] | 689 | }; |
| 690 | |
| 691 | // Send two tiny images, mapping to single RTP packets. |
| 692 | // Send in key frame. |
| 693 | encoded_image._frameType = VideoFrameType::kVideoFrameKey; |
| 694 | codec_specific.generic_frame_info = |
| 695 | GenericFrameInfo::Builder().T(0).Dtis("S").Build(); |
| 696 | codec_specific.generic_frame_info->encoder_buffers = {{0, false, true}}; |
Danil Chapovalov | 383f2cf | 2020-08-12 09:06:53 | [diff] [blame] | 697 | EXPECT_EQ(test.router()->OnEncodedImage(encoded_image, &codec_specific).error, |
Danil Chapovalov | 2272f20 | 2020-02-18 11:09:43 | [diff] [blame] | 698 | EncodedImageCallback::Result::OK); |
| 699 | test.AdvanceTime(TimeDelta::Millis(33)); |
| 700 | ASSERT_THAT(sent_packets, SizeIs(1)); |
| 701 | EXPECT_TRUE( |
| 702 | sent_packets.back().HasExtension<RtpDependencyDescriptorExtension>()); |
| 703 | |
| 704 | // Send in delta frame. |
| 705 | encoded_image._frameType = VideoFrameType::kVideoFrameDelta; |
| 706 | codec_specific.template_structure = absl::nullopt; |
| 707 | codec_specific.generic_frame_info = |
| 708 | GenericFrameInfo::Builder().T(1).Dtis("D").Build(); |
| 709 | codec_specific.generic_frame_info->encoder_buffers = {{0, true, false}}; |
Danil Chapovalov | 383f2cf | 2020-08-12 09:06:53 | [diff] [blame] | 710 | EXPECT_EQ(test.router()->OnEncodedImage(encoded_image, &codec_specific).error, |
Danil Chapovalov | 2272f20 | 2020-02-18 11:09:43 | [diff] [blame] | 711 | EncodedImageCallback::Result::OK); |
| 712 | test.AdvanceTime(TimeDelta::Millis(33)); |
| 713 | ASSERT_THAT(sent_packets, SizeIs(2)); |
| 714 | EXPECT_TRUE( |
| 715 | sent_packets.back().HasExtension<RtpDependencyDescriptorExtension>()); |
| 716 | } |
| 717 | |
Danil Chapovalov | 0be1846 | 2021-01-20 11:11:29 | [diff] [blame] | 718 | TEST(RtpVideoSenderTest, SupportsDependencyDescriptorForVp9) { |
| 719 | RtpVideoSenderTestFixture test({kSsrc1}, {}, kPayloadType, {}); |
| 720 | test.router()->SetActive(true); |
| 721 | |
| 722 | RtpHeaderExtensionMap extensions; |
| 723 | extensions.Register<RtpDependencyDescriptorExtension>( |
| 724 | kDependencyDescriptorExtensionId); |
| 725 | std::vector<RtpPacket> sent_packets; |
| 726 | ON_CALL(test.transport(), SendRtp) |
| 727 | .WillByDefault([&](const uint8_t* packet, size_t length, |
| 728 | const PacketOptions& options) { |
| 729 | sent_packets.emplace_back(&extensions); |
| 730 | EXPECT_TRUE(sent_packets.back().Parse(packet, length)); |
| 731 | return true; |
| 732 | }); |
| 733 | |
| 734 | const uint8_t kPayload[1] = {'a'}; |
| 735 | EncodedImage encoded_image; |
| 736 | encoded_image.SetTimestamp(1); |
| 737 | encoded_image.capture_time_ms_ = 2; |
| 738 | encoded_image._frameType = VideoFrameType::kVideoFrameKey; |
| 739 | encoded_image.SetEncodedData( |
| 740 | EncodedImageBuffer::Create(kPayload, sizeof(kPayload))); |
| 741 | |
| 742 | CodecSpecificInfo codec_specific; |
| 743 | codec_specific.codecType = VideoCodecType::kVideoCodecVP9; |
| 744 | codec_specific.template_structure.emplace(); |
| 745 | codec_specific.template_structure->num_decode_targets = 2; |
| 746 | codec_specific.template_structure->templates = { |
| 747 | FrameDependencyTemplate().S(0).Dtis("SS"), |
| 748 | FrameDependencyTemplate().S(1).Dtis("-S").FrameDiffs({1}), |
| 749 | }; |
| 750 | |
| 751 | // Send two tiny images, each mapping to single RTP packet. |
| 752 | // Send in key frame for the base spatial layer. |
| 753 | codec_specific.generic_frame_info = |
| 754 | GenericFrameInfo::Builder().S(0).Dtis("SS").Build(); |
| 755 | codec_specific.generic_frame_info->encoder_buffers = {{0, false, true}}; |
| 756 | EXPECT_EQ(test.router()->OnEncodedImage(encoded_image, &codec_specific).error, |
| 757 | EncodedImageCallback::Result::OK); |
| 758 | // Send in 2nd spatial layer. |
| 759 | codec_specific.template_structure = absl::nullopt; |
| 760 | codec_specific.generic_frame_info = |
| 761 | GenericFrameInfo::Builder().S(1).Dtis("-S").Build(); |
| 762 | codec_specific.generic_frame_info->encoder_buffers = {{0, true, false}, |
| 763 | {1, false, true}}; |
| 764 | EXPECT_EQ(test.router()->OnEncodedImage(encoded_image, &codec_specific).error, |
| 765 | EncodedImageCallback::Result::OK); |
| 766 | |
| 767 | test.AdvanceTime(TimeDelta::Millis(33)); |
| 768 | ASSERT_THAT(sent_packets, SizeIs(2)); |
| 769 | EXPECT_TRUE(sent_packets[0].HasExtension<RtpDependencyDescriptorExtension>()); |
| 770 | EXPECT_TRUE(sent_packets[1].HasExtension<RtpDependencyDescriptorExtension>()); |
| 771 | } |
| 772 | |
Danil Chapovalov | 748550d | 2021-04-29 09:42:54 | [diff] [blame] | 773 | TEST(RtpVideoSenderTest, |
| 774 | SupportsDependencyDescriptorForVp9NotProvidedByEncoder) { |
Danil Chapovalov | 748550d | 2021-04-29 09:42:54 | [diff] [blame] | 775 | RtpVideoSenderTestFixture test({kSsrc1}, {}, kPayloadType, {}); |
| 776 | test.router()->SetActive(true); |
| 777 | |
| 778 | RtpHeaderExtensionMap extensions; |
| 779 | extensions.Register<RtpDependencyDescriptorExtension>( |
| 780 | kDependencyDescriptorExtensionId); |
| 781 | std::vector<RtpPacket> sent_packets; |
| 782 | ON_CALL(test.transport(), SendRtp) |
| 783 | .WillByDefault([&](const uint8_t* packet, size_t length, |
| 784 | const PacketOptions& options) { |
| 785 | sent_packets.emplace_back(&extensions); |
| 786 | EXPECT_TRUE(sent_packets.back().Parse(packet, length)); |
| 787 | return true; |
| 788 | }); |
| 789 | |
| 790 | const uint8_t kPayload[1] = {'a'}; |
| 791 | EncodedImage encoded_image; |
| 792 | encoded_image.SetTimestamp(1); |
| 793 | encoded_image.capture_time_ms_ = 2; |
| 794 | encoded_image._frameType = VideoFrameType::kVideoFrameKey; |
| 795 | encoded_image._encodedWidth = 320; |
| 796 | encoded_image._encodedHeight = 180; |
| 797 | encoded_image.SetEncodedData( |
| 798 | EncodedImageBuffer::Create(kPayload, sizeof(kPayload))); |
| 799 | |
| 800 | CodecSpecificInfo codec_specific; |
| 801 | codec_specific.codecType = VideoCodecType::kVideoCodecVP9; |
| 802 | codec_specific.codecSpecific.VP9.num_spatial_layers = 1; |
| 803 | codec_specific.codecSpecific.VP9.temporal_idx = kNoTemporalIdx; |
| 804 | codec_specific.codecSpecific.VP9.first_frame_in_picture = true; |
| 805 | codec_specific.end_of_picture = true; |
| 806 | codec_specific.codecSpecific.VP9.inter_pic_predicted = false; |
| 807 | |
| 808 | // Send two tiny images, each mapping to single RTP packet. |
| 809 | EXPECT_EQ(test.router()->OnEncodedImage(encoded_image, &codec_specific).error, |
| 810 | EncodedImageCallback::Result::OK); |
| 811 | |
| 812 | // Send in 2nd picture. |
| 813 | encoded_image._frameType = VideoFrameType::kVideoFrameDelta; |
| 814 | encoded_image.SetTimestamp(3000); |
| 815 | codec_specific.codecSpecific.VP9.inter_pic_predicted = true; |
| 816 | codec_specific.codecSpecific.VP9.num_ref_pics = 1; |
| 817 | codec_specific.codecSpecific.VP9.p_diff[0] = 1; |
| 818 | EXPECT_EQ(test.router()->OnEncodedImage(encoded_image, &codec_specific).error, |
| 819 | EncodedImageCallback::Result::OK); |
| 820 | |
| 821 | test.AdvanceTime(TimeDelta::Millis(33)); |
| 822 | ASSERT_THAT(sent_packets, SizeIs(2)); |
| 823 | EXPECT_TRUE(sent_packets[0].HasExtension<RtpDependencyDescriptorExtension>()); |
| 824 | EXPECT_TRUE(sent_packets[1].HasExtension<RtpDependencyDescriptorExtension>()); |
| 825 | } |
| 826 | |
philipel | 5b231de | 2021-09-01 13:21:16 | [diff] [blame] | 827 | TEST(RtpVideoSenderTest, GenerateDependecyDescriptorForGenericCodecs) { |
| 828 | test::ScopedFieldTrials field_trials( |
| 829 | "WebRTC-GenericCodecDependencyDescriptor/Enabled/"); |
| 830 | RtpVideoSenderTestFixture test({kSsrc1}, {}, kPayloadType, {}); |
| 831 | test.router()->SetActive(true); |
| 832 | |
| 833 | RtpHeaderExtensionMap extensions; |
| 834 | extensions.Register<RtpDependencyDescriptorExtension>( |
| 835 | kDependencyDescriptorExtensionId); |
| 836 | std::vector<RtpPacket> sent_packets; |
| 837 | ON_CALL(test.transport(), SendRtp) |
| 838 | .WillByDefault([&](const uint8_t* packet, size_t length, |
| 839 | const PacketOptions& options) { |
| 840 | sent_packets.emplace_back(&extensions); |
| 841 | EXPECT_TRUE(sent_packets.back().Parse(packet, length)); |
| 842 | return true; |
| 843 | }); |
| 844 | |
| 845 | const uint8_t kPayload[1] = {'a'}; |
| 846 | EncodedImage encoded_image; |
| 847 | encoded_image.SetTimestamp(1); |
| 848 | encoded_image.capture_time_ms_ = 2; |
| 849 | encoded_image._frameType = VideoFrameType::kVideoFrameKey; |
| 850 | encoded_image._encodedWidth = 320; |
| 851 | encoded_image._encodedHeight = 180; |
| 852 | encoded_image.SetEncodedData( |
| 853 | EncodedImageBuffer::Create(kPayload, sizeof(kPayload))); |
| 854 | |
| 855 | CodecSpecificInfo codec_specific; |
| 856 | codec_specific.codecType = VideoCodecType::kVideoCodecGeneric; |
| 857 | codec_specific.end_of_picture = true; |
| 858 | |
| 859 | // Send two tiny images, each mapping to single RTP packet. |
| 860 | EXPECT_EQ(test.router()->OnEncodedImage(encoded_image, &codec_specific).error, |
| 861 | EncodedImageCallback::Result::OK); |
| 862 | |
| 863 | // Send in 2nd picture. |
| 864 | encoded_image._frameType = VideoFrameType::kVideoFrameDelta; |
| 865 | encoded_image.SetTimestamp(3000); |
| 866 | EXPECT_EQ(test.router()->OnEncodedImage(encoded_image, &codec_specific).error, |
| 867 | EncodedImageCallback::Result::OK); |
| 868 | |
| 869 | test.AdvanceTime(TimeDelta::Millis(33)); |
| 870 | ASSERT_THAT(sent_packets, SizeIs(2)); |
| 871 | EXPECT_TRUE(sent_packets[0].HasExtension<RtpDependencyDescriptorExtension>()); |
| 872 | EXPECT_TRUE(sent_packets[1].HasExtension<RtpDependencyDescriptorExtension>()); |
| 873 | } |
| 874 | |
Danil Chapovalov | 2272f20 | 2020-02-18 11:09:43 | [diff] [blame] | 875 | TEST(RtpVideoSenderTest, SupportsStoppingUsingDependencyDescriptor) { |
Danil Chapovalov | 2272f20 | 2020-02-18 11:09:43 | [diff] [blame] | 876 | RtpVideoSenderTestFixture test({kSsrc1}, {}, kPayloadType, {}); |
| 877 | test.router()->SetActive(true); |
| 878 | |
| 879 | RtpHeaderExtensionMap extensions; |
| 880 | extensions.Register<RtpDependencyDescriptorExtension>( |
| 881 | kDependencyDescriptorExtensionId); |
| 882 | std::vector<RtpPacket> sent_packets; |
| 883 | ON_CALL(test.transport(), SendRtp) |
| 884 | .WillByDefault([&](const uint8_t* packet, size_t length, |
| 885 | const PacketOptions& options) { |
| 886 | sent_packets.emplace_back(&extensions); |
| 887 | EXPECT_TRUE(sent_packets.back().Parse(packet, length)); |
| 888 | return true; |
| 889 | }); |
| 890 | |
| 891 | const uint8_t kPayload[1] = {'a'}; |
| 892 | EncodedImage encoded_image; |
| 893 | encoded_image.SetTimestamp(1); |
| 894 | encoded_image.capture_time_ms_ = 2; |
| 895 | encoded_image.SetEncodedData( |
| 896 | EncodedImageBuffer::Create(kPayload, sizeof(kPayload))); |
| 897 | |
| 898 | CodecSpecificInfo codec_specific; |
| 899 | codec_specific.codecType = VideoCodecType::kVideoCodecGeneric; |
| 900 | codec_specific.template_structure.emplace(); |
| 901 | codec_specific.template_structure->num_decode_targets = 1; |
| 902 | codec_specific.template_structure->templates = { |
Danil Chapovalov | 24263f4 | 2020-06-11 11:23:45 | [diff] [blame] | 903 | FrameDependencyTemplate().T(0).Dtis("S"), |
| 904 | FrameDependencyTemplate().T(0).Dtis("S").FrameDiffs({2}), |
| 905 | FrameDependencyTemplate().T(1).Dtis("D").FrameDiffs({1}), |
Danil Chapovalov | 2272f20 | 2020-02-18 11:09:43 | [diff] [blame] | 906 | }; |
| 907 | |
| 908 | // Send two tiny images, mapping to single RTP packets. |
| 909 | // Send in a key frame. |
| 910 | encoded_image._frameType = VideoFrameType::kVideoFrameKey; |
| 911 | codec_specific.generic_frame_info = |
| 912 | GenericFrameInfo::Builder().T(0).Dtis("S").Build(); |
| 913 | codec_specific.generic_frame_info->encoder_buffers = {{0, false, true}}; |
Danil Chapovalov | 383f2cf | 2020-08-12 09:06:53 | [diff] [blame] | 914 | EXPECT_EQ(test.router()->OnEncodedImage(encoded_image, &codec_specific).error, |
Danil Chapovalov | 2272f20 | 2020-02-18 11:09:43 | [diff] [blame] | 915 | EncodedImageCallback::Result::OK); |
| 916 | test.AdvanceTime(TimeDelta::Millis(33)); |
| 917 | ASSERT_THAT(sent_packets, SizeIs(1)); |
| 918 | EXPECT_TRUE( |
| 919 | sent_packets.back().HasExtension<RtpDependencyDescriptorExtension>()); |
| 920 | |
| 921 | // Send in a new key frame without the support for the dependency descriptor. |
| 922 | encoded_image._frameType = VideoFrameType::kVideoFrameKey; |
| 923 | codec_specific.template_structure = absl::nullopt; |
Danil Chapovalov | 383f2cf | 2020-08-12 09:06:53 | [diff] [blame] | 924 | EXPECT_EQ(test.router()->OnEncodedImage(encoded_image, &codec_specific).error, |
Danil Chapovalov | 2272f20 | 2020-02-18 11:09:43 | [diff] [blame] | 925 | EncodedImageCallback::Result::OK); |
| 926 | test.AdvanceTime(TimeDelta::Millis(33)); |
| 927 | ASSERT_THAT(sent_packets, SizeIs(2)); |
| 928 | EXPECT_FALSE( |
| 929 | sent_packets.back().HasExtension<RtpDependencyDescriptorExtension>()); |
| 930 | } |
| 931 | |
Danil Chapovalov | 37dfddd | 2021-01-27 18:24:23 | [diff] [blame] | 932 | TEST(RtpVideoSenderTest, |
| 933 | SupportsStoppingUsingDependencyDescriptorForVp8Simulcast) { |
| 934 | RtpVideoSenderTestFixture test({kSsrc1, kSsrc2}, {}, kPayloadType, {}); |
| 935 | test.router()->SetActive(true); |
| 936 | |
| 937 | RtpHeaderExtensionMap extensions; |
| 938 | extensions.Register<RtpDependencyDescriptorExtension>( |
| 939 | kDependencyDescriptorExtensionId); |
| 940 | std::vector<RtpPacket> sent_packets; |
| 941 | ON_CALL(test.transport(), SendRtp) |
| 942 | .WillByDefault([&](const uint8_t* packet, size_t length, |
| 943 | const PacketOptions& options) { |
| 944 | sent_packets.emplace_back(&extensions); |
| 945 | EXPECT_TRUE(sent_packets.back().Parse(packet, length)); |
| 946 | return true; |
| 947 | }); |
| 948 | |
| 949 | const uint8_t kPayload[1] = {'a'}; |
| 950 | EncodedImage encoded_image; |
| 951 | encoded_image.SetTimestamp(1); |
| 952 | encoded_image.capture_time_ms_ = 2; |
| 953 | encoded_image.SetEncodedData( |
| 954 | EncodedImageBuffer::Create(kPayload, sizeof(kPayload))); |
| 955 | // VP8 simulcast uses spatial index to communicate simulcast stream. |
| 956 | encoded_image.SetSpatialIndex(1); |
| 957 | |
| 958 | CodecSpecificInfo codec_specific; |
| 959 | codec_specific.codecType = VideoCodecType::kVideoCodecVP8; |
| 960 | codec_specific.template_structure.emplace(); |
| 961 | codec_specific.template_structure->num_decode_targets = 1; |
| 962 | codec_specific.template_structure->templates = { |
| 963 | FrameDependencyTemplate().T(0).Dtis("S")}; |
| 964 | |
| 965 | // Send two tiny images, mapping to single RTP packets. |
| 966 | // Send in a key frame. |
| 967 | encoded_image._frameType = VideoFrameType::kVideoFrameKey; |
| 968 | codec_specific.generic_frame_info = |
| 969 | GenericFrameInfo::Builder().T(0).Dtis("S").Build(); |
| 970 | codec_specific.generic_frame_info->encoder_buffers = {{0, false, true}}; |
| 971 | EXPECT_EQ(test.router()->OnEncodedImage(encoded_image, &codec_specific).error, |
| 972 | EncodedImageCallback::Result::OK); |
| 973 | test.AdvanceTime(TimeDelta::Millis(33)); |
| 974 | ASSERT_THAT(sent_packets, SizeIs(1)); |
| 975 | EXPECT_TRUE( |
| 976 | sent_packets.back().HasExtension<RtpDependencyDescriptorExtension>()); |
| 977 | |
| 978 | // Send in a new key frame without the support for the dependency descriptor. |
| 979 | encoded_image._frameType = VideoFrameType::kVideoFrameKey; |
| 980 | codec_specific.template_structure = absl::nullopt; |
| 981 | codec_specific.generic_frame_info = absl::nullopt; |
| 982 | EXPECT_EQ(test.router()->OnEncodedImage(encoded_image, &codec_specific).error, |
| 983 | EncodedImageCallback::Result::OK); |
| 984 | test.AdvanceTime(TimeDelta::Millis(33)); |
| 985 | ASSERT_THAT(sent_packets, SizeIs(2)); |
| 986 | EXPECT_FALSE( |
| 987 | sent_packets.back().HasExtension<RtpDependencyDescriptorExtension>()); |
| 988 | } |
| 989 | |
Jakob Ivarsson | 9a12ee5 | 2020-11-26 15:04:18 | [diff] [blame] | 990 | TEST(RtpVideoSenderTest, CanSetZeroBitrate) { |
Sebastian Jansson | cf41eb1 | 2019-06-10 09:30:59 | [diff] [blame] | 991 | RtpVideoSenderTestFixture test({kSsrc1}, {kRtxSsrc1}, kPayloadType, {}); |
Jakob Ivarsson | 9a12ee5 | 2020-11-26 15:04:18 | [diff] [blame] | 992 | test.router()->OnBitrateUpdated(CreateBitrateAllocationUpdate(0), |
| 993 | /*framerate*/ 0); |
Sebastian Jansson | cf41eb1 | 2019-06-10 09:30:59 | [diff] [blame] | 994 | } |
Marina Ciocea | dc69fd2 | 2020-04-10 18:19:14 | [diff] [blame] | 995 | |
| 996 | TEST(RtpVideoSenderTest, SimulcastSenderRegistersFrameTransformers) { |
Marina Ciocea | dc69fd2 | 2020-04-10 18:19:14 | [diff] [blame] | 997 | rtc::scoped_refptr<MockFrameTransformer> transformer = |
Tomas Gunnarsson | c1d5891 | 2021-04-22 17:21:43 | [diff] [blame] | 998 | rtc::make_ref_counted<MockFrameTransformer>(); |
Marina Ciocea | dc69fd2 | 2020-04-10 18:19:14 | [diff] [blame] | 999 | |
| 1000 | EXPECT_CALL(*transformer, RegisterTransformedFrameSinkCallback(_, kSsrc1)); |
| 1001 | EXPECT_CALL(*transformer, RegisterTransformedFrameSinkCallback(_, kSsrc2)); |
| 1002 | RtpVideoSenderTestFixture test({kSsrc1, kSsrc2}, {kRtxSsrc1, kRtxSsrc2}, |
| 1003 | kPayloadType, {}, nullptr, transformer); |
| 1004 | |
| 1005 | EXPECT_CALL(*transformer, UnregisterTransformedFrameSinkCallback(kSsrc1)); |
| 1006 | EXPECT_CALL(*transformer, UnregisterTransformedFrameSinkCallback(kSsrc2)); |
| 1007 | } |
Jakob Ivarsson | 9a12ee5 | 2020-11-26 15:04:18 | [diff] [blame] | 1008 | |
| 1009 | TEST(RtpVideoSenderTest, OverheadIsSubtractedFromTargetBitrate) { |
| 1010 | test::ScopedFieldTrials field_trials( |
| 1011 | "WebRTC-Video-UseFrameRateForOverhead/Enabled/"); |
| 1012 | |
| 1013 | // TODO(jakobi): RTP header size should not be hard coded. |
| 1014 | constexpr uint32_t kRtpHeaderSizeBytes = 20; |
| 1015 | constexpr uint32_t kTransportPacketOverheadBytes = 40; |
| 1016 | constexpr uint32_t kOverheadPerPacketBytes = |
| 1017 | kRtpHeaderSizeBytes + kTransportPacketOverheadBytes; |
Danil Chapovalov | 9554a7b | 2021-02-05 18:30:16 | [diff] [blame] | 1018 | RtpVideoSenderTestFixture test({kSsrc1}, {}, kPayloadType, {}); |
Jakob Ivarsson | 9a12ee5 | 2020-11-26 15:04:18 | [diff] [blame] | 1019 | test.router()->OnTransportOverheadChanged(kTransportPacketOverheadBytes); |
| 1020 | test.router()->SetActive(true); |
| 1021 | |
| 1022 | { |
| 1023 | test.router()->OnBitrateUpdated(CreateBitrateAllocationUpdate(300000), |
| 1024 | /*framerate*/ 15); |
| 1025 | // 1 packet per frame. |
| 1026 | EXPECT_EQ(test.router()->GetPayloadBitrateBps(), |
| 1027 | 300000 - kOverheadPerPacketBytes * 8 * 30); |
| 1028 | } |
| 1029 | { |
| 1030 | test.router()->OnBitrateUpdated(CreateBitrateAllocationUpdate(150000), |
| 1031 | /*framerate*/ 15); |
| 1032 | // 1 packet per frame. |
| 1033 | EXPECT_EQ(test.router()->GetPayloadBitrateBps(), |
| 1034 | 150000 - kOverheadPerPacketBytes * 8 * 15); |
| 1035 | } |
| 1036 | { |
| 1037 | test.router()->OnBitrateUpdated(CreateBitrateAllocationUpdate(1000000), |
| 1038 | /*framerate*/ 30); |
| 1039 | // 3 packets per frame. |
| 1040 | EXPECT_EQ(test.router()->GetPayloadBitrateBps(), |
| 1041 | 1000000 - kOverheadPerPacketBytes * 8 * 30 * 3); |
| 1042 | } |
| 1043 | } |
| 1044 | |
mflodman@webrtc.org | 02270cd | 2015-02-06 13:10:19 | [diff] [blame] | 1045 | } // namespace webrtc |