stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license |
| 5 | * that can be found in the LICENSE file in the root of the source |
| 6 | * tree. An additional intellectual property rights grant can be found |
| 7 | * in the file PATENTS. All contributing project authors may |
| 8 | * be found in the AUTHORS file in the root of the source tree. |
| 9 | */ |
| 10 | |
Jonas Olsson | a4d8737 | 2019-07-05 17:08:33 | [diff] [blame] | 11 | #include "call/bitrate_allocator.h" |
| 12 | |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 13 | #include <algorithm> |
kwiberg | b25345e | 2016-03-12 14:10:44 | [diff] [blame] | 14 | #include <memory> |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 15 | #include <vector> |
| 16 | |
Sebastian Jansson | 4ad51d8 | 2019-06-11 09:24:40 | [diff] [blame] | 17 | #include "system_wrappers/include/clock.h" |
Mirko Bonadei | 92ea95e | 2017-09-15 04:47:31 | [diff] [blame] | 18 | #include "test/gmock.h" |
| 19 | #include "test/gtest.h" |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 20 | |
Seth Hampson | fe73d6a | 2017-11-14 18:49:06 | [diff] [blame] | 21 | using ::testing::_; |
Sebastian Jansson | 93b1ea2 | 2019-09-18 16:31:52 | [diff] [blame] | 22 | using ::testing::AllOf; |
| 23 | using ::testing::Field; |
Rasmus Brandt | 681de20 | 2019-02-04 14:09:34 | [diff] [blame] | 24 | using ::testing::NiceMock; |
perkj | 71ee44c | 2016-06-15 07:47:53 | [diff] [blame] | 25 | |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 26 | namespace webrtc { |
| 27 | |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 28 | namespace { |
Sebastian Jansson | 93b1ea2 | 2019-09-18 16:31:52 | [diff] [blame] | 29 | auto AllocationLimitsEq(uint32_t min_allocatable_rate_bps, |
| 30 | uint32_t max_padding_rate_bps, |
| 31 | uint32_t max_allocatable_rate_bps) { |
| 32 | return AllOf(Field(&BitrateAllocationLimits::min_allocatable_rate, |
Danil Chapovalov | cad3e0e | 2020-02-17 17:46:07 | [diff] [blame] | 33 | DataRate::BitsPerSec(min_allocatable_rate_bps)), |
Sebastian Jansson | 93b1ea2 | 2019-09-18 16:31:52 | [diff] [blame] | 34 | Field(&BitrateAllocationLimits::max_allocatable_rate, |
Danil Chapovalov | cad3e0e | 2020-02-17 17:46:07 | [diff] [blame] | 35 | DataRate::BitsPerSec(max_allocatable_rate_bps)), |
Sebastian Jansson | 93b1ea2 | 2019-09-18 16:31:52 | [diff] [blame] | 36 | Field(&BitrateAllocationLimits::max_padding_rate, |
Danil Chapovalov | cad3e0e | 2020-02-17 17:46:07 | [diff] [blame] | 37 | DataRate::BitsPerSec(max_padding_rate_bps))); |
Sebastian Jansson | 93b1ea2 | 2019-09-18 16:31:52 | [diff] [blame] | 38 | } |
| 39 | |
| 40 | auto AllocationLimitsEq(uint32_t min_allocatable_rate_bps, |
| 41 | uint32_t max_padding_rate_bps) { |
| 42 | return AllOf(Field(&BitrateAllocationLimits::min_allocatable_rate, |
Danil Chapovalov | cad3e0e | 2020-02-17 17:46:07 | [diff] [blame] | 43 | DataRate::BitsPerSec(min_allocatable_rate_bps)), |
Sebastian Jansson | 93b1ea2 | 2019-09-18 16:31:52 | [diff] [blame] | 44 | Field(&BitrateAllocationLimits::max_padding_rate, |
Danil Chapovalov | cad3e0e | 2020-02-17 17:46:07 | [diff] [blame] | 45 | DataRate::BitsPerSec(max_padding_rate_bps))); |
Sebastian Jansson | 93b1ea2 | 2019-09-18 16:31:52 | [diff] [blame] | 46 | } |
| 47 | |
| 48 | class MockLimitObserver : public BitrateAllocator::LimitObserver { |
perkj | 71ee44c | 2016-06-15 07:47:53 | [diff] [blame] | 49 | public: |
Danil Chapovalov | 9a5efe9 | 2020-05-14 20:06:18 | [diff] [blame] | 50 | MOCK_METHOD(void, |
| 51 | OnAllocationLimitsChanged, |
| 52 | (BitrateAllocationLimits), |
| 53 | (override)); |
perkj | 71ee44c | 2016-06-15 07:47:53 | [diff] [blame] | 54 | }; |
| 55 | |
mflodman | 86aabb2 | 2016-03-11 14:44:32 | [diff] [blame] | 56 | class TestBitrateObserver : public BitrateAllocatorObserver { |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 57 | public: |
| 58 | TestBitrateObserver() |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 59 | : last_bitrate_bps_(0), |
| 60 | last_fraction_loss_(0), |
| 61 | last_rtt_ms_(0), |
minyue | 78b4d56 | 2016-11-30 12:47:39 | [diff] [blame] | 62 | last_probing_interval_ms_(0), |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 63 | protection_ratio_(0.0) {} |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 64 | |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 65 | void SetBitrateProtectionRatio(double protection_ratio) { |
| 66 | protection_ratio_ = protection_ratio; |
| 67 | } |
| 68 | |
Sebastian Jansson | c0e4d45 | 2018-10-25 13:08:32 | [diff] [blame] | 69 | uint32_t OnBitrateUpdated(BitrateAllocationUpdate update) override { |
Sebastian Jansson | 13e5903 | 2018-11-21 18:13:07 | [diff] [blame] | 70 | last_bitrate_bps_ = update.target_bitrate.bps(); |
| 71 | last_fraction_loss_ = |
| 72 | rtc::dchecked_cast<uint8_t>(update.packet_loss_ratio * 256); |
| 73 | last_rtt_ms_ = update.round_trip_time.ms(); |
| 74 | last_probing_interval_ms_ = update.bwe_period.ms(); |
| 75 | return update.target_bitrate.bps() * protection_ratio_; |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 76 | } |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 77 | uint32_t last_bitrate_bps_; |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 78 | uint8_t last_fraction_loss_; |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 79 | int64_t last_rtt_ms_; |
minyue | 78b4d56 | 2016-11-30 12:47:39 | [diff] [blame] | 80 | int last_probing_interval_ms_; |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 81 | double protection_ratio_; |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 82 | }; |
| 83 | |
minyue | 78b4d56 | 2016-11-30 12:47:39 | [diff] [blame] | 84 | constexpr int64_t kDefaultProbingIntervalMs = 3000; |
Seth Hampson | 24722b3 | 2017-12-22 17:36:42 | [diff] [blame] | 85 | const double kDefaultBitratePriority = 1.0; |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 86 | |
| 87 | TargetTransferRate CreateTargetRateMessage(uint32_t target_bitrate_bps, |
| 88 | uint8_t fraction_loss, |
| 89 | int64_t rtt_ms, |
| 90 | int64_t bwe_period_ms) { |
| 91 | TargetTransferRate msg; |
| 92 | // The timestamp is just for log output, keeping it fixed just means fewer log |
| 93 | // messages in the test. |
Danil Chapovalov | 0c626af | 2020-02-10 10:16:00 | [diff] [blame] | 94 | msg.at_time = Timestamp::Seconds(10000); |
Danil Chapovalov | cad3e0e | 2020-02-17 17:46:07 | [diff] [blame] | 95 | msg.target_rate = DataRate::BitsPerSec(target_bitrate_bps); |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 96 | msg.stable_target_rate = msg.target_rate; |
| 97 | msg.network_estimate.bandwidth = msg.target_rate; |
| 98 | msg.network_estimate.loss_rate_ratio = fraction_loss / 255.0; |
Danil Chapovalov | 0c626af | 2020-02-10 10:16:00 | [diff] [blame] | 99 | msg.network_estimate.round_trip_time = TimeDelta::Millis(rtt_ms); |
| 100 | msg.network_estimate.bwe_period = TimeDelta::Millis(bwe_period_ms); |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 101 | return msg; |
| 102 | } |
Yves Gerey | 665174f | 2018-06-19 13:03:05 | [diff] [blame] | 103 | } // namespace |
minyue | 78b4d56 | 2016-11-30 12:47:39 | [diff] [blame] | 104 | |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 105 | class BitrateAllocatorTest : public ::testing::Test { |
| 106 | protected: |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 107 | BitrateAllocatorTest() : allocator_(new BitrateAllocator(&limit_observer_)) { |
| 108 | allocator_->OnNetworkEstimateChanged( |
| 109 | CreateTargetRateMessage(300000u, 0, 0, kDefaultProbingIntervalMs)); |
Stefan Holmer | e590416 | 2015-03-26 10:11:06 | [diff] [blame] | 110 | } |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 111 | ~BitrateAllocatorTest() {} |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 112 | void AddObserver(BitrateAllocatorObserver* observer, |
| 113 | uint32_t min_bitrate_bps, |
| 114 | uint32_t max_bitrate_bps, |
| 115 | uint32_t pad_up_bitrate_bps, |
| 116 | bool enforce_min_bitrate, |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 117 | double bitrate_priority) { |
| 118 | allocator_->AddObserver( |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 119 | observer, |
| 120 | {min_bitrate_bps, max_bitrate_bps, pad_up_bitrate_bps, |
| 121 | /* priority_bitrate */ 0, enforce_min_bitrate, bitrate_priority}); |
Sebastian Jansson | 464a557 | 2019-02-12 12:32:32 | [diff] [blame] | 122 | } |
| 123 | MediaStreamAllocationConfig DefaultConfig() const { |
| 124 | MediaStreamAllocationConfig default_config; |
| 125 | default_config.min_bitrate_bps = 0; |
| 126 | default_config.max_bitrate_bps = 1500000; |
| 127 | default_config.pad_up_bitrate_bps = 0; |
| 128 | default_config.priority_bitrate_bps = 0; |
| 129 | default_config.enforce_min_bitrate = true; |
Sebastian Jansson | 464a557 | 2019-02-12 12:32:32 | [diff] [blame] | 130 | default_config.bitrate_priority = kDefaultBitratePriority; |
| 131 | return default_config; |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 132 | } |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 133 | |
perkj | 71ee44c | 2016-06-15 07:47:53 | [diff] [blame] | 134 | NiceMock<MockLimitObserver> limit_observer_; |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 135 | std::unique_ptr<BitrateAllocator> allocator_; |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 136 | }; |
| 137 | |
Sebastian Jansson | 464a557 | 2019-02-12 12:32:32 | [diff] [blame] | 138 | TEST_F(BitrateAllocatorTest, RespectsPriorityBitrate) { |
| 139 | TestBitrateObserver stream_a; |
| 140 | auto config_a = DefaultConfig(); |
| 141 | config_a.min_bitrate_bps = 100000; |
| 142 | config_a.priority_bitrate_bps = 0; |
| 143 | allocator_->AddObserver(&stream_a, config_a); |
| 144 | |
| 145 | TestBitrateObserver stream_b; |
| 146 | auto config_b = DefaultConfig(); |
| 147 | config_b.min_bitrate_bps = 100000; |
| 148 | config_b.max_bitrate_bps = 300000; |
| 149 | config_b.priority_bitrate_bps = 300000; |
| 150 | allocator_->AddObserver(&stream_b, config_b); |
| 151 | |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 152 | allocator_->OnNetworkEstimateChanged( |
| 153 | CreateTargetRateMessage(100000, 0, 0, 0)); |
Sebastian Jansson | 464a557 | 2019-02-12 12:32:32 | [diff] [blame] | 154 | EXPECT_EQ(stream_a.last_bitrate_bps_, 100000u); |
| 155 | EXPECT_EQ(stream_b.last_bitrate_bps_, 100000u); |
| 156 | |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 157 | allocator_->OnNetworkEstimateChanged( |
| 158 | CreateTargetRateMessage(200000, 0, 0, 0)); |
Sebastian Jansson | 464a557 | 2019-02-12 12:32:32 | [diff] [blame] | 159 | EXPECT_EQ(stream_a.last_bitrate_bps_, 100000u); |
| 160 | EXPECT_EQ(stream_b.last_bitrate_bps_, 100000u); |
| 161 | |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 162 | allocator_->OnNetworkEstimateChanged( |
| 163 | CreateTargetRateMessage(300000, 0, 0, 0)); |
Sebastian Jansson | 464a557 | 2019-02-12 12:32:32 | [diff] [blame] | 164 | EXPECT_EQ(stream_a.last_bitrate_bps_, 100000u); |
| 165 | EXPECT_EQ(stream_b.last_bitrate_bps_, 200000u); |
| 166 | |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 167 | allocator_->OnNetworkEstimateChanged( |
| 168 | CreateTargetRateMessage(400000, 0, 0, 0)); |
Sebastian Jansson | 464a557 | 2019-02-12 12:32:32 | [diff] [blame] | 169 | EXPECT_EQ(stream_a.last_bitrate_bps_, 100000u); |
| 170 | EXPECT_EQ(stream_b.last_bitrate_bps_, 300000u); |
| 171 | |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 172 | allocator_->OnNetworkEstimateChanged( |
| 173 | CreateTargetRateMessage(800000, 0, 0, 0)); |
Sebastian Jansson | 464a557 | 2019-02-12 12:32:32 | [diff] [blame] | 174 | EXPECT_EQ(stream_a.last_bitrate_bps_, 500000u); |
| 175 | EXPECT_EQ(stream_b.last_bitrate_bps_, 300000u); |
| 176 | } |
| 177 | |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 178 | TEST_F(BitrateAllocatorTest, UpdatingBitrateObserver) { |
| 179 | TestBitrateObserver bitrate_observer; |
perkj | 71ee44c | 2016-06-15 07:47:53 | [diff] [blame] | 180 | const uint32_t kMinSendBitrateBps = 100000; |
| 181 | const uint32_t kPadUpToBitrateBps = 50000; |
philipel | f69e768 | 2018-02-28 12:06:28 | [diff] [blame] | 182 | const uint32_t kMaxBitrateBps = 1500000; |
perkj | 71ee44c | 2016-06-15 07:47:53 | [diff] [blame] | 183 | |
philipel | f69e768 | 2018-02-28 12:06:28 | [diff] [blame] | 184 | EXPECT_CALL(limit_observer_, |
Sebastian Jansson | 93b1ea2 | 2019-09-18 16:31:52 | [diff] [blame] | 185 | OnAllocationLimitsChanged(AllocationLimitsEq( |
| 186 | kMinSendBitrateBps, kPadUpToBitrateBps, kMaxBitrateBps))); |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 187 | AddObserver(&bitrate_observer, kMinSendBitrateBps, kMaxBitrateBps, |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 188 | kPadUpToBitrateBps, true, kDefaultBitratePriority); |
perkj | 57c21f9 | 2016-06-17 14:27:16 | [diff] [blame] | 189 | EXPECT_EQ(300000, allocator_->GetStartBitrate(&bitrate_observer)); |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 190 | allocator_->OnNetworkEstimateChanged( |
| 191 | CreateTargetRateMessage(200000, 0, 0, kDefaultProbingIntervalMs)); |
perkj | 57c21f9 | 2016-06-17 14:27:16 | [diff] [blame] | 192 | EXPECT_EQ(200000, allocator_->GetStartBitrate(&bitrate_observer)); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 193 | |
Peter Boström | 8e4e8b0 | 2015-09-15 13:08:03 | [diff] [blame] | 194 | // TODO(pbos): Expect capping to 1.5M instead of 3M when not boosting the max |
mflodman | 0e7e259 | 2015-11-13 05:02:42 | [diff] [blame] | 195 | // bitrate for FEC/retransmissions (see todo in BitrateAllocator). |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 196 | allocator_->OnNetworkEstimateChanged( |
| 197 | CreateTargetRateMessage(4000000, 0, 0, kDefaultProbingIntervalMs)); |
perkj | 57c21f9 | 2016-06-17 14:27:16 | [diff] [blame] | 198 | EXPECT_EQ(3000000, allocator_->GetStartBitrate(&bitrate_observer)); |
perkj | 71ee44c | 2016-06-15 07:47:53 | [diff] [blame] | 199 | |
| 200 | // Expect |max_padding_bitrate_bps| to change to 0 if the observer is updated. |
Sebastian Jansson | 93b1ea2 | 2019-09-18 16:31:52 | [diff] [blame] | 201 | EXPECT_CALL(limit_observer_, OnAllocationLimitsChanged( |
| 202 | AllocationLimitsEq(kMinSendBitrateBps, 0))); |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 203 | AddObserver(&bitrate_observer, kMinSendBitrateBps, 4000000, 0, true, |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 204 | kDefaultBitratePriority); |
Sebastian Jansson | 93b1ea2 | 2019-09-18 16:31:52 | [diff] [blame] | 205 | EXPECT_CALL(limit_observer_, OnAllocationLimitsChanged( |
| 206 | AllocationLimitsEq(kMinSendBitrateBps, 0))); |
perkj | 57c21f9 | 2016-06-17 14:27:16 | [diff] [blame] | 207 | EXPECT_EQ(4000000, allocator_->GetStartBitrate(&bitrate_observer)); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 208 | |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 209 | AddObserver(&bitrate_observer, kMinSendBitrateBps, kMaxBitrateBps, 0, true, |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 210 | kDefaultBitratePriority); |
perkj | 57c21f9 | 2016-06-17 14:27:16 | [diff] [blame] | 211 | EXPECT_EQ(3000000, allocator_->GetStartBitrate(&bitrate_observer)); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 212 | EXPECT_EQ(3000000u, bitrate_observer.last_bitrate_bps_); |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 213 | allocator_->OnNetworkEstimateChanged( |
| 214 | CreateTargetRateMessage(kMaxBitrateBps, 0, 0, kDefaultProbingIntervalMs)); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 215 | EXPECT_EQ(1500000u, bitrate_observer.last_bitrate_bps_); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 216 | } |
| 217 | |
| 218 | TEST_F(BitrateAllocatorTest, TwoBitrateObserversOneRtcpObserver) { |
| 219 | TestBitrateObserver bitrate_observer_1; |
| 220 | TestBitrateObserver bitrate_observer_2; |
philipel | f69e768 | 2018-02-28 12:06:28 | [diff] [blame] | 221 | const uint32_t kObs1StartBitrateBps = 100000; |
| 222 | const uint32_t kObs2StartBitrateBps = 200000; |
| 223 | const uint32_t kObs1MaxBitrateBps = 300000; |
| 224 | const uint32_t kObs2MaxBitrateBps = 300000; |
| 225 | |
Sebastian Jansson | 93b1ea2 | 2019-09-18 16:31:52 | [diff] [blame] | 226 | EXPECT_CALL(limit_observer_, |
| 227 | OnAllocationLimitsChanged(AllocationLimitsEq( |
| 228 | kObs1StartBitrateBps, 0, kObs1MaxBitrateBps))); |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 229 | AddObserver(&bitrate_observer_1, kObs1StartBitrateBps, kObs1MaxBitrateBps, 0, |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 230 | true, kDefaultBitratePriority); |
philipel | f69e768 | 2018-02-28 12:06:28 | [diff] [blame] | 231 | EXPECT_EQ(static_cast<int>(kObs1MaxBitrateBps), |
| 232 | allocator_->GetStartBitrate(&bitrate_observer_1)); |
Sebastian Jansson | 93b1ea2 | 2019-09-18 16:31:52 | [diff] [blame] | 233 | EXPECT_CALL(limit_observer_, |
| 234 | OnAllocationLimitsChanged(AllocationLimitsEq( |
| 235 | kObs1StartBitrateBps + kObs2StartBitrateBps, 0, |
| 236 | kObs1MaxBitrateBps + kObs2MaxBitrateBps))); |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 237 | AddObserver(&bitrate_observer_2, kObs2StartBitrateBps, kObs2MaxBitrateBps, 0, |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 238 | true, kDefaultBitratePriority); |
philipel | f69e768 | 2018-02-28 12:06:28 | [diff] [blame] | 239 | EXPECT_EQ(static_cast<int>(kObs2StartBitrateBps), |
| 240 | allocator_->GetStartBitrate(&bitrate_observer_2)); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 241 | |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 242 | // Test too low start bitrate, hence lower than sum of min. Min bitrates |
| 243 | // will |
| 244 | // be allocated to all observers. |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 245 | allocator_->OnNetworkEstimateChanged(CreateTargetRateMessage( |
| 246 | kObs2StartBitrateBps, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 247 | EXPECT_EQ(100000u, bitrate_observer_1.last_bitrate_bps_); |
| 248 | EXPECT_EQ(0, bitrate_observer_1.last_fraction_loss_); |
| 249 | EXPECT_EQ(50, bitrate_observer_1.last_rtt_ms_); |
| 250 | EXPECT_EQ(200000u, bitrate_observer_2.last_bitrate_bps_); |
| 251 | EXPECT_EQ(0, bitrate_observer_2.last_fraction_loss_); |
| 252 | EXPECT_EQ(50, bitrate_observer_2.last_rtt_ms_); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 253 | |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 254 | // Test a bitrate which should be distributed equally. |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 255 | allocator_->OnNetworkEstimateChanged( |
| 256 | CreateTargetRateMessage(500000, 0, 50, kDefaultProbingIntervalMs)); |
philipel | f69e768 | 2018-02-28 12:06:28 | [diff] [blame] | 257 | const uint32_t kBitrateToShare = |
| 258 | 500000 - kObs2StartBitrateBps - kObs1StartBitrateBps; |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 259 | EXPECT_EQ(100000u + kBitrateToShare / 2, |
| 260 | bitrate_observer_1.last_bitrate_bps_); |
| 261 | EXPECT_EQ(200000u + kBitrateToShare / 2, |
| 262 | bitrate_observer_2.last_bitrate_bps_); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 263 | |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 264 | // Limited by 2x max bitrates since we leave room for FEC and |
| 265 | // retransmissions. |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 266 | allocator_->OnNetworkEstimateChanged( |
| 267 | CreateTargetRateMessage(1500000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 268 | EXPECT_EQ(600000u, bitrate_observer_1.last_bitrate_bps_); |
| 269 | EXPECT_EQ(600000u, bitrate_observer_2.last_bitrate_bps_); |
perkj | ec81bcd | 2016-05-11 13:01:13 | [diff] [blame] | 270 | |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 271 | // Verify that if the bandwidth estimate is set to zero, the allocated |
| 272 | // rate is |
| 273 | // zero. |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 274 | allocator_->OnNetworkEstimateChanged( |
| 275 | CreateTargetRateMessage(0, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 276 | EXPECT_EQ(0u, bitrate_observer_1.last_bitrate_bps_); |
| 277 | EXPECT_EQ(0u, bitrate_observer_2.last_bitrate_bps_); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 278 | } |
| 279 | |
perkj | 71ee44c | 2016-06-15 07:47:53 | [diff] [blame] | 280 | TEST_F(BitrateAllocatorTest, RemoveObserverTriggersLimitObserver) { |
| 281 | TestBitrateObserver bitrate_observer; |
| 282 | const uint32_t kMinSendBitrateBps = 100000; |
| 283 | const uint32_t kPadUpToBitrateBps = 50000; |
philipel | f69e768 | 2018-02-28 12:06:28 | [diff] [blame] | 284 | const uint32_t kMaxBitrateBps = 1500000; |
perkj | 71ee44c | 2016-06-15 07:47:53 | [diff] [blame] | 285 | |
philipel | f69e768 | 2018-02-28 12:06:28 | [diff] [blame] | 286 | EXPECT_CALL(limit_observer_, |
Sebastian Jansson | 93b1ea2 | 2019-09-18 16:31:52 | [diff] [blame] | 287 | OnAllocationLimitsChanged(AllocationLimitsEq( |
| 288 | kMinSendBitrateBps, kPadUpToBitrateBps, kMaxBitrateBps))); |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 289 | AddObserver(&bitrate_observer, kMinSendBitrateBps, kMaxBitrateBps, |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 290 | kPadUpToBitrateBps, true, kDefaultBitratePriority); |
Sebastian Jansson | 93b1ea2 | 2019-09-18 16:31:52 | [diff] [blame] | 291 | EXPECT_CALL(limit_observer_, |
| 292 | OnAllocationLimitsChanged(AllocationLimitsEq(0, 0))); |
perkj | 71ee44c | 2016-06-15 07:47:53 | [diff] [blame] | 293 | allocator_->RemoveObserver(&bitrate_observer); |
| 294 | } |
| 295 | |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 296 | class BitrateAllocatorTestNoEnforceMin : public ::testing::Test { |
| 297 | protected: |
perkj | 71ee44c | 2016-06-15 07:47:53 | [diff] [blame] | 298 | BitrateAllocatorTestNoEnforceMin() |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 299 | : allocator_(new BitrateAllocator(&limit_observer_)) { |
| 300 | allocator_->OnNetworkEstimateChanged( |
| 301 | CreateTargetRateMessage(300000u, 0, 0, kDefaultProbingIntervalMs)); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 302 | } |
| 303 | ~BitrateAllocatorTestNoEnforceMin() {} |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 304 | void AddObserver(BitrateAllocatorObserver* observer, |
| 305 | uint32_t min_bitrate_bps, |
| 306 | uint32_t max_bitrate_bps, |
| 307 | uint32_t pad_up_bitrate_bps, |
| 308 | bool enforce_min_bitrate, |
| 309 | std::string track_id, |
| 310 | double bitrate_priority) { |
| 311 | allocator_->AddObserver( |
Sebastian Jansson | 464a557 | 2019-02-12 12:32:32 | [diff] [blame] | 312 | observer, {min_bitrate_bps, max_bitrate_bps, pad_up_bitrate_bps, 0, |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 313 | enforce_min_bitrate, bitrate_priority}); |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 314 | } |
perkj | 71ee44c | 2016-06-15 07:47:53 | [diff] [blame] | 315 | NiceMock<MockLimitObserver> limit_observer_; |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 316 | std::unique_ptr<BitrateAllocator> allocator_; |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 317 | }; |
| 318 | |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 319 | // The following three tests verify enforcing a minimum bitrate works as |
| 320 | // intended. |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 321 | TEST_F(BitrateAllocatorTestNoEnforceMin, OneBitrateObserver) { |
| 322 | TestBitrateObserver bitrate_observer_1; |
perkj | 71ee44c | 2016-06-15 07:47:53 | [diff] [blame] | 323 | // Expect OnAllocationLimitsChanged with |min_send_bitrate_bps| = 0 since |
| 324 | // AddObserver is called with |enforce_min_bitrate| = false. |
Sebastian Jansson | 93b1ea2 | 2019-09-18 16:31:52 | [diff] [blame] | 325 | EXPECT_CALL(limit_observer_, |
| 326 | OnAllocationLimitsChanged(AllocationLimitsEq(0, 0))); |
| 327 | EXPECT_CALL(limit_observer_, |
| 328 | OnAllocationLimitsChanged(AllocationLimitsEq(0, 120000))); |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 329 | AddObserver(&bitrate_observer_1, 100000, 400000, 0, false, "", |
| 330 | kDefaultBitratePriority); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 331 | EXPECT_EQ(300000, allocator_->GetStartBitrate(&bitrate_observer_1)); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 332 | |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 333 | // High BWE. |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 334 | allocator_->OnNetworkEstimateChanged( |
| 335 | CreateTargetRateMessage(150000, 0, 0, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 336 | EXPECT_EQ(150000u, bitrate_observer_1.last_bitrate_bps_); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 337 | |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 338 | // Low BWE. |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 339 | allocator_->OnNetworkEstimateChanged( |
| 340 | CreateTargetRateMessage(10000, 0, 0, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 341 | EXPECT_EQ(0u, bitrate_observer_1.last_bitrate_bps_); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 342 | |
Sebastian Jansson | 93b1ea2 | 2019-09-18 16:31:52 | [diff] [blame] | 343 | EXPECT_CALL(limit_observer_, |
| 344 | OnAllocationLimitsChanged(AllocationLimitsEq(0, 0))); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 345 | allocator_->RemoveObserver(&bitrate_observer_1); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 346 | } |
| 347 | |
| 348 | TEST_F(BitrateAllocatorTestNoEnforceMin, ThreeBitrateObservers) { |
| 349 | TestBitrateObserver bitrate_observer_1; |
| 350 | TestBitrateObserver bitrate_observer_2; |
| 351 | TestBitrateObserver bitrate_observer_3; |
| 352 | // Set up the observers with min bitrates at 100000, 200000, and 300000. |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 353 | AddObserver(&bitrate_observer_1, 100000, 400000, 0, false, "", |
| 354 | kDefaultBitratePriority); |
perkj | 57c21f9 | 2016-06-17 14:27:16 | [diff] [blame] | 355 | EXPECT_EQ(300000, allocator_->GetStartBitrate(&bitrate_observer_1)); |
Stefan Holmer | e590416 | 2015-03-26 10:11:06 | [diff] [blame] | 356 | |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 357 | AddObserver(&bitrate_observer_2, 200000, 400000, 0, false, "", |
| 358 | kDefaultBitratePriority); |
perkj | 57c21f9 | 2016-06-17 14:27:16 | [diff] [blame] | 359 | EXPECT_EQ(200000, allocator_->GetStartBitrate(&bitrate_observer_2)); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 360 | EXPECT_EQ(100000u, bitrate_observer_1.last_bitrate_bps_); |
Stefan Holmer | e590416 | 2015-03-26 10:11:06 | [diff] [blame] | 361 | |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 362 | AddObserver(&bitrate_observer_3, 300000, 400000, 0, false, "", |
| 363 | kDefaultBitratePriority); |
perkj | 57c21f9 | 2016-06-17 14:27:16 | [diff] [blame] | 364 | EXPECT_EQ(0, allocator_->GetStartBitrate(&bitrate_observer_3)); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 365 | EXPECT_EQ(100000u, bitrate_observer_1.last_bitrate_bps_); |
| 366 | EXPECT_EQ(200000u, bitrate_observer_2.last_bitrate_bps_); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 367 | |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 368 | // High BWE. Make sure the controllers get a fair share of the surplus (i.e., |
| 369 | // what is left after each controller gets its min rate). |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 370 | allocator_->OnNetworkEstimateChanged( |
| 371 | CreateTargetRateMessage(690000, 0, 0, kDefaultProbingIntervalMs)); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 372 | // Verify that each observer gets its min rate (sum of min rates is 600000), |
| 373 | // and that the remaining 90000 is divided equally among the three. |
Stefan Holmer | e590416 | 2015-03-26 10:11:06 | [diff] [blame] | 374 | uint32_t bitrate_to_share = 690000u - 100000u - 200000u - 300000u; |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 375 | EXPECT_EQ(100000u + bitrate_to_share / 3, |
| 376 | bitrate_observer_1.last_bitrate_bps_); |
| 377 | EXPECT_EQ(200000u + bitrate_to_share / 3, |
| 378 | bitrate_observer_2.last_bitrate_bps_); |
| 379 | EXPECT_EQ(300000u + bitrate_to_share / 3, |
| 380 | bitrate_observer_3.last_bitrate_bps_); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 381 | |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 382 | // BWE below the sum of observer's min bitrate. |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 383 | allocator_->OnNetworkEstimateChanged( |
| 384 | CreateTargetRateMessage(300000, 0, 0, kDefaultProbingIntervalMs)); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 385 | EXPECT_EQ(100000u, bitrate_observer_1.last_bitrate_bps_); // Min bitrate. |
| 386 | EXPECT_EQ(200000u, bitrate_observer_2.last_bitrate_bps_); // Min bitrate. |
Yves Gerey | 665174f | 2018-06-19 13:03:05 | [diff] [blame] | 387 | EXPECT_EQ(0u, bitrate_observer_3.last_bitrate_bps_); // Nothing. |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 388 | |
| 389 | // Increased BWE, but still below the sum of configured min bitrates for all |
| 390 | // observers and too little for observer 3. 1 and 2 will share the rest. |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 391 | allocator_->OnNetworkEstimateChanged( |
| 392 | CreateTargetRateMessage(500000, 0, 0, kDefaultProbingIntervalMs)); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 393 | EXPECT_EQ(200000u, bitrate_observer_1.last_bitrate_bps_); // Min + split. |
| 394 | EXPECT_EQ(300000u, bitrate_observer_2.last_bitrate_bps_); // Min + split. |
Yves Gerey | 665174f | 2018-06-19 13:03:05 | [diff] [blame] | 395 | EXPECT_EQ(0u, bitrate_observer_3.last_bitrate_bps_); // Nothing. |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 396 | |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 397 | // Below min for all. |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 398 | allocator_->OnNetworkEstimateChanged( |
| 399 | CreateTargetRateMessage(10000, 0, 0, kDefaultProbingIntervalMs)); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 400 | EXPECT_EQ(0u, bitrate_observer_1.last_bitrate_bps_); |
| 401 | EXPECT_EQ(0u, bitrate_observer_2.last_bitrate_bps_); |
| 402 | EXPECT_EQ(0u, bitrate_observer_3.last_bitrate_bps_); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 403 | |
perkj | ec81bcd | 2016-05-11 13:01:13 | [diff] [blame] | 404 | // Verify that zero estimated bandwidth, means that that all gets zero, |
| 405 | // regardless of set min bitrate. |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 406 | allocator_->OnNetworkEstimateChanged( |
| 407 | CreateTargetRateMessage(0, 0, 0, kDefaultProbingIntervalMs)); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 408 | EXPECT_EQ(0u, bitrate_observer_1.last_bitrate_bps_); |
| 409 | EXPECT_EQ(0u, bitrate_observer_2.last_bitrate_bps_); |
| 410 | EXPECT_EQ(0u, bitrate_observer_3.last_bitrate_bps_); |
perkj | ec81bcd | 2016-05-11 13:01:13 | [diff] [blame] | 411 | |
mflodman | 86aabb2 | 2016-03-11 14:44:32 | [diff] [blame] | 412 | allocator_->RemoveObserver(&bitrate_observer_1); |
| 413 | allocator_->RemoveObserver(&bitrate_observer_2); |
| 414 | allocator_->RemoveObserver(&bitrate_observer_3); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 415 | } |
| 416 | |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 417 | TEST_F(BitrateAllocatorTestNoEnforceMin, OneBitrateObserverWithPacketLoss) { |
Erik Språng | d1d7b23 | 2018-12-06 16:31:25 | [diff] [blame] | 418 | const uint32_t kMinBitrateBps = 100000; |
| 419 | const uint32_t kMaxBitrateBps = 400000; |
| 420 | // Hysteresis adds another 10% or 20kbps to min bitrate. |
| 421 | const uint32_t kMinStartBitrateBps = |
| 422 | kMinBitrateBps + std::max(20000u, kMinBitrateBps / 10); |
| 423 | |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 424 | // Expect OnAllocationLimitsChanged with |min_send_bitrate_bps| = 0 since |
| 425 | // AddObserver is called with |enforce_min_bitrate| = false. |
Erik Språng | d1d7b23 | 2018-12-06 16:31:25 | [diff] [blame] | 426 | TestBitrateObserver bitrate_observer; |
Sebastian Jansson | 93b1ea2 | 2019-09-18 16:31:52 | [diff] [blame] | 427 | EXPECT_CALL(limit_observer_, OnAllocationLimitsChanged( |
| 428 | AllocationLimitsEq(0, 0, kMaxBitrateBps))); |
Erik Språng | d1d7b23 | 2018-12-06 16:31:25 | [diff] [blame] | 429 | AddObserver(&bitrate_observer, kMinBitrateBps, kMaxBitrateBps, 0, false, "", |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 430 | kDefaultBitratePriority); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 431 | EXPECT_EQ(300000, allocator_->GetStartBitrate(&bitrate_observer)); |
| 432 | |
| 433 | // High BWE. |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 434 | allocator_->OnNetworkEstimateChanged( |
| 435 | CreateTargetRateMessage(150000, 0, 0, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 436 | EXPECT_EQ(150000u, bitrate_observer.last_bitrate_bps_); |
| 437 | |
| 438 | // Add loss and use a part of the bitrate for protection. |
Erik Språng | d1d7b23 | 2018-12-06 16:31:25 | [diff] [blame] | 439 | const double kProtectionRatio = 0.4; |
Rasmus Brandt | 681de20 | 2019-02-04 14:09:34 | [diff] [blame] | 440 | const uint8_t fraction_loss = kProtectionRatio * 256; |
Erik Språng | d1d7b23 | 2018-12-06 16:31:25 | [diff] [blame] | 441 | bitrate_observer.SetBitrateProtectionRatio(kProtectionRatio); |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 442 | allocator_->OnNetworkEstimateChanged(CreateTargetRateMessage( |
| 443 | 200000, 0, fraction_loss, kDefaultProbingIntervalMs)); |
Rasmus Brandt | 681de20 | 2019-02-04 14:09:34 | [diff] [blame] | 444 | EXPECT_EQ(200000u, bitrate_observer.last_bitrate_bps_); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 445 | |
| 446 | // Above the min threshold, but not enough given the protection used. |
Erik Språng | d1d7b23 | 2018-12-06 16:31:25 | [diff] [blame] | 447 | // Limits changed, as we will video is now off and we need to pad up to the |
| 448 | // start bitrate. |
Erik Språng | d1d7b23 | 2018-12-06 16:31:25 | [diff] [blame] | 449 | // Verify the hysteresis is added for the protection. |
| 450 | const uint32_t kMinStartBitrateWithProtectionBps = |
| 451 | static_cast<uint32_t>(kMinStartBitrateBps * (1 + kProtectionRatio)); |
| 452 | EXPECT_CALL(limit_observer_, |
Sebastian Jansson | 93b1ea2 | 2019-09-18 16:31:52 | [diff] [blame] | 453 | OnAllocationLimitsChanged(AllocationLimitsEq( |
| 454 | 0, kMinStartBitrateWithProtectionBps, kMaxBitrateBps))); |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 455 | allocator_->OnNetworkEstimateChanged(CreateTargetRateMessage( |
| 456 | kMinStartBitrateBps + 1000, 0, fraction_loss, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 457 | EXPECT_EQ(0u, bitrate_observer.last_bitrate_bps_); |
| 458 | |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 459 | allocator_->OnNetworkEstimateChanged( |
| 460 | CreateTargetRateMessage(kMinStartBitrateWithProtectionBps - 1000, 0, |
| 461 | fraction_loss, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 462 | EXPECT_EQ(0u, bitrate_observer.last_bitrate_bps_); |
| 463 | |
| 464 | // Just enough to enable video again. |
Sebastian Jansson | 93b1ea2 | 2019-09-18 16:31:52 | [diff] [blame] | 465 | EXPECT_CALL(limit_observer_, OnAllocationLimitsChanged( |
| 466 | AllocationLimitsEq(0, 0, kMaxBitrateBps))); |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 467 | allocator_->OnNetworkEstimateChanged( |
| 468 | CreateTargetRateMessage(kMinStartBitrateWithProtectionBps, 0, |
| 469 | fraction_loss, kDefaultProbingIntervalMs)); |
Erik Språng | d1d7b23 | 2018-12-06 16:31:25 | [diff] [blame] | 470 | EXPECT_EQ(kMinStartBitrateWithProtectionBps, |
| 471 | bitrate_observer.last_bitrate_bps_); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 472 | |
| 473 | // Remove all protection and make sure video is not paused as earlier. |
| 474 | bitrate_observer.SetBitrateProtectionRatio(0.0); |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 475 | allocator_->OnNetworkEstimateChanged( |
| 476 | CreateTargetRateMessage(kMinStartBitrateWithProtectionBps - 1000, 0, 0, |
| 477 | kDefaultProbingIntervalMs)); |
Erik Språng | d1d7b23 | 2018-12-06 16:31:25 | [diff] [blame] | 478 | EXPECT_EQ(kMinStartBitrateWithProtectionBps - 1000, |
| 479 | bitrate_observer.last_bitrate_bps_); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 480 | |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 481 | allocator_->OnNetworkEstimateChanged(CreateTargetRateMessage( |
| 482 | kMinStartBitrateBps, 0, 0, kDefaultProbingIntervalMs)); |
Erik Språng | d1d7b23 | 2018-12-06 16:31:25 | [diff] [blame] | 483 | EXPECT_EQ(kMinStartBitrateBps, bitrate_observer.last_bitrate_bps_); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 484 | |
Sebastian Jansson | 93b1ea2 | 2019-09-18 16:31:52 | [diff] [blame] | 485 | EXPECT_CALL(limit_observer_, |
| 486 | OnAllocationLimitsChanged(AllocationLimitsEq(0, 0, 0))); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 487 | allocator_->RemoveObserver(&bitrate_observer); |
| 488 | } |
| 489 | |
Rasmus Brandt | 681de20 | 2019-02-04 14:09:34 | [diff] [blame] | 490 | TEST_F(BitrateAllocatorTest, |
| 491 | TotalAllocationLimitsAreUnaffectedByProtectionRatio) { |
| 492 | TestBitrateObserver bitrate_observer; |
| 493 | |
| 494 | const uint32_t kMinBitrateBps = 100000; |
| 495 | const uint32_t kMaxBitrateBps = 400000; |
| 496 | |
| 497 | // Register |bitrate_observer| and expect total allocation limits to change. |
Sebastian Jansson | 93b1ea2 | 2019-09-18 16:31:52 | [diff] [blame] | 498 | EXPECT_CALL(limit_observer_, OnAllocationLimitsChanged(AllocationLimitsEq( |
| 499 | kMinBitrateBps, 0, kMaxBitrateBps))) |
Rasmus Brandt | 681de20 | 2019-02-04 14:09:34 | [diff] [blame] | 500 | .Times(1); |
Sebastian Jansson | 464a557 | 2019-02-12 12:32:32 | [diff] [blame] | 501 | MediaStreamAllocationConfig allocation_config = DefaultConfig(); |
| 502 | allocation_config.min_bitrate_bps = kMinBitrateBps; |
| 503 | allocation_config.max_bitrate_bps = kMaxBitrateBps; |
| 504 | allocator_->AddObserver(&bitrate_observer, allocation_config); |
Rasmus Brandt | 681de20 | 2019-02-04 14:09:34 | [diff] [blame] | 505 | |
| 506 | // Observer uses 20% of it's allocated bitrate for protection. |
| 507 | bitrate_observer.SetBitrateProtectionRatio(/*protection_ratio=*/0.2); |
| 508 | // Total allocation limits are unaffected by the protection rate change. |
Sebastian Jansson | 93b1ea2 | 2019-09-18 16:31:52 | [diff] [blame] | 509 | EXPECT_CALL(limit_observer_, OnAllocationLimitsChanged(_)).Times(0); |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 510 | allocator_->OnNetworkEstimateChanged( |
| 511 | CreateTargetRateMessage(200000u, 0, 100, kDefaultProbingIntervalMs)); |
Rasmus Brandt | 681de20 | 2019-02-04 14:09:34 | [diff] [blame] | 512 | |
| 513 | // Observer uses 0% of it's allocated bitrate for protection. |
| 514 | bitrate_observer.SetBitrateProtectionRatio(/*protection_ratio=*/0.0); |
| 515 | // Total allocation limits are unaffected by the protection rate change. |
Sebastian Jansson | 93b1ea2 | 2019-09-18 16:31:52 | [diff] [blame] | 516 | EXPECT_CALL(limit_observer_, OnAllocationLimitsChanged(_)).Times(0); |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 517 | allocator_->OnNetworkEstimateChanged( |
| 518 | CreateTargetRateMessage(200000u, 0, 100, kDefaultProbingIntervalMs)); |
Rasmus Brandt | 681de20 | 2019-02-04 14:09:34 | [diff] [blame] | 519 | |
| 520 | // Observer again uses 20% of it's allocated bitrate for protection. |
| 521 | bitrate_observer.SetBitrateProtectionRatio(/*protection_ratio=*/0.2); |
| 522 | // Total allocation limits are unaffected by the protection rate change. |
Sebastian Jansson | 93b1ea2 | 2019-09-18 16:31:52 | [diff] [blame] | 523 | EXPECT_CALL(limit_observer_, OnAllocationLimitsChanged(_)).Times(0); |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 524 | allocator_->OnNetworkEstimateChanged( |
| 525 | CreateTargetRateMessage(200000u, 0, 100, kDefaultProbingIntervalMs)); |
Rasmus Brandt | 681de20 | 2019-02-04 14:09:34 | [diff] [blame] | 526 | } |
| 527 | |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 528 | TEST_F(BitrateAllocatorTestNoEnforceMin, TwoBitrateObserverWithPacketLoss) { |
| 529 | TestBitrateObserver bitrate_observer_1; |
| 530 | TestBitrateObserver bitrate_observer_2; |
| 531 | |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 532 | AddObserver(&bitrate_observer_1, 100000, 400000, 0, false, "", |
| 533 | kDefaultBitratePriority); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 534 | EXPECT_EQ(300000, allocator_->GetStartBitrate(&bitrate_observer_1)); |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 535 | AddObserver(&bitrate_observer_2, 200000, 400000, 0, false, "", |
| 536 | kDefaultBitratePriority); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 537 | EXPECT_EQ(200000, allocator_->GetStartBitrate(&bitrate_observer_2)); |
| 538 | EXPECT_EQ(100000u, bitrate_observer_1.last_bitrate_bps_); |
| 539 | |
| 540 | // Enough bitrate for both. |
| 541 | bitrate_observer_2.SetBitrateProtectionRatio(0.5); |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 542 | allocator_->OnNetworkEstimateChanged( |
| 543 | CreateTargetRateMessage(300000, 0, 0, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 544 | EXPECT_EQ(100000u, bitrate_observer_1.last_bitrate_bps_); |
| 545 | EXPECT_EQ(200000u, bitrate_observer_2.last_bitrate_bps_); |
| 546 | |
| 547 | // Above min for observer 2, but too little given the protection used. |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 548 | allocator_->OnNetworkEstimateChanged( |
| 549 | CreateTargetRateMessage(330000, 0, 0, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 550 | EXPECT_EQ(330000u, bitrate_observer_1.last_bitrate_bps_); |
| 551 | EXPECT_EQ(0u, bitrate_observer_2.last_bitrate_bps_); |
| 552 | |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 553 | allocator_->OnNetworkEstimateChanged( |
| 554 | CreateTargetRateMessage(100000, 0, 0, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 555 | EXPECT_EQ(100000u, bitrate_observer_1.last_bitrate_bps_); |
| 556 | EXPECT_EQ(0u, bitrate_observer_2.last_bitrate_bps_); |
| 557 | |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 558 | allocator_->OnNetworkEstimateChanged( |
| 559 | CreateTargetRateMessage(99999, 0, 0, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 560 | EXPECT_EQ(0u, bitrate_observer_1.last_bitrate_bps_); |
| 561 | EXPECT_EQ(0u, bitrate_observer_2.last_bitrate_bps_); |
| 562 | |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 563 | allocator_->OnNetworkEstimateChanged( |
| 564 | CreateTargetRateMessage(119000, 0, 0, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 565 | EXPECT_EQ(0u, bitrate_observer_1.last_bitrate_bps_); |
| 566 | EXPECT_EQ(0u, bitrate_observer_2.last_bitrate_bps_); |
| 567 | |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 568 | allocator_->OnNetworkEstimateChanged( |
| 569 | CreateTargetRateMessage(120000, 0, 0, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 570 | EXPECT_EQ(120000u, bitrate_observer_1.last_bitrate_bps_); |
| 571 | EXPECT_EQ(0u, bitrate_observer_2.last_bitrate_bps_); |
| 572 | |
| 573 | // Verify the protection is accounted for before resuming observer 2. |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 574 | allocator_->OnNetworkEstimateChanged( |
| 575 | CreateTargetRateMessage(429000, 0, 0, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 576 | EXPECT_EQ(400000u, bitrate_observer_1.last_bitrate_bps_); |
| 577 | EXPECT_EQ(0u, bitrate_observer_2.last_bitrate_bps_); |
| 578 | |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 579 | allocator_->OnNetworkEstimateChanged( |
| 580 | CreateTargetRateMessage(430000, 0, 0, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 581 | EXPECT_EQ(100000u, bitrate_observer_1.last_bitrate_bps_); |
| 582 | EXPECT_EQ(330000u, bitrate_observer_2.last_bitrate_bps_); |
| 583 | |
| 584 | allocator_->RemoveObserver(&bitrate_observer_1); |
| 585 | allocator_->RemoveObserver(&bitrate_observer_2); |
| 586 | } |
| 587 | |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 588 | TEST_F(BitrateAllocatorTest, ThreeBitrateObserversLowBweEnforceMin) { |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 589 | TestBitrateObserver bitrate_observer_1; |
| 590 | TestBitrateObserver bitrate_observer_2; |
| 591 | TestBitrateObserver bitrate_observer_3; |
Stefan Holmer | e590416 | 2015-03-26 10:11:06 | [diff] [blame] | 592 | |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 593 | AddObserver(&bitrate_observer_1, 100000, 400000, 0, true, |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 594 | kDefaultBitratePriority); |
perkj | 57c21f9 | 2016-06-17 14:27:16 | [diff] [blame] | 595 | EXPECT_EQ(300000, allocator_->GetStartBitrate(&bitrate_observer_1)); |
| 596 | |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 597 | AddObserver(&bitrate_observer_2, 200000, 400000, 0, true, |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 598 | kDefaultBitratePriority); |
perkj | 57c21f9 | 2016-06-17 14:27:16 | [diff] [blame] | 599 | EXPECT_EQ(200000, allocator_->GetStartBitrate(&bitrate_observer_2)); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 600 | EXPECT_EQ(100000u, bitrate_observer_1.last_bitrate_bps_); |
Stefan Holmer | e590416 | 2015-03-26 10:11:06 | [diff] [blame] | 601 | |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 602 | AddObserver(&bitrate_observer_3, 300000, 400000, 0, true, |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 603 | kDefaultBitratePriority); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 604 | EXPECT_EQ(300000, allocator_->GetStartBitrate(&bitrate_observer_3)); |
| 605 | EXPECT_EQ(100000, static_cast<int>(bitrate_observer_1.last_bitrate_bps_)); |
| 606 | EXPECT_EQ(200000, static_cast<int>(bitrate_observer_2.last_bitrate_bps_)); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 607 | |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 608 | // Low BWE. Verify that all observers still get their respective min |
| 609 | // bitrate. |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 610 | allocator_->OnNetworkEstimateChanged( |
| 611 | CreateTargetRateMessage(1000, 0, 0, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 612 | EXPECT_EQ(100000u, bitrate_observer_1.last_bitrate_bps_); // Min cap. |
| 613 | EXPECT_EQ(200000u, bitrate_observer_2.last_bitrate_bps_); // Min cap. |
| 614 | EXPECT_EQ(300000u, bitrate_observer_3.last_bitrate_bps_); // Min cap. |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 615 | |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 616 | allocator_->RemoveObserver(&bitrate_observer_1); |
| 617 | allocator_->RemoveObserver(&bitrate_observer_2); |
| 618 | allocator_->RemoveObserver(&bitrate_observer_3); |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 619 | } |
perkj | fea9309 | 2016-05-14 07:58:48 | [diff] [blame] | 620 | |
| 621 | TEST_F(BitrateAllocatorTest, AddObserverWhileNetworkDown) { |
| 622 | TestBitrateObserver bitrate_observer_1; |
Sebastian Jansson | 93b1ea2 | 2019-09-18 16:31:52 | [diff] [blame] | 623 | EXPECT_CALL(limit_observer_, |
| 624 | OnAllocationLimitsChanged(AllocationLimitsEq(50000, 0))); |
perkj | 57c21f9 | 2016-06-17 14:27:16 | [diff] [blame] | 625 | |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 626 | AddObserver(&bitrate_observer_1, 50000, 400000, 0, true, |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 627 | kDefaultBitratePriority); |
perkj | 57c21f9 | 2016-06-17 14:27:16 | [diff] [blame] | 628 | EXPECT_EQ(300000, allocator_->GetStartBitrate(&bitrate_observer_1)); |
perkj | fea9309 | 2016-05-14 07:58:48 | [diff] [blame] | 629 | |
| 630 | // Set network down, ie, no available bitrate. |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 631 | allocator_->OnNetworkEstimateChanged( |
| 632 | CreateTargetRateMessage(0, 0, 0, kDefaultProbingIntervalMs)); |
perkj | fea9309 | 2016-05-14 07:58:48 | [diff] [blame] | 633 | |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 634 | EXPECT_EQ(0u, bitrate_observer_1.last_bitrate_bps_); |
perkj | fea9309 | 2016-05-14 07:58:48 | [diff] [blame] | 635 | |
| 636 | TestBitrateObserver bitrate_observer_2; |
perkj | 71ee44c | 2016-06-15 07:47:53 | [diff] [blame] | 637 | // Adding an observer while the network is down should not affect the limits. |
Sebastian Jansson | 93b1ea2 | 2019-09-18 16:31:52 | [diff] [blame] | 638 | EXPECT_CALL(limit_observer_, |
| 639 | OnAllocationLimitsChanged(AllocationLimitsEq(50000 + 50000, 0))); |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 640 | AddObserver(&bitrate_observer_2, 50000, 400000, 0, true, |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 641 | kDefaultBitratePriority); |
perkj | fea9309 | 2016-05-14 07:58:48 | [diff] [blame] | 642 | |
| 643 | // Expect the start_bitrate to be set as if the network was still up but that |
| 644 | // the new observer have been notified that the network is down. |
perkj | 57c21f9 | 2016-06-17 14:27:16 | [diff] [blame] | 645 | EXPECT_EQ(300000 / 2, allocator_->GetStartBitrate(&bitrate_observer_2)); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 646 | EXPECT_EQ(0u, bitrate_observer_1.last_bitrate_bps_); |
| 647 | EXPECT_EQ(0u, bitrate_observer_2.last_bitrate_bps_); |
perkj | fea9309 | 2016-05-14 07:58:48 | [diff] [blame] | 648 | |
| 649 | // Set network back up. |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 650 | allocator_->OnNetworkEstimateChanged( |
| 651 | CreateTargetRateMessage(1500000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 652 | EXPECT_EQ(750000u, bitrate_observer_1.last_bitrate_bps_); |
| 653 | EXPECT_EQ(750000u, bitrate_observer_2.last_bitrate_bps_); |
| 654 | } |
| 655 | |
| 656 | TEST_F(BitrateAllocatorTest, MixedEnforecedConfigs) { |
| 657 | TestBitrateObserver enforced_observer; |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 658 | AddObserver(&enforced_observer, 6000, 30000, 0, true, |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 659 | kDefaultBitratePriority); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 660 | EXPECT_EQ(60000, allocator_->GetStartBitrate(&enforced_observer)); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 661 | |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 662 | TestBitrateObserver not_enforced_observer; |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 663 | AddObserver(¬_enforced_observer, 30000, 2500000, 0, false, |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 664 | kDefaultBitratePriority); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 665 | EXPECT_EQ(270000, allocator_->GetStartBitrate(¬_enforced_observer)); |
| 666 | EXPECT_EQ(30000u, enforced_observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 667 | |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 668 | allocator_->OnNetworkEstimateChanged( |
| 669 | CreateTargetRateMessage(36000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 670 | EXPECT_EQ(6000u, enforced_observer.last_bitrate_bps_); |
| 671 | EXPECT_EQ(30000u, not_enforced_observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 672 | |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 673 | allocator_->OnNetworkEstimateChanged( |
| 674 | CreateTargetRateMessage(35000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 675 | EXPECT_EQ(30000u, enforced_observer.last_bitrate_bps_); |
| 676 | EXPECT_EQ(0u, not_enforced_observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 677 | |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 678 | allocator_->OnNetworkEstimateChanged( |
| 679 | CreateTargetRateMessage(5000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 680 | EXPECT_EQ(6000u, enforced_observer.last_bitrate_bps_); |
| 681 | EXPECT_EQ(0u, not_enforced_observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 682 | |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 683 | allocator_->OnNetworkEstimateChanged( |
| 684 | CreateTargetRateMessage(36000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 685 | EXPECT_EQ(30000u, enforced_observer.last_bitrate_bps_); |
| 686 | EXPECT_EQ(0u, not_enforced_observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 687 | |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 688 | allocator_->OnNetworkEstimateChanged( |
| 689 | CreateTargetRateMessage(55000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 690 | EXPECT_EQ(30000u, enforced_observer.last_bitrate_bps_); |
| 691 | EXPECT_EQ(0u, not_enforced_observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 692 | |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 693 | allocator_->OnNetworkEstimateChanged( |
| 694 | CreateTargetRateMessage(56000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 695 | EXPECT_EQ(6000u, enforced_observer.last_bitrate_bps_); |
| 696 | EXPECT_EQ(50000u, not_enforced_observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 697 | |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 698 | allocator_->OnNetworkEstimateChanged( |
| 699 | CreateTargetRateMessage(56000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 700 | EXPECT_EQ(16000u, enforced_observer.last_bitrate_bps_); |
| 701 | EXPECT_EQ(40000u, not_enforced_observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 702 | |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 703 | allocator_->RemoveObserver(&enforced_observer); |
| 704 | allocator_->RemoveObserver(¬_enforced_observer); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 705 | } |
| 706 | |
| 707 | TEST_F(BitrateAllocatorTest, AvoidToggleAbsolute) { |
| 708 | TestBitrateObserver observer; |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 709 | AddObserver(&observer, 30000, 300000, 0, false, kDefaultBitratePriority); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 710 | EXPECT_EQ(300000, allocator_->GetStartBitrate(&observer)); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 711 | |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 712 | allocator_->OnNetworkEstimateChanged( |
| 713 | CreateTargetRateMessage(30000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 714 | EXPECT_EQ(30000u, observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 715 | |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 716 | allocator_->OnNetworkEstimateChanged( |
| 717 | CreateTargetRateMessage(20000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 718 | EXPECT_EQ(0u, observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 719 | |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 720 | allocator_->OnNetworkEstimateChanged( |
| 721 | CreateTargetRateMessage(30000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 722 | EXPECT_EQ(0u, observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 723 | |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 724 | allocator_->OnNetworkEstimateChanged( |
| 725 | CreateTargetRateMessage(49000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 726 | EXPECT_EQ(0u, observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 727 | |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 728 | allocator_->OnNetworkEstimateChanged( |
| 729 | CreateTargetRateMessage(50000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 730 | EXPECT_EQ(50000u, observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 731 | |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 732 | allocator_->OnNetworkEstimateChanged( |
| 733 | CreateTargetRateMessage(30000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 734 | EXPECT_EQ(30000u, observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 735 | |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 736 | allocator_->RemoveObserver(&observer); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 737 | } |
| 738 | |
| 739 | TEST_F(BitrateAllocatorTest, AvoidTogglePercent) { |
| 740 | TestBitrateObserver observer; |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 741 | AddObserver(&observer, 300000, 600000, 0, false, kDefaultBitratePriority); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 742 | EXPECT_EQ(300000, allocator_->GetStartBitrate(&observer)); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 743 | |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 744 | allocator_->OnNetworkEstimateChanged( |
| 745 | CreateTargetRateMessage(300000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 746 | EXPECT_EQ(300000u, observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 747 | |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 748 | allocator_->OnNetworkEstimateChanged( |
| 749 | CreateTargetRateMessage(200000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 750 | EXPECT_EQ(0u, observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 751 | |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 752 | allocator_->OnNetworkEstimateChanged( |
| 753 | CreateTargetRateMessage(300000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 754 | EXPECT_EQ(0u, observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 755 | |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 756 | allocator_->OnNetworkEstimateChanged( |
| 757 | CreateTargetRateMessage(329000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 758 | EXPECT_EQ(0u, observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 759 | |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 760 | allocator_->OnNetworkEstimateChanged( |
| 761 | CreateTargetRateMessage(330000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 762 | EXPECT_EQ(330000u, observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 763 | |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 764 | allocator_->OnNetworkEstimateChanged( |
| 765 | CreateTargetRateMessage(300000, 0, 50, kDefaultProbingIntervalMs)); |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 766 | EXPECT_EQ(300000u, observer.last_bitrate_bps_); |
mflodman | 101f250 | 2016-06-09 15:21:19 | [diff] [blame] | 767 | |
mflodman | 48a4beb | 2016-07-01 11:03:59 | [diff] [blame] | 768 | allocator_->RemoveObserver(&observer); |
perkj | fea9309 | 2016-05-14 07:58:48 | [diff] [blame] | 769 | } |
| 770 | |
minyue | 78b4d56 | 2016-11-30 12:47:39 | [diff] [blame] | 771 | TEST_F(BitrateAllocatorTest, PassProbingInterval) { |
| 772 | TestBitrateObserver observer; |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 773 | AddObserver(&observer, 300000, 600000, 0, false, kDefaultBitratePriority); |
minyue | 78b4d56 | 2016-11-30 12:47:39 | [diff] [blame] | 774 | EXPECT_EQ(300000, allocator_->GetStartBitrate(&observer)); |
| 775 | |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 776 | allocator_->OnNetworkEstimateChanged( |
| 777 | CreateTargetRateMessage(300000, 0, 50, 5000)); |
minyue | 78b4d56 | 2016-11-30 12:47:39 | [diff] [blame] | 778 | EXPECT_EQ(5000, observer.last_probing_interval_ms_); |
| 779 | |
| 780 | allocator_->RemoveObserver(&observer); |
| 781 | } |
| 782 | |
Seth Hampson | fe73d6a | 2017-11-14 18:49:06 | [diff] [blame] | 783 | TEST_F(BitrateAllocatorTest, PriorityRateOneObserverBasic) { |
| 784 | TestBitrateObserver observer; |
| 785 | const uint32_t kMinSendBitrateBps = 10; |
| 786 | const uint32_t kMaxSendBitrateBps = 60; |
| 787 | const uint32_t kNetworkBandwidthBps = 30; |
| 788 | |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 789 | AddObserver(&observer, kMinSendBitrateBps, kMaxSendBitrateBps, 0, true, 2.0); |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 790 | allocator_->OnNetworkEstimateChanged(CreateTargetRateMessage( |
| 791 | kNetworkBandwidthBps, 0, 0, kDefaultProbingIntervalMs)); |
Seth Hampson | fe73d6a | 2017-11-14 18:49:06 | [diff] [blame] | 792 | |
| 793 | EXPECT_EQ(kNetworkBandwidthBps, observer.last_bitrate_bps_); |
| 794 | |
| 795 | allocator_->RemoveObserver(&observer); |
| 796 | } |
| 797 | |
| 798 | // Tests that two observers with the same bitrate priority are allocated |
| 799 | // their bitrate evenly. |
| 800 | TEST_F(BitrateAllocatorTest, PriorityRateTwoObserversBasic) { |
| 801 | TestBitrateObserver observer_low_1; |
| 802 | TestBitrateObserver observer_low_2; |
| 803 | const uint32_t kMinSendBitrateBps = 10; |
| 804 | const uint32_t kMaxSendBitrateBps = 60; |
| 805 | const uint32_t kNetworkBandwidthBps = 60; |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 806 | AddObserver(&observer_low_1, kMinSendBitrateBps, kMaxSendBitrateBps, 0, false, |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 807 | 2.0); |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 808 | AddObserver(&observer_low_2, kMinSendBitrateBps, kMaxSendBitrateBps, 0, false, |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 809 | 2.0); |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 810 | allocator_->OnNetworkEstimateChanged(CreateTargetRateMessage( |
| 811 | kNetworkBandwidthBps, 0, 0, kDefaultProbingIntervalMs)); |
Seth Hampson | fe73d6a | 2017-11-14 18:49:06 | [diff] [blame] | 812 | |
| 813 | EXPECT_EQ(kNetworkBandwidthBps / 2, observer_low_1.last_bitrate_bps_); |
| 814 | EXPECT_EQ(kNetworkBandwidthBps / 2, observer_low_2.last_bitrate_bps_); |
| 815 | |
| 816 | allocator_->RemoveObserver(&observer_low_1); |
| 817 | allocator_->RemoveObserver(&observer_low_2); |
| 818 | } |
| 819 | |
| 820 | // Tests that there is no difference in functionality when the min bitrate is |
| 821 | // enforced. |
| 822 | TEST_F(BitrateAllocatorTest, PriorityRateTwoObserversBasicMinEnforced) { |
| 823 | TestBitrateObserver observer_low_1; |
| 824 | TestBitrateObserver observer_low_2; |
| 825 | const uint32_t kMinSendBitrateBps = 0; |
| 826 | const uint32_t kMaxSendBitrateBps = 60; |
| 827 | const uint32_t kNetworkBandwidthBps = 60; |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 828 | AddObserver(&observer_low_1, kMinSendBitrateBps, kMaxSendBitrateBps, 0, true, |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 829 | 2.0); |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 830 | AddObserver(&observer_low_2, kMinSendBitrateBps, kMaxSendBitrateBps, 0, true, |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 831 | 2.0); |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 832 | allocator_->OnNetworkEstimateChanged(CreateTargetRateMessage( |
| 833 | kNetworkBandwidthBps, 0, 0, kDefaultProbingIntervalMs)); |
Seth Hampson | fe73d6a | 2017-11-14 18:49:06 | [diff] [blame] | 834 | |
| 835 | EXPECT_EQ(kNetworkBandwidthBps / 2, observer_low_1.last_bitrate_bps_); |
| 836 | EXPECT_EQ(kNetworkBandwidthBps / 2, observer_low_2.last_bitrate_bps_); |
| 837 | |
| 838 | allocator_->RemoveObserver(&observer_low_1); |
| 839 | allocator_->RemoveObserver(&observer_low_2); |
| 840 | } |
| 841 | |
| 842 | // Tests that if the available bandwidth is the sum of the max bitrate |
| 843 | // of all observers, they will be allocated their max. |
| 844 | TEST_F(BitrateAllocatorTest, PriorityRateTwoObserversBothAllocatedMax) { |
| 845 | TestBitrateObserver observer_low; |
| 846 | TestBitrateObserver observer_mid; |
| 847 | const uint32_t kMinSendBitrateBps = 0; |
| 848 | const uint32_t kMaxSendBitrateBps = 60; |
| 849 | const uint32_t kNetworkBandwidthBps = kMaxSendBitrateBps * 2; |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 850 | AddObserver(&observer_low, kMinSendBitrateBps, kMaxSendBitrateBps, 0, true, |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 851 | 2.0); |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 852 | AddObserver(&observer_mid, kMinSendBitrateBps, kMaxSendBitrateBps, 0, true, |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 853 | 4.0); |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 854 | allocator_->OnNetworkEstimateChanged(CreateTargetRateMessage( |
| 855 | kNetworkBandwidthBps, 0, 0, kDefaultProbingIntervalMs)); |
Seth Hampson | fe73d6a | 2017-11-14 18:49:06 | [diff] [blame] | 856 | |
| 857 | EXPECT_EQ(kMaxSendBitrateBps, observer_low.last_bitrate_bps_); |
| 858 | EXPECT_EQ(kMaxSendBitrateBps, observer_mid.last_bitrate_bps_); |
| 859 | |
| 860 | allocator_->RemoveObserver(&observer_low); |
| 861 | allocator_->RemoveObserver(&observer_mid); |
| 862 | } |
| 863 | |
| 864 | // Tests that after a higher bitrate priority observer has been allocated its |
| 865 | // max bitrate the lower priority observer will then be allocated the remaining |
| 866 | // bitrate. |
| 867 | TEST_F(BitrateAllocatorTest, PriorityRateTwoObserversOneAllocatedToMax) { |
| 868 | TestBitrateObserver observer_low; |
| 869 | TestBitrateObserver observer_mid; |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 870 | AddObserver(&observer_low, 10, 50, 0, false, 2.0); |
| 871 | AddObserver(&observer_mid, 10, 50, 0, false, 4.0); |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 872 | allocator_->OnNetworkEstimateChanged( |
| 873 | CreateTargetRateMessage(90, 0, 0, kDefaultProbingIntervalMs)); |
Seth Hampson | fe73d6a | 2017-11-14 18:49:06 | [diff] [blame] | 874 | |
| 875 | EXPECT_EQ(40u, observer_low.last_bitrate_bps_); |
| 876 | EXPECT_EQ(50u, observer_mid.last_bitrate_bps_); |
| 877 | |
| 878 | allocator_->RemoveObserver(&observer_low); |
| 879 | allocator_->RemoveObserver(&observer_mid); |
| 880 | } |
| 881 | |
| 882 | // Tests that three observers with three different bitrate priorities will all |
| 883 | // be allocated bitrate according to their relative bitrate priority. |
| 884 | TEST_F(BitrateAllocatorTest, |
| 885 | PriorityRateThreeObserversAllocatedRelativeAmounts) { |
| 886 | TestBitrateObserver observer_low; |
| 887 | TestBitrateObserver observer_mid; |
| 888 | TestBitrateObserver observer_high; |
| 889 | const uint32_t kMaxBitrate = 100; |
| 890 | // Not enough bandwidth to fill any observer's max bitrate. |
| 891 | const uint32_t kNetworkBandwidthBps = 70; |
| 892 | const double kLowBitratePriority = 2.0; |
| 893 | const double kMidBitratePriority = 4.0; |
| 894 | const double kHighBitratePriority = 8.0; |
| 895 | const double kTotalBitratePriority = |
| 896 | kLowBitratePriority + kMidBitratePriority + kHighBitratePriority; |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 897 | AddObserver(&observer_low, 0, kMaxBitrate, 0, false, kLowBitratePriority); |
| 898 | AddObserver(&observer_mid, 0, kMaxBitrate, 0, false, kMidBitratePriority); |
| 899 | AddObserver(&observer_high, 0, kMaxBitrate, 0, false, kHighBitratePriority); |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 900 | allocator_->OnNetworkEstimateChanged(CreateTargetRateMessage( |
| 901 | kNetworkBandwidthBps, 0, 0, kDefaultProbingIntervalMs)); |
Seth Hampson | fe73d6a | 2017-11-14 18:49:06 | [diff] [blame] | 902 | |
| 903 | const double kLowFractionAllocated = |
| 904 | kLowBitratePriority / kTotalBitratePriority; |
| 905 | const double kMidFractionAllocated = |
| 906 | kMidBitratePriority / kTotalBitratePriority; |
| 907 | const double kHighFractionAllocated = |
| 908 | kHighBitratePriority / kTotalBitratePriority; |
| 909 | EXPECT_EQ(kLowFractionAllocated * kNetworkBandwidthBps, |
| 910 | observer_low.last_bitrate_bps_); |
| 911 | EXPECT_EQ(kMidFractionAllocated * kNetworkBandwidthBps, |
| 912 | observer_mid.last_bitrate_bps_); |
| 913 | EXPECT_EQ(kHighFractionAllocated * kNetworkBandwidthBps, |
| 914 | observer_high.last_bitrate_bps_); |
| 915 | |
| 916 | allocator_->RemoveObserver(&observer_low); |
| 917 | allocator_->RemoveObserver(&observer_mid); |
| 918 | allocator_->RemoveObserver(&observer_high); |
| 919 | } |
| 920 | |
| 921 | // Tests that after the high priority observer has been allocated its maximum |
| 922 | // bitrate, the other two observers are still allocated bitrate according to |
| 923 | // their relative bitrate priority. |
| 924 | TEST_F(BitrateAllocatorTest, PriorityRateThreeObserversHighAllocatedToMax) { |
| 925 | TestBitrateObserver observer_low; |
| 926 | const double kLowBitratePriority = 2.0; |
| 927 | TestBitrateObserver observer_mid; |
| 928 | const double kMidBitratePriority = 4.0; |
| 929 | TestBitrateObserver observer_high; |
| 930 | const double kHighBitratePriority = 8.0; |
| 931 | |
| 932 | const uint32_t kAvailableBitrate = 90; |
| 933 | const uint32_t kMaxBitrate = 40; |
| 934 | const uint32_t kMinBitrate = 10; |
| 935 | // Remaining bitrate after allocating to all mins and knowing that the high |
| 936 | // priority observer will have its max bitrate allocated. |
| 937 | const uint32_t kRemainingBitrate = |
| 938 | kAvailableBitrate - kMaxBitrate - (2 * kMinBitrate); |
| 939 | |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 940 | AddObserver(&observer_low, kMinBitrate, kMaxBitrate, 0, false, |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 941 | kLowBitratePriority); |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 942 | AddObserver(&observer_mid, kMinBitrate, kMaxBitrate, 0, false, |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 943 | kMidBitratePriority); |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 944 | AddObserver(&observer_high, kMinBitrate, kMaxBitrate, 0, false, |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 945 | kHighBitratePriority); |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 946 | allocator_->OnNetworkEstimateChanged(CreateTargetRateMessage( |
| 947 | kAvailableBitrate, 0, 0, kDefaultProbingIntervalMs)); |
Seth Hampson | fe73d6a | 2017-11-14 18:49:06 | [diff] [blame] | 948 | |
| 949 | const double kLowFractionAllocated = |
| 950 | kLowBitratePriority / (kLowBitratePriority + kMidBitratePriority); |
| 951 | const double kMidFractionAllocated = |
| 952 | kMidBitratePriority / (kLowBitratePriority + kMidBitratePriority); |
| 953 | EXPECT_EQ(kMinBitrate + (kRemainingBitrate * kLowFractionAllocated), |
| 954 | observer_low.last_bitrate_bps_); |
| 955 | EXPECT_EQ(kMinBitrate + (kRemainingBitrate * kMidFractionAllocated), |
| 956 | observer_mid.last_bitrate_bps_); |
| 957 | EXPECT_EQ(40u, observer_high.last_bitrate_bps_); |
| 958 | |
| 959 | allocator_->RemoveObserver(&observer_low); |
| 960 | allocator_->RemoveObserver(&observer_mid); |
| 961 | allocator_->RemoveObserver(&observer_high); |
| 962 | } |
| 963 | |
| 964 | // Tests that after the low priority observer has been allocated its maximum |
| 965 | // bitrate, the other two observers are still allocated bitrate according to |
| 966 | // their relative bitrate priority. |
| 967 | TEST_F(BitrateAllocatorTest, PriorityRateThreeObserversLowAllocatedToMax) { |
| 968 | TestBitrateObserver observer_low; |
| 969 | const double kLowBitratePriority = 2.0; |
| 970 | const uint32_t kLowMaxBitrate = 10; |
| 971 | TestBitrateObserver observer_mid; |
| 972 | const double kMidBitratePriority = 4.0; |
| 973 | TestBitrateObserver observer_high; |
| 974 | const double kHighBitratePriority = 8.0; |
| 975 | |
| 976 | const uint32_t kMinBitrate = 0; |
| 977 | const uint32_t kMaxBitrate = 60; |
| 978 | const uint32_t kAvailableBitrate = 100; |
| 979 | // Remaining bitrate knowing that the low priority observer is allocated its |
| 980 | // max bitrate. We know this because it is allocated 2.0/14.0 (1/7) of the |
| 981 | // available bitrate, so 70 bps would be sufficient network bandwidth. |
| 982 | const uint32_t kRemainingBitrate = kAvailableBitrate - kLowMaxBitrate; |
| 983 | |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 984 | AddObserver(&observer_low, kMinBitrate, kLowMaxBitrate, 0, false, |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 985 | kLowBitratePriority); |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 986 | AddObserver(&observer_mid, kMinBitrate, kMaxBitrate, 0, false, |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 987 | kMidBitratePriority); |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 988 | AddObserver(&observer_high, kMinBitrate, kMaxBitrate, 0, false, |
Sebastian Jansson | 24ad720 | 2018-04-19 06:25:12 | [diff] [blame] | 989 | kHighBitratePriority); |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 990 | allocator_->OnNetworkEstimateChanged(CreateTargetRateMessage( |
| 991 | kAvailableBitrate, 0, 0, kDefaultProbingIntervalMs)); |
Seth Hampson | fe73d6a | 2017-11-14 18:49:06 | [diff] [blame] | 992 | |
| 993 | const double kMidFractionAllocated = |
| 994 | kMidBitratePriority / (kMidBitratePriority + kHighBitratePriority); |
| 995 | const double kHighFractionAllocated = |
| 996 | kHighBitratePriority / (kMidBitratePriority + kHighBitratePriority); |
| 997 | EXPECT_EQ(kLowMaxBitrate, observer_low.last_bitrate_bps_); |
| 998 | EXPECT_EQ(kMinBitrate + (kRemainingBitrate * kMidFractionAllocated), |
| 999 | observer_mid.last_bitrate_bps_); |
| 1000 | EXPECT_EQ(kMinBitrate + (kRemainingBitrate * kHighFractionAllocated), |
| 1001 | observer_high.last_bitrate_bps_); |
| 1002 | |
| 1003 | allocator_->RemoveObserver(&observer_low); |
| 1004 | allocator_->RemoveObserver(&observer_mid); |
| 1005 | allocator_->RemoveObserver(&observer_high); |
| 1006 | } |
| 1007 | |
| 1008 | // Tests that after two observers are allocated bitrate to their max, the |
| 1009 | // the remaining observer is allocated what's left appropriately. This test |
| 1010 | // handles an edge case where the medium and high observer reach their |
| 1011 | // "relative" max allocation at the same time. The high has 40 to allocate |
| 1012 | // above its min, and the mid has 20 to allocate above its min, which scaled |
| 1013 | // by their bitrate priority is the same for each. |
| 1014 | TEST_F(BitrateAllocatorTest, PriorityRateThreeObserversTwoAllocatedToMax) { |
| 1015 | TestBitrateObserver observer_low; |
| 1016 | TestBitrateObserver observer_mid; |
| 1017 | TestBitrateObserver observer_high; |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 1018 | AddObserver(&observer_low, 10, 40, 0, false, 2.0); |
Seth Hampson | fe73d6a | 2017-11-14 18:49:06 | [diff] [blame] | 1019 | // Scaled allocation above the min allocation is the same for these two, |
| 1020 | // meaning they will get allocated their max at the same time. |
| 1021 | // Scaled (target allocation) = (max - min) / bitrate priority |
Jonas Olsson | 0182a03 | 2019-07-09 10:31:20 | [diff] [blame] | 1022 | AddObserver(&observer_mid, 10, 30, 0, false, 4.0); |
| 1023 | AddObserver(&observer_high, 10, 50, 0, false, 8.0); |
Sebastian Jansson | 40de3cc | 2019-09-19 12:54:43 | [diff] [blame] | 1024 | allocator_->OnNetworkEstimateChanged( |
| 1025 | CreateTargetRateMessage(110, 0, 0, kDefaultProbingIntervalMs)); |
Seth Hampson | fe73d6a | 2017-11-14 18:49:06 | [diff] [blame] | 1026 | |
| 1027 | EXPECT_EQ(30u, observer_low.last_bitrate_bps_); |
| 1028 | EXPECT_EQ(30u, observer_mid.last_bitrate_bps_); |
| 1029 | EXPECT_EQ(50u, observer_high.last_bitrate_bps_); |
| 1030 | |
| 1031 | allocator_->RemoveObserver(&observer_low); |
| 1032 | allocator_->RemoveObserver(&observer_mid); |
| 1033 | allocator_->RemoveObserver(&observer_high); |
| 1034 | } |
| 1035 | |
stefan@webrtc.org | 792f1a1 | 2015-03-04 12:24:26 | [diff] [blame] | 1036 | } // namespace webrtc |