Implement Socket::RecvFrom(ReceiveBuffer& buffer) in PhysicalSocketServer
And RTC_CHECK(NOTREACHED) Socket::RecvFrom(void* pv..)
This cl also change usage of PhysicalSocket to use PhysicalSocket::RecvFrom(ReceivedBuffer&) in Nat and tests.
Note that Socket::RecvFrom(ReceiveBuffer& buffer) is already used in AsyncUdpSocket.( https://webrtc-review.googlesource.com/c/src/+/332200)
AsyncTCPSocket uses Socket::Recv(). Therefore, there should be no production usage left of Socket::RecvFrom(void* pv..) in open source webrtc.
Follow up cls should remove usage of Socket::RecvFrom(void* pv..) in implementations of rtc:AsyncSocketAdapter such as FirewallSocketAdapter.
Change-Id: I597dc32b14be98e954a3dc419723f043e8a7e19e
Bug: webrtc:15368
Change-Id: I597dc32b14be98e954a3dc419723f043e8a7e19e
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/332341
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#41635}
diff --git a/rtc_base/BUILD.gn b/rtc_base/BUILD.gn
index ac30d87..8d108bb 100644
--- a/rtc_base/BUILD.gn
+++ b/rtc_base/BUILD.gn
@@ -1106,6 +1106,7 @@
]
deps = [
":buffer",
+ ":checks",
":macromagic",
":socket_address",
"../api/units:timestamp",
@@ -1718,6 +1719,7 @@
":async_socket",
":async_tcp_socket",
":async_udp_socket",
+ ":buffer",
":byte_buffer",
":checks",
":ip_address",
@@ -1737,6 +1739,7 @@
":stringutils",
":threading",
":timeutils",
+ "../api:array_view",
"../api:make_ref_counted",
"../api:refcountedbase",
"../api:scoped_refptr",
@@ -1852,6 +1855,7 @@
":threading",
":timeutils",
"../api/units:time_delta",
+ "../api/units:timestamp",
"../system_wrappers",
"../test:field_trial",
"../test:fileutils",
