commit 0d0d7531b50a78efe7468610395e9dc5f496e2e9
author magjed <magjed@webrtc.org> Thu Nov 17 15:51:30 2016
committer Commit bot <commit-bot@chromium.org> Thu Nov 17 15:51:35 2016
tree a334d22840f3cb203f5f7894c2c55541310e7da1
parent de4980311c01264baf29011afc7c40fc37c7dd18

Revert of Split out target rtc_media_base from rtc_media (patchset #3 id:40001 of https://codereview.webrtc.org/2471573003/ )

Reason for revert:
Breaks downstream import.

Original issue's description:
> Split out target rtc_media_base from rtc_media
>
> The purpose with this CL is to be able to depend on
> cricket::VideoCodec (webrtc/media/base/codec.h) from other targets
> without getting cyclic dependencies.
>
> BUG=webrtc:6402,webrtc:6337
>
> NOTRY=True
>
> Committed: https://crrev.com/aae7e7cf35a5bb43ebbaf75396aa7ccc544e920a
> Cr-Commit-Position: refs/heads/master@{#15137}

TBR=kjellander@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6402,webrtc:6337

Review-Url: https://codereview.webrtc.org/2508163002
Cr-Commit-Position: refs/heads/master@{#15139}

webrtc/media/BUILD.gn

diff --git a/webrtc/media/BUILD.gn b/webrtc/media/BUILD.gn
index 695cb8d..590450b 100644
--- a/webrtc/media/BUILD.gn
+++ b/webrtc/media/BUILD.gn
@@ -12,7 +12,6 @@
 group("media") {
   public_deps = [
     ":rtc_media",
-    ":rtc_media_base",
   ]
 }
 
@@ -42,7 +41,7 @@
   }
 }
 
-rtc_static_library("rtc_media_base") {
+rtc_static_library("rtc_media") {
   defines = []
   libs = []
   deps = []
@@ -82,38 +81,6 @@
     "base/videoframe.h",
     "base/videosourcebase.cc",
     "base/videosourcebase.h",
-  ]
-
-  configs += [ ":rtc_media_warnings_config" ]
-
-  if (!build_with_chromium && is_clang) {
-    # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
-    suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
-  }
-
-  include_dirs = []
-  if (rtc_build_libyuv) {
-    deps += [ "$rtc_libyuv_dir" ]
-    public_deps = [
-      "$rtc_libyuv_dir",
-    ]
-  } else {
-    # Need to add a directory normally exported by libyuv.
-    include_dirs += [ "$rtc_libyuv_dir/include" ]
-  }
-
-  deps += [
-    "..:webrtc_common",
-    "../base:rtc_base_approved",
-    "../p2p",
-  ]
-}
-
-rtc_static_library("rtc_media") {
-  defines = []
-  libs = []
-  deps = []
-  sources = [
     "engine/internalencoderfactory.cc",
     "engine/internalencoderfactory.h",
     "engine/nullwebrtcvideoengine.h",
@@ -199,14 +166,15 @@
     public_configs += [ ":gtk-lib" ]
   }
   deps += [
-    ":rtc_media_base",
     "..:webrtc_common",
     "../api:call_api",
     "../base:rtc_base_approved",
     "../call",
     "../modules/audio_mixer:audio_mixer_impl",
     "../modules/video_coding",
+    "../p2p",
     "../system_wrappers",
+    "../video",
     "../voice_engine",
   ]
 }

webrtc/media/base/codec.cc

diff --git a/webrtc/media/base/codec.cc b/webrtc/media/base/codec.cc
index aac2100..0320e58 100644
--- a/webrtc/media/base/codec.cc
+++ b/webrtc/media/base/codec.cc
@@ -13,7 +13,7 @@
 #include <algorithm>
 #include <sstream>
 
-#include "webrtc/base/checks.h"
+#include "webrtc/base/common.h"
 #include "webrtc/base/logging.h"
 #include "webrtc/base/stringencode.h"
 #include "webrtc/base/stringutils.h"
@@ -54,7 +54,7 @@
     return;
   }
   params_.push_back(param);
-  RTC_CHECK(!HasDuplicateEntries());
+  ASSERT(!HasDuplicateEntries());
 }
 
 void FeedbackParams::Intersect(const FeedbackParams& from) {
@@ -192,7 +192,7 @@
 
 webrtc::RtpCodecParameters AudioCodec::ToCodecParameters() const {
   webrtc::RtpCodecParameters codec_params = Codec::ToCodecParameters();
-  codec_params.channels = static_cast<int>(channels);
+  codec_params.channels = channels;
   return codec_params;
 }