commit | 0d51a5fc009a0d88bfc6a38a5ce697c1112d6c3d | [log] [tgz] |
---|---|---|
author | Olga Sharonova <olka@webrtc.org> | Wed Sep 01 11:32:21 2021 |
committer | WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Sep 01 11:32:42 2021 |
tree | 900d38db3ea3cb86c8365ea37146083684af090d | |
parent | eb89027733c511962120a5f7fd309d1893ad389c [diff] |
Revert "PipeWire capturer: implement proper DMA-BUFs support" This reverts commit f2177f6612079ccce9c320ea7e77bc934c684f5c. Reason for revert: Broke WebRTC to Chrome rolls: https://chromium-review.googlesource.com/c/chromium/src/+/3135220 example: https://ci.chromium.org/ui/p/chromium/builders/try/fuchsia-x64-cast/431230/overview ERROR at //third_party/webrtc/modules/desktop_capture/linux/egl_dmabuf.cc:26:11: Include not allowed. #include "rtc_base/sanitizer.h" ^------------------- It is not in any dependency of //third_party/webrtc/modules/desktop_capture:desktop_capture_generic The include file is in the target(s): //third_party/webrtc/rtc_base:sanitizer which should somehow be reachable. Original change's description: > PipeWire capturer: implement proper DMA-BUFs support > > Currently both KWin (KDE) and Mutter (GNOME) window managers don't > use DMA-BUFs by default, but only when client asks specifically for > them (KWin) or when experimental DMA-BUF support is enabled (Mutter). > While current implementation works just fine on integrated graphics > cards, it causes issues on dedicated GPUs (AMD and NVidia) where the > code either crashes or screensharing is slow and unusable. > > To fix this, DMA-BUFs has to be opened using OpenGL context and not > being directly mmaped(). This implementation requires to use DMA-BUF > modifiers, as they are now mandatory for DMA-BUFs usage. > > Documentation for this behavior can be found here: > https://gitlab.freedesktop.org/pipewire/pipewire/-/blob/master/doc/dma-buf.dox > > Bug: chromium:1233417, webrtc:13137 > Change-Id: I0cecf16d6bb0f576954b9e8f071cab526f7baf2c > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/227022 > Commit-Queue: Tommi <tommi@webrtc.org> > Reviewed-by: Tommi <tommi@webrtc.org> > Reviewed-by: Erik Språng <sprang@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#34889} TBR=mbonadei@webrtc.org,tommi@webrtc.org,sprang@webrtc.org,mfoltz@chromium.org,webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com,grulja@gmail.com Change-Id: I2c573f17adbb216156cd72f62f4dbb7328f8fb6a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1233417, webrtc:13137 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/230944 Reviewed-by: Olga Sharonova <olka@webrtc.org> Commit-Queue: Olga Sharonova <olka@webrtc.org> Cr-Commit-Position: refs/heads/main@{#34892}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See here for instructions on how to get started developing with the native code.
Authoritative list of directories that contain the native API header files.