commit 166e65669ba4edf0986f4758c6136236da4f465d
author Tommi <tommi@webrtc.org> Sun Aug 31 09:31:00 2025
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Sep 01 06:49:19 2025
tree 8df205f69a9bfc497f5c06a4e808431fe3c79e80
parent 3de01cf99aaa45667a36179c60148ecb3accb8ee

Add checks to track down flake

Add explicit checks for scalability_mode presence

This is to help with identifying the source of flakiness:

gen/third_party/libc++/src/include/optional:874: libc++ Hardening
assertion this->has_value() failed: optional operator* called on a
disengaged value *** SIGABRT received at time=1756631788 on cpu 3 ***
PC: @ 0x7ffff709eb1c (unknown) pthread_kill
    @     0x555557ef1364        256  absl::AbslFailureSignalHandler()
    @     0x555555d5169e         64  SignalAction()
    @     0x7ffff7045320  157537360  (unknown)
    @     0x7ffff704526e         32  raise
    @     0x7ffff70288ff        192  abort
    @     0x55555b0c8552        624  std::__Cr::__libcpp_verbose_abort()
    @     0x55555654b2ff       2656  webrtc::PeerConnectionEncodingsIntegrationParameterizedTest_Simulcast_Test::TestBody()
    @     0x5555580ec194         80  testing::Test::Run()
    @     0x5555580eec8c        144  testing::TestInfo::Run()
    @     0x5555580f1687        288  testing::TestSuite::Run()
    @     0x555558126a25        608  testing::internal::UnitTestImpl::RunAllTests()
    @     0x555558124fb1         96  testing::UnitTest::Run()
    @     0x55555826a970       1024  webrtc::(anonymous namespace)::TestMainImpl::Run()
    @     0x555557e3d081        272  main
    @     0x7ffff702a1ca        160  (unknown)
    @     0x7ffff702a28b         96  __libc_start_main
    @     0x555555cd32fa  (unknown)  _start

To help diagnose the intermittent failures, this change adds explicit
`EXPECT_TRUE` assertions to verify that `scalability_mode.has_value()`
before checking the mode's string content. These more granular checks
will help pinpoint the root cause of the test flake.

Bug: none
Change-Id: Ia3d846cde1a28ec397a20573b929dad3bf0636fa
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407340
Commit-Queue: Henrik Boström <hbos@webrtc.org>
Auto-Submit: Tomas Gunnarsson <tommi@webrtc.org>
Reviewed-by: Henrik Boström <hbos@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#45502}