dcsctp: Remove assignment of redundant metrics

The DcSctpSocket::GetMetrics() returns a Metrics struct that contains
both constant values calculated when the connection was established,
such as capabilities, and also dynamic information that change for each
incoming or outgoing packet.

The constant values are stored within "metrics_" when the TCB is created
and copied into the returned metrics during GetMetrics() call. The
dynamic values are then only set on the local copy before returning.

Before this CL, the "negotiated_maximum_incoming_streams" metric, which
is a constant metric, was additionally set - twice - in GetMetrics(),
which could make one believe that the
"negotiated_maximum_outgoing_streams" was never set at all, but it was,
and this was also verified with the
DcSctpSocketParametrizedTest::ExposesTheNumberOfNegotiatedStreams test
case.

This change removes the redundant assignment, but please note that the
returned Metrics have always been correct.

Bug: webrtc:487768780
Change-Id: If29f5c28dc5499bb9dac8b461bdc15462671b9b1
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/452700
Reviewed-by: Danil Chapovalov <danilchap@webrtc.org>
Commit-Queue: Victor Boivie <boivie@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#47011}
1 file changed
tree: 2db1dd35ee0720ce41c6254b120365919c450e35
  1. agents/
  2. api/
  3. audio/
  4. build_overrides/
  5. call/
  6. common_audio/
  7. common_video/
  8. data/
  9. docs/
  10. examples/
  11. experiments/
  12. g3doc/
  13. infra/
  14. logging/
  15. media/
  16. modules/
  17. net/
  18. p2p/
  19. pc/
  20. resources/
  21. rtc_base/
  22. rtc_tools/
  23. sdk/
  24. stats/
  25. system_wrappers/
  26. test/
  27. tools_webrtc/
  28. video/
  29. .clang-format
  30. .clang-tidy
  31. .git-blame-ignore-revs
  32. .gitignore
  33. .gn
  34. .mailmap
  35. .rustfmt.toml
  36. .style.yapf
  37. .vpython3
  38. AUTHORS
  39. BUILD.gn
  40. CODE_OF_CONDUCT.md
  41. codereview.settings
  42. DEPS
  43. DIR_METADATA
  44. ENG_REVIEW_OWNERS
  45. GEMINI.md
  46. LICENSE
  47. license_template.txt
  48. native-api.md
  49. OWNERS
  50. OWNERS_INFRA
  51. PATENTS
  52. PRESUBMIT.py
  53. presubmit_test.py
  54. presubmit_test_mocks.py
  55. pylintrc
  56. pylintrc_old_style
  57. README.chromium
  58. README.md
  59. unsafe_buffers_paths.txt
  60. WATCHLISTS
  61. webrtc.gni
  62. webrtc_lib_link_test.cc
  63. whitespace.txt
README.md

WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.

Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.

The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.

Development

See here for instructions on how to get started developing with the native code.

Authoritative list of directories that contain the native API header files.

More info