commit 1bda6a6a58abd4e98d91f714811a490bc2b03e66
author Florent Castelli <orphis@webrtc.org> Wed Nov 27 12:28:57 2024
committer WebRTC LUCI CQ <webrtc-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Nov 27 15:44:38 2024
tree 3fba248bc705707c449e201015fdafa90df7c6cf
parent 4a6a7465d03f0b581122f11385aca87294eebd5d

Make SSLStreamAdapter::SetPeerCertificateDigest use of const uint8_t

This allows it to accept rtc::CopyOnWriteBuffer.

Bug: webrtc:357776213
Change-Id: I8c9eeb5577e8de902db144aff5ad8eee87e5a530
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/369640
Commit-Queue: Florent Castelli <orphis@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43464}

rtc_base/openssl_stream_adapter.cc

diff --git a/rtc_base/openssl_stream_adapter.cc b/rtc_base/openssl_stream_adapter.cc
index 88e0916..7a62847 100644
--- a/rtc_base/openssl_stream_adapter.cc
+++ b/rtc_base/openssl_stream_adapter.cc
@@ -272,7 +272,7 @@
 
 SSLPeerCertificateDigestError OpenSSLStreamAdapter::SetPeerCertificateDigest(
     absl::string_view digest_alg,
-    rtc::ArrayView<uint8_t> digest_val) {
+    rtc::ArrayView<const uint8_t> digest_val) {
   RTC_DCHECK(!peer_certificate_verified_);
   RTC_DCHECK(!HasPeerCertificateDigest());
   size_t expected_len;

rtc_base/openssl_stream_adapter.h

diff --git a/rtc_base/openssl_stream_adapter.h b/rtc_base/openssl_stream_adapter.h
index 2ae7c0d..82e0b1b 100644
--- a/rtc_base/openssl_stream_adapter.h
+++ b/rtc_base/openssl_stream_adapter.h
@@ -80,7 +80,7 @@
   void SetServerRole(SSLRole role = SSL_SERVER) override;
   SSLPeerCertificateDigestError SetPeerCertificateDigest(
       absl::string_view digest_alg,
-      rtc::ArrayView<uint8_t> digest_val) override;
+      rtc::ArrayView<const uint8_t> digest_val) override;
 
   std::unique_ptr<SSLCertChain> GetPeerSSLCertChain() const override;
 

rtc_base/ssl_stream_adapter.h

diff --git a/rtc_base/ssl_stream_adapter.h b/rtc_base/ssl_stream_adapter.h
index 49094b8..66617e3 100644
--- a/rtc_base/ssl_stream_adapter.h
+++ b/rtc_base/ssl_stream_adapter.h
@@ -175,7 +175,7 @@
   // Returns SSLPeerCertificateDigestError::NONE if successful.
   virtual SSLPeerCertificateDigestError SetPeerCertificateDigest(
       absl::string_view digest_alg,
-      rtc::ArrayView<uint8_t> digest_val) = 0;
+      rtc::ArrayView<const uint8_t> digest_val) = 0;
   [[deprecated(
       "Use SetPeerCertificateDigest with ArrayView instead")]] virtual bool
   SetPeerCertificateDigest(absl::string_view digest_alg,